200890 2019-08-19 10:07:55 -0700 results-webkit.org: Add timeout to Redis locks 2019-08-19 10:52:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1562742 0 jbedard 2019-08-19 10:07:55 -0700 We should add timeouts to our Redis locks so that they won't remain eternally locked if the worker processes crash. 1562744 1 376696 jbedard 2019-08-19 10:09:39 -0700 Created attachment 376696 Patch 1562752 2 376696 commit-queue 2019-08-19 10:51:53 -0700 Comment on attachment 376696 Patch Clearing flags on attachment: 376696 Committed r248858: <https://trac.webkit.org/changeset/248858> 1562753 3 commit-queue 2019-08-19 10:51:54 -0700 All reviewed patches have been landed. Closing bug. 1562754 4 webkit-bug-importer 2019-08-19 10:52:18 -0700 <rdar://problem/54473439> 376696 2019-08-19 10:09:39 -0700 2019-08-19 10:51:53 -0700 Patch bug-200890-20190819100939.patch text/plain 1364 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0ODg1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA4LTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLXdlYmtpdC5vcmc6IEFkZCB0aW1lb3V0IHRvIFJlZGlzIGxv Y2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA4 OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJl c3VsdHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5OgorICAgICAgICAo VXBsb2FkQ29udGV4dC5fZmluZF9qb2Jfd2l0aF9hdHRlbXB0cyk6IEFkZCB0aW1lb3V0IHRvIFJl ZGlzIGxvY2suCisKIDIwMTktMDgtMTkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbV1RGXSBTdHlsZSBjaGVja2VyIHNob3VsZCB0ZWxsIGVycm9ycyB3aGVu IGl0IGZpbmRzIHN0ZDo6bWFrZV91bmlxdWUKSW5kZXg6IFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3Vs dHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L21vZGVsL3VwbG9hZF9jb250ZXh0LnB5CShyZXZpc2lvbiAyNDg4 NTQpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS9tb2RlbC91cGxvYWRfY29udGV4 dC5weQkod29ya2luZyBjb3B5KQpAQCAtMTI3LDcgKzEyNyw3IEBAIGNsYXNzIFVwbG9hZENvbnRl eHQob2JqZWN0KToKICAgICAgICAgYXJlX2pvYnNfbGVmdCA9IEZhbHNlCiAgICAgICAgIHdpbGxf YXR0ZW1wdCA9IDAKIAotICAgICAgICB3aXRoIHNlbGYucmVkaXMubG9jayhuYW1lPWYnbG9ja197 c2VsZi5RVUVVRV9OQU1FfScpOgorICAgICAgICB3aXRoIHNlbGYucmVkaXMubG9jayhuYW1lPWYn bG9ja197c2VsZi5RVUVVRV9OQU1FfScsIHRpbWVvdXQ9NjApOgogICAgICAgICAgICAgZm9yIGtl eSBpbiBzZWxmLnJlZGlzLnNjYW5faXRlcihtYXRjaD1mJ3tzZWxmLlFVRVVFX05BTUV9KicsIGNv dW50PXNlbGYuTUFYX1RBU0tTX0lOX1NDQU4pOgogICAgICAgICAgICAgICAgIGFyZV9qb2JzX2xl ZnQgPSBUcnVlCiAgICAgICAgICAgICAgICAga2V5ID0ga2V5LmRlY29kZSgndXRmLTgnKQo=