200886 2019-08-19 06:44:28 -0700 [SOUP] NetworkProcessSoup does not initialize CacheOptions correctly 2019-08-22 02:40:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enometh csaavedra aperez bugs-noreply cgarcia commit-queue csaavedra pnormand zan oldest_to_newest 1562712 0 376683 enometh 2019-08-19 06:44:28 -0700 Created attachment 376683 sketch git commit 464bf0 http://svn.webkit.org/repository/webkit/trunk@247567 overlooked propagating the cacheOptions which are set in WebKit::NetworkProcess::platformInitializeNetworkProcess The attached patch outlines a fix 1562713 1 enometh 2019-08-19 06:59:03 -0700 (The attached patch unnecessarily marked the slot on NetworkProcess as protected . It shouldn't I hope this does not confuse the main issue.) 1563980 2 376683 csaavedra 2019-08-22 00:59:45 -0700 Comment on attachment 376683 sketch View in context: https://bugs.webkit.org/attachment.cgi?id=376683&action=review > Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:121 > + cacheOptions.add(NetworkCache::CacheOption::RegisterNotify); I'm confused by the original code here. I don't see this cacheOptions local variable used anywhere, only set here but never read. Is this correct at all or am I missing something? 1563981 3 csaavedra 2019-08-22 01:01:30 -0700 I think the code must have been wrong already before achristensen's patch. Here we should be setting m_cacheOptions, not a local variable. 1563990 4 376996 csaavedra 2019-08-22 01:39:02 -0700 Created attachment 376996 Patch 1563991 5 376997 csaavedra 2019-08-22 01:40:37 -0700 Created attachment 376997 Patch 1563992 6 376997 aperez 2019-08-22 01:46:54 -0700 Comment on attachment 376997 Patch r+, patch LGTM (reviewing informally) 1564006 7 376997 commit-queue 2019-08-22 02:40:32 -0700 Comment on attachment 376997 Patch Clearing flags on attachment: 376997 Committed r248999: <https://trac.webkit.org/changeset/248999> 1564007 8 commit-queue 2019-08-22 02:40:33 -0700 All reviewed patches have been landed. Closing bug. 376683 2019-08-19 06:44:28 -0700 2019-08-22 01:38:55 -0700 sketch file_200886.txt text/plain 1400 enometh ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3Mu aCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaA0KaW5kZXgg NDA5NGM2NjlkMDguLjNmYTg4Njk1MDQyIDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oDQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtQcm9jZXNzLmgNCkBAIC01NjgsNiArNTY4LDcgQEAgcHJpdmF0ZToNCiAN CiAgICAgSGFzaE1hcDxJUEM6OkNvbm5lY3Rpb246OlVuaXF1ZUlELCBQQUw6OlNlc3Npb25JRD4g bV9zZXNzaW9uQnlDb25uZWN0aW9uOw0KIA0KKyAgICBwcm90ZWN0ZWQ6DQogICAgIE9wdGlvblNl dDxOZXR3b3JrQ2FjaGU6OkNhY2hlT3B0aW9uPiBtX2NhY2hlT3B0aW9uczsNCiB9Ow0KIA0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vz c1NvdXAuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9j ZXNzU291cC5jcHANCmluZGV4IDdhNzQ4MWY3ZDQyLi4zZGYxNDBmNTMwMSAxMDA2NDQNCi0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3Bw DQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NT b3VwLmNwcA0KQEAgLTExNyw3ICsxMTcsOCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9y bUluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyhjb25zdCBOZXR3b3JrUHJvY2Vzc0NyZWF0aQ0KIA0K ICAgICBTb3VwTmV0d29ya1Nlc3Npb246OmNsZWFyT2xkU291cENhY2hlKEZpbGVTeXN0ZW06OmRp cmVjdG9yeU5hbWUobV9kaXNrQ2FjaGVEaXJlY3RvcnkpKTsNCiANCi0gICAgT3B0aW9uU2V0PE5l dHdvcmtDYWNoZTo6Q2FjaGVPcHRpb24+IGNhY2hlT3B0aW9ucyB7IE5ldHdvcmtDYWNoZTo6Q2Fj aGVPcHRpb246OlJlZ2lzdGVyTm90aWZ5IH07DQorICAgIE9wdGlvblNldDxOZXR3b3JrQ2FjaGU6 OkNhY2hlT3B0aW9uPiAmY2FjaGVPcHRpb25zID0gbV9jYWNoZU9wdGlvbnM7DQorICAgIGNhY2hl T3B0aW9ucy5hZGQoTmV0d29ya0NhY2hlOjpDYWNoZU9wdGlvbjo6UmVnaXN0ZXJOb3RpZnkpOw0K ICNpZiBFTkFCTEUoTkVUV09SS19DQUNIRV9TUEVDVUxBVElWRV9SRVZBTElEQVRJT04pDQogICAg IGlmIChwYXJhbWV0ZXJzLnNob3VsZEVuYWJsZU5ldHdvcmtDYWNoZVNwZWN1bGF0aXZlUmV2YWxp ZGF0aW9uKQ0KICAgICAgICAgY2FjaGVPcHRpb25zLmFkZChOZXR3b3JrQ2FjaGU6OkNhY2hlT3B0 aW9uOjpTcGVjdWxhdGl2ZVJldmFsaWRhdGlvbik7DQo= 376996 2019-08-22 01:39:02 -0700 2019-08-22 01:40:33 -0700 Patch bug-200886-20190822113901.patch text/plain 2128 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUxYTdiM2JlNGM5NDAxMDU5 NGU1ZmRiOGYxOTVkZGRhZWQ0M2MwZmUuLmRhMDU0NTc0NGJjMjVhMTdmNjZhMzBkY2VkM2NjOTll OTkxZGRkZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjIgIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gTmV0d29y a1Nlc3Npb25Tb3VwIGRvZXMgbm90IGluaXRpYWxpemUgQ2FjaGVPcHRpb25zIGNvcnJlY3RseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODg2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI0NzU2NyB3 cm9uZ2x5IGluaXRpYWxpemVzIENhY2hlT3B0aW9ucyBpbiBhIGxvY2FsIHZhcmlhYmxlIHRoYXQg aXMgbmV2ZXIgdXNlZAorICAgICAgICBpbnN0ZWFkIG9mIHVzaW5nIE5ldHdvcmtQcm9jZXNzJ3Mg bWVtYmVyIHZhcmlhYmxlLCB0aGF0IGlzIGxhdGVyIHVzZWQgYnkgdGhlCisgICAgICAgIE5ldHdv cmtTZXNzaW9uIHRvIGluaXRpYWxpemUgdGhlIGNhY2hlLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3MpOgorCiAyMDE5LTA4 LTIxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFtN YWlsXSBUYXBwaW5nIHRvcCBvZiBtZXNzYWdlIHNjcm9sbHMgYmFjayB0byBjb3BpZWQgdGV4dCBp bnN0ZWFkIG9mIHRvcCBvZiB0aGUgbWVzc2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAppbmRleCA3YTc0ODFm N2Q0MjVmMDIzMzdhMGMxMGFkZjlkNjU0ZjcwZWM3ZGQzLi4zZmY4NGRiMzVjYzU4M2JhZTJlYjIz NDUyNTVlMzFmMzM4ZTM3NTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcApAQCAtMTE3LDEwICsxMTcsMTAg QEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3Mo Y29uc3QgTmV0d29ya1Byb2Nlc3NDcmVhdGkKIAogICAgIFNvdXBOZXR3b3JrU2Vzc2lvbjo6Y2xl YXJPbGRTb3VwQ2FjaGUoRmlsZVN5c3RlbTo6ZGlyZWN0b3J5TmFtZShtX2Rpc2tDYWNoZURpcmVj dG9yeSkpOwogCi0gICAgT3B0aW9uU2V0PE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb24+IGNhY2hl T3B0aW9ucyB7IE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlJlZ2lzdGVyTm90aWZ5IH07Cisg ICAgbV9jYWNoZU9wdGlvbnMgPSB7IE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlJlZ2lzdGVy Tm90aWZ5IH07CiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEVfU1BFQ1VMQVRJVkVfUkVWQUxJREFU SU9OKQogICAgIGlmIChwYXJhbWV0ZXJzLnNob3VsZEVuYWJsZU5ldHdvcmtDYWNoZVNwZWN1bGF0 aXZlUmV2YWxpZGF0aW9uKQotICAgICAgICBjYWNoZU9wdGlvbnMuYWRkKE5ldHdvcmtDYWNoZTo6 Q2FjaGVPcHRpb246OlNwZWN1bGF0aXZlUmV2YWxpZGF0aW9uKTsKKyAgICAgICAgbV9jYWNoZU9w dGlvbnMuYWRkKE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlNwZWN1bGF0aXZlUmV2YWxpZGF0 aW9uKTsKICNlbmRpZgogCiAgICAgc3VwcGxlbWVudDxXZWJDb29raWVNYW5hZ2VyPigpLT5zZXRI VFRQQ29va2llQWNjZXB0UG9saWN5KHBhcmFtZXRlcnMuY29va2llQWNjZXB0UG9saWN5LCBPcHRp b25hbENhbGxiYWNrSUQoKSk7Cg== 376997 2019-08-22 01:40:37 -0700 2019-08-22 02:40:32 -0700 Patch bug-200886-20190822114036.patch text/plain 2128 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUxYTdiM2JlNGM5NDAxMDU5 NGU1ZmRiOGYxOTVkZGRhZWQ0M2MwZmUuLmJlM2EyMDhhMTBlMThmOWIyM2YwY2Q5ODIwOGIyNTVh MTRmZGFkYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMjIgIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gTmV0d29y a1Byb2Nlc3NTb3VwIGRvZXMgbm90IGluaXRpYWxpemUgQ2FjaGVPcHRpb25zIGNvcnJlY3RseQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODg2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI0NzU2NyB3 cm9uZ2x5IGluaXRpYWxpemVzIENhY2hlT3B0aW9ucyBpbiBhIGxvY2FsIHZhcmlhYmxlIHRoYXQg aXMgbmV2ZXIgdXNlZAorICAgICAgICBpbnN0ZWFkIG9mIHVzaW5nIE5ldHdvcmtQcm9jZXNzJ3Mg bWVtYmVyIHZhcmlhYmxlLCB0aGF0IGlzIGxhdGVyIHVzZWQgYnkgdGhlCisgICAgICAgIE5ldHdv cmtTZXNzaW9uIHRvIGluaXRpYWxpemUgdGhlIGNhY2hlLgorCisgICAgICAgICogTmV0d29ya1By b2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3MpOgorCiAyMDE5LTA4 LTIxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFtN YWlsXSBUYXBwaW5nIHRvcCBvZiBtZXNzYWdlIHNjcm9sbHMgYmFjayB0byBjb3BpZWQgdGV4dCBp bnN0ZWFkIG9mIHRvcCBvZiB0aGUgbWVzc2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAppbmRleCA3YTc0ODFm N2Q0MjVmMDIzMzdhMGMxMGFkZjlkNjU0ZjcwZWM3ZGQzLi4zZmY4NGRiMzVjYzU4M2JhZTJlYjIz NDUyNTVlMzFmMzM4ZTM3NTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcApAQCAtMTE3LDEwICsxMTcsMTAg QEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplTmV0d29ya1Byb2Nlc3Mo Y29uc3QgTmV0d29ya1Byb2Nlc3NDcmVhdGkKIAogICAgIFNvdXBOZXR3b3JrU2Vzc2lvbjo6Y2xl YXJPbGRTb3VwQ2FjaGUoRmlsZVN5c3RlbTo6ZGlyZWN0b3J5TmFtZShtX2Rpc2tDYWNoZURpcmVj dG9yeSkpOwogCi0gICAgT3B0aW9uU2V0PE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb24+IGNhY2hl T3B0aW9ucyB7IE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlJlZ2lzdGVyTm90aWZ5IH07Cisg ICAgbV9jYWNoZU9wdGlvbnMgPSB7IE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlJlZ2lzdGVy Tm90aWZ5IH07CiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEVfU1BFQ1VMQVRJVkVfUkVWQUxJREFU SU9OKQogICAgIGlmIChwYXJhbWV0ZXJzLnNob3VsZEVuYWJsZU5ldHdvcmtDYWNoZVNwZWN1bGF0 aXZlUmV2YWxpZGF0aW9uKQotICAgICAgICBjYWNoZU9wdGlvbnMuYWRkKE5ldHdvcmtDYWNoZTo6 Q2FjaGVPcHRpb246OlNwZWN1bGF0aXZlUmV2YWxpZGF0aW9uKTsKKyAgICAgICAgbV9jYWNoZU9w dGlvbnMuYWRkKE5ldHdvcmtDYWNoZTo6Q2FjaGVPcHRpb246OlNwZWN1bGF0aXZlUmV2YWxpZGF0 aW9uKTsKICNlbmRpZgogCiAgICAgc3VwcGxlbWVudDxXZWJDb29raWVNYW5hZ2VyPigpLT5zZXRI VFRQQ29va2llQWNjZXB0UG9saWN5KHBhcmFtZXRlcnMuY29va2llQWNjZXB0UG9saWN5LCBPcHRp b25hbENhbGxiYWNrSUQoKSk7Cg==