200878 2019-08-19 00:47:51 -0700 [WTF] Style checker should tell errors when it finds std::make_unique 2019-09-16 06:19:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=201818 InRadar P2 Normal --- 200620 1 ysuzuki ysuzuki ews-watchlist glenn mark.lam ross.kirsling webkit-bug-importer oldest_to_newest 1562666 0 ysuzuki 2019-08-19 00:47:51 -0700 [WTF] Style checker should tell errors when it finds std::make_unique 1562668 1 376670 ysuzuki 2019-08-19 00:48:15 -0700 Created attachment 376670 Patch 1562671 2 376670 ross.kirsling 2019-08-19 00:56:21 -0700 Comment on attachment 376670 Patch r=me 1562674 3 ysuzuki 2019-08-19 01:08:35 -0700 Committed r248848: <https://trac.webkit.org/changeset/248848> 1562675 4 webkit-bug-importer 2019-08-19 01:09:23 -0700 <rdar://problem/54458020> 376670 2019-08-19 00:48:15 -0700 2019-08-19 00:56:21 -0700 Patch bug-200878-20190819004814.patch text/plain 3147 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTNkMjU0NDQxMzk1M2QxN2MzZjdmYjUzYzU3NzQ0Mzk3 YjE4MjI3Zi4uNDRlZDhmZDA5ZTYwYjBkNGJkODE4YmQ2ZmQ0NDlkYmVhYTRhZTU3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA4LTE5ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAg ICAgICAgW1dURl0gU3R5bGUgY2hlY2tlciBzaG91bGQgdGVsbCBlcnJvcnMgd2hlbiBpdCBmaW5k cyBzdGQ6Om1ha2VfdW5pcXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDA4NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAg ICAgICAoY2hlY2tfd3RmX21ha2VfdW5pcXVlKToKKyAgICAgICAgKGNoZWNrX3N0eWxlKToKKyAg ICAgICAgKENwcENoZWNrZXIpOgorCiAyMDE5LTA4LTE4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gQWRkIG1ha2VVbmlxdWU8VD4sIHdoaWNoIGVu c3VyZXMgVCBpcyBmYXN0LWFsbG9jYXRlZCwgbWFrZVVuaXF1ZSAvIG1ha2VVbmlxdWVXaXRob3V0 RmFzdE1hbGxvY0NoZWNrIHBhcnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHAucHkKaW5kZXggNTRiMTM2ODNkZGEzYWIzY2QzZGY2ZjZlMDRiMzY4MWQ4ZTU2NDZh ZS4uMWM0MzkxNjAxMzliMTViMjE2NzlhMGIxMWNlMmI1ZWVmN2ZmYzc1YyAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIzOTgsNiArMjM5OCwy NiBAQCBkZWYgY2hlY2tfd3RmX29wdGlvbmFsKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmls ZV9zdGF0ZSwgZXJyb3IpOgogICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS93dGZfb3B0 aW9uYWwnLCA0LCAiVXNlICdXVEY6Ok9wdGlvbmFsPD4nIGluc3RlYWQgb2YgJ3N0ZDo6b3B0aW9u YWw8PicuIikKIAogCitkZWYgY2hlY2tfd3RmX21ha2VfdW5pcXVlKGNsZWFuX2xpbmVzLCBsaW5l X251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgorICAgICIiIkxvb2tzIGZvciB1c2Ugb2YgJ3N0 ZDo6bWFrZV91bmlxdWU8Picgd2hpY2ggc2hvdWxkIGJlIHJlcGxhY2VkIHdpdGggJ1dURjo6bWFr ZVVuaXF1ZTw+Jy4KKworICAgIEFyZ3M6CisgICAgICBjbGVhbl9saW5lczogQSBDbGVhbnNlZExp bmVzIGluc3RhbmNlIGNvbnRhaW5pbmcgdGhlIGZpbGUuCisgICAgICBsaW5lX251bWJlcjogVGhl IG51bWJlciBvZiB0aGUgbGluZSB0byBjaGVjay4KKyAgICAgIGZpbGVfc3RhdGU6IEEgX0ZpbGVT dGF0ZSBpbnN0YW5jZSB3aGljaCBtYWludGFpbnMgaW5mb3JtYXRpb24gYWJvdXQKKyAgICAgICAg ICAgICAgICAgIHRoZSBzdGF0ZSBvZiB0aGluZ3MgaW4gdGhlIGZpbGUuCisgICAgICBlcnJvcjog VGhlIGZ1bmN0aW9uIHRvIGNhbGwgd2l0aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgorCisg ICAgbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0gICMgR2V0IHJpZCBvZiBj b21tZW50cyBhbmQgc3RyaW5ncy4KKworICAgIHVzaW5nX3N0ZF9tYWtlX3VuaXF1ZSA9IHNlYXJj aChyJ1xic3RkOjptYWtlX3VuaXF1ZVxzKlw8JywgbGluZSkKKyAgICBpZiBub3QgdXNpbmdfc3Rk X21ha2VfdW5pcXVlOgorICAgICAgICByZXR1cm4KKworICAgIGVycm9yKGxpbmVfbnVtYmVyLCAn cnVudGltZS93dGZfbWFrZV91bmlxdWUnLCA0LCAiVXNlICdXVEY6Om1ha2VVbmlxdWU8PicgaW5z dGVhZCBvZiAnc3RkOjptYWtlX3VuaXF1ZTw+Jy4iKQorCisKIGRlZiBjaGVja19jdHlwZV9mdW5j dGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcik6CiAgICAg IiIiTG9va3MgZm9yIHVzZSBvZiB0aGUgc3RhbmRhcmQgZnVuY3Rpb25zIGluIGN0eXBlLmggYW5k IHN1Z2dlc3QgdGhleSBiZSByZXBsYWNlZAogICAgICAgIGJ5IHVzZSBvZiBlcXVpdmlsZW50IG9u ZXMgaW4gPHd0Zi9BU0NJSUNUeXBlLmg+Py4KQEAgLTI5NTcsNiArMjk3Nyw3IEBAIGRlZiBjaGVj a19zdHlsZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBjbGFzc19z dGF0ZSwgZmlsZV9zdGF0CiAgICAgY2hlY2tfbWF4X21pbl9tYWNyb3MoY2xlYW5fbGluZXMsIGxp bmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBjaGVja193dGZfbW92ZShjbGVhbl9s aW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKQogICAgIGNoZWNrX3d0Zl9vcHRp b25hbChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKQorICAgIGNo ZWNrX3d0Zl9tYWtlX3VuaXF1ZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUs IGVycm9yKQogICAgIGNoZWNrX2N0eXBlX2Z1bmN0aW9ucyhjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfc3RhdGUsIGVycm9yKQogICAgIGNoZWNrX3N3aXRjaF9pbmRlbnRhdGlvbihjbGVh bl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAgIGNoZWNrX2JyYWNlcyhjbGVhbl9saW5l cywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKQpAQCAtNDExMyw2ICs0MTM0LDcgQEAg Y2xhc3MgQ3BwQ2hlY2tlcihvYmplY3QpOgogICAgICAgICAncnVudGltZS91bnNpZ25lZCcsCiAg ICAgICAgICdydW50aW1lL3ZpcnR1YWwnLAogICAgICAgICAncnVudGltZS93dGZfb3B0aW9uYWwn LAorICAgICAgICAncnVudGltZS93dGZfbWFrZV91bmlxdWUnLAogICAgICAgICAncnVudGltZS93 dGZfbW92ZScsCiAgICAgICAgICdzZWN1cml0eS9hc3NlcnRpb24nLAogICAgICAgICAnc2VjdXJp dHkvcHJpbnRmJywK