200866 2019-08-17 18:39:27 -0700 Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled 2019-08-17 22:35:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap commit-queue jbedard simon.fraser webkit-bug-importer oldest_to_newest 1562538 0 thorton 2019-08-17 18:39:27 -0700 Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled 1562539 1 376625 thorton 2019-08-17 18:39:48 -0700 Created attachment 376625 Patch 1562540 2 thorton 2019-08-17 18:39:50 -0700 <rdar://problem/50254021> 1562558 3 376625 ap 2019-08-17 22:15:00 -0700 Comment on attachment 376625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376625&action=review > Source/WebKit/ChangeLog:15 > + except for in tests! So just pass the rects straight through, instead of Or just skip all those tests? Are they meaningful? 1562559 4 thorton 2019-08-17 22:33:07 -0700 I think it’s ok that a test resizes the “window” in order to resize the view, and it is incidental to the thing the test is actually testing, so it would be weird to skip it. Also possible there are other tests we can unskip now, I have to check. 1562560 5 376625 commit-queue 2019-08-17 22:35:50 -0700 Comment on attachment 376625 Patch Clearing flags on attachment: 376625 Committed r248828: <https://trac.webkit.org/changeset/248828> 1562561 6 commit-queue 2019-08-17 22:35:51 -0700 All reviewed patches have been landed. Closing bug. 376625 2019-08-17 18:39:48 -0700 2019-08-17 22:35:50 -0700 Patch bug-200866-20190817183947.patch text/plain 6178 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIxNjJjYzI5Y2I3MWE0ODAy ODk0NDQwODI1N2E3MDc5MDc3NjU4ZTguLjFkNThkNjg2YzJlNzdjMTZkYzg2ZTUzNTZkNzk1MTgy OTcxMzlhNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDgtMTcgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IHRlc3RzIHRo YXQgY2FsbCByZXNpemVUbygpIGNyYXNoIHdoZW4gcnVuIG9uIGlPUyB3aXRoIElPU3VyZmFjZSBz dXBwb3J0IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwMDg2NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTAyNTQwMjE+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1BhZ2VDbGllbnRJbXBsSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6 Y29udmVydFRvRGV2aWNlU3BhY2UpOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6 Y29udmVydFRvVXNlclNwYWNlKToKKyAgICAgICAgSW1wbGVtZW50IGNvbnZlcnRUb3tEZXZpY2Us VXNlcn1TcGFjZSBpbiBQYWdlQ2xpZW50SW1wbElPUy4KKyAgICAgICAgV2UgZG9uJ3QgYWN0dWFs bHkgZG8gYW55IGNvbnZlcnNpb24uIEZvciBvdXIgcHVycG9zZXMsIHRoZSB3aW5kb3cgaXMKKyAg ICAgICAgImRldmljZSIgc3BhY2UsIGFuZCB3ZSBuZXZlciBhbGxvdyBpT1MgV2ViS2l0IGNsaWVu dHMgdG8gcmVzaXplIHRoZSB3aW5kb3cuLi4KKyAgICAgICAgZXhjZXB0IGZvciBpbiB0ZXN0cyEg U28ganVzdCBwYXNzIHRoZSByZWN0cyBzdHJhaWdodCB0aHJvdWdoLCBpbnN0ZWFkIG9mCisgICAg ICAgIHJldHVybmluZyBhbiBlbXB0eSByZWN0LgorCiAyMDE5LTA4LTE3ICBFcmljIExpYW5nICA8 ZXJpY2xpYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgYnVuZGxlUGF0aCBTUEkgaW4gQWNj ZXNzaWJpbGl0eVN1cHBvcnQgZm9yIFdlYlByb2Nlc3NMb2FkZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbQppbmRleCA2NzhkNDAxMjY1MzYx NjUzNjk1ZDIwYzQzOGUxODU0ZjM1YmVkMTU0Li45MmZhYjdlMDU5OGZkMzZmM2Y1NTBiNDE0OWE0 N2UyNGY4YjY4YzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUGFn ZUNsaWVudEltcGxJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1BhZ2VD bGllbnRJbXBsSU9TLm1tCkBAIC0zNzEsMTQgKzM3MSwxMiBAQCB2b2lkIFBhZ2VDbGllbnRJbXBs OjptYWtlRmlyc3RSZXNwb25kZXIoKQogCiBGbG9hdFJlY3QgUGFnZUNsaWVudEltcGw6OmNvbnZl cnRUb0RldmljZVNwYWNlKGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKIHsKLSAgICBub3RJbXBsZW1l bnRlZCgpOwotICAgIHJldHVybiBGbG9hdFJlY3QoKTsKKyAgICByZXR1cm4gcmVjdDsKIH0KIAog RmxvYXRSZWN0IFBhZ2VDbGllbnRJbXBsOjpjb252ZXJ0VG9Vc2VyU3BhY2UoY29uc3QgRmxvYXRS ZWN0JiByZWN0KQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIEZsb2F0UmVj dCgpOworICAgIHJldHVybiByZWN0OwogfQogCiBJbnRQb2ludCBQYWdlQ2xpZW50SW1wbDo6c2Ny ZWVuVG9Sb290Vmlldyhjb25zdCBJbnRQb2ludCYgcG9pbnQpCmRpZmYgLS1naXQgYS9Ub29scy9D aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2I4NThkZjA0NjkwYjAyOWE2Yzg4YjU4 MDUwY2YzMTM2ZWEyYzM5YS4uY2I3YzI4MGQ5YmU1OWVhYmY1MDdiNTQzOGMzNmQzOGFiOGE3NmM2 YyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDE5LTA4LTE3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgorCisgICAgICAgIExheW91dCB0ZXN0cyB0aGF0IGNhbGwgcmVzaXplVG8oKSBjcmFz aCB3aGVuIHJ1biBvbiBpT1Mgd2l0aCBJT1N1cmZhY2Ugc3VwcG9ydCBlbmFibGVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA4NjYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzUwMjU0MDIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3 SU9TLm1tOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90SW1h Z2UpOgorICAgICAgICBSZXBsYWNlIHNvbWUgbG9nZ2luZyB3aXRoIHJlbGVhc2UgYXNzZXJ0aW9u cyB0aGF0IHdlIGFyZSBzbmFwc2hvdHRpbmcgYSByZWFzb25hYmxlCisgICAgICAgIHZpZXcgYW5k IGdldCBhIHJlYXNvbmFibGUgc25hcHNob3QgYmFjay4gRmFpbGluZyB0byBzbmFwc2hvdCBpcyBh IGJpZyBkZWFsLCBhbmQKKyAgICAgICAgInNpbGVudGx5IiBmYWlsaW5nIHdpdGgganVzdCBhIGxv ZyB0aGF0IHdpbGwgYmUgaWdub3JlZCBpcyBub3QgaGVscGZ1bC4KKwogMjAxOS0wOC0xNyAgRXJp YyBMaWFuZyAgPGVyaWNsaWFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgVGVzdGVkIHRoYXQgYWNj ZXNzaWJpbGl0eSBXZWJQcm9jZXNzTG9hZGVyIGJ1bmRsZSBpcyBsb2FkZWQgZm9yIHRoZSBjb3Jy ZWN0IHBhdGguCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9QbGF0Zm9y bVdlYlZpZXdJT1MubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9QbGF0Zm9ybVdlYlZp ZXdJT1MubW0KaW5kZXggNTczNDQ4NzFjMGM5ZTE2MGMzNDgyNGQ0MDE0ZmY3M2I5ZDJhYjZjYS4u NjYxZjI4ZWIzZjZjZDIxYTkxZGZhNzBlM2VhZTczOThjNmIwOTY5YSAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tCisrKyBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2ViVmlld0lPUy5tbQpAQCAtMzE4LDE1ICsz MTgsMjQgQEAgc3RhdGljIHZvaWQgcmVsZWFzZURhdGFQcm92aWRlckRhdGEodm9pZCogaW5mbywg Y29uc3Qgdm9pZCosIHNpemVfdCkKIFJldGFpblB0cjxDR0ltYWdlUmVmPiBQbGF0Zm9ybVdlYlZp ZXc6OndpbmRvd1NuYXBzaG90SW1hZ2UoKQogewogICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBU SU9OUzsKKworICAgIENHU2l6ZSB2aWV3U2l6ZSA9IG1fdmlldy5ib3VuZHMuc2l6ZTsKKyAgICBS RUxFQVNFX0FTU0VSVCh2aWV3U2l6ZS53aWR0aCk7CisgICAgUkVMRUFTRV9BU1NFUlQodmlld1Np emUuaGVpZ2h0KTsKKwogI2lmIEhBVkUoSU9TVVJGQUNFKQogICAgIF9fYmxvY2sgYm9vbCBpc0Rv bmUgPSBmYWxzZTsKICAgICBfX2Jsb2NrIFJldGFpblB0cjxDR0ltYWdlUmVmPiByZXN1bHQ7CiAg ICAgCiAgICAgUmV0YWluUHRyPFdLU25hcHNob3RDb25maWd1cmF0aW9uPiBzbmFwc2hvdENvbmZp Z3VyYXRpb24gPSBhZG9wdE5TKFtbV0tTbmFwc2hvdENvbmZpZ3VyYXRpb24gYWxsb2NdIGluaXRd KTsKLSAgICBbc25hcHNob3RDb25maWd1cmF0aW9uIHNldFJlY3Q6Q0dSZWN0TWFrZSgwLCAwLCBt X3ZpZXcuZnJhbWUuc2l6ZS53aWR0aCwgbV92aWV3LmZyYW1lLnNpemUuaGVpZ2h0KV07Ci0gICAg W3NuYXBzaG90Q29uZmlndXJhdGlvbiBzZXRTbmFwc2hvdFdpZHRoOkAobV92aWV3LmZyYW1lLnNp emUud2lkdGgpXTsKKyAgICBbc25hcHNob3RDb25maWd1cmF0aW9uIHNldFJlY3Q6Q0dSZWN0TWFr ZSgwLCAwLCB2aWV3U2l6ZS53aWR0aCwgdmlld1NpemUuaGVpZ2h0KV07CisgICAgW3NuYXBzaG90 Q29uZmlndXJhdGlvbiBzZXRTbmFwc2hvdFdpZHRoOkAodmlld1NpemUud2lkdGgpXTsKICAgICAK ICAgICBbbV92aWV3IHRha2VTbmFwc2hvdFdpdGhDb25maWd1cmF0aW9uOnNuYXBzaG90Q29uZmln dXJhdGlvbi5nZXQoKSBjb21wbGV0aW9uSGFuZGxlcjpeKFVJSW1hZ2UgKnNuYXBzaG90SW1hZ2Us IE5TRXJyb3IgKmVycm9yKSB7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFlcnJvcik7CisgICAg ICAgIFJFTEVBU0VfQVNTRVJUKHNuYXBzaG90SW1hZ2UpOworICAgICAgICBSRUxFQVNFX0FTU0VS VChzbmFwc2hvdEltYWdlLnNpemUud2lkdGgpOworICAgICAgICBSRUxFQVNFX0FTU0VSVChzbmFw c2hvdEltYWdlLnNpemUuaGVpZ2h0KTsKICAgICAgICAgaWYgKCFlcnJvcikKICAgICAgICAgICAg IHJlc3VsdCA9IFtzbmFwc2hvdEltYWdlIENHSW1hZ2VdOwogICAgICAgICBpc0RvbmUgPSB0cnVl OwpAQCAtMzM5LDE5ICszNDgsMTEgQEAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IFBsYXRmb3JtV2Vi Vmlldzo6d2luZG93U25hcHNob3RJbWFnZSgpCiAgICAgQ0dGbG9hdCBkZXZpY2VTY2FsZUZhY3Rv ciA9IDI7IC8vIEZJWE1FOiBoYXJkY29kZSAyeCBmb3Igbm93LiBJbiBmdXR1cmUgd2UgY291bGQg cmVzcGVjdCAxeCBhbmQgM3ggYXMgd2UgZG8gb24gTWFjLgogICAgIENBVHJhbnNmb3JtM0QgdHJh bnNmb3JtID0gQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZShkZXZpY2VTY2FsZUZhY3RvciwgZGV2aWNl U2NhbGVGYWN0b3IsIDEpOwogICAgIAotICAgIENHU2l6ZSB2aWV3U2l6ZSA9IG1fdmlldy5ib3Vu ZHMuc2l6ZTsKICAgICBpbnQgYnVmZmVyV2lkdGggPSBjZWlsKHZpZXdTaXplLndpZHRoICogZGV2 aWNlU2NhbGVGYWN0b3IpOwogICAgIGludCBidWZmZXJIZWlnaHQgPSBjZWlsKHZpZXdTaXplLmhl aWdodCAqIGRldmljZVNjYWxlRmFjdG9yKTsKLSAgICBpZiAoIWJ1ZmZlcldpZHRoIHx8ICFidWZm ZXJIZWlnaHQpIHsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJCZWluZyBhc2tlZCBmb3Igc25hcHNo b3Qgb2YgdmlldyB3aXRoIHdpZHRoICVkIGhlaWdodCAlZFxuIiwgYnVmZmVyV2lkdGgsIGJ1ZmZl ckhlaWdodCk7Ci0gICAgICAgIHJldHVybiBudWxscHRyOwotICAgIH0KIAogICAgIENBUmVuZGVy U2VydmVyQnVmZmVyUmVmIGJ1ZmZlciA9IENBUmVuZGVyU2VydmVyQ3JlYXRlQnVmZmVyKGJ1ZmZl cldpZHRoLCBidWZmZXJIZWlnaHQpOwotICAgIGlmICghYnVmZmVyKSB7Ci0gICAgICAgIFdURkxv Z0Fsd2F5cygiQ0FSZW5kZXJTZXJ2ZXJDcmVhdGVCdWZmZXIgZmFpbGVkIGZvciBidWZmZXIgd2l0 aCB3aWR0aCAlZCBoZWlnaHQgJWRcbiIsIGJ1ZmZlcldpZHRoLCBidWZmZXJIZWlnaHQpOwotICAg ICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICB9CisgICAgUkVMRUFTRV9BU1NFUlQoYnVmZmVyKTsK IAogICAgIENBUmVuZGVyU2VydmVyUmVuZGVyTGF5ZXJXaXRoVHJhbnNmb3JtKE1BQ0hfUE9SVF9O VUxMLCBtX3ZpZXcubGF5ZXIuY29udGV4dC5jb250ZXh0SWQsIHJlaW50ZXJwcmV0X2Nhc3Q8dWlu dDY0X3Q+KG1fdmlldy5sYXllciksIGJ1ZmZlciwgMCwgMCwgJnRyYW5zZm9ybSk7CiAKQEAgLTM2 Miw2ICszNjMsNyBAQCBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gUGxhdGZvcm1XZWJWaWV3Ojp3aW5k b3dTbmFwc2hvdEltYWdlKCkKICAgICBSZXRhaW5QdHI8Q0dEYXRhUHJvdmlkZXJSZWY+IHByb3Zp ZGVyID0gYWRvcHRDRihDR0RhdGFQcm92aWRlckNyZWF0ZVdpdGhEYXRhKGJ1ZmZlciwgZGF0YSwg Q0FSZW5kZXJTZXJ2ZXJHZXRCdWZmZXJEYXRhU2l6ZShidWZmZXIpLCByZWxlYXNlRGF0YVByb3Zp ZGVyRGF0YSkpOwogICAgIAogICAgIFJldGFpblB0cjxDR0ltYWdlUmVmPiBjZ0ltYWdlID0gYWRv cHRDRihDR0ltYWdlQ3JlYXRlKGJ1ZmZlcldpZHRoLCBidWZmZXJIZWlnaHQsIDgsIDMyLCByb3dC eXRlcywgc1JHQlNwYWNlLCBrQ0dJbWFnZUFscGhhUHJlbXVsdGlwbGllZEZpcnN0IHwga0NHQml0 bWFwQnl0ZU9yZGVyMzJIb3N0LCBwcm92aWRlci5nZXQoKSwgMCwgZmFsc2UsIGtDR1JlbmRlcmlu Z0ludGVudERlZmF1bHQpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChjZ0ltYWdlKTsKIAogICAgIHJl dHVybiBjZ0ltYWdlOwogI2VuZGlmCg==