200864 2019-08-17 16:43:07 -0700 [JSC] DFG ToNumber should support Boolean in fixup 2019-08-17 18:51:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1562515 0 ysuzuki 2019-08-17 16:43:07 -0700 [JSC] DFG ToNumber should supoort Boolean in fixup 1562516 1 376615 ysuzuki 2019-08-17 16:43:53 -0700 Created attachment 376615 Patch 1562517 2 ysuzuki 2019-08-17 16:45:56 -0700 https://twitter.com/WebReflection/status/1162373246030929926 1562521 3 376615 mark.lam 2019-08-17 17:18:38 -0700 Comment on attachment 376615 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376615&action=review r=me > Source/JavaScriptCore/ChangeLog:3 > + [JSC] DFG ToNumber should supoort Boolean in fixup /supoort/support/ 1562544 4 376615 ysuzuki 2019-08-17 18:49:56 -0700 Comment on attachment 376615 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376615&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] DFG ToNumber should supoort Boolean in fixup > > /supoort/support/ Thanks, fixed. 1562545 5 ysuzuki 2019-08-17 18:50:50 -0700 Committed r248825: <https://trac.webkit.org/changeset/248825> 1562546 6 webkit-bug-importer 2019-08-17 18:51:18 -0700 <rdar://problem/54435389> 376615 2019-08-17 16:43:53 -0700 2019-08-17 17:18:38 -0700 Patch bug-200864-20190817164351.patch text/plain 6257 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZTM0MmI2ZDIxMTEzNDY0NzczNTdmODdkYmYxMWEwZjg1ZTViZTU5Li5mNjdlYjc5ZGMyNmFkMTk1 NTNlYzA5NWY4ODFlNmEyM2IzNmYzZWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wOC0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERGRyBUb051bWJlciBzaG91bGQgc3Vwb29ydCBCb29sZWFuIGlu IGZpeHVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDA4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU b051bWJlciBzaG91bGQgc3BlY3VsYXRlIG9uIEJvb2xlYW4sIG9yIEJvb2xlYW5PckludDMyIGlu IGZpeHVwIHBoYXNlIHRvIG9wdGltaXplIGl0LgorCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBUb1QgICAgICAgICAgICAgICAgICAgICBQYXRjaGVkCisKKyAgICAg ICAgICAgIHRvLW51bWJlci1ib29sZWFuICAgICAgODk3LjY0MzArLTI2Ljg4NDMgICAgXiAgICAg ODcuNDgwMistNS4yODMxICAgICAgICBeIGRlZmluaXRlbHkgMTAuMjYxMXggZmFzdGVyCisKKyAg ICAgICAgKiBkZmcvREZHRml4dXBQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Rml4dXBQ aGFzZTo6Zml4dXBUb051bWJlcik6CisKIDIwMTktMDgtMTYgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIE1vcmUgbWlzc2luZyBleGNlcHRpb24gY2hlY2tzIGluIHN0 cmluZyBjb21wYXJpc29uIG9wZXJhdG9ycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0ZpeHVwUGhhc2UuY3BwCmluZGV4IGM1OGFhY2YxMmFkMTk2NWY5NGQwZDIxNmNjMjViYzU4ODRh NGRkOWMuLmZiYzlhYzI4NTNiZDNlZmU5ZDIwMmFhOWIyNmFhODYxNDM1NTIxNTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcApAQCAtMjgyMCw2ICsyODIw LDE1IEBAIGNsYXNzIEZpeHVwUGhhc2UgOiBwdWJsaWMgUGhhc2UgewogCiAgICAgdm9pZCBmaXh1 cFRvTnVtYmVyKE5vZGUqIG5vZGUpCiAgICAgeworICAgICAgICAvLyBBdCBmaXJzdCwgYXR0ZW1w dCB0byBmb2xkIEJvb2xlYW4gb3IgSW50MzIgdG8gSW50MzIuCisgICAgICAgIGlmIChub2RlLT5j aGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlSW50MzJPckJvb2xlYW4oKSkgeworICAgICAgICAgICAg aWYgKGlzSW50MzJTcGVjdWxhdGlvbihub2RlLT5nZXRIZWFwUHJlZGljdGlvbigpKSkgeworICAg ICAgICAgICAgICAgIGZpeEludE9yQm9vbGVhbkVkZ2Uobm9kZS0+Y2hpbGQxKCkpOworICAgICAg ICAgICAgICAgIG5vZGUtPmNvbnZlcnRUb0lkZW50aXR5KCk7CisgICAgICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICAgICAgfQorICAgICAgICB9CisKICAgICAgICAgLy8gSWYgdGhlIHByZWRp Y3Rpb24gb2YgdGhlIGNoaWxkIGlzIE51bWJlciwgd2UgYXR0ZW1wdCB0byBjb252ZXJ0IFRvTnVt YmVyIHRvIElkZW50aXR5LgogICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1 bGF0ZU51bWJlcigpKSB7CiAgICAgICAgICAgICBpZiAoaXNJbnQzMlNwZWN1bGF0aW9uKG5vZGUt PmdldEhlYXBQcmVkaWN0aW9uKCkpKSB7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBi L0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGViMTZiZDIyNzg1ZGY5YjE4NzZmZmFhMTg0MTQ5MjM0 NGNlNjM2MDAuLjhmN2IzNjExYzY3NjkwZmQyZTU3ZDUyNTU5ZjM4ZDAyMmYzNGRiYjkgMTAwNjQ0 Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjUgQEAKKzIwMTktMDgtMTcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4K KworICAgICAgICBbSlNDXSBERkcgVG9OdW1iZXIgc2hvdWxkIHN1cG9vcnQgQm9vbGVhbiBpbiBm aXh1cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAw ODY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBt aWNyb2JlbmNobWFya3MvdG8tbnVtYmVyLWJvb2xlYW4uanM6IEFkZGVkLgorICAgICAgICAodGVz dCk6CisgICAgICAgICogc3RyZXNzL3RvLW51bWJlci1ib29sZWFuLWludDMyLmpzOiBBZGRlZC4K KyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAgKHRlc3QpOgorICAgICAgICAoY2hlY2spOgor ICAgICAgICAqIHN0cmVzcy90by1udW1iZXItYm9vbGVhbi5qczogQWRkZWQuCisgICAgICAgIChz aG91bGRCZSk6CisgICAgICAgICh0ZXN0KToKKyAgICAgICAgKGNoZWNrKToKKyAgICAgICAgKiBz dHJlc3MvdG8tbnVtYmVyLWludDMyLmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAg ICAgICAgKHRlc3QpOgorICAgICAgICAoY2hlY2spOgorCiAyMDE5LTA4LTE2ICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3JlIG1pc3NpbmcgZXhjZXB0aW9uIGNo ZWNrcyBpbiBzdHJpbmcgY29tcGFyaXNvbiBvcGVyYXRvcnMuCmRpZmYgLS1naXQgYS9KU1Rlc3Rz L21pY3JvYmVuY2htYXJrcy90by1udW1iZXItYm9vbGVhbi5qcyBiL0pTVGVzdHMvbWljcm9iZW5j aG1hcmtzL3RvLW51bWJlci1ib29sZWFuLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY2NDU5MzRlZGYyYWIwYmMw NWRkMmMxMmViM2E5NmM3NzcyNmI1MmQKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL21pY3Jv YmVuY2htYXJrcy90by1udW1iZXItYm9vbGVhbi5qcwpAQCAtMCwwICsxLDE2IEBACit2YXIgYXJy YXkgPSBbXTsKK3ZhciBjYXN0ZWQgPSBbXTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgMWUzOyArK2kp IHsKKyAgICBhcnJheVtpXSA9IE1hdGgucmFuZG9tKCk7CisgICAgY2FzdGVkW2ldID0gMDsKK30K KworZnVuY3Rpb24gdGVzdChhcnJheSwgY2FzdGVkKQoreworICAgIGZvciAodmFyIGkgPSAwOyBp IDwgYXJyYXkubGVuZ3RoOyBpKyspCisgICAgICAgIGNhc3RlZFtpXSA9IE51bWJlcihhcnJheVtp XSA8IC41KTsKK30KK25vSW5saW5lKHRlc3QpOworCitmb3IgKHZhciBpID0gMDsgaSA8IDFlNTsg KytpKQorICAgIHRlc3QoYXJyYXksIGNhc3RlZCk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVz cy90by1udW1iZXItYm9vbGVhbi1pbnQzMi5qcyBiL0pTVGVzdHMvc3RyZXNzL3RvLW51bWJlci1i b29sZWFuLWludDMyLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ2ZjNjZjJmNjlmMzQxMjA3NzdjM2MxOWQ1M2Mx YWViNWM2YzIyY2IKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy90by1udW1iZXIt Ym9vbGVhbi1pbnQzMi5qcwpAQCAtMCwwICsxLDMwIEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1 YWwsIGV4cGVjdGVkKSB7CisgICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRo cm93IG5ldyBFcnJvcignYmFkIHZhbHVlOiAnICsgYWN0dWFsKTsKK30KKwordmFyIGFycmF5ID0g W107Cit2YXIgY2FzdGVkID0gW107Citmb3IgKHZhciBpID0gMDsgaSA8IDFlMjsgKytpKSB7Cisg ICAgYXJyYXlbaV0gPSBNYXRoLnJhbmRvbSgpOworICAgIGNhc3RlZFtpXSA9IDA7Cit9CisKK2Z1 bmN0aW9uIHRlc3QoYXJyYXksIGNhc3RlZCkKK3sKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IGFy cmF5Lmxlbmd0aDsgaSsrKQorICAgICAgICBjYXN0ZWRbaV0gPSBOdW1iZXIoYXJyYXlbaV0gPCAu NSA/IHRydWUgOiAwKTsKK30KK25vSW5saW5lKHRlc3QpOworCitmdW5jdGlvbiBjaGVjayhhcnJh eSwgY2FzdGVkKQoreworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYXJyYXkubGVuZ3RoOyBpKysp CisgICAgICAgIHNob3VsZEJlKGNhc3RlZFtpXSwgKGFycmF5W2ldIDwgLjUgPyAxIDogMCkpOwor fQorbm9JbmxpbmUoY2hlY2spOworCitmb3IgKHZhciBpID0gMDsgaSA8IDFlNTsgKytpKSB7Cisg ICAgdGVzdChhcnJheSwgY2FzdGVkKTsKKyAgICBjaGVjayhhcnJheSwgY2FzdGVkKTsKK30KZGlm ZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3RvLW51bWJlci1ib29sZWFuLmpzIGIvSlNUZXN0cy9z dHJlc3MvdG8tbnVtYmVyLWJvb2xlYW4uanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDQyM2U2ZDI2MTYzNDkyYTc5 YThjOTUwMmM0MTcyYzBlOGI4YTJiYQotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNz L3RvLW51bWJlci1ib29sZWFuLmpzCkBAIC0wLDAgKzEsMzAgQEAKK2Z1bmN0aW9uIHNob3VsZEJl KGFjdHVhbCwgZXhwZWN0ZWQpIHsKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkKKyAgICAg ICAgdGhyb3cgbmV3IEVycm9yKCdiYWQgdmFsdWU6ICcgKyBhY3R1YWwpOworfQorCit2YXIgYXJy YXkgPSBbXTsKK3ZhciBjYXN0ZWQgPSBbXTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgMWUyOyArK2kp IHsKKyAgICBhcnJheVtpXSA9IE1hdGgucmFuZG9tKCk7CisgICAgY2FzdGVkW2ldID0gMDsKK30K KworZnVuY3Rpb24gdGVzdChhcnJheSwgY2FzdGVkKQoreworICAgIGZvciAodmFyIGkgPSAwOyBp IDwgYXJyYXkubGVuZ3RoOyBpKyspCisgICAgICAgIGNhc3RlZFtpXSA9IE51bWJlcihhcnJheVtp XSA8IC41KTsKK30KK25vSW5saW5lKHRlc3QpOworCitmdW5jdGlvbiBjaGVjayhhcnJheSwgY2Fz dGVkKQoreworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYXJyYXkubGVuZ3RoOyBpKyspCisgICAg ICAgIHNob3VsZEJlKGNhc3RlZFtpXSwgKGFycmF5W2ldIDwgLjUgPyAxIDogMCkpOworfQorbm9J bmxpbmUoY2hlY2spOworCitmb3IgKHZhciBpID0gMDsgaSA8IDFlNTsgKytpKSB7CisgICAgdGVz dChhcnJheSwgY2FzdGVkKTsKKyAgICBjaGVjayhhcnJheSwgY2FzdGVkKTsKK30KZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL3RvLW51bWJlci1pbnQzMi5qcyBiL0pTVGVzdHMvc3RyZXNzL3Rv LW51bWJlci1pbnQzMi5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MzQ2Y2FjMGYxMDA3NjViMzNkNTU2MmEyZjBl MWUzOTZlMjI1MjBjCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvdG8tbnVtYmVy LWludDMyLmpzCkBAIC0wLDAgKzEsMzAgQEAKK2Z1bmN0aW9uIHNob3VsZEJlKGFjdHVhbCwgZXhw ZWN0ZWQpIHsKKyAgICBpZiAoYWN0dWFsICE9PSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cgbmV3 IEVycm9yKCdiYWQgdmFsdWU6ICcgKyBhY3R1YWwpOworfQorCit2YXIgYXJyYXkgPSBbXTsKK3Zh ciBjYXN0ZWQgPSBbXTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgMWUyOyArK2kpIHsKKyAgICBhcnJh eVtpXSA9IE1hdGgucmFuZG9tKCk7CisgICAgY2FzdGVkW2ldID0gMDsKK30KKworZnVuY3Rpb24g dGVzdChhcnJheSwgY2FzdGVkKQoreworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYXJyYXkubGVu Z3RoOyBpKyspCisgICAgICAgIGNhc3RlZFtpXSA9IE51bWJlcihhcnJheVtpXSA8IC41ID8gMSA6 IDApOworfQorbm9JbmxpbmUodGVzdCk7CisKK2Z1bmN0aW9uIGNoZWNrKGFycmF5LCBjYXN0ZWQp Cit7CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBhcnJheS5sZW5ndGg7IGkrKykKKyAgICAgICAg c2hvdWxkQmUoY2FzdGVkW2ldLCAoYXJyYXlbaV0gPCAuNSA/IDEgOiAwKSk7Cit9Citub0lubGlu ZShjaGVjayk7CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMWU1OyArK2kpIHsKKyAgICB0ZXN0KGFy cmF5LCBjYXN0ZWQpOworICAgIGNoZWNrKGFycmF5LCBjYXN0ZWQpOworfQo=