20086 2008-07-17 14:31:16 -0700 Assertion about creating Length with percentage value when blending transforms 2008-07-18 14:49:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino oldest_to_newest 86274 0 simon.fraser 2008-07-17 14:31:16 -0700 In the attached testcase, hover over the blue box. It asserts here: Length(int v, LengthType t, bool q = false) : m_value((v * 16) | (q << 3) | t) // FIXME: Doesn't work if the passed-in value is very large! { ASSERT(t != Percent); } 86275 1 22351 simon.fraser 2008-07-17 14:33:26 -0700 Created attachment 22351 Testcase; asserts in debug build on hover. 86276 2 simon.fraser 2008-07-17 14:37:03 -0700 The issue is that Length(0, m_x.type()).blend(m_x, progress) creates a Length() using a value of 0 and the type from m_x, which can be percentage. This asserts in the Length ctor. Instead, we use Length(m_x.type()).blend(m_x, progress) which just constructs a Length with the right type, and blends that. 86279 3 22352 simon.fraser 2008-07-17 14:40:32 -0700 Created attachment 22352 Patch, changelog 86359 4 22352 hyatt 2008-07-18 12:17:50 -0700 Comment on attachment 22352 Patch, changelog r=me 86382 5 simon.fraser 2008-07-18 14:49:02 -0700 Fixed in r35238. 22351 2008-07-17 14:33:26 -0700 2008-07-17 14:33:26 -0700 Testcase; asserts in debug build on hover. percentage_blend.html text/html 801 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+QmxlbmQgd2l0aCBQZXJjZW50 YWdlPC90aXRsZT4KICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgogICAg LmJveCB7CiAgICAgIGhlaWdodDogMzAwcHg7CiAgICAgIHdpZHRoOiAzMDBweDsKICAgICAgYmFj a2dyb3VuZC1jb2xvcjogYmx1ZTsKICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgt NTAlLCAtNTAlKSBzY2FsZSgwLjI1LCAwLjI1KSB0cmFuc2xhdGUoNTAlLCA1MCUpOwogICAgICAt d2Via2l0LXRyYW5zaXRpb24tcHJvcGVydHk6IC13ZWJraXQtdHJhbnNmb3JtOwogICAgICAtd2Vi a2l0LXRyYW5zaXRpb24tZHVyYXRpb246IDFzOwogICAgfQogICAgCiAgICAuYm94OmhvdmVyIHsK ICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHNjYWxlKDEpOwogICAgfQogIDwvc3R5bGU+CjwvaGVh ZD4KPGJvZHk+Cgo8cD5TaG91bGQgbm90IGFzc2VydCB3aGVuIGhvdmVyaW5nIG92ZXIgdGhlIGJs dWUgYm94ICg8YSBocmVmPSJyZGFyOi8vcHJvYmxlbS82MDU4Mzc1Ij5yZGFyOi8vcHJvYmxlbS82 MDU4Mzc1PC9hPik8L3A+CjxkaXYgY2xhc3M9ImJveCI+CiAgCjwvZGl2Pgo8L2JvZHk+CjwvaHRt bD4K 22352 2008-07-17 14:40:32 -0700 2008-07-18 12:17:50 -0700 Patch, changelog percentage_blend_patch.txt text/plain 1699 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGU0NjBlMC4uMGFmZTU3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOC0wNy0xNyAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggYXNzZXJ0aW9uIGFib3V0IGNyZWF0aW5nIExlbmd0aCB2 YWx1ZXMgd2l0aCBwZXJjZW50YWdlIHR5cGVzCisgICAgICAgIHdoZW4gYmxlbmRpbmcgdHJhbnNm b3Jtcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDg2CisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZCk6CisKIDIwMDgt MDctMTUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGUuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCmlu ZGV4IGNiYTYwYjAuLmZhZmY3ZTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1JlbmRlclN0eWxlLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZS5jcHAKQEAgLTYyNywxMSArNjI3LDExIEBAIFRyYW5zZm9ybU9wZXJhdGlvbiogVHJhbnNsYXRl VHJhbnNmb3JtT3BlcmF0aW9uOjpibGVuZChjb25zdCBUcmFuc2Zvcm1PcGVyYXRpb24qCiAgICAg ICAgIHJldHVybiB0aGlzOwogICAgIAogICAgIGlmIChibGVuZFRvSWRlbnRpdHkpCi0gICAgICAg IHJldHVybiBuZXcgVHJhbnNsYXRlVHJhbnNmb3JtT3BlcmF0aW9uKExlbmd0aCgwLCBtX3gudHlw ZSgpKS5ibGVuZChtX3gsIHByb2dyZXNzKSwgTGVuZ3RoKDAsIG1feS50eXBlKCkpLmJsZW5kKG1f eSwgcHJvZ3Jlc3MpKTsKKyAgICAgICAgcmV0dXJuIG5ldyBUcmFuc2xhdGVUcmFuc2Zvcm1PcGVy YXRpb24oTGVuZ3RoKG1feC50eXBlKCkpLmJsZW5kKG1feCwgcHJvZ3Jlc3MpLCBMZW5ndGgobV95 LnR5cGUoKSkuYmxlbmQobV95LCBwcm9ncmVzcykpOwogCiAgICAgY29uc3QgVHJhbnNsYXRlVHJh bnNmb3JtT3BlcmF0aW9uKiBmcm9tT3AgPSBzdGF0aWNfY2FzdDxjb25zdCBUcmFuc2xhdGVUcmFu c2Zvcm1PcGVyYXRpb24qPihmcm9tKTsKLSAgICBMZW5ndGggZnJvbVggPSBmcm9tT3AgPyBmcm9t T3AtPm1feCA6IExlbmd0aCgwLCBtX3gudHlwZSgpKTsKLSAgICBMZW5ndGggZnJvbVkgPSBmcm9t T3AgPyBmcm9tT3AtPm1feSA6IExlbmd0aCgwLCBtX3kudHlwZSgpKTsKKyAgICBMZW5ndGggZnJv bVggPSBmcm9tT3AgPyBmcm9tT3AtPm1feCA6IExlbmd0aChtX3gudHlwZSgpKTsKKyAgICBMZW5n dGggZnJvbVkgPSBmcm9tT3AgPyBmcm9tT3AtPm1feSA6IExlbmd0aChtX3kudHlwZSgpKTsKICAg ICByZXR1cm4gbmV3IFRyYW5zbGF0ZVRyYW5zZm9ybU9wZXJhdGlvbihtX3guYmxlbmQoZnJvbVgs IHByb2dyZXNzKSwgbV95LmJsZW5kKGZyb21ZLCBwcm9ncmVzcykpOwogfQogCg==