200839 2019-08-16 16:07:13 -0700 [results.webkit.org Timeline] Disable back gesture 2019-08-19 11:10:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang webkit-unassigned commit-queue jbedard webkit-bug-importer zhifei_fang oldest_to_newest 1562276 0 zhifei_fang 2019-08-16 16:07:13 -0700 Disable back gesture, so that when user scroll, it won't be accidentally back to the pervious page, this is supper annoying, and create a bad UX. 1562281 1 376557 zhifei_fang 2019-08-16 16:10:39 -0700 Created attachment 376557 Patch 1562289 2 376557 jbedard 2019-08-16 16:32:39 -0700 Comment on attachment 376557 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376557&action=review > Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:92 > + //console.log(e); Did we forget to remove this? > Tools/resultsdbpy/resultsdbpy/view/templates/base.html:54 > + // This will disable back gesture We don't need the comment, function name is enough. 1562348 3 376572 zhifei_fang 2019-08-16 18:08:53 -0700 Created attachment 376572 Patch 1562757 4 376572 commit-queue 2019-08-19 11:09:47 -0700 Comment on attachment 376572 Patch Clearing flags on attachment: 376572 Committed r248859: <https://trac.webkit.org/changeset/248859> 1562758 5 commit-queue 2019-08-19 11:09:50 -0700 All reviewed patches have been landed. Closing bug. 1562759 6 webkit-bug-importer 2019-08-19 11:10:21 -0700 <rdar://problem/54474386> 376557 2019-08-16 16:10:39 -0700 2019-08-16 18:08:51 -0700 Patch bug-200839-20190816161038.patch text/plain 2357 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjczYmJjYzA5MTRkM2I3MDg5YTU3MzFiMjhjOGFjMWZi MDY3Mjc3Ny4uNDMzMTljMWYwM2Y2MmFmMjU5NDViZjMxYWM1MmU5ZWFjMzg2MGZjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA4LTE2ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBbcmVzdWx0cy53ZWJraXQub3JnIFRpbWVsaW5lXSBEaXNhYmxlIGJhY2sgZ2VzdHVy ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODM5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1V0aWxzLmpzOgorICAg ICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvdGVtcGxhdGVzL2Jhc2UuaHRtbDoK KwogMjAxOS0wOC0xNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjI0ODQzNik6IFdLV2ViVmlldyBkb2VzbuKAmXQgcmVzcGVjdCBp c09wYXF1ZSBzZXR0aW5nIGluIE5JQi4KZGlmZiAtLWdpdCBhL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvVXRpbHMuanMgYi9Ub29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1V0aWxzLmpzCmluZGV4IDg3 OTZiMTA4Y2MzM2E4NmVkMWMzNmFiZDNiYzJiYTMzMDFiY2Y5OTAuLmU2NTJlMWY3MzY1ODc0Njg2 MjEzMjg1ODUzZjEzNzNhYzlhM2EzYjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvVXRpbHMuanMKKysrIGIvVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9VdGlscy5qcwpAQCAt ODIsNCArODIsMTcgQEAgZnVuY3Rpb24gY3JlYXRlSW5zZXJ0aW9uT2JzZXJ2ZXJzKGVsZW1lbnQs IGNhbGxiYWNrPSgpPT57fSwgc3RhcnRUaHJlc2hvbGQ9MC4wLAogICAgIH0pOwogfQogCi1leHBv cnQge3RpbWVEaWZmZXJlbmNlLCBpc0RhcmtNb2RlLCBDb29raWUsIGNyZWF0ZUluc2VydGlvbk9i c2VydmVyc307CitmdW5jdGlvbiBkaXNhYmxlQmFja0dlc3R1cmUoKSB7CisgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ21vdXNld2hlZWwnLCBlID0+IHsKKyAgICAgICAgY29uc3QgdGFyZ2V0 ID0gZS50YXJnZXQ7CisgICAgICAgIGZvciAobGV0IHBhcmVudCA9IHRhcmdldC5wYXJlbnRFbGVt ZW50OyBwYXJlbnQ7IHBhcmVudCA9IHBhcmVudC5wYXJlbnRFbGVtZW50ICkgeworICAgICAgICAg ICAgaWYgKHBhcmVudC5zY3JvbGxMZWZ0ICE9PSAwICYmIGUuZGVsdGFYIDwgMCkKKyAgICAgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgLy9jb25zb2xlLmxvZyhlKTsKKyAg ICAgICAgaWYgKGUuZGVsdGFYIDwgMCkKKyAgICAgICAgICAgIGUucHJldmVudERlZmF1bHQoKTsK KyAgICB9KTsKK30KKworZXhwb3J0IHt0aW1lRGlmZmVyZW5jZSwgaXNEYXJrTW9kZSwgQ29va2ll LCBjcmVhdGVJbnNlcnRpb25PYnNlcnZlcnMsIGRpc2FibGVCYWNrR2VzdHVyZX07CmRpZmYgLS1n aXQgYS9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9iYXNlLmh0 bWwgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3RlbXBsYXRlcy9iYXNlLmh0 bWwKaW5kZXggNmI5NTA0Y2Q0NzVhZTU2ZTUzYmVjMjM0Zjk0ZmI0OGE4Y2NmOWVjMy4uNzYxMmVl MDkwNGMwYWVmYzMwMTYwNjBmMDhjYmIyODhlNjBhMmIzZSAxMDA2NDQKLS0tIGEvVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy90ZW1wbGF0ZXMvYmFzZS5odG1sCisrKyBiL1Rvb2xz L3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvdGVtcGxhdGVzL2Jhc2UuaHRtbApAQCAtNTAs NSArNTAsMTAgQEAKICAgICA8L2Rpdj4KIDwvZGl2PgogeyUgYmxvY2sgY29udGVudCAlfXslIGVu ZGJsb2NrICV9Cis8c2NyaXB0IHR5cGU9Im1vZHVsZSI+CisgICAgLy8gVGhpcyB3aWxsIGRpc2Fi bGUgYmFjayBnZXN0dXJlCisgICAgaW1wb3J0IHtkaXNhYmxlQmFja0dlc3R1cmV9IGZyb20gJy9s aWJyYXJ5L2pzL1V0aWxzLmpzJzsKKyAgICBkaXNhYmxlQmFja0dlc3R1cmUoKTsKKzwvc2NyaXB0 PgogPC9ib2R5PgogPC9odG1sPgo= 376572 2019-08-16 18:08:53 -0700 2019-08-19 11:09:47 -0700 Patch bug-200839-20190816180852.patch text/plain 2290 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4ODAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjczYmJjYzA5MTRkM2I3MDg5YTU3MzFiMjhjOGFjMWZi MDY3Mjc3Ny4uNDMzMTljMWYwM2Y2MmFmMjU5NDViZjMxYWM1MmU5ZWFjMzg2MGZjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA4LTE2ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBbcmVzdWx0cy53ZWJraXQub3JnIFRpbWVsaW5lXSBEaXNhYmxlIGJhY2sgZ2VzdHVy ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODM5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1V0aWxzLmpzOgorICAg ICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvdGVtcGxhdGVzL2Jhc2UuaHRtbDoK KwogMjAxOS0wOC0xNiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjI0ODQzNik6IFdLV2ViVmlldyBkb2VzbuKAmXQgcmVzcGVjdCBp c09wYXF1ZSBzZXR0aW5nIGluIE5JQi4KZGlmZiAtLWdpdCBhL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvVXRpbHMuanMgYi9Ub29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL1V0aWxzLmpzCmluZGV4IDg3 OTZiMTA4Y2MzM2E4NmVkMWMzNmFiZDNiYzJiYTMzMDFiY2Y5OTAuLjViZmZkMmI5YjI5ZDViMzlk YTdiZTFjNTg4YjA5ZWEzMmRlM2Q1MDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvVXRpbHMuanMKKysrIGIvVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9VdGlscy5qcwpAQCAt ODIsNCArODIsMTYgQEAgZnVuY3Rpb24gY3JlYXRlSW5zZXJ0aW9uT2JzZXJ2ZXJzKGVsZW1lbnQs IGNhbGxiYWNrPSgpPT57fSwgc3RhcnRUaHJlc2hvbGQ9MC4wLAogICAgIH0pOwogfQogCi1leHBv cnQge3RpbWVEaWZmZXJlbmNlLCBpc0RhcmtNb2RlLCBDb29raWUsIGNyZWF0ZUluc2VydGlvbk9i c2VydmVyc307CitmdW5jdGlvbiBkaXNhYmxlQmFja0dlc3R1cmUoKSB7CisgICAgd2luZG93LmFk ZEV2ZW50TGlzdGVuZXIoJ21vdXNld2hlZWwnLCBlID0+IHsKKyAgICAgICAgY29uc3QgdGFyZ2V0 ID0gZS50YXJnZXQ7CisgICAgICAgIGZvciAobGV0IHBhcmVudCA9IHRhcmdldC5wYXJlbnRFbGVt ZW50OyBwYXJlbnQ7IHBhcmVudCA9IHBhcmVudC5wYXJlbnRFbGVtZW50ICkgeworICAgICAgICAg ICAgaWYgKHBhcmVudC5zY3JvbGxMZWZ0ICE9PSAwICYmIGUuZGVsdGFYIDwgMCkKKyAgICAgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgaWYgKGUuZGVsdGFYIDwgMCkKKyAg ICAgICAgICAgIGUucHJldmVudERlZmF1bHQoKTsKKyAgICB9KTsKK30KKworZXhwb3J0IHt0aW1l RGlmZmVyZW5jZSwgaXNEYXJrTW9kZSwgQ29va2llLCBjcmVhdGVJbnNlcnRpb25PYnNlcnZlcnMs IGRpc2FibGVCYWNrR2VzdHVyZX07CmRpZmYgLS1naXQgYS9Ub29scy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3RlbXBsYXRlcy9iYXNlLmh0bWwgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3RlbXBsYXRlcy9iYXNlLmh0bWwKaW5kZXggNmI5NTA0Y2Q0NzVhZTU2ZTUz YmVjMjM0Zjk0ZmI0OGE4Y2NmOWVjMy4uZjU3ZjJlMzc1Mjk3MDIwYzRkYTRjYjg1ZjBlZWIzZjVl MWNmNDcwZSAxMDA2NDQKLS0tIGEvVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy90 ZW1wbGF0ZXMvYmFzZS5odG1sCisrKyBiL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3Zp ZXcvdGVtcGxhdGVzL2Jhc2UuaHRtbApAQCAtNTAsNSArNTAsOSBAQAogICAgIDwvZGl2PgogPC9k aXY+CiB7JSBibG9jayBjb250ZW50ICV9eyUgZW5kYmxvY2sgJX0KKzxzY3JpcHQgdHlwZT0ibW9k dWxlIj4KKyAgICBpbXBvcnQge2Rpc2FibGVCYWNrR2VzdHVyZX0gZnJvbSAnL2xpYnJhcnkvanMv VXRpbHMuanMnOworICAgIGRpc2FibGVCYWNrR2VzdHVyZSgpOworPC9zY3JpcHQ+CiA8L2JvZHk+ CiA8L2h0bWw+Cg==