200829 2019-08-16 13:34:24 -0700 [JSC] Promise.prototype.finally should accept non-promise objects 2019-08-16 14:04:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200739 1 ysuzuki ysuzuki ews-watchlist joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1562181 0 ysuzuki 2019-08-16 13:34:24 -0700 [JSC] Promise.prototype.finally should accept non-promise objects 1562183 1 376532 ysuzuki 2019-08-16 13:35:59 -0700 Created attachment 376532 Patch 1562186 2 376532 ysuzuki 2019-08-16 13:36:53 -0700 Comment on attachment 376532 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376532&action=review > Source/JavaScriptCore/builtins/PromisePrototype.js:72 > + @throwTypeError("|this| is not a object"); We pick `a object` since the other methods are using this... We should fix it in a separate patch in a bulk manner. 1562187 3 376532 mark.lam 2019-08-16 13:39:41 -0700 Comment on attachment 376532 Patch r=me 1562191 4 ysuzuki 2019-08-16 13:44:11 -0700 I also added a test passing `non-object` to finally to check the thrown error. 1562193 5 ysuzuki 2019-08-16 13:44:46 -0700 Committed r248793: <https://trac.webkit.org/changeset/248793> 1562194 6 webkit-bug-importer 2019-08-16 13:45:18 -0700 <rdar://problem/54405556> 376532 2019-08-16 13:35:59 -0700 2019-08-16 13:39:41 -0700 Patch bug-200829-20190816133558.patch text/plain 3433 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjI4NTBiODRlYTNhYjFiOTc0YjJjZDM2MWJiNGRmMjUzNzI4MThjLi41MDliYzYzNzk4ODAxY2Nm ZDBiY2I0MDVmZmFhYjk0NWZlNmJiOGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wOC0xNiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFByb21pc2UucHJvdG90eXBlLmZpbmFsbHkgc2hvdWxkIGFjY2Vw dCBub24tcHJvbWlzZSBvYmplY3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA4MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIFByb21pc2UucHJvdG90eXBlLmZpbmFsbHkg c3BlYyBzdGVwIDJbMV0sIHdlIHNob3VsZCBjaGVjayBAaXNPYmplY3QgaW5zdGVhZCBvZiBAaXNQ cm9taXNlLAorICAgICAgICBzaW5jZSBQcm9taXNlLnByb3RvdHlwZS5maW5hbGx5IHNob3VsZCBh Y2NlcHQgdGhlbmFibGUgb2JqZWN0cyB0aGF0IGFyZSBkZWZpbmVkIGJ5IHVzZXIgbGlicmFyaWVz IChsaWtlLCBibHVlYmlyZCBmb3IgZXhhbXBsZSkuCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdl cyB0aGlzIGNoZWNrIHRvIHRoZSBzcGVjaWZpZWQgb25lLgorCisgICAgICAgIFsxXTogaHR0cHM6 Ly90YzM5LmVzL3Byb3Bvc2FsLXByb21pc2UtZmluYWxseS8KKworICAgICAgICAqIGJ1aWx0aW5z L1Byb21pc2VQcm90b3R5cGUuanM6CisgICAgICAgIChmaW5hbGx5KToKKwogMjAxOS0wOC0xNiAg QWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CiAKICAgICAgICAgUHJvbWlz ZSBjb25zdHJ1Y3RvciBzaG91bGQgY2hlY2sgYXJndW1lbnQgYmVmb3JlIFtbQ29uc3RydWN0XV0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9Qcm9taXNlUHJvdG90 eXBlLmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUu anMKaW5kZXggNDY0NjQyYWY5ODI4YTE4YzRlMzkwYzVkZWM5NDJjODllMjJkYjBiMi4uMGE2ZmIx ZGRkMjY3YTdjYjZkN2JlMzQ3OGM1NTZlZGY1MDU4MGEyNiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUuanMKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VQcm90b3R5cGUuanMKQEAgLTY4LDggKzY4LDgg QEAgZnVuY3Rpb24gZmluYWxseShvbkZpbmFsbHkpCiB7CiAgICAgInVzZSBzdHJpY3QiOwogCi0g ICAgaWYgKCFAaXNQcm9taXNlKHRoaXMpKQotICAgICAgICBAdGhyb3dUeXBlRXJyb3IoInx0aGlz fCBpcyBub3QgYSBQcm9taXNlIik7CisgICAgaWYgKCFAaXNPYmplY3QodGhpcykpCisgICAgICAg IEB0aHJvd1R5cGVFcnJvcigifHRoaXN8IGlzIG5vdCBhIG9iamVjdCIpOwogCiAgICAgY29uc3Qg Y29uc3RydWN0b3IgPSBAc3BlY2llc0NvbnN0cnVjdG9yKHRoaXMsIEBQcm9taXNlKTsKIApkaWZm IC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA0YmMz YTk2ODEwYTIxNzE2MThlYTZmYTI2Yzk1MjMwYmUzMjY5NTU4Li42NzdkOGNmZTNkMWY5OTc1YjZm Mzc3ODk1NjExYTgxYmViMWQzMjFmIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysg Yi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTE2ICBZdXN1a2Ug U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gUHJvbWlzZS5wcm90 b3R5cGUuZmluYWxseSBzaG91bGQgYWNjZXB0IG5vbi1wcm9taXNlIG9iamVjdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDgyOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3Byb21pc2Ut ZmluYWxseS1zaG91bGQtYWNjZXB0LW5vbi1wcm9taXNlLW9iamVjdHMuanM6IEFkZGVkLgorICAg ICAgICAoc2hvdWxkQmUpOgorICAgICAgICAoVGhlbmFibGUpOgorICAgICAgICAoVGhlbmFibGUu cHJvdG90eXBlLnRoZW4pOgorCiAyMDE5LTA4LTE2ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2Fs ZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBQcm9taXNlIGNvbnN0cnVjdG9yIHNob3VsZCBjaGVj ayBhcmd1bWVudCBiZWZvcmUgW1tDb25zdHJ1Y3RdXQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJl c3MvcHJvbWlzZS1maW5hbGx5LXNob3VsZC1hY2NlcHQtbm9uLXByb21pc2Utb2JqZWN0cy5qcyBi L0pTVGVzdHMvc3RyZXNzL3Byb21pc2UtZmluYWxseS1zaG91bGQtYWNjZXB0LW5vbi1wcm9taXNl LW9iamVjdHMuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWNiY2I5ZjgxNzkwNjFiMjMzMjI1MDhjNDZjNzk5YjM3 OTFjMmY2NgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL3Byb21pc2UtZmluYWxs eS1zaG91bGQtYWNjZXB0LW5vbi1wcm9taXNlLW9iamVjdHMuanMKQEAgLTAsMCArMSwyNSBAQAor ZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09 IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFjdHVh bCk7Cit9CisKK2NsYXNzIFRoZW5hYmxlIHsKKyAgICBjb25zdHJ1Y3Rvcihwcm9taXNlKQorICAg IHsKKyAgICAgICAgdGhpcy5wcm9taXNlID0gcHJvbWlzZTsKKyAgICB9CisKKyAgICB0aGVuKGZ1 bGZpbGwsIHJlamVjdGVkKQorICAgIHsKKyAgICAgICAgcmV0dXJuIG5ldyBUaGVuYWJsZSh0aGlz LnByb21pc2UudGhlbihmdWxmaWxsLCByZWplY3RlZCkpOworICAgIH0KK307CisKK3ZhciBmdWxm aWxsZWQgPSBuZXcgVGhlbmFibGUoUHJvbWlzZS5yZWplY3QoMCkpOwordmFyIHJlamVjdGVkID0g bmV3IFRoZW5hYmxlKFByb21pc2UucmVzb2x2ZSg0MikpOworCit2YXIgY291bnRlciA9IDA7CitQ cm9taXNlLnByb3RvdHlwZS5maW5hbGx5LmNhbGwoZnVsZmlsbGVkLCBmdW5jdGlvbiAoKSB7IGNv dW50ZXIrKzsgfSk7CitQcm9taXNlLnByb3RvdHlwZS5maW5hbGx5LmNhbGwocmVqZWN0ZWQsIGZ1 bmN0aW9uICgpIHsgY291bnRlcisrOyB9KTsKK2RyYWluTWljcm90YXNrcygpOworc2hvdWxkQmUo Y291bnRlciwgMik7Cg==