200828 2019-08-16 13:26:52 -0700 LocalStorageDatabase should use inline initialization for its data members 2019-08-16 17:05:21 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ews-feeder ggaren sihui_liu webkit-bug-importer wilander youennf oldest_to_newest 1562175 0 cdumez 2019-08-16 13:26:52 -0700 LocalStorageDatabase should use inline initialization for its data members. 1562178 1 376530 cdumez 2019-08-16 13:30:10 -0700 Created attachment 376530 Patch 1562311 2 376530 wilander 2019-08-16 16:58:29 -0700 Comment on attachment 376530 Patch r=me 1562312 3 376530 ews-feeder 2019-08-16 16:58:37 -0700 Comment on attachment 376530 Patch Rejecting attachment 376530 from review queue. wilander@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1562314 4 cdumez 2019-08-16 16:59:13 -0700 (In reply to ews-feeder from comment #3) > Comment on attachment 376530 [details] > Patch > > Rejecting attachment 376530 [details] from review queue. > > wilander@apple.com does not have reviewer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > > - If you do not have reviewer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. > > - If you have reviewer rights please correct the error in > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > the file (no review needed). The commit-queue restarts itself every 2 > hours. After restart the commit-queue will correctly respect your reviewer > rights. Darn it :P 1562315 5 wilander 2019-08-16 17:00:37 -0700 (In reply to Chris Dumez from comment #4) > (In reply to ews-feeder from comment #3) > > Comment on attachment 376530 [details] > > Patch > > > > Rejecting attachment 376530 [details] from review queue. > > > > wilander@apple.com does not have reviewer permissions according to > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > contributors.json. > > > > - If you do not have reviewer rights please read > > http://webkit.org/coding/contributing.html for instructions on how to use > > bugzilla flags. > > > > - If you have reviewer rights please correct the error in > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > > the file (no review needed). The commit-queue restarts itself every 2 > > hours. After restart the commit-queue will correctly respect your reviewer > > rights. > > Darn it :P Two hours. What year is this, 1995? :P 1562316 6 cdumez 2019-08-16 17:01:41 -0700 (In reply to John Wilander from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to ews-feeder from comment #3) > > > Comment on attachment 376530 [details] > > > Patch > > > > > > Rejecting attachment 376530 [details] from review queue. > > > > > > wilander@apple.com does not have reviewer permissions according to > > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > > contributors.json. > > > > > > - If you do not have reviewer rights please read > > > http://webkit.org/coding/contributing.html for instructions on how to use > > > bugzilla flags. > > > > > > - If you have reviewer rights please correct the error in > > > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > > > the file (no review needed). The commit-queue restarts itself every 2 > > > hours. After restart the commit-queue will correctly respect your reviewer > > > rights. > > > > Darn it :P > > Two hours. What year is this, 1995? :P Yes, let's move to GitHub :D 1562317 7 cdumez 2019-08-16 17:04:09 -0700 Committed r248804: <https://trac.webkit.org/changeset/248804> 1562319 8 376530 cdumez 2019-08-16 17:04:35 -0700 Comment on attachment 376530 Patch Landed manually. 1562321 9 webkit-bug-importer 2019-08-16 17:05:21 -0700 <rdar://problem/54413913> 376530 2019-08-16 13:30:10 -0700 2019-08-16 17:04:35 -0700 Patch bug-200828-20190816133009.patch text/plain 2587 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE2MGQzMjM1MzFlYzcyOGIz MjAxMWYzZGJjMThmMWMzYjdjZDlkZTYuLjE5YmFkNDc3MTk5ODVjYjlhZjY3MDk5MzhjMWYxZTQ1 NzliMGYxM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBMb2NhbFN0b3JhZ2VEYXRhYmFzZSBz aG91bGQgdXNlIGlubGluZSBpbml0aWFsaXphdGlvbiBmb3IgaXRzIGRhdGEgbWVtYmVycworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODI4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYktp dDo6TG9jYWxTdG9yYWdlRGF0YWJhc2U6OkxvY2FsU3RvcmFnZURhdGFiYXNlKToKKyAgICAgICAg KiBOZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmg6CisKIDIw MTktMDgtMTYgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3Bs aXQgdGFiSW5kZXggY29tcHV0YXRpb24gZm9yIERPTSBhbmQgdGhlIHJlc3Qgb2YgV2ViQ29yZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2Fs U3RvcmFnZURhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3Rv cmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZS5jcHAKaW5kZXggOGY0NzYzYzlkYzg2YWI0YTQyZDk0 NmYyNmRiMjhiY2M2OTAyOWNiZS4uYjI0MDFmMDA0M2Y2ZjYzMTQ4MzBmMTIxYjExYWI3MzhiYmI4 MTNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdl L0xvY2FsU3RvcmFnZURhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuY3BwCkBAIC01NSwxMSArNTUsNiBA QCBMb2NhbFN0b3JhZ2VEYXRhYmFzZTo6TG9jYWxTdG9yYWdlRGF0YWJhc2UoUmVmPFdvcmtRdWV1 ZT4mJiBxdWV1ZSwgUmVmPExvY2FsU3RvcgogICAgICwgbV90cmFja2VyKFdURk1vdmUodHJhY2tl cikpCiAgICAgLCBtX3NlY3VyaXR5T3JpZ2luKHNlY3VyaXR5T3JpZ2luKQogICAgICwgbV9kYXRh YmFzZVBhdGgobV90cmFja2VyLT5kYXRhYmFzZVBhdGgobV9zZWN1cml0eU9yaWdpbikpCi0gICAg LCBtX2ZhaWxlZFRvT3BlbkRhdGFiYXNlKGZhbHNlKQotICAgICwgbV9kaWRJbXBvcnRJdGVtcyhm YWxzZSkKLSAgICAsIG1faXNDbG9zZWQoZmFsc2UpCi0gICAgLCBtX2RpZFNjaGVkdWxlRGF0YWJh c2VVcGRhdGUoZmFsc2UpCi0gICAgLCBtX3Nob3VsZENsZWFySXRlbXMoZmFsc2UpCiB7CiB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2Nh bFN0b3JhZ2VEYXRhYmFzZS5oIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9y YWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmgKaW5kZXggOGNmYjI0YjIxZjNhMGE0MjZiZGIyMmQ0 NWNhYjQyMDk1MjNlYzgxMC4uYTViZDczMTkwMmI5YzE2M2FhMGYxM2Q2ODI5NDM2YWYwMDRlNTA3 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL0xv Y2FsU3RvcmFnZURhdGFiYXNlLmgKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9X ZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmgKQEAgLTg1LDEyICs4NSwxMiBAQCBwcml2 YXRlOgogCiAgICAgU3RyaW5nIG1fZGF0YWJhc2VQYXRoOwogICAgIFdlYkNvcmU6OlNRTGl0ZURh dGFiYXNlIG1fZGF0YWJhc2U7Ci0gICAgYm9vbCBtX2ZhaWxlZFRvT3BlbkRhdGFiYXNlOwotICAg IGJvb2wgbV9kaWRJbXBvcnRJdGVtczsKLSAgICBib29sIG1faXNDbG9zZWQ7CisgICAgYm9vbCBt X2ZhaWxlZFRvT3BlbkRhdGFiYXNlIHsgZmFsc2UgfTsKKyAgICBib29sIG1fZGlkSW1wb3J0SXRl bXMgeyBmYWxzZSB9OworICAgIGJvb2wgbV9pc0Nsb3NlZCB7IGZhbHNlIH07CiAKLSAgICBib29s IG1fZGlkU2NoZWR1bGVEYXRhYmFzZVVwZGF0ZTsKLSAgICBib29sIG1fc2hvdWxkQ2xlYXJJdGVt czsKKyAgICBib29sIG1fZGlkU2NoZWR1bGVEYXRhYmFzZVVwZGF0ZSB7IGZhbHNlIH07CisgICAg Ym9vbCBtX3Nob3VsZENsZWFySXRlbXMgeyBmYWxzZSB9OwogICAgIEhhc2hNYXA8U3RyaW5nLCBT dHJpbmc+IG1fY2hhbmdlZEl0ZW1zOwogCiAgICAgc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OlN1 ZGRlblRlcm1pbmF0aW9uRGlzYWJsZXI+IG1fZGlzYWJsZVN1ZGRlblRlcm1pbmF0aW9uV2hpbGVX cml0aW5nVG9Mb2NhbFN0b3JhZ2U7Cg==