200822 2019-08-16 12:57:12 -0700 LocalStorageDatabase does not need to subclass ThreadSafeRefCounted 2019-08-16 13:57:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren sihui_liu webkit-bug-importer youennf oldest_to_newest 1562138 0 cdumez 2019-08-16 12:57:12 -0700 LocalStorageDatabaseTracker does not need to subclass ThreadSafeRefCounted, it is only ref'd / deref'd by the StorageArea on the com.apple.WebKit.WebStorage serial WorkQueue, and in LocalStorageDatabase::scheduleDatabaseUpdate() on the same WorkQueue. 1562142 1 376519 cdumez 2019-08-16 12:58:16 -0700 Created attachment 376519 Patch 1562144 2 376519 ggaren 2019-08-16 13:03:05 -0700 Comment on attachment 376519 Patch r=me 1562164 3 376526 cdumez 2019-08-16 13:13:23 -0700 Created attachment 376526 Patch 1562198 4 376526 commit-queue 2019-08-16 13:56:06 -0700 Comment on attachment 376526 Patch Clearing flags on attachment: 376526 Committed r248794: <https://trac.webkit.org/changeset/248794> 1562199 5 commit-queue 2019-08-16 13:56:07 -0700 All reviewed patches have been landed. Closing bug. 1562200 6 webkit-bug-importer 2019-08-16 13:57:18 -0700 <rdar://problem/54406074> 376519 2019-08-16 12:58:16 -0700 2019-08-16 13:13:22 -0700 Patch bug-200822-20190816125815.patch text/plain 2900 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzMDVhNzg2MDBmMjg1MDE3 MGRjMjUzZTAzMjk0Nzk2ZTY1YzAyMmYuLmFjYjY1NTU4YTMwODg4MWI2MWM3NDllOGJkNTgzNDJl N2Q2MzU4NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRy YWNrZXIgZG9lcyBub3QgbmVlZCB0byBzdWJjbGFzcyBUaHJlYWRTYWZlUmVmQ291bnRlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODIyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9jYWxTdG9yYWdl RGF0YWJhc2VUcmFja2VyIGRvZXMgbm90IG5lZWQgdG8gc3ViY2xhc3MgVGhyZWFkU2FmZVJlZkNv dW50ZWQsIGl0IGlzIG9ubHkgcmVmJ2QgLyBkZXJlZidkIGJ5CisgICAgICAgIHRoZSBTdG9yYWdl QXJlYSBvbiB0aGUgY29tLmFwcGxlLldlYktpdC5XZWJTdG9yYWdlIHNlcmlhbCBXb3JrUXVldWUs IGFuZCBpbiBMb2NhbFN0b3JhZ2VEYXRhYmFzZTo6c2NoZWR1bGVEYXRhYmFzZVVwZGF0ZSgpCisg ICAgICAgIG9uIHRoZSBzYW1lIFdvcmtRdWV1ZS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpM b2NhbFN0b3JhZ2VEYXRhYmFzZTo6TG9jYWxTdG9yYWdlRGF0YWJhc2UpOgorICAgICAgICAoV2Vi S2l0OjpMb2NhbFN0b3JhZ2VEYXRhYmFzZTo6fkxvY2FsU3RvcmFnZURhdGFiYXNlKToKKyAgICAg ICAgKiBOZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmg6CisK IDIwMTktMDgtMTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBN YW55IFdlYlN0b3JhZ2UgY2xhc3NlcyBkbyBub3QgbmVlZCB0byBzdWJjbGFzcyBUaHJlYWRTYWZl UmVmQ291bnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJT dG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZS5jcHAKaW5kZXggOGY0NzYzYzlk Yzg2YWI0YTQyZDk0NmYyNmRiMjhiY2M2OTAyOWNiZS4uM2E0NWI5NTUyNzZlYjUxMTQyZmI3NmIz OTE2Y2VhYWMwMDgzMjlkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuY3BwCkBAIC02 MSwxMCArNjEsMTIgQEAgTG9jYWxTdG9yYWdlRGF0YWJhc2U6OkxvY2FsU3RvcmFnZURhdGFiYXNl KFJlZjxXb3JrUXVldWU+JiYgcXVldWUsIFJlZjxMb2NhbFN0b3IKICAgICAsIG1fZGlkU2NoZWR1 bGVEYXRhYmFzZVVwZGF0ZShmYWxzZSkKICAgICAsIG1fc2hvdWxkQ2xlYXJJdGVtcyhmYWxzZSkK IHsKKyAgICBBU1NFUlQoIVJ1bkxvb3A6OmlzTWFpbigpKTsKIH0KIAogTG9jYWxTdG9yYWdlRGF0 YWJhc2U6On5Mb2NhbFN0b3JhZ2VEYXRhYmFzZSgpCiB7CisgICAgQVNTRVJUKCFSdW5Mb29wOjpp c01haW4oKSk7CiAgICAgQVNTRVJUKG1faXNDbG9zZWQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2Uu aCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VE YXRhYmFzZS5oCmluZGV4IDhjZmIyNGIyMWYzYTBhNDI2YmRiMjJkNDVjYWI0MjA5NTIzZWM4MTAu LmZiMGQxOGQ3MGFiM2U3YTQzZGIwNDkyOTVjNGJiYmM1YmIzMzVjYjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFz ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0 b3JhZ2VEYXRhYmFzZS5oCkBAIC0yOSw4ICsyOSw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9TZWN1 cml0eU9yaWdpbkRhdGEuaD4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0 Zi9IYXNoTWFwLmg+Ci0jaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgotI2luY2x1ZGUgPHd0Zi9UaHJl YWRTYWZlUmVmQ291bnRlZC5oPgorI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAjaW5jbHVk ZSA8d3RmL1dvcmtRdWV1ZS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00Myw3ICs0Miw3 IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNr ZXI7CiAKLWNsYXNzIExvY2FsU3RvcmFnZURhdGFiYXNlIDogcHVibGljIFRocmVhZFNhZmVSZWZD b3VudGVkPExvY2FsU3RvcmFnZURhdGFiYXNlPiB7CitjbGFzcyBMb2NhbFN0b3JhZ2VEYXRhYmFz ZSA6IHB1YmxpYyBSZWZDb3VudGVkPExvY2FsU3RvcmFnZURhdGFiYXNlPiB7CiBwdWJsaWM6CiAg ICAgc3RhdGljIFJlZjxMb2NhbFN0b3JhZ2VEYXRhYmFzZT4gY3JlYXRlKFJlZjxXb3JrUXVldWU+ JiYsIFJlZjxMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI+JiYsIGNvbnN0IFdlYkNvcmU6OlNl Y3VyaXR5T3JpZ2luRGF0YSYpOwogICAgIH5Mb2NhbFN0b3JhZ2VEYXRhYmFzZSgpOwo= 376526 2019-08-16 13:13:23 -0700 2019-08-16 13:56:06 -0700 Patch bug-200822-20190816131322.patch text/plain 2883 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzMDVhNzg2MDBmMjg1MDE3 MGRjMjUzZTAzMjk0Nzk2ZTY1YzAyMmYuLjU1ODNjNzk0YmVmNjg2M2I4N2MwM2E1N2JjOGZmM2My ODg0MTY2MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBMb2NhbFN0b3JhZ2VEYXRhYmFzZSBk b2VzIG5vdCBuZWVkIHRvIHN1YmNsYXNzIFRocmVhZFNhZmVSZWZDb3VudGVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA4MjIKKworICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KKworICAgICAgICBMb2NhbFN0b3JhZ2VEYXRhYmFzZSBk b2VzIG5vdCBuZWVkIHRvIHN1YmNsYXNzIFRocmVhZFNhZmVSZWZDb3VudGVkLCBpdCBpcyBvbmx5 IHJlZidkIC8gZGVyZWYnZCBieSB0aGUgU3RvcmFnZUFyZWEKKyAgICAgICAgb24gdGhlIGNvbS5h cHBsZS5XZWJLaXQuV2ViU3RvcmFnZSBzZXJpYWwgV29ya1F1ZXVlLCBhbmQgaW4gTG9jYWxTdG9y YWdlRGF0YWJhc2U6OnNjaGVkdWxlRGF0YWJhc2VVcGRhdGUoKSBvbiB0aGUKKyAgICAgICAgc2Ft ZSBXb3JrUXVldWUuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2Fs U3RvcmFnZURhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdlRGF0YWJh c2U6OkxvY2FsU3RvcmFnZURhdGFiYXNlKToKKyAgICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdl RGF0YWJhc2U6On5Mb2NhbFN0b3JhZ2VEYXRhYmFzZSk6CisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZS5oOgorCiAyMDE5LTA4LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFueSBXZWJTdG9yYWdlIGNs YXNzZXMgZG8gbm90IG5lZWQgdG8gc3ViY2xhc3MgVGhyZWFkU2FmZVJlZkNvdW50ZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3Jh Z2VEYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2Uv TG9jYWxTdG9yYWdlRGF0YWJhc2UuY3BwCmluZGV4IDhmNDc2M2M5ZGM4NmFiNGE0MmQ5NDZmMjZk YjI4YmNjNjkwMjljYmUuLjNhNDViOTU1Mjc2ZWI1MTE0MmZiNzZiMzkxNmNlYWFjMDA4MzI5ZDQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9Mb2Nh bFN0b3JhZ2VEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9X ZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmNwcApAQCAtNjEsMTAgKzYxLDEyIEBAIExv Y2FsU3RvcmFnZURhdGFiYXNlOjpMb2NhbFN0b3JhZ2VEYXRhYmFzZShSZWY8V29ya1F1ZXVlPiYm IHF1ZXVlLCBSZWY8TG9jYWxTdG9yCiAgICAgLCBtX2RpZFNjaGVkdWxlRGF0YWJhc2VVcGRhdGUo ZmFsc2UpCiAgICAgLCBtX3Nob3VsZENsZWFySXRlbXMoZmFsc2UpCiB7CisgICAgQVNTRVJUKCFS dW5Mb29wOjppc01haW4oKSk7CiB9CiAKIExvY2FsU3RvcmFnZURhdGFiYXNlOjp+TG9jYWxTdG9y YWdlRGF0YWJhc2UoKQogeworICAgIEFTU0VSVCghUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIEFT U0VSVChtX2lzQ2xvc2VkKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlLmggYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuaAppbmRleCA4 Y2ZiMjRiMjFmM2EwYTQyNmJkYjIyZDQ1Y2FiNDIwOTUyM2VjODEwLi5mYjBkMThkNzBhYjNlN2E0 M2RiMDQ5Mjk1YzRiYmJjNWJiMzM1Y2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuaApA QCAtMjksOCArMjksNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvU2VjdXJpdHlPcmlnaW5EYXRhLmg+ CiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgotI2lu Y2x1ZGUgPHd0Zi9SZWZQdHIuaD4KLSNpbmNsdWRlIDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQu aD4KKyNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi9Xb3JrUXVldWUu aD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDMsNyArNDIsNyBAQCBuYW1lc3BhY2UgV2Vi S2l0IHsKIAogY2xhc3MgTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOwogCi1jbGFzcyBMb2Nh bFN0b3JhZ2VEYXRhYmFzZSA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxMb2NhbFN0b3Jh Z2VEYXRhYmFzZT4geworY2xhc3MgTG9jYWxTdG9yYWdlRGF0YWJhc2UgOiBwdWJsaWMgUmVmQ291 bnRlZDxMb2NhbFN0b3JhZ2VEYXRhYmFzZT4gewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8TG9j YWxTdG9yYWdlRGF0YWJhc2U+IGNyZWF0ZShSZWY8V29ya1F1ZXVlPiYmLCBSZWY8TG9jYWxTdG9y YWdlRGF0YWJhc2VUcmFja2VyPiYmLCBjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEm KTsKICAgICB+TG9jYWxTdG9yYWdlRGF0YWJhc2UoKTsK