200818 2019-08-16 10:07:28 -0700 StorageManager does not need to subclass RefCounted 2019-08-16 11:23:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren sihui_liu webkit-bug-importer youennf oldest_to_newest 1562072 0 cdumez 2019-08-16 10:07:28 -0700 StorageManager does not need to subclass RefCounted. It is owned by the StorageManagerSet and is never ref'd / deref'd. 1562074 1 376507 cdumez 2019-08-16 10:09:15 -0700 Created attachment 376507 Patch 1562082 2 376507 ggaren 2019-08-16 10:27:28 -0700 Comment on attachment 376507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376507&action=review r=me > Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69 > + return std::make_unique<StorageManager>(WTFMove(localStorageDirectory)); Please consider using WTF::makeUnique (a new helper added yesterday). 1562084 3 cdumez 2019-08-16 10:29:33 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 376507 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376507&action=review > > r=me > > > Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69 > > + return std::make_unique<StorageManager>(WTFMove(localStorageDirectory)); > > Please consider using WTF::makeUnique (a new helper added yesterday). I would if it existed. The patch you're talking about does not seem to have landed. 1562103 4 376507 commit-queue 2019-08-16 11:22:22 -0700 Comment on attachment 376507 Patch Clearing flags on attachment: 376507 Committed r248780: <https://trac.webkit.org/changeset/248780> 1562104 5 commit-queue 2019-08-16 11:22:24 -0700 All reviewed patches have been landed. Closing bug. 1562105 6 webkit-bug-importer 2019-08-16 11:23:20 -0700 <rdar://problem/54399242> 376507 2019-08-16 10:09:15 -0700 2019-08-16 11:22:22 -0700 Patch bug-200818-20190816100915.patch text/plain 4735 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiN2FlN2NkM2Q5NThkYzMx OTRlZjNhYjIyMThlMmQ1YTU3MDE5NzYuLmJkODNhNzJhNTFmZGQxYmQyYTc0MmZmN2E1NGIyNTlm ZTFhYTk4NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9yYWdlTWFuYWdlciBkb2VzIG5v dCBuZWVkIHRvIHN1YmNsYXNzIFJlZkNvdW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDgxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFN0b3JhZ2VNYW5hZ2VyIGRvZXMgbm90IG5lZWQgdG8gc3Vi Y2xhc3MgUmVmQ291bnRlZC4gSXQgaXMgb3duZWQgYnkgdGhlIFN0b3JhZ2VNYW5hZ2VyU2V0Cisg ICAgICAgIGFuZCBpcyBuZXZlciByZWYnZCAvIGRlcmVmJ2QuCisKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmg6CisgICAgICAgIChXZWJLaXQ6OlN0 b3JhZ2VNYW5hZ2VyOjpjcmVhdGUpOiBEZWxldGVkLgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9y YWdlTWFuYWdlclNldDo6YWRkKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdl L1N0b3JhZ2VNYW5hZ2VyU2V0Lmg6CisKIDIwMTktMDgtMTUgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbV1RGXSBBZGQgbWFrZVVuaXF1ZTxUPiwgd2hpY2gg ZW5zdXJlcyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRCBhbm5v dGF0aW9uIHBhcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2Vi U3RvcmFnZS9TdG9yYWdlTWFuYWdlci5oIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9X ZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmgKaW5kZXggNmI1M2UxYjJlMDQ0OWY5YjNjMDQwM2I1 MzIzYWVhZDAwYzNhOTYwOS4uNjg2MzdhNDcyZTQyZjA4YWNhMjI1NmNiNGNjMDZhMGIyZWEyM2Jj OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0 b3JhZ2VNYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9y YWdlL1N0b3JhZ2VNYW5hZ2VyLmgKQEAgLTQ5LDEzICs0OSwxMSBAQCBjbGFzcyBXZWJQcm9jZXNz UHJveHk7CiAKIHVzaW5nIEdldFZhbHVlc0NhbGxiYWNrID0gQ29tcGxldGlvbkhhbmRsZXI8dm9p ZChjb25zdCBIYXNoTWFwPFN0cmluZywgU3RyaW5nPiYpPjsKIAotY2xhc3MgU3RvcmFnZU1hbmFn ZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxTdG9yYWdlTWFuYWdlcj4geworY2xhc3MgU3RvcmFnZU1h bmFnZXIgeworICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFN0b3JhZ2VNYW5hZ2VyKTsKKyAgICBX VEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUmVmPFN0b3JhZ2VN YW5hZ2VyPiBjcmVhdGUoU3RyaW5nJiYgbG9jYWxTdG9yYWdlRGlyZWN0b3J5KQotICAgIHsKLSAg ICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgU3RvcmFnZU1hbmFnZXIoV1RGTW92ZShsb2NhbFN0 b3JhZ2VEaXJlY3RvcnkpKSk7Ci0gICAgfQotICAgIAorICAgIGV4cGxpY2l0IFN0b3JhZ2VNYW5h Z2VyKFN0cmluZyYmIGxvY2FsU3RvcmFnZURpcmVjdG9yeSk7CiAgICAgflN0b3JhZ2VNYW5hZ2Vy KCk7CiAKICAgICB2b2lkIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHVpbnQ2NF90IHN0 b3JhZ2VOYW1lc3BhY2VJRCwgdW5zaWduZWQgcXVvdGFJbkJ5dGVzKTsKQEAgLTg1LDggKzgzLDYg QEAgcHVibGljOgogICAgIFN0b3JhZ2VBcmVhKiBjcmVhdGVTZXNzaW9uU3RvcmFnZUFyZWEodWlu dDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlELCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmJik7 CiAKIHByaXZhdGU6Ci0gICAgZXhwbGljaXQgU3RvcmFnZU1hbmFnZXIoU3RyaW5nJiYgbG9jYWxT dG9yYWdlRGlyZWN0b3J5KTsKLQogICAgIExvY2FsU3RvcmFnZU5hbWVzcGFjZSogZ2V0T3JDcmVh dGVMb2NhbFN0b3JhZ2VOYW1lc3BhY2UodWludDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlEKTsKICAg ICBUcmFuc2llbnRMb2NhbFN0b3JhZ2VOYW1lc3BhY2UqIGdldE9yQ3JlYXRlVHJhbnNpZW50TG9j YWxTdG9yYWdlTmFtZXNwYWNlKHVpbnQ2NF90IHN0b3JhZ2VOYW1lc3BhY2VJRCwgV2ViQ29yZTo6 U2VjdXJpdHlPcmlnaW5EYXRhJiYgdG9wTGV2ZWxPcmlnaW4pOwogICAgIFNlc3Npb25TdG9yYWdl TmFtZXNwYWNlKiBnZXRPckNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKHVpbnQ2NF90IHN0 b3JhZ2VOYW1lc3BhY2VJRCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmNwcAppbmRleCA4MWM3Yjcx YmY0NTMwMzExZjg5OTk2ZGRmOGQ0NjgwZTliYjA5MjRhLi5lYmJhMjg1NGUxNTgwNTczZmUyZjE1 NWU4M2M2NDBiODAyMjBmZmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlclNldC5jcHAKQEAgLTY0LDkg KzY0LDkgQEAgdm9pZCBTdG9yYWdlTWFuYWdlclNldDo6YWRkKFBBTDo6U2Vzc2lvbklEIHNlc3Np b25JRCwgY29uc3QgU3RyaW5nJiBsb2NhbFN0b3JhZ2UKICAgICAgICAgaWYgKCFzZXNzaW9uSUQu aXNFcGhlbWVyYWwoKSkKICAgICAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OmNvbnN1bWVQZXJt YW5lbnRseShsb2NhbFN0b3JhZ2VEaXJlY3RvcnlIYW5kbGUpOwogCi0gICAgICAgIG1fcXVldWUt PmRpc3BhdGNoKFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIHNlc3Npb25J RCwgZGlyZWN0b3J5ID0gbG9jYWxTdG9yYWdlRGlyZWN0b3J5Lmlzb2xhdGVkQ29weSgpXSgpIG11 dGFibGUgewotICAgICAgICAgICAgbV9zdG9yYWdlTWFuYWdlcnMuZW5zdXJlKHNlc3Npb25JRCwg W2RpcmVjdG9yeV0oKSBtdXRhYmxlIHsKLSAgICAgICAgICAgICAgICByZXR1cm4gU3RvcmFnZU1h bmFnZXI6OmNyZWF0ZShXVEZNb3ZlKGRpcmVjdG9yeSkpOworICAgICAgICBtX3F1ZXVlLT5kaXNw YXRjaChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBzZXNzaW9uSUQsIGxv Y2FsU3RvcmFnZURpcmVjdG9yeSA9IGxvY2FsU3RvcmFnZURpcmVjdG9yeS5pc29sYXRlZENvcHko KV0oKSBtdXRhYmxlIHsKKyAgICAgICAgICAgIG1fc3RvcmFnZU1hbmFnZXJzLmVuc3VyZShzZXNz aW9uSUQsIFsmXSgpIG11dGFibGUgeworICAgICAgICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2Vf dW5pcXVlPFN0b3JhZ2VNYW5hZ2VyPihXVEZNb3ZlKGxvY2FsU3RvcmFnZURpcmVjdG9yeSkpOwog ICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlclNldC5oIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgK aW5kZXggNzcwMzJhYzNlMmFjODZmOThjOTA5MGMyNmU5OGY1Y2EwNzgwZTFiMi4uY2U0NDYzMmU1 YzgyMzhlOTZlODIyNDE2OTAzOTkyZmNhNmQyNjNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgKKysrIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgK QEAgLTgzLDcgKzgzLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNsZWFyKElQQzo6Q29ubmVjdGlv biYsIHVpbnQ2NF90IHN0b3JhZ2VBcmVhSUQsIHVpbnQ2NF90IHNvdXJjZVN0b3JhZ2VBcmVhSUQs IHVpbnQ2NF90IHN0b3JhZ2VNYXBTZWVkLCBjb25zdCBTdHJpbmcmIHVybFN0cmluZyk7CiAgICAg dm9pZCBjbG9uZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKElQQzo6Q29ubmVjdGlvbiYsIFBBTDo6 U2Vzc2lvbklELCB1aW50NjRfdCBmcm9tU3RvcmFnZU5hbWVzcGFjZUlELCB1aW50NjRfdCB0b1N0 b3JhZ2VOYW1lc3BhY2VJRCk7CiAKLSAgICBIYXNoTWFwPFBBTDo6U2Vzc2lvbklELCBSZWZQdHI8 U3RvcmFnZU1hbmFnZXI+PiBtX3N0b3JhZ2VNYW5hZ2VyczsKKyAgICBIYXNoTWFwPFBBTDo6U2Vz c2lvbklELCBzdGQ6OnVuaXF1ZV9wdHI8U3RvcmFnZU1hbmFnZXI+PiBtX3N0b3JhZ2VNYW5hZ2Vy czsKICAgICBIYXNoTWFwPFBBTDo6U2Vzc2lvbklELCBTdHJpbmc+IG1fc3RvcmFnZU1hbmFnZXJQ YXRoczsKICAgICBIYXNoTWFwPHVpbnQ2NF90LCBTdG9yYWdlQXJlYSo+IG1fc3RvcmFnZUFyZWFz OwogCg==