200816 2019-08-16 09:11:57 -0700 StorageManagerSet constructor should not be public 2019-08-16 15:06:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren sihui_liu youennf oldest_to_newest 1562050 0 cdumez 2019-08-16 09:11:57 -0700 StorageManagerSet constructor should not be public since it subclasses ThreadSafeRefCounted and has a factory method. 1562051 1 376502 cdumez 2019-08-16 09:12:39 -0700 Created attachment 376502 Patch 1562081 2 376502 ggaren 2019-08-16 10:26:10 -0700 Comment on attachment 376502 Patch r=me 1562092 3 376502 commit-queue 2019-08-16 10:55:31 -0700 Comment on attachment 376502 Patch Clearing flags on attachment: 376502 Committed r248778: <https://trac.webkit.org/changeset/248778> 1562093 4 commit-queue 2019-08-16 10:55:33 -0700 All reviewed patches have been landed. Closing bug. 1562238 5 webkit-bug-importer 2019-08-16 15:06:15 -0700 <rdar://problem/54409109> 376502 2019-08-16 09:12:39 -0700 2019-08-16 10:55:31 -0700 Patch bug-200816-20190816091239.patch text/plain 2109 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJiN2FlN2NkM2Q5NThkYzMx OTRlZjNhYjIyMThlMmQ1YTU3MDE5NzYuLmZkMDk0ZTU1NTA1ZDk0YzFiYTVmYjZlYTc2Yzg0OWJk OTA0N2QwZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDgtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9yYWdlTWFuYWdlclNldCBjb25z dHJ1Y3RvciBzaG91bGQgbm90IGJlIHB1YmxpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwODE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3RvcmFnZU1hbmFnZXJTZXQgY29uc3RydWN0b3Igc2hvdWxk IG5vdCBiZSBwdWJsaWMgc2luY2UgaXQgc3ViY2xhc3NlcyBUaHJlYWRTYWZlUmVmQ291bnRlZCBh bmQKKyAgICAgICAgaGFzIGEgZmFjdG9yeSBtZXRob2QuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0Lmg6CisKIDIwMTktMDgtMTUgIFl1c3Vr ZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbV1RGXSBBZGQgbWFrZVVu aXF1ZTxUPiwgd2hpY2ggZW5zdXJlcyBUIGlzIGZhc3QtYWxsb2NhdGVkLCBXVEZfTUFLRV9GQVNU X0FMTE9DQVRFRCBhbm5vdGF0aW9uIHBhcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlclNldC5oIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgKaW5kZXggNzcw MzJhYzNlMmFjODZmOThjOTA5MGMyNmU5OGY1Y2EwNzgwZTFiMi4uZTlkYWFhZTc3YTBlMjQxYTll NWJlYjg1MzI1N2JjNWJiOWM1ODAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmgKQEAgLTQ1LDcg KzQ1LDYgQEAgdXNpbmcgRGVsZXRlQ2FsbGJhY2sgPSBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+ OwogY2xhc3MgU3RvcmFnZU1hbmFnZXJTZXQgOiBwdWJsaWMgSVBDOjpDb25uZWN0aW9uOjpXb3Jr UXVldWVNZXNzYWdlUmVjZWl2ZXIgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8U3RvcmFnZU1h bmFnZXJTZXQ+IGNyZWF0ZSgpOwotICAgIFN0b3JhZ2VNYW5hZ2VyU2V0KCk7CiAgICAgflN0b3Jh Z2VNYW5hZ2VyU2V0KCk7CiAKICAgICB2b2lkIGFkZChQQUw6OlNlc3Npb25JRCwgY29uc3QgU3Ry aW5nJiBsb2NhbFN0b3JhZ2VEaXJlY3RvcnksIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSYgbG9j YWxTdG9yYWdlRGlyZWN0b3J5SGFuZGxlKTsKQEAgLTcyLDYgKzcxLDggQEAgcHVibGljOgogICAg IHZvaWQgZGlkUmVjZWl2ZVN5bmNNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6RGVjb2Rl ciYsIHN0ZDo6dW5pcXVlX3B0cjxJUEM6OkVuY29kZXI+JiByZXBseUVuY29kZXIpOwogCiBwcml2 YXRlOgorICAgIFN0b3JhZ2VNYW5hZ2VyU2V0KCk7CisKICAgICAvLyBNZXNzYWdlIEhhbmRsZXJz CiAgICAgdm9pZCBjb25uZWN0VG9Mb2NhbFN0b3JhZ2VBcmVhKElQQzo6Q29ubmVjdGlvbiYsIFBB TDo6U2Vzc2lvbklEICwgdWludDY0X3Qgc3RvcmFnZU5hbWVzcGFjZUlELCBTZWN1cml0eU9yaWdp bkRhdGEmJiwgQ29ubmVjdFRvU3RvcmFnZUFyZWFDYWxsYmFjayYmKTsKICAgICB2b2lkIGNvbm5l Y3RUb1RyYW5zaWVudExvY2FsU3RvcmFnZUFyZWEoSVBDOjpDb25uZWN0aW9uJiwgUEFMOjpTZXNz aW9uSUQgLCB1aW50NjRfdCBzdG9yYWdlTmFtZXNwYWNlSUQsIFNlY3VyaXR5T3JpZ2luRGF0YSYm LCBTZWN1cml0eU9yaWdpbkRhdGEmJiwgQ29ubmVjdFRvU3RvcmFnZUFyZWFDYWxsYmFjayYmKTsK