200808 2019-08-15 23:52:43 -0700 Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity 2019-08-16 09:55:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1561947 0 hi 2019-08-15 23:52:43 -0700 In reality, an "invalid" character is just a non-printable character (a.k.a. an "invisible" character). 1561949 1 376475 hi 2019-08-15 23:54:14 -0700 Created attachment 376475 Patch 1561965 2 376475 joepeck 2019-08-16 00:46:22 -0700 Comment on attachment 376475 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376475&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Setting.js:170 > - showInvalidCharacters: new WI.Setting("show-invalid-characters", false), > + showInvisibleCharacters: new WI.Setting("show-invisible-characters", !!WI.Setting.migrateValue("show-invalid-characters")), Nice! 1562061 3 376475 commit-queue 2019-08-16 09:54:54 -0700 Comment on attachment 376475 Patch Clearing flags on attachment: 376475 Committed r248773: <https://trac.webkit.org/changeset/248773> 1562062 4 commit-queue 2019-08-16 09:54:55 -0700 All reviewed patches have been landed. Closing bug. 1562063 5 webkit-bug-importer 2019-08-16 09:55:18 -0700 <rdar://problem/54395136> 376475 2019-08-15 23:54:14 -0700 2019-08-16 09:54:54 -0700 Patch bug-200808-20190815235413.patch text/plain 5927 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUyM2FiZTlkN2NlODZhYzk4MDdlYTZjZDJlZjZl NmQ4YzE3NDI2NTAuLjE4NjlkNDc4OTU1MjQ5MzdjZTkwMjgxNWYyOWM0MzkyOTJlMzI0NzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA4LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBy ZW5hbWUgIkludmFsaWQgQ2hhcmFjdGVycyIgdG8gIkludmlzaWJsZSBDaGFyYWN0ZXJzIiBmb3Ig Y2xhcml0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAwODA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5TZXR0aW5nc1Rh YkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY3JlYXRlR2VuZXJhbFNldHRpbmdzVmlldyk6CisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKHNldEludmlzaWJs ZUNoYXJhY3RlckNsYXNzTmFtZSk6IEFkZGVkLgorICAgICAgICAoc2V0SW52YWxpZENoYXJhY3Rl ckNsYXNzTmFtZSk6IERlbGV0ZWQuCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db2Rl TWlycm9yT3ZlcnJpZGVzLmNzczoKKyAgICAgICAgKC5zaG93LWludmlzaWJsZS1jaGFyYWN0ZXJz IC5Db2RlTWlycm9yIC5jbS1pbnZhbGlkY2hhcik6IEFkZGVkLgorICAgICAgICAoLnNob3ctaW52 YWxpZC1jaGFyYWN0ZXJzIC5Db2RlTWlycm9yIC5jbS1pbnZhbGlkY2hhcik6IERlbGV0ZWQuCisK KyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisK IDIwMTktMDgtMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBVcGRhdGUgRXNwcmltYSB0byBzdXBwb3J0IG1vZGVybiBKYXZh U2NyaXB0IGxhbmd1YWdlIGZlYXR1cmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpp bmRleCBmYjg5YzExOTY4NTQyMTJlYWE5ZmJjMDUyOGFkMzI3MTAxYTE3ZjBmLi43MTE5ZjUzNmJi MGM5OGQ1Y2FiMzA5MWFjNjg3YjgzODkxYmFjY2M0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0 cmluZ3MuanMKQEAgLTYxMyw4ICs2MTMsOCBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJJbnB1dDogIl0g PSAiSW5wdXQ6ICI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJJbnNwZWN0b3IgU3R5bGUgU2hlZXQiXSA9 ICJJbnNwZWN0b3IgU3R5bGUgU2hlZXQiOwogbG9jYWxpemVkU3RyaW5nc1siSW5zdGFuY2VzIl0g PSAiSW5zdGFuY2VzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkludmFsaWQiXSA9ICJJbnZhbGlkIjsK LWxvY2FsaXplZFN0cmluZ3NbIkludmFsaWQgY2hhcmFjdGVycyJdID0gIkludmFsaWQgY2hhcmFj dGVycyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJJbnZlcnRlZCJdID0gIkludmVydGVkIjsKK2xvY2Fs aXplZFN0cmluZ3NbIkludmlzaWJsZSBjaGFyYWN0ZXJzIl0gPSAiSW52aXNpYmxlIGNoYXJhY3Rl cnMiOwogbG9jYWxpemVkU3RyaW5nc1siSW52b2tlIGdldHRlciJdID0gIkludm9rZSBnZXR0ZXIi OwogbG9jYWxpemVkU3RyaW5nc1siSlAyIl0gPSAiSlAyIjsKIGxvY2FsaXplZFN0cmluZ3NbIkpQ RUciXSA9ICJKUEVHIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcwppbmRleCAwM2RjYjE1NGJlMGNjODIyZGYwNDY0MTM5YzA0ZGFkZDAxNDc5 NmU3Li5jYmM2MTNiYWJiMjk3MWUwZGZlMzNkOWFmZjJjYTQ5Y2E1MTYyN2U4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0zMDcs MTEgKzMwNywxMSBAQCBXSS5jb250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIFdJLnNldHRp bmdzLnRhYlNpemUuYWRkRXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHNl dFRhYlNpemUpOwogICAgIHNldFRhYlNpemUoKTsKIAotICAgIGZ1bmN0aW9uIHNldEludmFsaWRD aGFyYWN0ZXJDbGFzc05hbWUoKSB7Ci0gICAgICAgIGRvY3VtZW50LmJvZHkuY2xhc3NMaXN0LnRv Z2dsZSgic2hvdy1pbnZhbGlkLWNoYXJhY3RlcnMiLCBXSS5zZXR0aW5ncy5zaG93SW52YWxpZENo YXJhY3RlcnMudmFsdWUpOworICAgIGZ1bmN0aW9uIHNldEludmlzaWJsZUNoYXJhY3RlckNsYXNz TmFtZSgpIHsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QudG9nZ2xlKCJzaG93LWlu dmlzaWJsZS1jaGFyYWN0ZXJzIiwgV0kuc2V0dGluZ3Muc2hvd0ludmlzaWJsZUNoYXJhY3RlcnMu dmFsdWUpOwogICAgIH0KLSAgICBXSS5zZXR0aW5ncy5zaG93SW52YWxpZENoYXJhY3RlcnMuYWRk RXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHNldEludmFsaWRDaGFyYWN0 ZXJDbGFzc05hbWUpOwotICAgIHNldEludmFsaWRDaGFyYWN0ZXJDbGFzc05hbWUoKTsKKyAgICBX SS5zZXR0aW5ncy5zaG93SW52aXNpYmxlQ2hhcmFjdGVycy5hZGRFdmVudExpc3RlbmVyKFdJLlNl dHRpbmcuRXZlbnQuQ2hhbmdlZCwgc2V0SW52aXNpYmxlQ2hhcmFjdGVyQ2xhc3NOYW1lKTsKKyAg ICBzZXRJbnZpc2libGVDaGFyYWN0ZXJDbGFzc05hbWUoKTsKIAogICAgIGZ1bmN0aW9uIHNldFdo aXRlc3BhY2VDaGFyYWN0ZXJDbGFzc05hbWUoKSB7CiAgICAgICAgIGRvY3VtZW50LmJvZHkuY2xh c3NMaXN0LnRvZ2dsZSgic2hvdy13aGl0ZXNwYWNlLWNoYXJhY3RlcnMiLCBXSS5zZXR0aW5ncy5z aG93V2hpdGVzcGFjZUNoYXJhY3RlcnMudmFsdWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4IDk5OTA2ZTE3NjBlMjg3 NjdjNGZlN2JlOTAwYjZkZjZlMzU2NjdkZWYuLjYyNTM5NGE5OWMzN2RjMDk1ZjQ0ZTJkN2E0NTlm N2VjOTNhZTI3YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvU2V0dGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL1NldHRpbmcuanMKQEAgLTE2Nyw3ICsxNjcsNyBAQCBXSS5zZXR0aW5ncyA9IHsK ICAgICBzaG93QXNzZXJ0aW9uRmFpbHVyZXNCcmVha3BvaW50OiBuZXcgV0kuU2V0dGluZygic2hv dy1hc3NlcnRpb24tZmFpbHVyZXMtYnJlYWtwb2ludCIsIHRydWUpLAogICAgIHNob3dDYW52YXNQ YXRoOiBuZXcgV0kuU2V0dGluZygic2hvdy1jYW52YXMtcGF0aCIsIGZhbHNlKSwKICAgICBzaG93 SW1hZ2VHcmlkOiBuZXcgV0kuU2V0dGluZygic2hvdy1pbWFnZS1ncmlkIiwgZmFsc2UpLAotICAg IHNob3dJbnZhbGlkQ2hhcmFjdGVyczogbmV3IFdJLlNldHRpbmcoInNob3ctaW52YWxpZC1jaGFy YWN0ZXJzIiwgZmFsc2UpLAorICAgIHNob3dJbnZpc2libGVDaGFyYWN0ZXJzOiBuZXcgV0kuU2V0 dGluZygic2hvdy1pbnZpc2libGUtY2hhcmFjdGVycyIsICEhV0kuU2V0dGluZy5taWdyYXRlVmFs dWUoInNob3ctaW52YWxpZC1jaGFyYWN0ZXJzIikpLAogICAgIHNob3dKYXZhU2NyaXB0VHlwZUlu Zm9ybWF0aW9uOiBuZXcgV0kuU2V0dGluZygic2hvdy1qYXZhc2NyaXB0LXR5cGUtaW5mb3JtYXRp b24iLCBmYWxzZSksCiAgICAgc2hvd1BhaW50UmVjdHM6IG5ldyBXSS5TZXR0aW5nKCJzaG93LXBh aW50LXJlY3RzIiwgZmFsc2UpLAogICAgIHNob3dSdWxlcnM6IG5ldyBXSS5TZXR0aW5nKCJzaG93 LXJ1bGVycyIsIGZhbHNlKSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JPdmVycmlkZXMuY3NzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvck92ZXJyaWRlcy5jc3MKaW5kZXgg ZjE4ZDRmY2QyNWI2YzU3MzRhOGQxMjE0NmQ3OGU0YmJhY2RiMDViNy4uNzAyZDgyMTNlMWNlOWQ0 OTE2NTE5OGM4OGFhNDI5MDc0OTcyNTdjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvck92ZXJyaWRlcy5jc3MKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvck92ZXJyaWRl cy5jc3MKQEAgLTExNCw3ICsxMTQsNyBAQAogICAgIGNvbG9yOiBoc2woMCwgMCUsIDcwJSk7CiB9 CiAKLS5zaG93LWludmFsaWQtY2hhcmFjdGVycyAuQ29kZU1pcnJvciAuY20taW52YWxpZGNoYXIg eworLnNob3ctaW52aXNpYmxlLWNoYXJhY3RlcnMgLkNvZGVNaXJyb3IgLmNtLWludmFsaWRjaGFy IHsKICAgICBkaXNwbGF5OiBpbml0aWFsOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250 ZW50Vmlldy5qcwppbmRleCBmOThlMzRiYmQ4ZDNjNDAyYWYxZTQ4NjhjMTFhMWIzZTI0N2ViOTk3 Li5mMzhkMDllYmIwMGRlMTY3OWRiYzQ2YmUwN2FiNWE1ODk3NTBjZjAzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKQEAgLTIwNyw3ICsyMDcsNyBAQCBXSS5TZXR0aW5n c1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJ LlRhYkNvbnRlbnRWaQogCiAgICAgICAgIGxldCBzaG93R3JvdXAgPSBnZW5lcmFsU2V0dGluZ3NW aWV3LmFkZEdyb3VwKFdJLlVJU3RyaW5nKCJTaG93OiIpKTsKICAgICAgICAgc2hvd0dyb3VwLmFk ZFNldHRpbmcoV0kuc2V0dGluZ3Muc2hvd1doaXRlc3BhY2VDaGFyYWN0ZXJzLCBXSS5VSVN0cmlu ZygiV2hpdGVzcGFjZSBjaGFyYWN0ZXJzIikpOwotICAgICAgICBzaG93R3JvdXAuYWRkU2V0dGlu ZyhXSS5zZXR0aW5ncy5zaG93SW52YWxpZENoYXJhY3RlcnMsIFdJLlVJU3RyaW5nKCJJbnZhbGlk IGNoYXJhY3RlcnMiKSk7CisgICAgICAgIHNob3dHcm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdz LnNob3dJbnZpc2libGVDaGFyYWN0ZXJzLCBXSS5VSVN0cmluZygiSW52aXNpYmxlIGNoYXJhY3Rl cnMiKSk7CiAKICAgICAgICAgZ2VuZXJhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKIAo=