200789 2019-08-15 14:08:02 -0700 mozilla-tests.yaml/js1_5/Array/regress-101964.js is frequently failing on JSC EWS bots 2019-12-08 06:31:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad mark.lam aakash_jain ap commit-queue ews-watchlist fpizlo guijemont keith_miller mark.lam msaboff pmatos ross.kirsling saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1561740 0 ryanhaddad 2019-08-15 14:08:02 -0700 mozilla-tests.yaml/js1_5/Array/regress-101964.js is a flaky failure on JSC EWS bots. Here are examples: https://bugs.webkit.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&f0=OP&f1=OP&f2=product&f3=component&f4=alias&f5=short_desc&f7=content&f8=CP&f9=CP&j1=OR&list_id=4991060&o2=substring&o3=substring&o4=substring&o5=substring&o6=substring&o7=matches&query_format=advanced&v2=mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js&v3=mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js&v4=mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js&v5=mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js&v6=mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js&v7=%22mozilla-tests.yaml%2Fjs1_5%2FArray%2Fregress-101964.js%22 1561741 1 webkit-bug-importer 2019-08-15 14:09:06 -0700 <rdar://problem/54361916> 1582843 2 ap 2019-10-23 09:28:48 -0700 There were 15 false positives because of this on EWS in a month, so worth looking into soon. 1592830 3 ap 2019-11-22 09:21:31 -0800 *** Bug 204502 has been marked as a duplicate of this bug. *** 1592832 4 ap 2019-11-22 09:21:41 -0800 *** Bug 204406 has been marked as a duplicate of this bug. *** 1592856 5 keith_miller 2019-11-22 10:00:12 -0800 Let's just delete that test... I'm assuming it's failing because it's being run with dozens of other processes so it happens to get scheduled weirdly. 1592862 6 ap 2019-11-22 10:11:02 -0800 Indeed! Testing that something takes under 100 ms makes no sense when running many tests in parallel. mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-baseline: STATUS: Performance: truncating even very large arrays should be fast! mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-baseline: FAILED!: [reported from test()] Section 1 of test - mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-baseline: FAILED!: [reported from test()] Expected value 'Truncation took less than 100 ms', Actual value 'Truncation took 193 ms' mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-baseline: FAILED!: [reported from test()] 1594016 7 aakash_jain 2019-11-28 05:06:52 -0800 This test flaked again in https://ews-build.webkit.org/#/builders/26/builds/469 mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases: Detected failures: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases: BUGNUMBER: 101964 mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases: STATUS: Performance: truncating even very large arrays should be fast! mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases: FAILED!: [reported from test()] Section 1 of test - mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases: FAILED!: [reported from test()] Expected value 'Truncation took less than 100 ms', Actual value 'Truncation took 336 ms' Note that these tests are running on Raspberry Pi on Igalia JSC queues (ARMv7 and MIPSEL). 1594097 8 aakash_jain 2019-11-28 11:49:15 -0800 Flaked again in: https://ews-build.webkit.org/#/builders/26/builds/527 1594573 9 pmatos 2019-12-02 07:01:37 -0800 I have noticed, as Aakash that this test keeps passing/failing on mips and armv7. I have opened bug 204746 to skip it on these architectures, but I am happy if it's removed altogether. 1594643 10 guijemont 2019-12-02 09:30:48 -0800 As Paulo just said, it flakes quite regularly on mips (though our mips test devices are not raspberry pis, obviously, but they're quite slow ci20 dev boards) and on armv7 (rpi3s). Running the test on its own with nothing else running on the board it always passes though, failures only seem to happen while running other tests. Maybe raising the timeout could be a solution? I think on mips when it fails, it's still always under 200ms, I guess we could do 300ms to be on the safe side, and from what I understand, if the regression it's testing would happen, the truncation would take an order of magnitude more than that, so a timeout of 300-500ms might be more appropriate for this test? 1594646 11 aakash_jain 2019-12-02 09:38:59 -0800 (In reply to Guillaume Emont from comment #10) > Maybe raising the timeout could be a solution? I think on mips when it > fails, it's still always under 200ms, I guess we could do 300ms to be on the safe side On armv7 it took 336ms in https://ews-build.webkit.org/#/builders/26/builds/469/steps/9/logs/stdio (line 37271). So, for armv7 we would either need to skip/disable this test or choose higher timeout. 1594648 12 keith_miller 2019-12-02 09:41:01 -0800 I think we should just get rid of this test. We don't run tests in isolation so even on high power machines the system could and likely does suspend this test to run other tests. 1594655 13 384634 keith_miller 2019-12-02 09:45:47 -0800 Created attachment 384634 Patch 1594656 14 aakash_jain 2019-12-02 09:50:06 -0800 Should we delete https://trac.webkit.org/browser/webkit/trunk/JSTests/mozilla/js1_5/Array/regress-101964.js as well? 1594657 15 mark.lam 2019-12-02 09:52:49 -0800 (In reply to Aakash Jain from comment #14) > Should we delete > https://trac.webkit.org/browser/webkit/trunk/JSTests/mozilla/js1_5/Array/ > regress-101964.js as well? I was just looking at the test. It seems strange that it should ever time out. I suggest filing a bug to investigate why it times out. 1594658 16 mark.lam 2019-12-02 09:55:44 -0800 (In reply to Mark Lam from comment #15) > (In reply to Aakash Jain from comment #14) > > Should we delete > > https://trac.webkit.org/browser/webkit/trunk/JSTests/mozilla/js1_5/Array/ > > regress-101964.js as well? > > I was just looking at the test. It seems strange that it should ever time > out. I suggest filing a bug to investigate why it times out. Sorry. I mean I don't see why the test should ever fail. It's testing a trivial operation. I think we should do some due dilligence to make sure there's not some latent perf bug here. 1594670 17 keith_miller 2019-12-02 10:14:28 -0800 (In reply to Mark Lam from comment #16) > (In reply to Mark Lam from comment #15) > > (In reply to Aakash Jain from comment #14) > > > Should we delete > > > https://trac.webkit.org/browser/webkit/trunk/JSTests/mozilla/js1_5/Array/ > > > regress-101964.js as well? > > > > I was just looking at the test. It seems strange that it should ever time > > out. I suggest filing a bug to investigate why it times out. > > Sorry. I mean I don't see why the test should ever fail. It's testing a > trivial operation. I think we should do some due dilligence to make sure > there's not some latent perf bug here. It could fail because the os schedules so other tests to run between the time checks. 1594678 18 ross.kirsling 2019-12-02 10:21:23 -0800 Interestingly, we already raised the threshold from 50ms to 100ms three years ago: https://github.com/WebKit/webkit/commit/50c9e3155e5fa74b2579f8240fd00afbda4a00ae 1594717 19 mark.lam 2019-12-02 11:32:52 -0800 (In reply to Keith Miller from comment #17) > (In reply to Mark Lam from comment #16) > > (In reply to Mark Lam from comment #15) > > > (In reply to Aakash Jain from comment #14) > > > > Should we delete > > > > https://trac.webkit.org/browser/webkit/trunk/JSTests/mozilla/js1_5/Array/ > > > > regress-101964.js as well? > > > > > > I was just looking at the test. It seems strange that it should ever time > > > out. I suggest filing a bug to investigate why it times out. > > > > Sorry. I mean I don't see why the test should ever fail. It's testing a > > trivial operation. I think we should do some due dilligence to make sure > > there's not some latent perf bug here. > > It could fail because the os schedules so other tests to run between the > time checks. If this is the case, then we can trivially solve this by changing the test to use CPU time instead of wall clock time. That should also prove that there's nothing else wrong. I'll prepare a patch. 1594737 20 384646 mark.lam 2019-12-02 12:18:56 -0800 Created attachment 384646 proposed patch. 1594739 21 384647 mark.lam 2019-12-02 12:21:39 -0800 Created attachment 384647 proposed patch. 1594741 22 384647 keith_miller 2019-12-02 12:24:08 -0800 Comment on attachment 384647 proposed patch. r=me. 1594764 23 384647 mark.lam 2019-12-02 13:32:58 -0800 Comment on attachment 384647 proposed patch. Thanks for the review. Landing now. 1594790 24 384647 commit-queue 2019-12-02 14:16:49 -0800 Comment on attachment 384647 proposed patch. Clearing flags on attachment: 384647 Committed r253008: <https://trac.webkit.org/changeset/253008> 1594792 25 commit-queue 2019-12-02 14:16:51 -0800 All reviewed patches have been landed. Closing bug. 1596677 26 guijemont 2019-12-08 06:31:39 -0800 (In reply to Mark Lam from comment #19) > (In reply to Keith Miller from comment #17) > > > > It could fail because the os schedules so other tests to run between the > > time checks. > > If this is the case, then we can trivially solve this by changing the test > to use CPU time instead of wall clock time. That should also prove that > there's nothing else wrong. I'll prepare a patch. Looking at the mips bot results, this seems to have solved it: the test lately was failing every second run, and it's now been 16 runs without it failing. Good idea, thanks! 384634 2019-12-02 09:45:47 -0800 2019-12-02 12:18:56 -0800 Patch bug-200789-20191202094544.patch text/plain 1380 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTg3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRiNzg0ODNhYzlhOGE5NzE0Y2Q1MmY3NDk0YTEw YjVlMzU0ZjhmNmMuLjY2OTAyMWQyN2U1OWVjYzliOWNmODkyMmQ2Mzg3ODc4NjY4YTVjYTkgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMTItMDIgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBs ZS5jb20+CisKKyAgICAgICAgbW96aWxsYS10ZXN0cy55YW1sL2pzMV81L0FycmF5L3JlZ3Jlc3Mt MTAxOTY0LmpzIGlzIGZyZXF1ZW50bHkgZmFpbGluZyBvbiBKU0MgRVdTIGJvdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc4OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNraXAgdGhpcyB0ZXN0IG9u IGFsbCBwbGF0Zm9ybXMgYmVjYXVzZSBpdCBjYW4gYmUgdmVyeSBmbGFreS4KKworICAgICAgICAq IG1vemlsbGEvbW96aWxsYS10ZXN0cy55YW1sOgorCiAyMDE5LTEyLTAxICBDYWlvIExpbWEgIDx0 aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXVtNSVBTXSBDYWxsRnJhbWUgaXMg YmVpbmcgY2xvYmJlcmVkIG9uIEludGVybmFsRnVuY3Rpb24gZXhlY3V0aW9uCmRpZmYgLS1naXQg YS9KU1Rlc3RzL21vemlsbGEvbW96aWxsYS10ZXN0cy55YW1sIGIvSlNUZXN0cy9tb3ppbGxhL21v emlsbGEtdGVzdHMueWFtbAppbmRleCBkMWY3N2I3MTJlMzhjYzUzNzMwNzI2Y2Y5MjI4NDM3MGQz NTg3OGUyLi5lZDdmYjc3NjY4NzYzZWUzMTQ1NjdiOWQxM2VhMWJmODViNmZhYjFhIDEwMDY0NAot LS0gYS9KU1Rlc3RzL21vemlsbGEvbW96aWxsYS10ZXN0cy55YW1sCisrKyBiL0pTVGVzdHMvbW96 aWxsYS9tb3ppbGxhLXRlc3RzLnlhbWwKQEAgLTIwMjcsOCArMjAyNyw2IEBACiAgIGNtZDogZGVm YXVsdFJ1bk1vemlsbGFUZXN0IDpuZWdhdGl2ZSwgIi4uL3NoZWxsLmpzIgogLSBwYXRoOiBqczFf NS9BcnJheS9hcnJheS0wMDEuanMKICAgY21kOiBkZWZhdWx0UnVuTW96aWxsYVRlc3QgOm5vcm1h bCwgIi4uL3NoZWxsLmpzIgotLSBwYXRoOiBqczFfNS9BcnJheS9yZWdyZXNzLTEwMTk2NC5qcwot ICBjbWQ6IGRlZmF1bHRSdW5Nb3ppbGxhVGVzdCA6bm9ybWFsLCAiLi4vc2hlbGwuanMiCiAtIHBh dGg6IGpzMV81L0FycmF5L3JlZ3Jlc3MtMTA3MTM4LmpzCiAgIGNtZDogZGVmYXVsdFJ1bk1vemls bGFUZXN0IDpub3JtYWwsICIuLi9zaGVsbC5qcyIKIC0gcGF0aDoganMxXzUvQXJyYXkvcmVncmVz cy0xMDg0NDAuanMK 384646 2019-12-02 12:18:56 -0800 2019-12-02 12:20:56 -0800 proposed patch. bug-200789.patch text/plain 5350 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTMwMDMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBtb3ppbGxhLXRlc3RzLnlhbWwvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5 NjQuanMgaXMgZnJlcXVlbnRseSBmYWlsaW5nIG9uIEpTQyBFV1MgYm90cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc4OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTQzNjE5MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIHByZXZhaWxpbmcgdGhlb3J5IGlzIHRoYXQgdGhpcyB0ZXN0IGlz IGJlaW5nIHByZS1lbXB0ZWQgYW5kIG5vdCBnZXR0aW5nIHRoZQorICAgICAgICBDUFUgdGltZSBp dCBuZWVkcyB0byBjb21wbGV0ZS4gIEFzIGEgcmVzdWx0LCB0aGUgd2FsbCBjbG9jayB0aW1lIHBl cmlvZCBmb3IKKyAgICAgICAgcnVubmluZyB0aGUgdGVzdCBleGNlZWRzIHRoZSBleHBlY3RlZCB0 aW1lLiAgVGhpcyBwYXRjaCB0ZXN0cyB0aGlzIHRoZW9yeSBieQorICAgICAgICBjaGFuZ2luZyB0 aGUgdGltZSBtZWFzdXJlbWVudCB0byB1c2UgQ1BVIHRpbWUgaW5zdGVhZC4KKworICAgICAgICAq IG1vemlsbGEvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5NjQuanM6CisKIDIwMTktMTItMDEgIENh aW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdW01JUFNdIENh bGxGcmFtZSBpcyBiZWluZyBjbG9iYmVyZWQgb24gSW50ZXJuYWxGdW5jdGlvbiBleGVjdXRpb24K SW5kZXg6IEpTVGVzdHMvbW96aWxsYS9qczFfNS9BcnJheS9yZWdyZXNzLTEwMTk2NC5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL21vemlsbGEvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5NjQuanMJ KHJldmlzaW9uIDI1MzAwMSkKKysrIEpTVGVzdHMvbW96aWxsYS9qczFfNS9BcnJheS9yZWdyZXNz LTEwMTk2NC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCB2YXIgZXhwZWN0ZWR2 YWx1ZXMgPSBbXTsKIAogc3RhdHVzID0gaW5TZWN0aW9uKDEpOwogdmFyIGFyciA9IEFycmF5KEJJ Ryk7Ci12YXIgc3RhcnQgPSBuZXcgRGF0ZSgpOwordmFyIHN0YXJ0ID0gJHZtLmN1cnJlbnRDUFVU aW1lKCk7CiBhcnIubGVuZ3RoID0gTElUVExFOwogYWN0dWFsID0gZWxhcHNlZFRpbWUoc3RhcnQp OwogZXhwZWN0ID0gRkFTVDsKQEAgLTYyLDcgKzYyLDcgQEAgdGVzdCgpOwogCiBmdW5jdGlvbiBl bGFwc2VkVGltZShzdGFydFRpbWUpCiB7Ci0gIHJldHVybiBuZXcgRGF0ZSgpIC0gc3RhcnRUaW1l OworICByZXR1cm4gJHZtLmN1cnJlbnRDUFVUaW1lKCkgLSBzdGFydFRpbWU7CiB9CiAKIApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTMwMDEpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTktMTItMDIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIG1vemls bGEtdGVzdHMueWFtbC9qczFfNS9BcnJheS9yZWdyZXNzLTEwMTk2NC5qcyBpcyBmcmVxdWVudGx5 IGZhaWxpbmcgb24gSlNDIEVXUyBib3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDM2MTkx Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRv b2xzL0pTRG9sbGFyVk0uY3BwOgorICAgICAgICAoSlNDOjpmdW5jdGlvbkN1cnJlbnRDUFVUaW1l KToKKyAgICAgICAgKEpTQzo6SlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24pOgorCiAyMDE5LTEy LTAxICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBGdXp6ZXJBZ2VudCB0aGF0IHJlYWRzIHByZWRpY3Rpb25zIGZyb20gYSBmaWxlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCShyZXZpc2lv biAyNTMwMDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDcgQEAKICNpbmNsdWRlICJWTUluc3BlY3Rvci5o IgogI2luY2x1ZGUgIldhc21DYXBhYmlsaXRpZXMuaCIKICNpbmNsdWRlIDx3dGYvQXRvbWljcy5o PgorI2luY2x1ZGUgPHd0Zi9DUFVUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KICNp bmNsdWRlIDx3dGYvUHJvY2Vzc0lELmg+CiAjaW5jbHVkZSA8d3RmL1N0cmluZ1ByaW50U3RyZWFt Lmg+CkBAIC0yNjc1LDYgKzI2NzYsMTIgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgZnVuYwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoc3RhdGljX2Nh c3Q8aW50MzJfdD4oZGVsdGEpKSk7CiB9CiAKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGZ1bmN0aW9uQ3VycmVudENQVVRpbWUoSlNHbG9iYWxPYmplY3QqLCBDYWxsRnJhbWUq KQoreworICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CisgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShqc051bWJlcihDUFVUaW1lOjpmb3JDdXJyZW50VGhyZWFkKCkudmFsdWUo KSkpOworfQorCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblRv dGFsR0NUaW1lKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSopCiB7CiAg ICAgRG9sbGFyVk1Bc3NlcnRTY29wZSBhc3NlcnRTY29wZTsKQEAgLTI4MzIsNiArMjgzOSw3IEBA IHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogCiAgICAgYWRkRnVuY3Rp b24odm0sICJkZWx0YUJldHdlZW5CdXR0ZXJmbGllcyIsIGZ1bmN0aW9uRGVsdGFCZXR3ZWVuQnV0 dGVyZmxpZXMsIDIpOwogICAgIAorICAgIGFkZEZ1bmN0aW9uKHZtLCAiY3VycmVudENQVVRpbWUi LCBmdW5jdGlvbkN1cnJlbnRDUFVUaW1lLCAwKTsKICAgICBhZGRGdW5jdGlvbih2bSwgInRvdGFs R0NUaW1lIiwgZnVuY3Rpb25Ub3RhbEdDVGltZSwgMCk7CiAKICAgICBhZGRGdW5jdGlvbih2bSwg InBhcnNlQ291bnQiLCBmdW5jdGlvblBhcnNlQ291bnQsIDApOwpJbmRleDogV2ViS2l0Lnhjd29y a3NwYWNlL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvQWxsIFNvdXJjZS54Y3NjaGVtZQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQueGN3b3Jrc3BhY2UveGNzaGFyZWRkYXRhL3hjc2NoZW1lcy9BbGwgU291 cmNlLnhjc2NoZW1lCShyZXZpc2lvbiAyNTMwMDEpCisrKyBXZWJLaXQueGN3b3Jrc3BhY2UveGNz aGFyZWRkYXRhL3hjc2NoZW1lcy9BbGwgU291cmNlLnhjc2NoZW1lCSh3b3JraW5nIGNvcHkpCkBA IC01Nyw3ICs1Nyw3IEBACiAgICAgICAgICAgICA8QnVpbGRhYmxlUmVmZXJlbmNlCiAgICAgICAg ICAgICAgICBCdWlsZGFibGVJZGVudGlmaWVyID0gInByaW1hcnkiCiAgICAgICAgICAgICAgICBC bHVlcHJpbnRJZGVudGlmaWVyID0gIkZCMzlEMEQwMTIwMEYwRTMwMDA4OEU2OSIKLSAgICAgICAg ICAgICAgIEJ1aWxkYWJsZU5hbWUgPSAibGliQU5HTEUuYSIKKyAgICAgICAgICAgICAgIEJ1aWxk YWJsZU5hbWUgPSAibGliQU5HTEUuZHlsaWIiCiAgICAgICAgICAgICAgICBCbHVlcHJpbnROYW1l ID0gIkFOR0xFIgogICAgICAgICAgICAgICAgUmVmZXJlbmNlZENvbnRhaW5lciA9ICJjb250YWlu ZXI6U291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5HTEUueGNvZGVwcm9qIj4KICAgICAgICAgICAg IDwvQnVpbGRhYmxlUmVmZXJlbmNlPgpAQCAtMTM5LDggKzEzOSw2IEBACiAgICAgICBzZWxlY3Rl ZERlYnVnZ2VySWRlbnRpZmllciA9ICJYY29kZS5EZWJ1Z2dlckZvdW5kYXRpb24uRGVidWdnZXIu TExEQiIKICAgICAgIHNlbGVjdGVkTGF1bmNoZXJJZGVudGlmaWVyID0gIlhjb2RlLkRlYnVnZ2Vy Rm91bmRhdGlvbi5MYXVuY2hlci5MTERCIgogICAgICAgc2hvdWxkVXNlTGF1bmNoU2NoZW1lQXJn c0VudiA9ICJZRVMiPgotICAgICAgPFRlc3RhYmxlcz4KLSAgICAgIDwvVGVzdGFibGVzPgogICAg ICAgPE1hY3JvRXhwYW5zaW9uPgogICAgICAgICAgPEJ1aWxkYWJsZVJlZmVyZW5jZQogICAgICAg ICAgICAgQnVpbGRhYmxlSWRlbnRpZmllciA9ICJwcmltYXJ5IgpAQCAtMTUwLDggKzE0OCw4IEBA CiAgICAgICAgICAgICBSZWZlcmVuY2VkQ29udGFpbmVyID0gImNvbnRhaW5lcjpUb29scy9NaW5p QnJvd3Nlci9NaW5pQnJvd3Nlci54Y29kZXByb2oiPgogICAgICAgICAgPC9CdWlsZGFibGVSZWZl cmVuY2U+CiAgICAgICA8L01hY3JvRXhwYW5zaW9uPgotICAgICAgPEFkZGl0aW9uYWxPcHRpb25z PgotICAgICAgPC9BZGRpdGlvbmFsT3B0aW9ucz4KKyAgICAgIDxUZXN0YWJsZXM+CisgICAgICA8 L1Rlc3RhYmxlcz4KICAgIDwvVGVzdEFjdGlvbj4KICAgIDxMYXVuY2hBY3Rpb24KICAgICAgIGJ1 aWxkQ29uZmlndXJhdGlvbiA9ICJEZWJ1ZyIKQEAgLTE3Myw4ICsxNzEsNiBAQAogICAgICAgICAg ICAgUmVmZXJlbmNlZENvbnRhaW5lciA9ICJjb250YWluZXI6VG9vbHMvTWluaUJyb3dzZXIvTWlu aUJyb3dzZXIueGNvZGVwcm9qIj4KICAgICAgICAgIDwvQnVpbGRhYmxlUmVmZXJlbmNlPgogICAg ICAgPC9CdWlsZGFibGVQcm9kdWN0UnVubmFibGU+Ci0gICAgICA8QWRkaXRpb25hbE9wdGlvbnM+ Ci0gICAgICA8L0FkZGl0aW9uYWxPcHRpb25zPgogICAgPC9MYXVuY2hBY3Rpb24+CiAgICA8UHJv ZmlsZUFjdGlvbgogICAgICAgYnVpbGRDb25maWd1cmF0aW9uID0gIlJlbGVhc2UiCg== 384647 2019-12-02 12:21:39 -0800 2019-12-02 14:16:49 -0800 proposed patch. bug-200789.patch text/plain 3629 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTMwMDMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE4IEBACisyMDE5LTEyLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBtb3ppbGxhLXRlc3RzLnlhbWwvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5 NjQuanMgaXMgZnJlcXVlbnRseSBmYWlsaW5nIG9uIEpTQyBFV1MgYm90cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc4OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTQzNjE5MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIHByZXZhaWxpbmcgdGhlb3J5IGlzIHRoYXQgdGhpcyB0ZXN0IGlz IGJlaW5nIHByZS1lbXB0ZWQgYW5kIG5vdCBnZXR0aW5nIHRoZQorICAgICAgICBDUFUgdGltZSBp dCBuZWVkcyB0byBjb21wbGV0ZS4gIEFzIGEgcmVzdWx0LCB0aGUgd2FsbCBjbG9jayB0aW1lIHBl cmlvZCBmb3IKKyAgICAgICAgcnVubmluZyB0aGUgdGVzdCBleGNlZWRzIHRoZSBleHBlY3RlZCB0 aW1lLiAgVGhpcyBwYXRjaCB0ZXN0cyB0aGlzIHRoZW9yeSBieQorICAgICAgICBjaGFuZ2luZyB0 aGUgdGltZSBtZWFzdXJlbWVudCB0byB1c2UgQ1BVIHRpbWUgaW5zdGVhZC4KKworICAgICAgICAq IG1vemlsbGEvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5NjQuanM6CisKIDIwMTktMTItMDEgIENh aW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdW01JUFNdIENh bGxGcmFtZSBpcyBiZWluZyBjbG9iYmVyZWQgb24gSW50ZXJuYWxGdW5jdGlvbiBleGVjdXRpb24K SW5kZXg6IEpTVGVzdHMvbW96aWxsYS9qczFfNS9BcnJheS9yZWdyZXNzLTEwMTk2NC5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL21vemlsbGEvanMxXzUvQXJyYXkvcmVncmVzcy0xMDE5NjQuanMJ KHJldmlzaW9uIDI1MzAwMSkKKysrIEpTVGVzdHMvbW96aWxsYS9qczFfNS9BcnJheS9yZWdyZXNz LTEwMTk2NC5qcwkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCB2YXIgZXhwZWN0ZWR2 YWx1ZXMgPSBbXTsKIAogc3RhdHVzID0gaW5TZWN0aW9uKDEpOwogdmFyIGFyciA9IEFycmF5KEJJ Ryk7Ci12YXIgc3RhcnQgPSBuZXcgRGF0ZSgpOwordmFyIHN0YXJ0ID0gJHZtLmN1cnJlbnRDUFVU aW1lKCk7CiBhcnIubGVuZ3RoID0gTElUVExFOwogYWN0dWFsID0gZWxhcHNlZFRpbWUoc3RhcnQp OwogZXhwZWN0ID0gRkFTVDsKQEAgLTYyLDcgKzYyLDcgQEAgdGVzdCgpOwogCiBmdW5jdGlvbiBl bGFwc2VkVGltZShzdGFydFRpbWUpCiB7Ci0gIHJldHVybiBuZXcgRGF0ZSgpIC0gc3RhcnRUaW1l OworICByZXR1cm4gJHZtLmN1cnJlbnRDUFVUaW1lKCkgLSBzdGFydFRpbWU7CiB9CiAKIApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTMwMDEpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTktMTItMDIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIG1vemls bGEtdGVzdHMueWFtbC9qczFfNS9BcnJheS9yZWdyZXNzLTEwMTk2NC5qcyBpcyBmcmVxdWVudGx5 IGZhaWxpbmcgb24gSlNDIEVXUyBib3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDM2MTkx Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRv b2xzL0pTRG9sbGFyVk0uY3BwOgorICAgICAgICAoSlNDOjpmdW5jdGlvbkN1cnJlbnRDUFVUaW1l KToKKyAgICAgICAgKEpTQzo6SlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24pOgorCiAyMDE5LTEy LTAxICBUdW9tYXMgS2Fya2thaW5lbiAgPHR1b21hcy53ZWJraXRAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBGdXp6ZXJBZ2VudCB0aGF0IHJlYWRzIHByZWRpY3Rpb25zIGZyb20gYSBmaWxlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCShyZXZpc2lv biAyNTMwMDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDcgQEAKICNpbmNsdWRlICJWTUluc3BlY3Rvci5o IgogI2luY2x1ZGUgIldhc21DYXBhYmlsaXRpZXMuaCIKICNpbmNsdWRlIDx3dGYvQXRvbWljcy5o PgorI2luY2x1ZGUgPHd0Zi9DUFVUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KICNp bmNsdWRlIDx3dGYvUHJvY2Vzc0lELmg+CiAjaW5jbHVkZSA8d3RmL1N0cmluZ1ByaW50U3RyZWFt Lmg+CkBAIC0yNjc1LDYgKzI2NzYsMTIgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgZnVuYwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoc3RhdGljX2Nh c3Q8aW50MzJfdD4oZGVsdGEpKSk7CiB9CiAKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGZ1bmN0aW9uQ3VycmVudENQVVRpbWUoSlNHbG9iYWxPYmplY3QqLCBDYWxsRnJhbWUq KQoreworICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CisgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShqc051bWJlcihDUFVUaW1lOjpmb3JDdXJyZW50VGhyZWFkKCkudmFsdWUo KSkpOworfQorCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblRv dGFsR0NUaW1lKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENhbGxGcmFtZSopCiB7CiAg ICAgRG9sbGFyVk1Bc3NlcnRTY29wZSBhc3NlcnRTY29wZTsKQEAgLTI4MzIsNiArMjgzOSw3IEBA IHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogCiAgICAgYWRkRnVuY3Rp b24odm0sICJkZWx0YUJldHdlZW5CdXR0ZXJmbGllcyIsIGZ1bmN0aW9uRGVsdGFCZXR3ZWVuQnV0 dGVyZmxpZXMsIDIpOwogICAgIAorICAgIGFkZEZ1bmN0aW9uKHZtLCAiY3VycmVudENQVVRpbWUi LCBmdW5jdGlvbkN1cnJlbnRDUFVUaW1lLCAwKTsKICAgICBhZGRGdW5jdGlvbih2bSwgInRvdGFs R0NUaW1lIiwgZnVuY3Rpb25Ub3RhbEdDVGltZSwgMCk7CiAKICAgICBhZGRGdW5jdGlvbih2bSwg InBhcnNlQ291bnQiLCBmdW5jdGlvblBhcnNlQ291bnQsIDApOwo=