200785 2019-08-15 13:20:33 -0700 [WHLSL] Don't accept operator&& or operator|| in the Lexer 2019-08-15 14:19:17 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist mmaxfield saam webkit-bug-importer oldest_to_newest 1561715 0 rmorisset 2019-08-15 13:20:33 -0700 They don't make sense: implementing && or || as function calls would lose us short-circuiting. 1561719 1 376415 rmorisset 2019-08-15 13:29:18 -0700 Created attachment 376415 Patch 1561747 2 376415 commit-queue 2019-08-15 14:18:17 -0700 Comment on attachment 376415 Patch Clearing flags on attachment: 376415 Committed r248746: <https://trac.webkit.org/changeset/248746> 1561748 3 commit-queue 2019-08-15 14:18:19 -0700 All reviewed patches have been landed. Closing bug. 1561749 4 webkit-bug-importer 2019-08-15 14:19:17 -0700 <rdar://problem/54362301> 376415 2019-08-15 13:29:18 -0700 2019-08-15 14:18:17 -0700 Patch patch200785 text/plain 2742 rmorisset ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2NjI1YTg0YmIyYy4uZmU2ZDM2NDNmNzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOS0wOC0xNSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUuY29tPgorCisgICAg ICAgIFtXSExTTF0gRG9uJ3QgYWNjZXB0IG9wZXJhdG9yJiYgb3Igb3BlcmF0b3J8fCBpbiB0aGUg TGV4ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDc4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog d2ViZ3B1L3dobHNsL2xleGluZy5odG1sOgorCiAyMDE5LTA4LTE0ICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IGBjb25z b2xlLnNjcmVlbnNob3RgIHdpdGggZGF0YVVSTCBzdHJpbmdzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy93ZWJncHUvd2hsc2wvbGV4aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wv bGV4aW5nLmh0bWwKaW5kZXggMDk0N2FmMjY0OGUuLjZhMDNmOTAzN2JiIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvbGV4aW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2Vi Z3B1L3dobHNsL2xleGluZy5odG1sCkBAIC0xNTUsNiArMTU1LDE4IEBAIHdobHNsVGVzdHMub3Bl cmF0b3JOYW1lcyA9IGFzeW5jICgpID0+IHsKICAgICAgICAgICAgIHJldHVybiA0MjsKICAgICAg ICAgfQogICAgIGApOworCisgICAgYXdhaXQgY2hlY2tGYWlsKGAKKyAgICAgICAgaW50IG9wZXJh dG9yJiYoaW50IHgsIGludCB5KSB7CisgICAgICAgICAgICByZXR1cm4gNDI7CisgICAgICAgIH0K KyAgICBgKTsKKworICAgIGF3YWl0IGNoZWNrRmFpbChgCisgICAgICAgIGJvb2wgb3BlcmF0b3J8 fChpbnQgeCwgaW50IHkpIHsKKyAgICAgICAgICAgIHJldHVybiA0MjsKKyAgICAgICAgfQorICAg IGApOwogfTsKIAogcnVuVGVzdHMod2hsc2xUZXN0cyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg3NWYxZmMy ZmMuLmI4ZWRiNjFjYjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMTUg IFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBbV0hMU0xd IERvbid0IGFjY2VwdCBvcGVyYXRvciYmIG9yIG9wZXJhdG9yfHwgaW4gdGhlIExleGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3ODUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRpbmcg JiYgb3IgfHwgYXMgZnVuY3Rpb24gY2FsbHMgd291bGQgbG9zZSB1cyBzaG9ydC1jaXJjdWl0aW5n LgorCisgICAgICAgIDIgbmV3IHRlc3RzIGluIExheW91dFRlc3RzL3dlYmdwdS93aGxzbC9sZXhp bmcuaHRtbAorCisgICAgICAgICogTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xMZXhlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpXSExTTDo6TGV4ZXI6OmNvbnN1bWVUb2tlbkZyb21TdHJlYW0p OgorCiAyMDE5LTA4LTE0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IGBjb25zb2xlLnNjcmVlbnNob3RgIHdpdGggZGF0 YVVSTCBzdHJpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9X SExTTC9XSExTTExleGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNM L1dITFNMTGV4ZXIuY3BwCmluZGV4IGY0Y2NhOGU4YWQyLi4xYWE1ZGZhMzI0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xMZXhlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xMZXhlci5jcHAKQEAg LTg2OCw5ICs4NjgsNiBAQCBwYXJzZUlkZW50aWZpZXI6CiAgICAgICAgICAgICAgICAgaWYgKGNv bnN1bWUoJ10nKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRva2VuKFRva2VuOjpUeXBl OjpPcGVyYXRvck5hbWUpOwogICAgICAgICAgICAgICAgIHJldHVybiB0b2tlbihUb2tlbjo6VHlw ZTo6SW52YWxpZCk7Ci0gICAgICAgICAgICBjYXNlICcmJzoKLSAgICAgICAgICAgICAgICBzaGlm dCgpOwotICAgICAgICAgICAgICAgIHJldHVybiB0b2tlbihUb2tlbjo6VHlwZTo6T3BlcmF0b3JO YW1lKTsKICAgICAgICAgICAgIGNhc2UgJy4nOgogICAgICAgICAgICAgICAgIHNoaWZ0KCk7CiAg ICAgICAgICAgICAgICAgaWYgKCFpc1ZhbGlkSWRlbnRpZmllclN0YXJ0KHBlZWsoKSkpCkBAIC05 MTgsNyArOTE1LDYgQEAgcGFyc2VJZGVudGlmaWVyOgogCiAgICAgICAgIGNhc2UgJ3wnOgogICAg ICAgICAgICAgc2hpZnQoKTsKLSAgICAgICAgICAgIGNvbnN1bWUoJ3wnKTsKICAgICAgICAgICAg IHJldHVybiB0b2tlbihUb2tlbjo6VHlwZTo6T3BlcmF0b3JOYW1lKTsKIAogICAgICAgICBjYXNl ICc9JzoK