20078 2008-07-17 06:58:52 -0700 [GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h 2008-07-25 16:18:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 uws+webkit webkit-unassigned zecke oldest_to_newest 86214 0 uws+webkit 2008-07-17 06:58:52 -0700 The GTK type checking macros have been deprecated in favor for the (identical) glib ones. Using the old ones breaks the build with -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED enabled. Will attach a patch in a minute. 86215 1 22338 uws+webkit 2008-07-17 07:03:57 -0700 Created attachment 22338 Proposed fix 86228 2 22338 zecke 2008-07-17 09:58:42 -0700 Comment on attachment 22338 Proposed fix Compared with http://library.gnome.org/devel/gtk/stable/gtk-Types.html#GTK-CHECK-CAST:CAPS. I couldn't see a deprecation note though. 86260 3 uws+webkit 2008-07-17 12:18:56 -0700 It will be deprecated in the upcoming GTK release [1]. The corresponding Glib are also in the current stable release [2]. [1] http://library.gnome.org/devel/gtk/unstable/gtk-Types.html#GTK-CHECK-CAST:CAPS (note that there's "unstable", not "stable" in the url!) [2] http://library.gnome.org/devel/gobject/stable/gobject-Type-Information.html#G-TYPE-CHECK-CLASS-CAST:CAPS 86261 4 uws+webkit 2008-07-17 12:22:04 -0700 Note that the GTK checks macros are exactly the same as the Glib macros, as can be seen in gtk+/gtk/gtktypeutils.h: > /* glib macro wrappers (compatibility) */ > #define GTK_CHECK_CAST G_TYPE_CHECK_INSTANCE_CAST > #define GTK_CHECK_CLASS_CAST G_TYPE_CHECK_CLASS_CAST > #define GTK_CHECK_GET_CLASS G_TYPE_INSTANCE_GET_CLASS > #define GTK_CHECK_TYPE G_TYPE_CHECK_INSTANCE_TYPE > #define GTK_CHECK_CLASS_TYPE G_TYPE_CHECK_CLASS_TYPE 86974 5 jmalonzo 2008-07-25 16:18:29 -0700 landed in r35361. 22338 2008-07-17 07:03:57 -0700 2008-07-17 09:58:42 -0700 Proposed fix webkit-glib-type-checking-mmacros-bug-20078.patch text/plain 1207 uws+webkit PT09IG1vZGlmaWVkIGZpbGUgJ1dlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmgnCi0tLSBX ZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5oCTIwMDgtMDctMTcgMTI6NTE6MDUgKzAwMDAK KysrIFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmgJMjAwOC0wNy0xNyAxNDowMDoyMiAr MDAwMApAQCAtNjMsMTMgKzYzLDEzIEBACiB0eXBlZGVmIHN0cnVjdCBfR3RrWHRCaW5DbGFzcyBH dGtYdEJpbkNsYXNzOwogCiAjZGVmaW5lIEdUS19UWVBFX1hUQklOICAgICAgICAgICAgICAgICAg KGd0a194dGJpbl9nZXRfdHlwZSAoKSkKLSNkZWZpbmUgR1RLX1hUQklOKG9iaikgICAgICAgICAg ICAgICAgICAoR1RLX0NIRUNLX0NBU1QgKChvYmopLCBcCisjZGVmaW5lIEdUS19YVEJJTihvYmop ICAgICAgICAgICAgICAgICAgKEdfVFlQRV9DSEVDS19JTlNUQU5DRV9DQVNUICgob2JqKSwgXAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVEtfVFlQRV9YVEJJTiwg R3RrWHRCaW4pKQotI2RlZmluZSBHVEtfWFRCSU5fQ0xBU1Moa2xhc3MpICAgICAgICAgIChHVEtf Q0hFQ0tfQ0xBU1NfQ0FTVCAoKGtsYXNzKSwgXAorI2RlZmluZSBHVEtfWFRCSU5fQ0xBU1Moa2xh c3MpICAgICAgICAgIChHX1RZUEVfQ0hFQ0tfQ0xBU1NfQ0FTVCAoKGtsYXNzKSwgXAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVEtfVFlQRV9YVEJJTiwgR3RrWHRC aW5DbGFzcykpCi0jZGVmaW5lIEdUS19JU19YVEJJTihvYmopICAgICAgICAgICAgICAgKEdUS19D SEVDS19UWVBFICgob2JqKSwgXAorI2RlZmluZSBHVEtfSVNfWFRCSU4ob2JqKSAgICAgICAgICAg ICAgIChHX1RZUEVfQ0hFQ0tfSU5TVEFOQ0VfVFlQRSAoKG9iaiksIFwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgR1RLX1RZUEVfWFRCSU4pKQotI2RlZmluZSBHVEtf SVNfWFRCSU5fQ0xBU1Moa2xhc3MpICAgICAgIChHVEtfQ0hFQ0tfQ0xBU1NfVFlQRSAoKGtsYXNz KSwgXAorI2RlZmluZSBHVEtfSVNfWFRCSU5fQ0xBU1Moa2xhc3MpICAgICAgIChHX1RZUEVfQ0hF Q0tfQ0xBU1NfVFlQRSAoKGtsYXNzKSwgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBHVEtfVFlQRV9YVEJJTikpCiB0eXBlZGVmIHN0cnVjdCBfWHRDbGllbnQgWHRD bGllbnQ7CiAKCg==