200778 2019-08-15 12:11:01 -0700 Yellow Lookup highlight gets stuck over Mail messages 2019-08-15 13:21:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1561665 0 thorton 2019-08-15 12:11:01 -0700 Yellow Lookup highlight gets stuck over Mail messages 1561666 1 376404 thorton 2019-08-15 12:11:19 -0700 Created attachment 376404 Patch 1561667 2 thorton 2019-08-15 12:11:22 -0700 <rdar://problem/53868514> 1561673 3 376405 thorton 2019-08-15 12:14:44 -0700 Created attachment 376405 Patch 1561676 4 376406 thorton 2019-08-15 12:16:41 -0700 Created attachment 376406 Patch 1561681 5 376406 wenson_hsieh 2019-08-15 12:19:04 -0700 Comment on attachment 376406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376406&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:9511 > + [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut]; Nit - I don’t think the .get() is necessary here. 1561687 6 wenson_hsieh 2019-08-15 12:22:25 -0700 (In reply to Wenson Hsieh from comment #5) > Comment on attachment 376406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376406&action=review > > > Source/WebKitLegacy/mac/WebView/WebView.mm:9511 > > + [weakSelf.get() _clearTextIndicatorWithAnimation:TextIndicatorWindowDismissalAnimation::FadeOut]; > > Nit - I don’t think the .get() is necessary here. Oops, never mind — I take that back :/ 1561716 7 376406 commit-queue 2019-08-15 13:21:12 -0700 Comment on attachment 376406 Patch Clearing flags on attachment: 376406 Committed r248741: <https://trac.webkit.org/changeset/248741> 1561717 8 commit-queue 2019-08-15 13:21:13 -0700 All reviewed patches have been landed. Closing bug. 376404 2019-08-15 12:11:19 -0700 2019-08-15 12:14:43 -0700 Patch bug-200778-20190815121118.patch text/plain 1652 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggMDJhMWNlN2JhNjhlYmRkMmU3ZmIzYWJmODRjM2RiNjhkNzQ4NWU2ZS4uZWY2NGNkYWVjMGY1 YjRlZWY3MmYxMGExNmFhMThkZGQ5ZThmMzM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTE1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgorCisgICAgICAgIFllbGxvdyBMb29rdXAgaGlnaGxpZ2h0IGdldHMgc3R1 Y2sgb3ZlciBNYWlsIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA3NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzODY4NTE0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmll dy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9zaG93RGljdGlvbmFyeUxvb2t1cFBv cHVwOl0pOgorICAgICAgICBBZGQgYSBkaXNtaXNzYWwgY2FsbGJhY2sgc28gdGhhdCB3aGVuIFJl dmVhbCBoaWRlcyB0aGUgcGFuZWwsIGl0IGFsc28KKyAgICAgICAgZGlzbWlzc2VzIHRoZSB5ZWxs b3cgaW5kaWNhdG9yLiBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yIGluIG1vZGVybiBXZWJLaXQu CisKIDIwMTktMDgtMTQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0ODUyNi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCBiOGQ5NzExZTcwZDc3NDVkN2QzOWIxZjlm NTQxYTE2NTRkNjU5YzgyLi5lMjdiYjBiNWRkMmFmZGExNjU4NDhjNjZlYjNmNjllZjg5MjY1MTNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0K KysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC05NTA2 LDYgKzk1MDYsOCBAQCAtICh2b2lkKV9zaG93RGljdGlvbmFyeUxvb2t1cFBvcHVwOihjb25zdCBE aWN0aW9uYXJ5UG9wdXBJbmZvJilkaWN0aW9uYXJ5UG9wdXBJbgogICAgICAgICBbc2VsZiBfc2V0 VGV4dEluZGljYXRvcjp0ZXh0SW5kaWNhdG9yIHdpdGhMaWZldGltZTpUZXh0SW5kaWNhdG9yV2lu ZG93TGlmZXRpbWU6OlBlcm1hbmVudF07CiAgICAgfSwgW3NlbGZdKEZsb2F0UmVjdCByZWN0SW5S b290Vmlld0Nvb3JkaW5hdGVzKSB7CiAgICAgICAgIHJldHVybiBbc2VsZiBfY29udmVydFJlY3RG cm9tUm9vdFZpZXc6cmVjdEluUm9vdFZpZXdDb29yZGluYXRlc107CisgICAgfSwgW3NlbGZdKCkg eworICAgICAgICBbc2VsZiBfY2xlYXJUZXh0SW5kaWNhdG9yV2l0aEFuaW1hdGlvbjpUZXh0SW5k aWNhdG9yV2luZG93RGlzbWlzc2FsQW5pbWF0aW9uOjpGYWRlT3V0XTsKICAgICB9KTsKIH0KIAo= 376405 2019-08-15 12:14:44 -0700 2019-08-15 12:16:39 -0700 Patch bug-200778-20190815121444.patch text/plain 1936 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggMDJhMWNlN2JhNjhlYmRkMmU3ZmIzYWJmODRjM2RiNjhkNzQ4NWU2ZS4uZWY2NGNkYWVjMGY1 YjRlZWY3MmYxMGExNmFhMThkZGQ5ZThmMzM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTE1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgorCisgICAgICAgIFllbGxvdyBMb29rdXAgaGlnaGxpZ2h0IGdldHMgc3R1 Y2sgb3ZlciBNYWlsIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA3NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzODY4NTE0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmll dy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9zaG93RGljdGlvbmFyeUxvb2t1cFBv cHVwOl0pOgorICAgICAgICBBZGQgYSBkaXNtaXNzYWwgY2FsbGJhY2sgc28gdGhhdCB3aGVuIFJl dmVhbCBoaWRlcyB0aGUgcGFuZWwsIGl0IGFsc28KKyAgICAgICAgZGlzbWlzc2VzIHRoZSB5ZWxs b3cgaW5kaWNhdG9yLiBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yIGluIG1vZGVybiBXZWJLaXQu CisKIDIwMTktMDgtMTQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0ODUyNi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCBiOGQ5NzExZTcwZDc3NDVkN2QzOWIxZjlm NTQxYTE2NTRkNjU5YzgyLi4yN2ZkMDcxNWQyNGU1Y2Y0ZjkwNmFmNjliZWQ5MWU0MmVkOWJiMmVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0K KysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC0yNDYs NiArMjQ2LDcgQEAKICNpbXBvcnQgPHd0Zi9TZXRGb3JTY29wZS5oPgogI2ltcG9ydCA8d3RmL1Nv ZnRMaW5raW5nLmg+CiAjaW1wb3J0IDx3dGYvU3RkTGliRXh0cmFzLmg+CisjaW1wb3J0IDx3dGYv V2Vha09iakNQdHIuaD4KICNpbXBvcnQgPHd0Zi9Xb3JrUXVldWUuaD4KICNpbXBvcnQgPHd0Zi9z cGkvZGFyd2luL2R5bGRTUEkuaD4KIApAQCAtOTUwNiw2ICs5NTA3LDkgQEAgLSAodm9pZClfc2hv d0RpY3Rpb25hcnlMb29rdXBQb3B1cDooY29uc3QgRGljdGlvbmFyeVBvcHVwSW5mbyYpZGljdGlv bmFyeVBvcHVwSW4KICAgICAgICAgW3NlbGYgX3NldFRleHRJbmRpY2F0b3I6dGV4dEluZGljYXRv ciB3aXRoTGlmZXRpbWU6VGV4dEluZGljYXRvcldpbmRvd0xpZmV0aW1lOjpQZXJtYW5lbnRdOwog ICAgIH0sIFtzZWxmXShGbG9hdFJlY3QgcmVjdEluUm9vdFZpZXdDb29yZGluYXRlcykgewogICAg ICAgICByZXR1cm4gW3NlbGYgX2NvbnZlcnRSZWN0RnJvbVJvb3RWaWV3OnJlY3RJblJvb3RWaWV3 Q29vcmRpbmF0ZXNdOworICAgIH0sIFt3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdlYlZpZXc+KHNl bGYpXSgpIHsKKyAgICAgICAgYXV0byBzdHJvbmdTZWxmID0gd2Vha1NlbGYuZ2V0KCk7CisgICAg ICAgIFtzdHJvbmdTZWxmIF9jbGVhclRleHRJbmRpY2F0b3JXaXRoQW5pbWF0aW9uOlRleHRJbmRp Y2F0b3JXaW5kb3dEaXNtaXNzYWxBbmltYXRpb246OkZhZGVPdXRdOwogICAgIH0pOwogfQogCg== 376406 2019-08-15 12:16:41 -0700 2019-08-15 13:21:12 -0700 Patch bug-200778-20190815121640.patch text/plain 1897 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggMDJhMWNlN2JhNjhlYmRkMmU3ZmIzYWJmODRjM2RiNjhkNzQ4NWU2ZS4uZWY2NGNkYWVjMGY1 YjRlZWY3MmYxMGExNmFhMThkZGQ5ZThmMzM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA4LTE1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgorCisgICAgICAgIFllbGxvdyBMb29rdXAgaGlnaGxpZ2h0IGdldHMgc3R1 Y2sgb3ZlciBNYWlsIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA3NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzODY4NTE0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViVmll dy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9zaG93RGljdGlvbmFyeUxvb2t1cFBv cHVwOl0pOgorICAgICAgICBBZGQgYSBkaXNtaXNzYWwgY2FsbGJhY2sgc28gdGhhdCB3aGVuIFJl dmVhbCBoaWRlcyB0aGUgcGFuZWwsIGl0IGFsc28KKyAgICAgICAgZGlzbWlzc2VzIHRoZSB5ZWxs b3cgaW5kaWNhdG9yLiBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yIGluIG1vZGVybiBXZWJLaXQu CisKIDIwMTktMDgtMTQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0ODUyNi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCBiOGQ5NzExZTcwZDc3NDVkN2QzOWIxZjlm NTQxYTE2NTRkNjU5YzgyLi40ODEzZDBiYmNhOTJiNjQyMGQzNDc1NWI3MmU5ZTI0MjFmMTFiZWU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0K KysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC0yNDYs NiArMjQ2LDcgQEAKICNpbXBvcnQgPHd0Zi9TZXRGb3JTY29wZS5oPgogI2ltcG9ydCA8d3RmL1Nv ZnRMaW5raW5nLmg+CiAjaW1wb3J0IDx3dGYvU3RkTGliRXh0cmFzLmg+CisjaW1wb3J0IDx3dGYv V2Vha09iakNQdHIuaD4KICNpbXBvcnQgPHd0Zi9Xb3JrUXVldWUuaD4KICNpbXBvcnQgPHd0Zi9z cGkvZGFyd2luL2R5bGRTUEkuaD4KIApAQCAtOTUwNiw2ICs5NTA3LDggQEAgLSAodm9pZClfc2hv d0RpY3Rpb25hcnlMb29rdXBQb3B1cDooY29uc3QgRGljdGlvbmFyeVBvcHVwSW5mbyYpZGljdGlv bmFyeVBvcHVwSW4KICAgICAgICAgW3NlbGYgX3NldFRleHRJbmRpY2F0b3I6dGV4dEluZGljYXRv ciB3aXRoTGlmZXRpbWU6VGV4dEluZGljYXRvcldpbmRvd0xpZmV0aW1lOjpQZXJtYW5lbnRdOwog ICAgIH0sIFtzZWxmXShGbG9hdFJlY3QgcmVjdEluUm9vdFZpZXdDb29yZGluYXRlcykgewogICAg ICAgICByZXR1cm4gW3NlbGYgX2NvbnZlcnRSZWN0RnJvbVJvb3RWaWV3OnJlY3RJblJvb3RWaWV3 Q29vcmRpbmF0ZXNdOworICAgIH0sIFt3ZWFrU2VsZiA9IFdlYWtPYmpDUHRyPFdlYlZpZXc+KHNl bGYpXSgpIHsKKyAgICAgICAgW3dlYWtTZWxmLmdldCgpIF9jbGVhclRleHRJbmRpY2F0b3JXaXRo QW5pbWF0aW9uOlRleHRJbmRpY2F0b3JXaW5kb3dEaXNtaXNzYWxBbmltYXRpb246OkZhZGVPdXRd OwogICAgIH0pOwogfQogCg==