200774 2019-08-15 10:36:09 -0700 [Cocoa] Adopt -preventDisplaySleepForVideoPlayback 2019-08-19 19:16:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200790 1 jer.noble jer.noble commit-queue darin eric.carlson ews-watchlist webkit-bug-importer oldest_to_newest 1561611 0 jer.noble 2019-08-15 10:36:09 -0700 [Cocoa] Adopt -preventDisplaySleepForVideoPlayback 1561615 1 jer.noble 2019-08-15 10:36:57 -0700 <rdar://problem/54321071> 1561616 2 376391 jer.noble 2019-08-15 10:37:25 -0700 Created attachment 376391 Patch 1561754 3 376391 commit-queue 2019-08-15 14:39:38 -0700 Comment on attachment 376391 Patch Clearing flags on attachment: 376391 Committed r248747: <https://trac.webkit.org/changeset/248747> 1561755 4 commit-queue 2019-08-15 14:39:40 -0700 All reviewed patches have been landed. Closing bug. 1561756 5 376391 darin 2019-08-15 14:44:10 -0700 Comment on attachment 376391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376391&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:70 > +@interface AVSampleBufferDisplayLayer (WebCorePrivate) > +@property (assign, nonatomic) BOOL preventDisplaySleepForVideoPlayback; > +@end I’d like us to make it a habit to put these kinds of things into SPI headers whenever possible. 1561763 6 jer.noble 2019-08-15 14:52:44 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 376391 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376391&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:70 > > +@interface AVSampleBufferDisplayLayer (WebCorePrivate) > > +@property (assign, nonatomic) BOOL preventDisplaySleepForVideoPlayback; > > +@end > > I’d like us to make it a habit to put these kinds of things into SPI headers > whenever possible. Understood. The SPI declarations for AVSampleBufferDisplayLayer in AVFoundationSPI.h are ... complicated, and I was trying to make the simplest patch possible to avoid any merge problems. 1561767 7 darin 2019-08-15 14:57:33 -0700 (In reply to Jer Noble from comment #6) > Understood. The SPI declarations for AVSampleBufferDisplayLayer in > AVFoundationSPI.h are ... complicated, and I was trying to make the simplest > patch possible to avoid any merge problems. Fine with me for the short term. Not the right thing for the longer term, I think. 1561778 8 jer.noble 2019-08-15 15:10:34 -0700 (In reply to Darin Adler from comment #7) > Fine with me for the short term. Not the right thing for the longer term, I > think. Filed bug# 200790 to track cleaning this all up. 1562862 9 jer.noble 2019-08-19 17:37:40 -0700 Darin was correct, I was wrong, and because I tried to do the most expedient fix instead of the most correct fix, a misspelling ("preventDisplaySleep" vs. "prevent_s_DisplaySleep") got into the build, negating the benefit of this patch. Fixing. 1562865 10 jer.noble 2019-08-19 17:39:10 -0700 Reopening to attach new patch. 1562866 11 376725 jer.noble 2019-08-19 17:39:11 -0700 Created attachment 376725 Patch 1562867 12 ews-watchlist 2019-08-19 17:41:10 -0700 Attachment 376725 did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h:310: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1562895 13 376725 commit-queue 2019-08-19 19:16:49 -0700 Comment on attachment 376725 Patch Clearing flags on attachment: 376725 Committed r248886: <https://trac.webkit.org/changeset/248886> 1562896 14 commit-queue 2019-08-19 19:16:50 -0700 All reviewed patches have been landed. Closing bug. 376391 2019-08-15 10:37:25 -0700 2019-08-19 17:39:09 -0700 Patch bug-200774-20190815103724.patch text/plain 2011 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI1YjJiM2U0NDQ3YjJh MTIyZDE1NTYzZDhlMzI5MjA3NGRhM2VlNi4uZjZhZGQwYTFhZTZlZGI1Nzg1M2U2MWJmYWYyZmE2 MmJiY2FmZGIyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTE1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gQWRvcHQgLXBy ZXZlbnREaXNwbGF5U2xlZXBGb3JWaWRlb1BsYXliYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbToKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQzo6ZW5zdXJlTGF5 ZXIpOgorCiAyMDE5LTA4LTA4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIEltcGxlbWVudCB0aGUgUmVtb3RlIFBsYXliYWNrIEFQSS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNl QVZGT2JqQy5tbQppbmRleCBmMTk1MTU2ZDhjZjIyNTZmNjBmOWY1NTMyNDEyOWU4NTIzZDlkMzhi Li43MmQxYWYxN2U5NzcwYzIyODdmN2Y1Y2NlOWM4NzZlMzM5ODNiNTIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBs YXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFT b3VyY2VBVkZPYmpDLm1tCkBAIC02NSw2ICs2NSwxMCBAQCBAaW50ZXJmYWNlIEFWU3RyZWFtU2Vz c2lvbiA6IE5TT2JqZWN0CiAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhTdG9yYWdlRGlyZWN0b3J5 QXRVUkw6KE5TVVJMICopc3RvcmFnZURpcmVjdG9yeTsKIEBlbmQKIAorQGludGVyZmFjZSBBVlNh bXBsZUJ1ZmZlckRpc3BsYXlMYXllciAoV2ViQ29yZVByaXZhdGUpCitAcHJvcGVydHkgKGFzc2ln biwgbm9uYXRvbWljKSBCT09MIHByZXZlbnREaXNwbGF5U2xlZXBGb3JWaWRlb1BsYXliYWNrOwor QGVuZAorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1lc3BhY2UgUEFMOwogCkBAIC03 NTgsNiArNzYyLDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFWRk9iakM6 OmVuc3VyZUxheWVyKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChbbV9zYW1w bGVCdWZmZXJEaXNwbGF5TGF5ZXIgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzZXRQcmV2 ZW50RGlzcGxheVNsZWVwRm9yVmlkZW9QbGF5YmFjazopXSkKKyAgICAgICAgbV9zYW1wbGVCdWZm ZXJEaXNwbGF5TGF5ZXIuZ2V0KCkucHJldmVudERpc3BsYXlTbGVlcEZvclZpZGVvUGxheWJhY2sg PSBOTzsKKwogICAgIFttX3N5bmNocm9uaXplciBhZGRSZW5kZXJlcjptX3NhbXBsZUJ1ZmZlckRp c3BsYXlMYXllci5nZXQoKV07CiAgICAgaWYgKG1fbWVkaWFTb3VyY2VQcml2YXRlKQogICAgICAg ICBtX21lZGlhU291cmNlUHJpdmF0ZS0+c2V0VmlkZW9MYXllcihtX3NhbXBsZUJ1ZmZlckRpc3Bs YXlMYXllci5nZXQoKSk7Cg== 376725 2019-08-19 17:39:11 -0700 2019-08-19 19:16:49 -0700 Patch bug-200774-20190819173910.patch text/plain 3850 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZhZGQwYTFhZTZlZGI1 Nzg1M2U2MWJmYWYyZmE2MmJiY2FmZGIyOS4uMmMzZjIwNDAwM2E4ZTJhZjIxODRkODM4MDBhOGQw NDQ2NjBlYWNiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTE5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gRml4IG1pc3Nw ZWxsaW5nIG9mIC1wcmV2ZW50c0Rpc3BsYXlTbGVlcEZvclZpZGVvUGxheWJhY2sKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc3NAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTQzMjEwNzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT25seSBkZWNsYXJlIHRoZSBBUEkgb24gcGxhdGZvcm1zIHdoZXJl IHRoYXQgQVBJIGlzIHVuZGVmaW5lZCwgc28gYXMKKyAgICAgICAgdG8gY2F0Y2ggdGhpcyBraW5k IG9mIG1pc3NwZWxsaW5nIGF0IGNvbXBpbGUgdGltZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZG T2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNl QVZGT2JqQzo6ZW5zdXJlTGF5ZXIpOgorCiAyMDE5LTA4LTE1ICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gQWRvcHQgLXByZXZlbnREaXNwbGF5U2xl ZXBGb3JWaWRlb1BsYXliYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAwZTFiZmU3MzU0MTQyNGMw ZDE5ZGI5MThjNDUyZmUwNWY5ZTY3NWFmLi44MzIyYmYwOWY5MmJiM2JjYjU2ZTIwOGRmM2Q2ZmY5 MDUwOWIwMWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wOC0x OSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEFk b3B0IC1wcmV2ZW50RGlzcGxheVNsZWVwRm9yVmlkZW9QbGF5YmFjaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzc0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81NDMyMTA3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHBhbC9zcGkvbWFjL0FWRm91bmRhdGlvblNQSS5oOgorCiAyMDE5LTA4LTA5 ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFRhcHBp bmcgYnV0dG9ucyBpbiBEYXRhIERldGVjdG9ycyBsb29rdXAgcHJldmlld3MgZG9lc24ndCB3b3Jr CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvQVZGb3VuZGF0aW9u U1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvQVZGb3VuZGF0aW9uU1BJLmgK aW5kZXggOWY5MWJkNWFjODY4Y2U3Y2M4YTIxOGE2ODc1MWEyMGRkZmVkYzg4Ni4uZmZmMWJlOTEz MzUyZTY0NzRlZjVlOTAwODkwMjNkYzM3MWI5MTY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvUEFML3BhbC9zcGkvbWFjL0FWRm91bmRhdGlvblNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvc3BpL21hYy9BVkZvdW5kYXRpb25TUEkuaApAQCAtMzE3LDYgKzMxNywxMiBAQCBO U19BU1NVTUVfTk9OTlVMTF9FTkQKIEBlbmQKICNlbmRpZgogCisjaWYgIVVTRShBUFBMRV9JTlRF Uk5BTF9TREspIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxM T1dFRCA8IDEwMTUwMCkgfHwgKFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUFYX0FMTE9XRUQgPCAxMzAwMDApCitAaW50ZXJmYWNlIEFWU2FtcGxlQnVmZmVyRGlz cGxheUxheWVyIChXZWJDb3JlUHJpdmF0ZSkKK0Bwcm9wZXJ0eSAoYXNzaWduLCBub25hdG9taWMp IEJPT0wgcHJldmVudHNEaXNwbGF5U2xlZXBEdXJpbmdWaWRlb1BsYXliYWNrOworQGVuZAorI2Vu ZGlmCisKICNpZiAhVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgUExBVEZPUk0oSU9TX0ZBTUlM WSkgJiYgIVBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9SKSAmJiAhUExBVEZPUk0oTUFDQ0FU QUxZU1QpCiAjaW1wb3J0IDxBVkZvdW5kYXRpb24vQVZBdWRpb1Nlc3Npb24uaD4KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMv TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFTb3VyY2VBVkZPYmpDLm1tCmluZGV4IDcyZDFhZjE3ZTk3NzBjMjI4N2Y3ZjVjY2U5Yzg3NmUz Mzk4M2I1MjIuLjgyOGJiMmM1YWM2MDU4NTQ1YmU1YjQ1Y2M5YjQxM2ZmNzAyMWZjOTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVNZWRpYVNvdXJjZUFWRk9iakMubW0KQEAgLTY1LDEwICs2NSw2IEBAIEBpbnRlcmZhY2UgQVZT dHJlYW1TZXNzaW9uIDogTlNPYmplY3QKIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aFN0b3JhZ2VE aXJlY3RvcnlBdFVSTDooTlNVUkwgKilzdG9yYWdlRGlyZWN0b3J5OwogQGVuZAogCi1AaW50ZXJm YWNlIEFWU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIChXZWJDb3JlUHJpdmF0ZSkKLUBwcm9wZXJ0 eSAoYXNzaWduLCBub25hdG9taWMpIEJPT0wgcHJldmVudERpc3BsYXlTbGVlcEZvclZpZGVvUGxh eWJhY2s7Ci1AZW5kCi0KIG5hbWVzcGFjZSBXZWJDb3JlIHsKIHVzaW5nIG5hbWVzcGFjZSBQQUw7 CiAKQEAgLTc2Miw4ICs3NTgsOCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNl QVZGT2JqQzo6ZW5zdXJlTGF5ZXIoKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYg KFttX3NhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KHNldFByZXZlbnREaXNwbGF5U2xlZXBGb3JWaWRlb1BsYXliYWNrOildKQotICAgICAgICBtX3Nh bXBsZUJ1ZmZlckRpc3BsYXlMYXllci5nZXQoKS5wcmV2ZW50RGlzcGxheVNsZWVwRm9yVmlkZW9Q bGF5YmFjayA9IE5POworICAgIGlmIChbbV9zYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIgcmVzcG9u ZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzZXRQcmV2ZW50c0Rpc3BsYXlTbGVlcER1cmluZ1ZpZGVv UGxheWJhY2s6KV0pCisgICAgICAgIG1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLmdldCgpLnBy ZXZlbnRzRGlzcGxheVNsZWVwRHVyaW5nVmlkZW9QbGF5YmFjayA9IE5POwogCiAgICAgW21fc3lu Y2hyb25pemVyIGFkZFJlbmRlcmVyOm1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLmdldCgpXTsK ICAgICBpZiAobV9tZWRpYVNvdXJjZVByaXZhdGUpCg==