200762 2019-08-14 23:47:27 -0700 More missing exception checks in String.prototype. 2019-08-15 09:31:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1561493 0 mark.lam 2019-08-14 23:47:27 -0700 <rdar://problem/54333896> 1561495 1 376364 mark.lam 2019-08-14 23:53:09 -0700 Created attachment 376364 proposed patch. 1561550 2 376364 msaboff 2019-08-15 08:25:40 -0700 Comment on attachment 376364 proposed patch. r=me 1561551 3 mark.lam 2019-08-15 08:27:28 -0700 Thanks for the review. 1561575 4 376364 commit-queue 2019-08-15 09:31:26 -0700 Comment on attachment 376364 proposed patch. Clearing flags on attachment: 376364 Committed r248716: <https://trac.webkit.org/changeset/248716> 1561576 5 commit-queue 2019-08-15 09:31:27 -0700 All reviewed patches have been landed. Closing bug. 376364 2019-08-14 23:53:09 -0700 2019-08-15 09:31:26 -0700 proposed patch. bug-200762.patch text/plain 5729 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDg3MTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBNb3JlIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrcyBpbiBTdHJpbmcucHJv dG90eXBlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAwNzYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDMzMzg5Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9taXNzaW5nLWV4Y2Vw dGlvbi1jaGVjay1pbi1zdHJpbmctbGFzdEluZGV4T2YuanM6IEFkZGVkLgorICAgICAgICAqIHN0 cmVzcy9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1pbi1zdHJpbmctdG9Mb3dlci5qczogQWRkZWQu CisgICAgICAgICogc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy10b1Vw cGVyLmpzOiBBZGRlZC4KKwogMjAxOS0wOC0xNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5j b20+CiAKICAgICAgICAgUHJveHlPYmplY3Qgc2hvdWxkIG5vdCBiZSBhbGxvdyB0byBhY2Nlc3Mg aXRzIHRhcmdldCdzIHByaXZhdGUgcHJvcGVydGllcy4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL21p c3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy1sYXN0SW5kZXhPZi5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL3N0cmVzcy9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1pbi1zdHJpbmctbGFz dEluZGV4T2YuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNl cHRpb24tY2hlY2staW4tc3RyaW5nLWxhc3RJbmRleE9mLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsOSBAQAorY29uc3QgczEgPSAoLTEpLnRvTG9jYWxlU3RyaW5nKCkucGFkRW5kKDIqKjMx LTEsICdhYScpOwordHJ5IHsKKyAgICBzMS5sYXN0SW5kZXhPZigpOworfSBjYXRjaCAoZSkgewor ICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK2lmIChleGNlcHRpb24gIT0gIkVycm9yOiBPdXQgb2Yg bWVtb3J5IikKKyAgICB0aHJvdyAiRkFJTEVEIjsKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL21pc3Np bmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy10b0xvd2VyLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpT VGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy10b0xvd2VyLmpz CShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNr LWluLXN0cmluZy10b0xvd2VyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBAQAorY29u c3QgczEgPSAoLTEpLnRvTG9jYWxlU3RyaW5nKCkucGFkRW5kKDIqKjMxLTEsICdhYScpOwordHJ5 IHsKKyAgICBzMS50b0xvd2VyQ2FzZSgpOworfSBjYXRjaCAoZSkgeworICAgIGV4Y2VwdGlvbiA9 IGU7Cit9CisKK2lmIChleGNlcHRpb24gIT0gIkVycm9yOiBPdXQgb2YgbWVtb3J5IikKKyAgICB0 aHJvdyAiRkFJTEVEIjsKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNo ZWNrLWluLXN0cmluZy10b1VwcGVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL21p c3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy10b1VwcGVyLmpzCShub25leGlzdGVudCkK KysrIEpTVGVzdHMvc3RyZXNzL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWluLXN0cmluZy10b1Vw cGVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBAQAorY29uc3QgczEgPSAoLTEpLnRv TG9jYWxlU3RyaW5nKCkucGFkRW5kKDIqKjMxLTEsICdhYScpOwordHJ5IHsKKyAgICBzMS50b1Vw cGVyQ2FzZSgpOworfSBjYXRjaCAoZSkgeworICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK2lmIChl eGNlcHRpb24gIT0gIkVycm9yOiBPdXQgb2YgbWVtb3J5IikKKyAgICB0aHJvdyAiRkFJTEVEIjsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ4NzA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTA4LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN b3JlIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrcyBpbiBTdHJpbmcucHJvdG90eXBlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzYyCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81NDMzMzg5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAg ICAgKEpTQzo6cmVwbGFjZVVzaW5nUmVnRXhwU2VhcmNoKToKKyAgICAgICAgKEpTQzo6b3BlcmF0 aW9uU3RyaW5nUHJvdG9GdW5jUmVwbGFjZVJlZ0V4cFN0cmluZyk6CisgICAgICAgIChKU0M6OnN0 cmluZ1Byb3RvRnVuY0xhc3RJbmRleE9mKToKKyAgICAgICAgKEpTQzo6c3RyaW5nUHJvdG9GdW5j VG9Mb3dlckNhc2UpOgorICAgICAgICAoSlNDOjpzdHJpbmdQcm90b0Z1bmNUb1VwcGVyQ2FzZSk6 CisKIDIwMTktMDgtMTQgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBzdXBwb3J0IGZvciBtYWNPUyA8IDEwLjEzCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHJldmlzaW9uIDI0 ODcwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUyOSw2ICs1MjksNyBAQCBzdGF0aWMgQUxXQVlTX0lOTElO RSBKU1N0cmluZyogcmVwbGFjZVVzCiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NP UEUodm0pOwogCiAgICAgU3RyaW5nIHNvdXJjZSA9IHN0cmluZy0+dmFsdWUoZXhlYyk7CisgICAg UkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgbnVsbHB0cik7CiAgICAgdW5zaWduZWQgc291cmNl TGVuID0gc291cmNlLmxlbmd0aCgpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIG51 bGxwdHIpOwogICAgIFJlZ0V4cE9iamVjdCogcmVnRXhwT2JqZWN0ID0ganNDYXN0PFJlZ0V4cE9i amVjdCo+KHNlYXJjaFZhbHVlKTsKQEAgLTc1NCwxMSArNzU1LDEzIEBAIEpTQ2VsbCogSklUX09Q RVJBVElPTiBvcGVyYXRpb25TdHJpbmdQcm8KIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwog ICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNlciB0cmFjZXIoJnZtLCBleGVjKTsKLSAgICAKKyAgICBh dXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CisKICAgICBDYWxsRGF0YSBjYWxs RGF0YTsKICAgICBTdHJpbmcgcmVwbGFjZW1lbnRTdHJpbmcgPSByZXBsYWNlU3RyaW5nLT52YWx1 ZShleGVjKTsKLSAgICByZXR1cm4gcmVwbGFjZVVzaW5nUmVnRXhwU2VhcmNoKAotICAgICAgICB2 bSwgZXhlYywgdGhpc1ZhbHVlLCBzZWFyY2hWYWx1ZSwgY2FsbERhdGEsIENhbGxUeXBlOjpOb25l LCByZXBsYWNlbWVudFN0cmluZywgcmVwbGFjZVN0cmluZyk7CisgICAgUkVUVVJOX0lGX0VYQ0VQ VElPTihzY29wZSwgbnVsbHB0cik7CisgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCByZXBs YWNlVXNpbmdSZWdFeHBTZWFyY2goCisgICAgICAgIHZtLCBleGVjLCB0aGlzVmFsdWUsIHNlYXJj aFZhbHVlLCBjYWxsRGF0YSwgQ2FsbFR5cGU6Ok5vbmUsIHJlcGxhY2VtZW50U3RyaW5nLCByZXBs YWNlU3RyaW5nKSk7CiB9CiAKIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEpTU3RyaW5nKiByZXBsYWNl VXNpbmdSZWdFeHBTZWFyY2goVk0mIHZtLCBFeGVjU3RhdGUqIGV4ZWMsIEpTU3RyaW5nKiBzdHJp bmcsIEpTVmFsdWUgc2VhcmNoVmFsdWUsIEpTVmFsdWUgcmVwbGFjZVZhbHVlKQpAQCAtMTEyNSw3 ICsxMTI4LDkgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBzdHJpbmdQcm90bwogICAg ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKC0xKSk7CiAKICAgICBTdHJpbmcg dGhpc1N0cmluZyA9IHRoaXNKU1N0cmluZy0+dmFsdWUoZXhlYyk7CisgICAgUkVUVVJOX0lGX0VY Q0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgU3RyaW5nIG90aGVyU3RyaW5n ID0gb3RoZXJKU1N0cmluZy0+dmFsdWUoZXhlYyk7CisgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihz Y29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgc2l6ZV90IHJlc3VsdDsKICAgICBpZiAoIXN0 YXJ0UG9zaXRpb24pCiAgICAgICAgIHJlc3VsdCA9IHRoaXNTdHJpbmcuc3RhcnRzV2l0aChvdGhl clN0cmluZykgPyAwIDogbm90Rm91bmQ7CkBAIC0xNDQ2LDYgKzE0NTEsNyBAQCBFbmNvZGVkSlNW YWx1ZSBKU0NfSE9TVF9DQUxMIHN0cmluZ1Byb3RvCiAgICAgSlNTdHJpbmcqIHNWYWwgPSB0aGlz VmFsdWUudG9TdHJpbmcoZXhlYyk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5j b2RlZEpTVmFsdWUoKSk7CiAgICAgU3RyaW5nIHMgPSBzVmFsLT52YWx1ZShleGVjKTsKKyAgICBS RVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgpKTsKICAgICBTdHJpbmcg bG93ZXJjYXNlZFN0cmluZyA9IHMuY29udmVydFRvTG93ZXJjYXNlV2l0aG91dExvY2FsZSgpOwog ICAgIGlmIChsb3dlcmNhc2VkU3RyaW5nLmltcGwoKSA9PSBzLmltcGwoKSkKICAgICAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZShzVmFsKTsKQEAgLTE0NjMsNiArMTQ2OSw3IEBAIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG8KICAgICBKU1N0cmluZyogc1ZhbCA9IHRo aXNWYWx1ZS50b1N0cmluZyhleGVjKTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBl bmNvZGVkSlNWYWx1ZSgpKTsKICAgICBTdHJpbmcgcyA9IHNWYWwtPnZhbHVlKGV4ZWMpOworICAg IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgIFN0cmlu ZyB1cHBlcmNhc2VkU3RyaW5nID0gcy5jb252ZXJ0VG9VcHBlcmNhc2VXaXRob3V0TG9jYWxlKCk7 CiAgICAgaWYgKHVwcGVyY2FzZWRTdHJpbmcuaW1wbCgpID09IHMuaW1wbCgpKQogICAgICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHNWYWwpOwo=