200761 2019-08-14 23:44:06 -0700 Web Inspector: Sources: enable by default 2019-10-07 16:41:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED DUPLICATE 202341 P2 Normal --- 1 hi hi hi inspector-bugzilla-changes joepeck timothy oldest_to_newest 1561492 0 hi 2019-08-14 23:44:06 -0700 I think that the Sources tab has reached a point where it's ready to be on-by-default. 1561494 1 376363 hi 2019-08-14 23:51:02 -0700 Created attachment 376363 Patch 1561970 2 376363 joepeck 2019-08-16 01:04:32 -0700 Comment on attachment 376363 Patch I suggest holding off on this a bit. Lets revisit this in a month. I want to live on the Sources tab a bit more myself to ensure it feels good and to catch any possible issues. I suggest that others live on it and provide feedback here if they think something aught be addressed before it is enabled by default. I've only been living on it for about a week and have some thoughts. --- I want to replace the default sources scope bar control to toggle between `Group by Path` / `Group by Type`. The current scope bar is a Resource Type filter, which should be with the other filters at the bottom. Burying the grouping toggles in the gear menu likely means they won't get noticed or used. The existing filter buttons / controls don't make sense anymore. We should revamp that to make sense, especially in light of recent controls being added (bug 200425) in poor places because of the existing filter controls. I want new icons, or at least an icon for origins in the "Group by Path" view (bug 200683). In "Group by Path" I've had cases where deep nested folders gave a poor experience. That may just be a follow-up bug. Finally, we have a few features in the pipeline (Bootstrap, Blackboxing) that are about to land. We should land those first and ensure they are at the quality bar we want before enabling the tab by default. 1577566 3 hi 2019-10-07 16:41:12 -0700 *** This bug has been marked as a duplicate of bug 202341 *** 376363 2019-08-14 23:51:02 -0700 2019-08-16 01:04:32 -0700 Patch bug-200761-20190814235101.patch text/plain 4642 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ2MTZiMDMxMDk0NjgwOGQ2YzRhYTYxMzgyNjhj OWVjOTUzMjkyNWUuLmYzMWZmMzM0YTM4MGM5NTMzNDA4NjBjMDJlMTJhMTc4ZjZjMjlkNWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA4LTE0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT b3VyY2VzOiBlbmFibGUgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qczoKKyAgICAg ICAgTWFrZSB0aGUgZGVmYXVsdCB2YWx1ZSBvZiB0aGUgYGV4cGVyaW1lbnRhbEVuYWJsZVNvdXJj ZXNUYWJgIHNldHRpbmcgYHRydWVgLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01h aW4uanM6CisgICAgICAgIChXSS5sb2FkZWQpOgorICAgICAgICBBZGQgdGhlIFNvdXJjZXMgdGFi IHRvIHRoZSBsaXN0IG9mIGRlZmF1bHQgdGFicy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlNldHRpbmdzVGFi Q29udGVudFZpZXcucHJvdG90eXBlLl9jcmVhdGVTb3VyY2VzU2V0dGluZ3NWaWV3KToKKyAgICAg ICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisgICAgICAg IERyaXZlLWJ5OiByZW5hbWUgdGhlICJEZWJ1Z2dlciIgZ3JvdXAgdG8gIkRlYnVnZ2luZyIgdG8g YmUgbGVzcyBjb25mdXNpbmcgd2l0aCB0aGUgdGFiIG5hbWUuCisKIDIwMTktMDgtMTQgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVs ZW1lbnRzOiBDb21wdXRlZDogbW92ZSB0aGUgQm94IE1vZGVsIHNlY3Rpb24gdG8gdGhlIHRvcApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25z L2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggNDQ4MzIzNzFmOTIyMDJhZTM3ZDY3 MzY4ZTIzOTdiNmMzMmJmZmMxZi4uNGE1OTIwMzQ4MGI2NTgyYTZiNDY5NDBiNzg0YWNiODAyNjMw N2QxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4u bHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9j YWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC0zMjYsNyArMzI2LDcg QEAgbG9jYWxpemVkU3RyaW5nc1siRGVidWdnZXIgUGF1c2VkIl0gPSAiRGVidWdnZXIgUGF1c2Vk IjsKIGxvY2FsaXplZFN0cmluZ3NbIkRlYnVnZ2VyIFN0YXRlbWVudCJdID0gIkRlYnVnZ2VyIFN0 YXRlbWVudCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJEZWJ1Z2dlciBkaXNhYmxlZCBkdXJpbmcgQXVk aXQiXSA9ICJEZWJ1Z2dlciBkaXNhYmxlZCBkdXJpbmcgQXVkaXQiOwogbG9jYWxpemVkU3RyaW5n c1siRGVidWdnZXIgZGlzYWJsZWQgZHVyaW5nIFRpbWVsaW5lIHJlY29yZGluZyJdID0gIkRlYnVn Z2VyIGRpc2FibGVkIGR1cmluZyBUaW1lbGluZSByZWNvcmRpbmciOwotbG9jYWxpemVkU3RyaW5n c1siRGVidWdnZXI6Il0gPSAiRGVidWdnZXI6IjsKK2xvY2FsaXplZFN0cmluZ3NbIkRlYnVnZ2lu ZzoiXSA9ICJEZWJ1Z2dpbmc6IjsKIGxvY2FsaXplZFN0cmluZ3NbIkRlYnVncyJdID0gIkRlYnVn cyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJEZWNvZGVkIl0gPSAiRGVjb2RlZCI7CiBsb2NhbGl6ZWRT dHJpbmdzWyJEZWZhdWx0Il0gPSAiRGVmYXVsdCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMDNkY2IxNTRiZTBjYzgyMmRmMDQ2 NDEzOWMwNGRhZGQwMTQ3OTZlNy4uN2Q3YTQ5OGMxN2I3NzhlYWI0NDNjYTEyNjczODY2NWE2OTA0 MDFiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv TWFpbi5qcwpAQCAtMTQzLDYgKzE0Myw3IEBAIFdJLmxvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICBX SS5fb3BlblRhYnNTZXR0aW5nID0gbmV3IFdJLlNldHRpbmcoIm9wZW4tdGFiLXR5cGVzIiwgWwog ICAgICAgICBXSS5FbGVtZW50c1RhYkNvbnRlbnRWaWV3LlR5cGUsCiAgICAgICAgIFdJLk5ldHdv cmtUYWJDb250ZW50Vmlldy5UeXBlLAorICAgICAgICBXSS5Tb3VyY2VzVGFiQ29udGVudFZpZXcu VHlwZSwKICAgICAgICAgV0kuRGVidWdnZXJUYWJDb250ZW50Vmlldy5UeXBlLAogICAgICAgICBX SS5SZXNvdXJjZXNUYWJDb250ZW50Vmlldy5UeXBlLAogICAgICAgICBXSS5UaW1lbGluZVRhYkNv bnRlbnRWaWV3LlR5cGUsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9CYXNlL1NldHRpbmcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL1NldHRpbmcuanMKaW5kZXggOTk5MDZlMTc2MGUyODc2N2M0ZmU3YmU5MDBiNmRm NmUzNTY2N2RlZi4uODcyMDNhNTgzYWYwYjVjNmYyYzMzZWRlNWZjNDUxZWIxOGQ2YWY4NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5n LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGlu Zy5qcwpAQCAtMTgzLDcgKzE4Myw3IEBAIFdJLnNldHRpbmdzID0gewogICAgIC8vIEV4cGVyaW1l bnRhbAogICAgIGV4cGVyaW1lbnRhbEVuYWJsZUxheWVyc1RhYjogbmV3IFdJLlNldHRpbmcoImV4 cGVyaW1lbnRhbC1lbmFibGUtbGF5ZXJzLXRhYiIsIGZhbHNlKSwKICAgICBleHBlcmltZW50YWxF bmFibGVOZXdUYWJCYXI6IG5ldyBXSS5TZXR0aW5nKCJleHBlcmltZW50YWwtZW5hYmxlLW5ldy10 YWItYmFyIiwgZmFsc2UpLAotICAgIGV4cGVyaW1lbnRhbEVuYWJsZVNvdXJjZXNUYWI6IG5ldyBX SS5TZXR0aW5nKCJleHBlcmltZW50YWwtZW5hYmxlLXNvdXJjZXMtdGFiIiwgZmFsc2UpLAorICAg IGV4cGVyaW1lbnRhbEVuYWJsZVNvdXJjZXNUYWI6IG5ldyBXSS5TZXR0aW5nKCJleHBlcmltZW50 YWwtZW5hYmxlLXNvdXJjZXMtdGFiIiwgdHJ1ZSksCiAgICAgZXhwZXJpbWVudGFsRW5hYmxlU3R5 bGVzSWNvbnM6IG5ldyBXSS5TZXR0aW5nKCJleHBlcmltZW50YWwtc3R5bGVzLWljb25zIiwgZmFs c2UpLAogICAgIGV4cGVyaW1lbnRhbEVuYWJsZVN0eWxlc0p1bXBUb0VmZmVjdGl2ZTogbmV3IFdJ LlNldHRpbmcoImV4cGVyaW1lbnRhbC1zdHlsZXMtanVtcC10by1lZmZlY3RpdmUiLCBmYWxzZSks CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCmluZGV4IGY5OGUzNGJiZDhk M2M0MDJhZjFlNDg2OGMxMWExYjNlMjQ3ZWI5OTcuLjQ4YWFkNDZmMmQ4Y2YxZDk3OTQyZTIxZGQy NTlhY2ZkNmZjOTM3MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcwpA QCAtMjUwLDcgKzI1MCw3IEBAIFdJLlNldHRpbmdzVGFiQ29udGVudFZpZXcgPSBjbGFzcyBTZXR0 aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuVGFiQ29udGVudFZpCiAgICAgewogICAgICAg ICBsZXQgc291cmNlc1NldHRpbmdzVmlldyA9IG5ldyBXSS5TZXR0aW5nc1ZpZXcoInNvdXJjZXMi LCBXSS5VSVN0cmluZygiU291cmNlcyIpKTsKIAotICAgICAgICBzb3VyY2VzU2V0dGluZ3NWaWV3 LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkRlYnVnZ2VyOiIpLCBXSS5zZXR0aW5ncy5zaG93U2Nv cGVDaGFpbk9uUGF1c2UsIFdJLlVJU3RyaW5nKCJTaG93IFNjb3BlIENoYWluIG9uIHBhdXNlIikp OworICAgICAgICBzb3VyY2VzU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkRl YnVnZ2luZzoiKSwgV0kuc2V0dGluZ3Muc2hvd1Njb3BlQ2hhaW5PblBhdXNlLCBXSS5VSVN0cmlu ZygiU2hvdyBTY29wZSBDaGFpbiBvbiBwYXVzZSIpKTsKIAogICAgICAgICBzb3VyY2VzU2V0dGlu Z3NWaWV3LmFkZFNlcGFyYXRvcigpOwogCg==