200758 2019-08-14 22:28:49 -0700 for-await-of has bad error message if used in non-async function 2019-08-15 01:41:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue ews-watchlist joepeck keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1561466 0 joepeck 2019-08-14 22:28:49 -0700 for-await-of has bad error message if used in non-async function ---- >>> function f() { for await (let x of []) {} } } for-await-of can't be used only in async function or async generator..:1 ---- It should say that it can only be used an async function or async generator. 1561467 1 376354 joepeck 2019-08-14 22:30:14 -0700 Created attachment 376354 [PATCH] Proposed Fix 1561468 2 376355 joepeck 2019-08-14 22:32:25 -0700 Created attachment 376355 [PATCH] Proposed Fix 1561471 3 376355 ross.kirsling 2019-08-14 22:46:34 -0700 Comment on attachment 376355 [PATCH] Proposed Fix Looks good as long as no tests are counting on this output. 1561508 4 376355 commit-queue 2019-08-15 01:40:12 -0700 Comment on attachment 376355 [PATCH] Proposed Fix Clearing flags on attachment: 376355 Committed r248711: <https://trac.webkit.org/changeset/248711> 1561509 5 commit-queue 2019-08-15 01:40:13 -0700 All reviewed patches have been landed. Closing bug. 1561510 6 webkit-bug-importer 2019-08-15 01:41:16 -0700 <rdar://problem/54337496> 376354 2019-08-14 22:30:14 -0700 2019-08-14 22:32:25 -0700 [PATCH] Proposed Fix t-1.patch text/plain 1378 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQyMjFjZmMyYTI1Li44YjU0YTkwMGQzMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBmb3ItYXdhaXQtb2Yg aGFzIGJhZCBlcnJvciBtZXNzYWdlIGlmIHVzZWQgaW4gbm9uLWFzeW5jIGZ1bmN0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3NTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9QYXJz ZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VGb3JTdGF0ZW1l bnQpOgorICAgICAgICBJbXByb3ZlIGVycm9yIG1lc3NhZ2UuCisKIDIwMTktMDgtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0NvbnRleHQgSW5z cGVjdG9yOiBCYXNpYyBDb21tYW5kTGluZUFQSSBkb2Vzbid0IHdvcmsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCBmOGRiZTcxOTZmMS4uMTgwMzI3MThmMjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTEzMjMsNyArMTMyMyw3 IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZVN0YXRlbWVudCBQYXJzZXI8TGV4 ZXJUeXBlPjo6cGFyc2VGb3JTdGF0ZW1lbnQoCiAgICAgbV9zdGF0ZW1lbnREZXB0aCsrOwogCiAg ICAgaWYgKG1hdGNoKEFXQUlUKSkgewotICAgICAgICBzZW1hbnRpY0ZhaWxJZkZhbHNlKGN1cnJl bnRTY29wZSgpLT5pc0FzeW5jRnVuY3Rpb24oKSwgImZvci1hd2FpdC1vZiBjYW4ndCBiZSB1c2Vk IG9ubHkgaW4gYXN5bmMgZnVuY3Rpb24gb3IgYXN5bmMgZ2VuZXJhdG9yLiIpOworICAgICAgICBz ZW1hbnRpY0ZhaWxJZkZhbHNlKGN1cnJlbnRTY29wZSgpLT5pc0FzeW5jRnVuY3Rpb24oKSwgImZv ci1hd2FpdC1vZiBjYW4gb25seSBiZSB1c2VkIGluIGFuIGFzeW5jIGZ1bmN0aW9uIG9yIGFzeW5j IGdlbmVyYXRvci4iKTsKICAgICAgICAgaXNBd2FpdEZvciA9IHRydWU7CiAgICAgICAgIG5leHQo KTsKICAgICB9Cg== 376355 2019-08-14 22:32:25 -0700 2019-08-15 01:40:12 -0700 [PATCH] Proposed Fix t-2.patch text/plain 1377 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQyMjFjZmMyYTI1Li44YjU0YTkwMGQzMSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBmb3ItYXdhaXQtb2Yg aGFzIGJhZCBlcnJvciBtZXNzYWdlIGlmIHVzZWQgaW4gbm9uLWFzeW5jIGZ1bmN0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3NTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9QYXJz ZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VGb3JTdGF0ZW1l bnQpOgorICAgICAgICBJbXByb3ZlIGVycm9yIG1lc3NhZ2UuCisKIDIwMTktMDgtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0NvbnRleHQgSW5z cGVjdG9yOiBCYXNpYyBDb21tYW5kTGluZUFQSSBkb2Vzbid0IHdvcmsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAppbmRleCBmOGRiZTcxOTZmMS4uNzNkOWFhZjllMjMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTEzMjMsNyArMTMyMyw3 IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZVN0YXRlbWVudCBQYXJzZXI8TGV4 ZXJUeXBlPjo6cGFyc2VGb3JTdGF0ZW1lbnQoCiAgICAgbV9zdGF0ZW1lbnREZXB0aCsrOwogCiAg ICAgaWYgKG1hdGNoKEFXQUlUKSkgewotICAgICAgICBzZW1hbnRpY0ZhaWxJZkZhbHNlKGN1cnJl bnRTY29wZSgpLT5pc0FzeW5jRnVuY3Rpb24oKSwgImZvci1hd2FpdC1vZiBjYW4ndCBiZSB1c2Vk IG9ubHkgaW4gYXN5bmMgZnVuY3Rpb24gb3IgYXN5bmMgZ2VuZXJhdG9yLiIpOworICAgICAgICBz ZW1hbnRpY0ZhaWxJZkZhbHNlKGN1cnJlbnRTY29wZSgpLT5pc0FzeW5jRnVuY3Rpb24oKSwgImZv ci1hd2FpdC1vZiBjYW4gb25seSBiZSB1c2VkIGluIGFuIGFzeW5jIGZ1bmN0aW9uIG9yIGFzeW5j IGdlbmVyYXRvciIpOwogICAgICAgICBpc0F3YWl0Rm9yID0gdHJ1ZTsKICAgICAgICAgbmV4dCgp OwogICAgIH0K