200751 2019-08-14 19:14:57 -0700 [WHLSL] Variables shouldn't be able to have void type 2019-08-14 20:37:15 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield webkit-unassigned commit-queue rmorisset webkit-bug-importer oldest_to_newest 1561424 0 mmaxfield 2019-08-14 19:14:57 -0700 ... 1561425 1 376342 mmaxfield 2019-08-14 19:18:18 -0700 Created attachment 376342 Patch 1561447 2 376342 commit-queue 2019-08-14 20:36:28 -0700 Comment on attachment 376342 Patch Clearing flags on attachment: 376342 Committed r248706: <https://trac.webkit.org/changeset/248706> 1561448 3 commit-queue 2019-08-14 20:36:30 -0700 All reviewed patches have been landed. Closing bug. 1561449 4 webkit-bug-importer 2019-08-14 20:37:15 -0700 <rdar://problem/54332046> 376342 2019-08-14 19:18:18 -0700 2019-08-14 20:36:28 -0700 Patch diff.txt text/plain 3716 mmaxfield ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOTlkY2RkNWE1Mi4uYWE2YjA4ZjZjZGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wOC0xNCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgorCisg ICAgICAgIFtXSExTTF0gVmFyaWFibGVzIHNob3VsZG4ndCBiZSBhYmxlIHRvIGhhdmUgdm9pZCB0 eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3 NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdl YmdwdS93aGxzbC92b2lkLXZhcmlhYmxlLXBhcmFtZXRlci1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIHdlYmdwdS93aGxzbC92b2lkLXZhcmlhYmxlLXBhcmFtZXRlci5odG1sOiBBZGRl ZC4KKwogMjAxOS0wOC0xNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtDb250ZW50Q2hhbmdlT2JzZXJ2ZXJdIEFueSBwcmV2aW91c2x5IGRlc3Ryb3llZCByZW5k ZXJlciBzaG91bGQgbm90IGJlIGNvbnNpZGVyZWQgYSBjYW5kaWRhdGUgZm9yIGNvbnRlbnQgb2Jz ZXJ2YXRpb24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvdm9pZC12YXJp YWJsZS1wYXJhbWV0ZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL3Zv aWQtdmFyaWFibGUtcGFyYW1ldGVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMC4uYmFjNjM2YzI4ODMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy93ZWJncHUvd2hsc2wvdm9pZC12YXJpYWJsZS1wYXJhbWV0ZXItZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsNCBAQAorCitQQVNTIHZvaWRWYXJpYWJsZSAKK1BBU1Mgdm9pZFBhcmFtZXRlciAK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViZ3B1L3dobHNsL3ZvaWQtdmFyaWFibGUtcGFy YW1ldGVyLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvdm9pZC12YXJpYWJsZS1wYXJh bWV0ZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYmFmNjE5 NTBmYmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJncHUvd2hsc2wvdm9pZC12 YXJpYWJsZS1wYXJhbWV0ZXIuaHRtbApAQCAtMCwwICsxLDM1IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPG1ldGEgY2hhcnNldD11dGYtOD4KKzxtZXRhIG5hbWU9InRpbWVvdXQiIGNvbnRl bnQ9ImxvbmciPgorPHRpdGxlPlRlc3Qgc3RydWN0cy48L3RpdGxlPgorPHNjcmlwdCBzcmM9Impz L3Rlc3QtaGFybmVzcy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvd2ViZ3B1LWZ1 bmN0aW9ucy5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL3Rlc3Ro YXJuZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvdGVzdGhh cm5lc3NyZXBvcnQuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2NvbnN0IHdobHNsVGVzdHMgPSB7 fTsKKword2hsc2xUZXN0cy52b2lkVmFyaWFibGUgPSBhc3luYyAoKSA9PgoreworICAgIGF3YWl0 IGNoZWNrRmFpbCgKKyAgICAgICAgYAorICAgICAgICAgICAgdm9pZCBmb28oKSB7CisgICAgICAg ICAgICAgICAgdm9pZCB4OworICAgICAgICAgICAgfQorICAgICAgICBgKTsKK30KKword2hsc2xU ZXN0cy52b2lkUGFyYW1ldGVyID0gYXN5bmMgKCkgPT4KK3sKKyAgICBhd2FpdCBjaGVja0ZhaWwo CisgICAgICAgIGAKKyAgICAgICAgICAgIHZvaWQgZm9vKHZvaWQgeCkgeworICAgICAgICAgICAg fQorICAgICAgICBgKTsKK30KKworcnVuVGVzdHMod2hsc2xUZXN0cyk7Cis8L3NjcmlwdD4KKzwv aHRtbD4KKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGIwNWUzMjA0NzQwLi5mYjIyY2QyMzQ5MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTE0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dITFNMXSBWYXJpYWJsZXMgc2hvdWxkbid0IGJl IGFibGUgdG8gaGF2ZSB2b2lkIHR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMDc1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRyaXZpYWwgZml4LiBGb3VuZCBieSBodHRwczovL2dpdGh1Yi5jb20v Z3B1d2ViL1dITFNML2lzc3Vlcy8zMjAuCisKKyAgICAgICAgVGVzdDogd2ViZ3B1L3dobHNsL3Zv aWQtdmFyaWFibGUtcGFyYW1ldGVyLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1L1dI TFNML1dITFNMQ2hlY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXSExTTDo6Q2hlY2tlcjo6 dmlzaXQpOgorCiAyMDE5LTA4LTE0ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDg1MjYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTENoZWNrZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xDaGVja2VyLmNwcAppbmRl eCA3N2RhNDhlMmVjZi4uOTAxYzYxMDIwM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQ2hlY2tlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xDaGVja2VyLmNwcApAQCAtOTUyLDYgKzk1MiwxMCBA QCB2b2lkIENoZWNrZXI6OnZpc2l0KEFTVDo6VmFyaWFibGVEZWNsYXJhdGlvbiYgdmFyaWFibGVE ZWNsYXJhdGlvbikKICAgICAvLyBSZWFkTW9kaWZ5V3JpdGVFeHByZXNzaW9ucyBhcmUgdGhlIG9u bHkgcGxhY2Ugd2hlcmUgYW5vbnltb3VzIHZhcmlhYmxlcyBleGlzdCwKICAgICAvLyBhbmQgdGhh dCBkb2Vzbid0IHJlY3Vyc2Ugb24gdGhlIGFub255bW91cyB2YXJpYWJsZXMsIHNvIHdlIGNhbiBh c3N1bWUgdGhlIHZhcmlhYmxlIGhhcyBhIHR5cGUuCiAgICAgY2hlY2tFcnJvckFuZFZpc2l0KCp2 YXJpYWJsZURlY2xhcmF0aW9uLnR5cGUoKSk7CisgICAgaWYgKG1hdGNoZXMoKnZhcmlhYmxlRGVj bGFyYXRpb24udHlwZSgpLCBtX2ludHJpbnNpY3Mudm9pZFR5cGUoKSkpIHsKKyAgICAgICAgc2V0 RXJyb3IoRXJyb3IoIlZhcmlhYmxlcyBjYW4ndCBoYXZlIHZvaWQgdHlwZS4iLCB2YXJpYWJsZURl Y2xhcmF0aW9uLmNvZGVMb2NhdGlvbigpKSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAg aWYgKHZhcmlhYmxlRGVjbGFyYXRpb24uaW5pdGlhbGl6ZXIoKSkgewogICAgICAgICBhdXRvJiBs aHNUeXBlID0gKnZhcmlhYmxlRGVjbGFyYXRpb24udHlwZSgpOwogICAgICAgICBhdXRvIGluaXRp YWxpemVySW5mbyA9IHJlY3Vyc2VBbmRHZXRJbmZvKCp2YXJpYWJsZURlY2xhcmF0aW9uLmluaXRp YWxpemVyKCkpOwo=