200750 2019-08-14 19:09:10 -0700 WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end 2019-08-15 09:34:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue thorton webkit-bug-importer oldest_to_newest 1561421 0 achristensen 2019-08-14 19:09:10 -0700 WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end 1561422 1 376341 achristensen 2019-08-14 19:09:58 -0700 Created attachment 376341 Patch 1561423 2 achristensen 2019-08-14 19:10:00 -0700 <rdar://problem/54232261> 1561577 3 376341 commit-queue 2019-08-15 09:34:06 -0700 Comment on attachment 376341 Patch Clearing flags on attachment: 376341 Committed r248717: <https://trac.webkit.org/changeset/248717> 1561578 4 commit-queue 2019-08-15 09:34:08 -0700 All reviewed patches have been landed. Closing bug. 376341 2019-08-14 19:09:58 -0700 2019-08-15 09:34:06 -0700 Patch bug-200750-20190814190957.patch text/plain 7479 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2ZTcxYWVlYjcyODFmNGVk YTRjMjVlNjE5MDUyZjQxNzQ5ZWFkNjguLmRjOWEzMTQzZThjYjYwY2E2MDcwNTc4YzBiMmNiYzhh ZjhmNTYzNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTQgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBXS1VJRGVsZWdh dGUncyB3ZWJWaWV3OmNvbnRleHRNZW51RGlkRW5kRm9yRWxlbWVudDogc2hvdWxkIGJlIGNhbGxl ZCB3aGVuIGNvbnRleHQgbWVudXMgZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDA3NTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU0MjMyMjYx PiBhbmQgPHJkYXI6Ly9wcm9ibGVtLzUyMzU1ODI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY29udGV4dE1lbnVJbnRlcmFj dGlvbjp3aWxsRW5kRm9yQ29uZmlndXJhdGlvbjphbmltYXRvcjpdKToKKwogMjAxOS0wOC0xMyAg U2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIHNo b3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uIHNob3VsZCBiZSBhIHZhbHVlIGluIEltYWdlT3Jp ZW50YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDllMTZjY2JmZDZiMjAxY2I1OWY3Mzg3YWJhZmY4 MThiNTU2MDY5NzIuLmE0MmY2MjEyYjcyZGFkYmI4NzBjMmMyMmQ4NzU2YjY0ZGE3OTBjZDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQpAQCAtODM2Niw3ICs4MzY2LDcgQEAgc3RhdGljIFJldGFpblB0cjxVSVRh cmdldGVkUHJldmlldz4gY3JlYXRlRmFsbGJhY2tUYXJnZXRlZFByZXZpZXcoVUlWaWV3ICpyb290 VmkKIAogICAgIC8vIEZJWE1FOiBUaGlzIGRlbGVnYXRlIGlzIGJlaW5nIGNhbGxlZCBtb3JlIHRo YW4gb25jZSBieSBVSUtpdC4gPHJkYXI6Ly9wcm9ibGVtLzUxNTUwMjkxPgogICAgIC8vIFRoaXMg Y29uZGl0aW9uYWwgYXZvaWRzIHRoZSBXS1VJRGVsZWdhdGUgYmVpbmcgY2FsbGVkIHR3aWNlIHRv by4KLSAgICBpZiAoIV9jb250ZXh0TWVudUVsZW1lbnRJbmZvKSB7CisgICAgaWYgKF9jb250ZXh0 TWVudUVsZW1lbnRJbmZvKSB7CiAgICAgICAgIGF1dG8gdWlEZWxlZ2F0ZSA9IHN0YXRpY19jYXN0 PGlkPFdLVUlEZWxlZ2F0ZVByaXZhdGU+Pihfd2ViVmlldy5VSURlbGVnYXRlKTsKICAgICAgICAg aWYgKFt1aURlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Iod2ViVmlldzpjb250 ZXh0TWVudURpZEVuZEZvckVsZW1lbnQ6KV0pCiAgICAgICAgICAgICBbdWlEZWxlZ2F0ZSB3ZWJW aWV3Ol93ZWJWaWV3IGNvbnRleHRNZW51RGlkRW5kRm9yRWxlbWVudDpfY29udGV4dE1lbnVFbGVt ZW50SW5mby5nZXQoKV07CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggMTdjZGExYTBiMzhhNmRlZjkwYWQzMzQ1YzIyNmNlYjBkN2U1NzYyMC4uNzk5 ZDAwMzc2Y2ZhOGFlMmMwZmM2ZmFjYmY1ZDEyYjk4NjMzOTdjZCAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4 LTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgV0tVSURlbGVnYXRlJ3Mgd2ViVmlldzpjb250ZXh0TWVudURpZEVuZEZvckVsZW1lbnQ6IHNo b3VsZCBiZSBjYWxsZWQgd2hlbiBjb250ZXh0IG1lbnVzIGVuZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzUwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81NDIzMjI2MT4gYW5kIDxyZGFyOi8vcHJvYmxlbS81MjM1NTgyOT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvQ29udGV4dE1lbnVzLm1tOgorICAgICAgICAoLVtUZXN0Q29udGV4dE1l bnVVSURlbGVnYXRlIHdlYlZpZXc6Y29udGV4dE1lbnVDb25maWd1cmF0aW9uRm9yRWxlbWVudDpj b21wbGV0aW9uSGFuZGxlcjpdKToKKyAgICAgICAgKC1bVGVzdENvbnRleHRNZW51VUlEZWxlZ2F0 ZSB3ZWJWaWV3OmNvbnRleHRNZW51Rm9yRWxlbWVudDp3aWxsQ29tbWl0V2l0aEFuaW1hdG9yOl0p OgorICAgICAgICAoLVtUZXN0Q29udGV4dE1lbnVVSURlbGVnYXRlIHdlYlZpZXc6Y29udGV4dE1l bnVEaWRFbmRGb3JFbGVtZW50Ol0pOgorICAgICAgICAoY29udGV4dE1lbnVXZWJWaWV3RHJpdmVy KToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE5LTA4LTEzICBTYW0gV2VpbmlnICA8d2VpbmlnQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgU3RyaW5nQnVpbGRlcjo6YXBwZW5kKFVDaGFyMzIp IHRvIFN0cmluZ0J1aWxkZXI6OmFwcGVuZENoYXJhY3RlcihVQ2hhcjMyKSB0byBhdm9pZCBhY2Np ZGVudGFsIGNoYW5nZSBpbiBiZWhhdmlvciB3aGVuIHJlcGxhY2luZyBhcHBlbmQgd2l0aCBmbGV4 aWJsZUFwcGVuZApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9Db250ZXh0TWVudXMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL0NvbnRleHRNZW51cy5tbQppbmRleCA2MWEzOTZkY2YxYjE3NjRkOTdkM2E5MDU0NTgxNjI1 NDU2N2RlYWNlLi4yNDc1M2M2YzZkZWFhMWU1Mjg1MzZhMDIwZjlhMjQ4NWEwMDAzNDRhIDEwMDY0 NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NvbnRleHRNZW51 cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0NvbnRleHRN ZW51cy5tbQpAQCAtMzQsOCArMzQsMTAgQEAKICNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXdDb25m aWd1cmF0aW9uUHJpdmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dlYktpdC5oPgogCi1zdGF0aWMg Ym9vbCB3aWxsUHJlc2VudENhbGxlZDsKIHN0YXRpYyBib29sIGNvbnRleHRNZW51UmVxdWVzdGVk Oworc3RhdGljIGJvb2wgd2lsbFByZXNlbnRDYWxsZWQ7CitzdGF0aWMgYm9vbCB3aWxsQ29tbWl0 Q2FsbGVkOworc3RhdGljIGJvb2wgZGlkRW5kQ2FsbGVkOwogc3RhdGljIFJldGFpblB0cjxOU1VS TD4gc2ltcGxlVVJMOwogCiBAaW50ZXJmYWNlIFRlc3RDb250ZXh0TWVudVVJRGVsZWdhdGUgOiBO U09iamVjdCA8V0tVSURlbGVnYXRlPgpAQCAtNDcsNyArNDksMTUgQEAgc3RhdGljIFJldGFpblB0 cjxOU1VSTD4gc2ltcGxlVVJMOwogewogICAgIEVYUEVDVF9UUlVFKFtlbGVtZW50SW5mby5saW5r VVJMLmFic29sdXRlU3RyaW5nIGlzRXF1YWxUb1N0cmluZzpbc2ltcGxlVVJMIGFic29sdXRlU3Ry aW5nXV0pOwogICAgIGNvbnRleHRNZW51UmVxdWVzdGVkID0gdHJ1ZTsKLSAgICBjb21wbGV0aW9u SGFuZGxlcihbVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gY29uZmlndXJhdGlvbldpdGhJZGVu dGlmaWVyOm5pbCBwcmV2aWV3UHJvdmlkZXI6bmlsIGFjdGlvblByb3ZpZGVyOm5pbF0pOworICAg IFVJQ29udGV4dE1lbnVDb250ZW50UHJldmlld1Byb3ZpZGVyIHByZXZpZXdQcm92aWRlciA9IF5V SVZpZXdDb250cm9sbGVyICogKCkKKyAgICB7CisgICAgICAgIHJldHVybiBbVUlWaWV3Q29udHJv bGxlciBuZXddOworICAgIH07CisgICAgVUlDb250ZXh0TWVudUFjdGlvblByb3ZpZGVyIGFjdGlv blByb3ZpZGVyID0gXlVJTWVudSAqKE5TQXJyYXk8VUlNZW51RWxlbWVudCAqPiAqc3VnZ2VzdGVk QWN0aW9ucykKKyAgICB7CisgICAgICAgIHJldHVybiBbVUlNZW51IG1lbnVXaXRoVGl0bGU6QCIi IGNoaWxkcmVuOnN1Z2dlc3RlZEFjdGlvbnNdOworICAgIH07CisgICAgY29tcGxldGlvbkhhbmRs ZXIoW1VJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRpb25XaXRoSWRlbnRpZmll cjpuaWwgcHJldmlld1Byb3ZpZGVyOnByZXZpZXdQcm92aWRlciBhY3Rpb25Qcm92aWRlcjphY3Rp b25Qcm92aWRlcl0pOwogfQogCiAtICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcg Y29udGV4dE1lbnVXaWxsUHJlc2VudEZvckVsZW1lbnQ6KFdLQ29udGV4dE1lbnVFbGVtZW50SW5m byAqKWVsZW1lbnRJbmZvCkBAIC01NywzNiArNjcsNTggQEAgc3RhdGljIFJldGFpblB0cjxOU1VS TD4gc2ltcGxlVVJMOwogCiAtICh2b2lkKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29u dGV4dE1lbnVGb3JFbGVtZW50OihXS0NvbnRleHRNZW51RWxlbWVudEluZm8gKillbGVtZW50SW5m byB3aWxsQ29tbWl0V2l0aEFuaW1hdG9yOihpZDxVSUNvbnRleHRNZW51SW50ZXJhY3Rpb25Db21t aXRBbmltYXRpbmc+KWFuaW1hdG9yCiB7CisgICAgd2lsbENvbW1pdENhbGxlZCA9IHRydWU7CiB9 CiAKIC0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb250ZXh0TWVudURpZEVu ZEZvckVsZW1lbnQ6KFdLQ29udGV4dE1lbnVFbGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvCiB7Cisg ICAgZGlkRW5kQ2FsbGVkID0gdHJ1ZTsKIH0KIAogQGVuZAogCi1URVNUKFdlYktpdCwgRElTQUJM RURfQ29udGV4dE1lbnVCYXNpYykKK3N0YXRpYyBSZXRhaW5QdHI8VGVzdENvbnRleHRNZW51RHJp dmVyPiBjb250ZXh0TWVudVdlYlZpZXdEcml2ZXIoKQogewotICAgIGF1dG8gd2luZG93ID0gYWRv cHROUyhbW1VJV2luZG93IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAw LCA2MDApXSk7Ci0gICAgYXV0byBkcml2ZXIgPSBhZG9wdE5TKFtUZXN0Q29udGV4dE1lbnVEcml2 ZXIgbmV3XSk7Ci0gICAgYXV0byB1aURlbGVnYXRlID0gYWRvcHROUyhbVGVzdENvbnRleHRNZW51 VUlEZWxlZ2F0ZSBuZXddKTsKLSAgICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtXS1dl YlZpZXdDb25maWd1cmF0aW9uIG5ld10pOworICAgIHN0YXRpYyBhdXRvIHdpbmRvdyA9IGFkb3B0 TlMoW1tVSVdpbmRvdyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwg NjAwKV0pOworICAgIHN0YXRpYyBhdXRvIGRyaXZlciA9IGFkb3B0TlMoW1Rlc3RDb250ZXh0TWVu dURyaXZlciBuZXddKTsKKyAgICBzdGF0aWMgYXV0byB1aURlbGVnYXRlID0gYWRvcHROUyhbVGVz dENvbnRleHRNZW51VUlEZWxlZ2F0ZSBuZXddKTsKKyAgICBzdGF0aWMgYXV0byBjb25maWd1cmF0 aW9uID0gYWRvcHROUyhbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBuZXddKTsKICAgICBbY29uZmln dXJhdGlvbiBfc2V0Q2xpY2tJbnRlcmFjdGlvbkRyaXZlckZvclRlc3Rpbmc6KGlkPF9VSUNsaWNr SW50ZXJhY3Rpb25Ecml2aW5nPilkcml2ZXIuZ2V0KCldOwotICAgIGF1dG8gd2ViVmlld0NvbnRy b2xsZXIgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlld0NvbnRyb2xsZXIgYWxsb2NdIGluaXRXaXRo RnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAyMDAsIDIwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0 aW9uLmdldCgpXSk7CisgICAgc3RhdGljIGF1dG8gd2ViVmlld0NvbnRyb2xsZXIgPSBhZG9wdE5T KFtbVGVzdFdLV2ViVmlld0NvbnRyb2xsZXIgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFr ZSgwLCAwLCAyMDAsIDIwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7CiAg ICAgVGVzdFdLV2ViVmlldyAqd2ViVmlldyA9IFt3ZWJWaWV3Q29udHJvbGxlciB3ZWJWaWV3XTsK ICAgICBbd2luZG93IGFkZFN1YnZpZXc6d2ViVmlld107CiAgICAgW3dlYlZpZXcgc2V0VUlEZWxl Z2F0ZTp1aURlbGVnYXRlLmdldCgpXTsKLQogICAgIHNpbXBsZVVSTCA9IFtbTlNCdW5kbGUgbWFp bkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6QCJzaW1wbGUiIHdpdGhFeHRlbnNpb246QCJodG1sIiBz dWJkaXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdOwogICAgIFt3ZWJWaWV3IHN5 bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzpbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIjxh IGhyZWY9JyVAJz5UaGlzIGlzIGEgbGluazwvYT4iLCBzaW1wbGVVUkwuZ2V0KCldXTsKKyAgICBy ZXR1cm4gZHJpdmVyOworfQorCitURVNUKFdlYktpdCwgQ29udGV4dE1lbnVDbGljaykKK3sKKyAg ICBhdXRvIGRyaXZlciA9IGNvbnRleHRNZW51V2ViVmlld0RyaXZlcigpOwogICAgIFtkcml2ZXIg YmVnaW46XihCT09MIHJlc3VsdCkgewotICAgICAgICBpZiAocmVzdWx0KSB7Ci0gICAgICAgICAg ICBbZHJpdmVyIGNsaWNrRG93bl07Ci0gICAgICAgICAgICBbZHJpdmVyIGNsaWNrVXBdOwotICAg ICAgICAgICAgW2RyaXZlciBlbmRdOwotICAgICAgICB9CisgICAgICAgIEVYUEVDVF9UUlVFKHJl c3VsdCk7CisgICAgICAgIFtkcml2ZXIgY2xpY2tEb3duXTsKKyAgICAgICAgW2RyaXZlciBjbGlj a1VwXTsKICAgICB9XTsKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJndpbGxQcmVzZW50 Q2FsbGVkKTsKKyAgICBFWFBFQ1RfVFJVRShjb250ZXh0TWVudVJlcXVlc3RlZCk7CisgICAgRVhQ RUNUX1RSVUUod2lsbFByZXNlbnRDYWxsZWQpOworICAgIEVYUEVDVF9GQUxTRSh3aWxsQ29tbWl0 Q2FsbGVkKTsKKyAgICBFWFBFQ1RfRkFMU0UoZGlkRW5kQ2FsbGVkKTsKIH0KIAorVEVTVChXZWJL aXQsIENvbnRleHRNZW51RW5kKQoreworICAgIGF1dG8gZHJpdmVyID0gY29udGV4dE1lbnVXZWJW aWV3RHJpdmVyKCk7CisgICAgW2RyaXZlciBiZWdpbjpeKEJPT0wgcmVzdWx0KSB7CisgICAgICAg IEVYUEVDVF9UUlVFKHJlc3VsdCk7CisgICAgICAgIFtkcml2ZXIgZW5kXTsKKyAgICB9XTsKKyAg ICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRpZEVuZENhbGxlZCk7CisgICAgRVhQRUNUX1RS VUUoY29udGV4dE1lbnVSZXF1ZXN0ZWQpOworICAgIEVYUEVDVF9GQUxTRSh3aWxsUHJlc2VudENh bGxlZCk7CisgICAgRVhQRUNUX0ZBTFNFKHdpbGxDb21taXRDYWxsZWQpOworICAgIEVYUEVDVF9U UlVFKGRpZEVuZENhbGxlZCk7Cit9CiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKSAmJiBVU0UoVUlD T05URVhUTUVOVSkK