200743 2019-08-14 16:25:27 -0700 Missing exception check in string compare. 2019-08-14 16:37:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1561379 0 mark.lam 2019-08-14 16:25:27 -0700 <rdar://problem/53975356> 1561380 1 376330 mark.lam 2019-08-14 16:28:30 -0700 Created attachment 376330 proposed patch. 1561381 2 mark.lam 2019-08-14 16:37:18 -0700 Thanks for the review. Landed in r248694: <http://trac.webkit.org/r248694>. 376330 2019-08-14 16:28:30 -0700 2019-08-14 16:29:59 -0700 proposed patch. bug-200743.patch text/plain 2331 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDg2OTIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBNaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBzdHJpbmcgY29tcGFyZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc0Mwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM5NzUzNTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvbWlzc2luZy1leGNlcHRpb24tY2hl Y2staW4tc3RyaW5nLWNvbXBhcmUuanM6IEFkZGVkLgorCiAyMDE5LTA4LTA4ICBSb3NzIEtpcnNs aW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSlNDXSBBZGQgImp1bXAg aWYgKG5vdCkgdW5kZWZpbmVkIG9yIG51bGwiIGJ5dGVjb2RlIG9wcwpJbmRleDogSlNUZXN0cy9z dHJlc3MvbWlzc2luZy1leGNlcHRpb24tY2hlY2staW4tc3RyaW5nLWNvbXBhcmUuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNlcHRpb24tY2hlY2staW4tc3RyaW5n LWNvbXBhcmUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvbWlzc2luZy1leGNl cHRpb24tY2hlY2staW4tc3RyaW5nLWNvbXBhcmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSw5IEBACitjb25zdCBzMSA9ICgtMSkudG9Mb2NhbGVTdHJpbmcoKS5wYWRFbmQoMioqMzEtMSwg J2FhJyk7Cit0cnkgeworICAgIHMxID09IHMxOworfSBjYXRjaCAoZSkgeworICAgIGV4Y2VwdGlv biA9IGU7Cit9CisKK2lmIChleGNlcHRpb24gIT0gIkVycm9yOiBPdXQgb2YgbWVtb3J5IikKKyAg ICB0aHJvdyAiRkFJTEVEIjsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24g MjQ4NjkxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA4LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KKworICAgICAgICBNaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBzdHJpbmcgY29tcGFy ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDc0 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM5NzUzNTY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0pTU3RyaW5nLmNwcDoKKyAg ICAgICAgKEpTQzo6SlNTdHJpbmc6OmVxdWFsU2xvd0Nhc2UgY29uc3QpOgorCiAyMDE5LTA4LTE0 ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgYnVpbGQgZml4IGZvciBNYWNyb0Fzc2VtYmxlckFSTTY0RSBjaGFuZ2UKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAJKHJldmlzaW9uIDI0ODY0MSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTYsNiArOTYsNyBAQCBib29sIEpTU3RyaW5nOjplcXVhbFNsb3dDYXNlKEV4ZWNT dGF0ZSogCiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKICAgICBhdXRvIHNjb3BlID0gREVDTEFS RV9USFJPV19TQ09QRSh2bSk7CiAgICAgU3RyaW5nIHN0cjEgPSB2YWx1ZShleGVjKTsKKyAgICBS RVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBmYWxzZSk7CiAgICAgU3RyaW5nIHN0cjIgPSBvdGhl ci0+dmFsdWUoZXhlYyk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZmFsc2UpOwog ICAgIHJldHVybiBXVEY6OmVxdWFsKCpzdHIxLmltcGwoKSwgKnN0cjIuaW1wbCgpKTsK