200740 2019-08-14 15:57:45 -0700 [WebGPU] Use of WebGPU should not force discrete GPU 2019-08-15 15:15:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_fan justin_fan commit-queue darin dino ews-watchlist graouts kondapallykalyan mmaxfield webkit-bug-importer oldest_to_newest 1561367 0 justin_fan 2019-08-14 15:57:45 -0700 [WebGPU] Use of WebGPU should not force discrete GPU 1561368 1 justin_fan 2019-08-14 15:58:23 -0700 <rdar://problem/53573849> 1561369 2 376325 justin_fan 2019-08-14 16:01:47 -0700 Created attachment 376325 Patch 1561378 3 376325 mmaxfield 2019-08-14 16:15:59 -0700 Comment on attachment 376325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376325&action=review > Source/WebCore/platform/graphics/gpu/GPURequestAdapterOptions.h:40 > + Optional<GPUPowerPreference> powerPreference { GPUPowerPreference::LowPower }; Why is this optional any more, then? 1561434 4 376325 commit-queue 2019-08-14 19:34:31 -0700 Comment on attachment 376325 Patch Clearing flags on attachment: 376325 Committed r248704: <https://trac.webkit.org/changeset/248704> 1561435 5 commit-queue 2019-08-14 19:34:32 -0700 All reviewed patches have been landed. Closing bug. 1561552 6 376325 darin 2019-08-15 08:32:51 -0700 Comment on attachment 376325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376325&action=review >> Source/WebCore/platform/graphics/gpu/GPURequestAdapterOptions.h:40 >> + Optional<GPUPowerPreference> powerPreference { GPUPowerPreference::LowPower }; > > Why is this optional any more, then? I’d like to understand this too. 1561702 7 justin_fan 2019-08-15 12:46:39 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 376325 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376325&action=review > > >> Source/WebCore/platform/graphics/gpu/GPURequestAdapterOptions.h:40 > >> + Optional<GPUPowerPreference> powerPreference { GPUPowerPreference::LowPower }; > > > > Why is this optional any more, then? > > I’d like to understand this too. Hi! I noted this only offline to Myles, but the current spec still calls for a ‘?’ in that field and not wrapping the member in Optional results in binding compile error. Us providing the default is an impl detail. 1561761 8 darin 2019-08-15 14:49:50 -0700 (In reply to Justin Fan from comment #7) > the current spec still calls for > a ‘?’ in that field and not wrapping the member in Optional results in > binding compile error. Us providing the default is an impl detail. I don’t think this is the right idiom for an optional value with default behavior. We should remove the default value from the struct and have the code that gets the value from the struct apply the default using valueOr. 1561764 9 justin_fan 2019-08-15 14:53:00 -0700 (In reply to Darin Adler from comment #8) > (In reply to Justin Fan from comment #7) > > the current spec still calls for > > a ‘?’ in that field and not wrapping the member in Optional results in > > binding compile error. Us providing the default is an impl detail. > > I don’t think this is the right idiom for an optional value with default > behavior. We should remove the default value from the struct and have the > code that gets the value from the struct apply the default using valueOr. Cool, did not know valueOr was a thing. Will update. 1561771 10 justin_fan 2019-08-15 15:05:41 -0700 Reopening to attach new patch. 1561772 11 376427 justin_fan 2019-08-15 15:05:42 -0700 Created attachment 376427 Patch 1561776 12 ews-watchlist 2019-08-15 15:07:34 -0700 Attachment 376427 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1561779 13 376428 justin_fan 2019-08-15 15:10:40 -0700 Created attachment 376428 Patch 1561780 14 376428 justin_fan 2019-08-15 15:15:32 -0700 Comment on attachment 376428 Patch Clearing flags on attachment: 376428 Committed r248749: <https://trac.webkit.org/changeset/248749> 1561781 15 justin_fan 2019-08-15 15:15:34 -0700 All reviewed patches have been landed. Closing bug. 376325 2019-08-14 16:01:47 -0700 2019-08-15 15:05:40 -0700 Patch bug-200740-20190814160146.patch text/plain 2341 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU4OTE5ZGExZjE5MGFk YmIzZjk3YzAzNWE1ZGE5YjYxNmI5NDJhYi4uZDMzMzkzZjAwYjljMTI4MmJiYjExZjVhZDE3MDc5 YzZjNTdmMGU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA4LTE0ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQVV0gVXNlIG9m IFdlYkdQVSBzaG91bGQgbm90IGZvcmNlIGRpc2NyZXRlIEdQVQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzQwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVxdWVzdCBhIGxvdy1wb3dlciBkZXZpY2Ug ZnJvbSBNZXRhbCBieSBkZWZhdWx0LgorCisgICAgICAgIE5vIGNoYW5nZSBpbiB0ZXN0YWJsZSBi ZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9HUFVSZXF1ZXN0QWRh cHRlck9wdGlvbnMuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BV RGV2aWNlTWV0YWwubW06CisgICAgICAgIChXZWJDb3JlOjpHUFVEZXZpY2U6OnRyeUNyZWF0ZSk6 CisKIDIwMTktMDgtMTQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbQ29udGVudENoYW5nZU9ic2VydmVyXSBTdG9wIGNvbnRlbnQgY2hhbmdlIG9ic2VydmF0aW9u IGV4cGxpY2l0bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ncHUvR1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ncHUvR1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zLmgKaW5kZXggMWY1ZTg4ZDQ0 MzZiNTFhODlkNjQ2OTc1OTY5OGFiZGNkNTJlYTM5MC4uNGU0NjMxMDRjYjlhNDg3ODJlZDkxNTgx MDc3MTEyYjQyM2Y1Zjk0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0dQVVJlcXVlc3RBZGFwdGVyT3B0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9HUFVSZXF1ZXN0QWRhcHRlck9wdGlvbnMuaApAQCAtMzcs NyArMzcsNyBAQCBlbnVtIGNsYXNzIEdQVVBvd2VyUHJlZmVyZW5jZSB7CiB9OwogCiBzdHJ1Y3Qg R1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zIHsKLSAgICBPcHRpb25hbDxHUFVQb3dlclByZWZlcmVu Y2U+IHBvd2VyUHJlZmVyZW5jZTsKKyAgICBPcHRpb25hbDxHUFVQb3dlclByZWZlcmVuY2U+IHBv d2VyUHJlZmVyZW5jZSB7IEdQVVBvd2VyUHJlZmVyZW5jZTo6TG93UG93ZXIgfTsKIH07CiAgICAg CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BVRGV2aWNlTWV0YWwubW0gYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvY29jb2EvR1BVRGV2aWNlTWV0YWwubW0KaW5kZXggMzJk MjVmMjc4OGNiOTVjYjNkMGY1ZDdlMzNiNGE2YzFmOGZmYzk4NS4uNDIwNDMwZTIxM2Q4MTgyODk2 YmM1MGM4ZjVkZjBjMWNkZWFhMDUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3B1L2NvY29hL0dQVURldmljZU1ldGFsLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9jb2NvYS9HUFVEZXZpY2VNZXRhbC5tbQpAQCAtNTgs NyArNTgsNyBAQCBSZWZQdHI8R1BVRGV2aWNlPiBHUFVEZXZpY2U6OnRyeUNyZWF0ZShjb25zdCBP cHRpb25hbDxHUFVSZXF1ZXN0QWRhcHRlck9wdGlvbnM+JgogICAgIEJFR0lOX0JMT0NLX09CSkNf RVhDRVBUSU9OUzsKICAgICAKICNpZiBQTEFURk9STShNQUMpCi0gICAgaWYgKG9wdGlvbnMgJiYg b3B0aW9ucy0+cG93ZXJQcmVmZXJlbmNlID09IEdQVVBvd2VyUHJlZmVyZW5jZTo6TG93UG93ZXIp IHsKKyAgICBpZiAoIW9wdGlvbnMgfHwgIW9wdGlvbnMtPnBvd2VyUHJlZmVyZW5jZSB8fCBvcHRp b25zLT5wb3dlclByZWZlcmVuY2UgPT0gR1BVUG93ZXJQcmVmZXJlbmNlOjpMb3dQb3dlcikgewog ICAgICAgICBhdXRvIGRldmljZXMgPSBhZG9wdE5TKE1UTENvcHlBbGxEZXZpY2VzKCkpOwogICAg ICAgICAKICAgICAgICAgZm9yIChpZCA8TVRMRGV2aWNlPiBkZXZpY2UgOiBkZXZpY2VzLmdldCgp KSB7Cg== 376427 2019-08-15 15:05:42 -0700 2019-08-15 15:10:36 -0700 Patch bug-200740-20190815150540.patch text/plain 1334 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg3ZmRiNWQwMTU5Yzg5 MWIzMmRlNTdiZWFjNjk0ODAwMzM2MDMzNy4uMzlhYmFjNmY5N2E5ZTM0ZTVhODRlZDc5NTIwNDRl NmM5YWRmM2RmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkdQVV0gVXNlIG9m IFdlYkdQVSBzaG91bGQgbm90IGZvcmNlIGRpc2NyZXRlIEdQVQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzQwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvR1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zLmg6 CisgICAgICAgICgpOiBEZWxldGVkLgorCiAyMDE5LTA4LTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIERlYnVnIGJ1aWxkIGZpeCBhZnRl ciByMjQ4NzMwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L0dQVVJlcXVlc3RBZGFwdGVyT3B0aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3B1L0dQVVJlcXVlc3RBZGFwdGVyT3B0aW9ucy5oCmluZGV4IDRlNDYzMTA0Y2I5 YTQ4NzgyZWQ5MTU4MTA3NzExMmI0MjNmNWY5NDEuLjFmNWU4OGQ0NDM2YjUxYTg5ZDY0Njk3NTk2 OThhYmRjZDUyZWEzOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dwdS9HUFVSZXF1ZXN0QWRhcHRlck9wdGlvbnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ncHUvR1BVUmVxdWVzdEFkYXB0ZXJPcHRpb25zLmgKQEAgLTM3LDcg KzM3LDcgQEAgZW51bSBjbGFzcyBHUFVQb3dlclByZWZlcmVuY2UgewogfTsKIAogc3RydWN0IEdQ VVJlcXVlc3RBZGFwdGVyT3B0aW9ucyB7Ci0gICAgT3B0aW9uYWw8R1BVUG93ZXJQcmVmZXJlbmNl PiBwb3dlclByZWZlcmVuY2UgeyBHUFVQb3dlclByZWZlcmVuY2U6Okxvd1Bvd2VyIH07CisgICAg T3B0aW9uYWw8R1BVUG93ZXJQcmVmZXJlbmNlPiBwb3dlclByZWZlcmVuY2U7CiB9OwogICAgIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 376428 2019-08-15 15:10:40 -0700 2019-08-15 15:15:32 -0700 Patch bug-200740-20190815151039.patch text/plain 1241 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg3ZmRiNWQwMTU5Yzg5 MWIzMmRlNTdiZWFjNjk0ODAwMzM2MDMzNy4uMWE5MzBkY2NkNjYxNmFjNGMwMjEwZTE4YTgxYTY0 MzY5YzYyNmE5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDE5LTA4LTE1ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCBzdWdn ZXN0ZWQgcGF0Y2ggZm9sbG93LXVwIHRvIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDA3NDAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvR1BVUmVx dWVzdEFkYXB0ZXJPcHRpb25zLmg6CisgICAgICAgICgpOiBEZWxldGVkLgorCiAyMDE5LTA4LTE1 ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQu IERlYnVnIGJ1aWxkIGZpeCBhZnRlciByMjQ4NzMwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0dQVVJlcXVlc3RBZGFwdGVyT3B0aW9ucy5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L0dQVVJlcXVlc3RBZGFwdGVyT3B0aW9u cy5oCmluZGV4IDRlNDYzMTA0Y2I5YTQ4NzgyZWQ5MTU4MTA3NzExMmI0MjNmNWY5NDEuLjFmNWU4 OGQ0NDM2YjUxYTg5ZDY0Njk3NTk2OThhYmRjZDUyZWEzOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9HUFVSZXF1ZXN0QWRhcHRlck9wdGlvbnMuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvR1BVUmVxdWVzdEFkYXB0 ZXJPcHRpb25zLmgKQEAgLTM3LDcgKzM3LDcgQEAgZW51bSBjbGFzcyBHUFVQb3dlclByZWZlcmVu Y2UgewogfTsKIAogc3RydWN0IEdQVVJlcXVlc3RBZGFwdGVyT3B0aW9ucyB7Ci0gICAgT3B0aW9u YWw8R1BVUG93ZXJQcmVmZXJlbmNlPiBwb3dlclByZWZlcmVuY2UgeyBHUFVQb3dlclByZWZlcmVu Y2U6Okxvd1Bvd2VyIH07CisgICAgT3B0aW9uYWw8R1BVUG93ZXJQcmVmZXJlbmNlPiBwb3dlclBy ZWZlcmVuY2U7CiB9OwogICAgIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=