200735 2019-08-14 14:09:18 -0700 Error thrown during "acceptNode" lookup is overridden 2019-08-14 23:12:16 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200066 https://github.com/web-platform-tests/wpt/pull/15122 InRadar P2 Minor --- 200737 1 ashvayka webkit-unassigned commit-queue ross.kirsling webkit-bug-importer oldest_to_newest 1561324 0 ashvayka 2019-08-14 14:09:18 -0700 Test case: ``` let myError = {name: "test"}; let el = document.createElement("div"); el.append("node"); let walker = document.createTreeWalker(el, NodeFilter.SHOW_TEXT, { get acceptNode() { throw myError; } }); walker.firstChild(); ``` Actual: TypeError is thrown Expected: myError is thrown WPT: https://github.com/web-platform-tests/wpt/pull/15122 WebIDL: https://heycam.github.io/webidl/#call-a-user-objects-operation (step 10.2) Both Firefox 68 and Chrome 76 throw correct error. 1561454 1 376350 ashvayka 2019-08-14 21:21:16 -0700 Created attachment 376350 Patch 1561461 2 376350 ross.kirsling 2019-08-14 21:51:35 -0700 Comment on attachment 376350 Patch r=me, as long as EWS is green 1561477 3 376350 commit-queue 2019-08-14 23:11:42 -0700 Comment on attachment 376350 Patch Clearing flags on attachment: 376350 Committed r248708: <https://trac.webkit.org/changeset/248708> 1561478 4 commit-queue 2019-08-14 23:11:43 -0700 All reviewed patches have been landed. Closing bug. 1561479 5 webkit-bug-importer 2019-08-14 23:12:16 -0700 <rdar://problem/54334630> 376350 2019-08-14 21:21:16 -0700 2019-08-14 23:11:42 -0700 Patch bug-200735-20190815072115.patch text/plain 3506 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODcwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA4LTE0ICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICBFcnJvciB0aHJvd24g ZHVyaW5nICJhY2NlcHROb2RlIiBsb29rdXAgaXMgb3ZlcnJpZGRlbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9kb20vdHJhdmVyc2FsL1RyZWVXYWxrZXItYWNjZXB0Tm9kZS1maWx0ZXIt ZXhwZWN0ZWQuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvanMvSlNDYWxsYmFja0RhdGEuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SlNDYWxsYmFja0RhdGE6Omludm9rZUNhbGxiYWNrKTogQ2F0 Y2ggYW5kIHJldHVybiBleGNlcHRpb24gb2YgY2FsbGJhY2stPmdldCBjYWxsLgorCiAyMDE5LTA4 LTE0ICBKdXN0aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdQ VV0gVXNlIG9mIFdlYkdQVSBzaG91bGQgbm90IGZvcmNlIGRpc2NyZXRlIEdQVQpJbmRleDogU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDYWxsYmFja0RhdGEuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ2FsbGJhY2tEYXRhLmNwcAkocmV2aXNpb24g MjQ4NzA1KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDYWxsYmFja0RhdGEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw4IEBAIEpTVmFsdWUgSlNDYWxsYmFja0RhdGE6 Omludm9rZUNhbGxiYWNrKEoKIAogICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGdsb2JhbE9iamVjdC5n bG9iYWxFeGVjKCk7CiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBhdXRvIHNjb3BlID0g REVDTEFSRV9DQVRDSF9TQ09QRSh2bSk7CisKICAgICBKU1ZhbHVlIGZ1bmN0aW9uOwogICAgIENh bGxEYXRhIGNhbGxEYXRhOwogICAgIENhbGxUeXBlIGNhbGxUeXBlID0gQ2FsbFR5cGU6Ok5vbmU7 CkBAIC02MCw2ICs2MiwxMiBAQCBKU1ZhbHVlIEpTQ2FsbGJhY2tEYXRhOjppbnZva2VDYWxsYmFj ayhKCiAKICAgICAgICAgQVNTRVJUKCFmdW5jdGlvbk5hbWUuaXNOdWxsKCkpOwogICAgICAgICBm dW5jdGlvbiA9IGNhbGxiYWNrLT5nZXQoZXhlYywgZnVuY3Rpb25OYW1lKTsKKyAgICAgICAgaWYg KFVOTElLRUxZKHNjb3BlLmV4Y2VwdGlvbigpKSkgeworICAgICAgICAgICAgcmV0dXJuZWRFeGNl cHRpb24gPSBzY29wZS5leGNlcHRpb24oKTsKKyAgICAgICAgICAgIHNjb3BlLmNsZWFyRXhjZXB0 aW9uKCk7CisgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZSgpOworICAgICAgICB9CisKICAgICAg ICAgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YSh2bSwgZnVuY3Rpb24sIGNhbGxEYXRhKTsKICAgICAg ICAgaWYgKGNhbGxUeXBlID09IENhbGxUeXBlOjpOb25lKSB7CiAgICAgICAgICAgICByZXR1cm5l ZEV4Y2VwdGlvbiA9IEpTQzo6RXhjZXB0aW9uOjpjcmVhdGUodm0sIGNyZWF0ZVR5cGVFcnJvcihl eGVjKSk7CkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODcw NikKKysrIExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMiBAQAorMjAxOS0wOC0xNCAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVz aEBnbWFpbC5jb20+CisKKyAgICAgICAgRXJyb3IgdGhyb3duIGR1cmluZyAiYWNjZXB0Tm9kZSIg bG9va3VwIGlzIG92ZXJyaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMDczNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS90cmF2ZXJzYWwvVHJlZVdhbGtl ci1hY2NlcHROb2RlLWZpbHRlci1leHBlY3RlZC50eHQ6CisKIDIwMTktMDgtMTQgIEFsZXhleSBT aHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFJlLXN5bmMgd2ViLXBs YXRmb3JtLXRlc3RzL2RvbS90cmF2ZXJzYWwgZnJvbSB1cHN0cmVhbQpJbmRleDogTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vdHJhdmVyc2FsL1RyZWVXYWxr ZXItYWNjZXB0Tm9kZS1maWx0ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL3RyYXZlcnNhbC9UcmVlV2Fs a2VyLWFjY2VwdE5vZGUtZmlsdGVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjQ4NzA1KQorKysg TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vdHJhdmVyc2Fs L1RyZWVXYWxrZXItYWNjZXB0Tm9kZS1maWx0ZXItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC03LDcgKzcsNyBAQCBQQVNTIFRlc3Rpbmcgd2l0aCBvYmplY3QgbGFja2luZyBhY2NlcHRO CiBQQVNTIFRlc3Rpbmcgd2l0aCBvYmplY3Qgd2l0aCBub24tZnVuY3Rpb24gYWNjZXB0Tm9kZSBw cm9wZXJ0eSAKIFBBU1MgVGVzdGluZyB3aXRoIGZ1bmN0aW9uIGhhdmluZyBhY2NlcHROb2RlIGZ1 bmN0aW9uIAogUEFTUyBUZXN0aW5nIHdpdGggZmlsdGVyIGZ1bmN0aW9uIHRoYXQgdGhyb3dzIAot RkFJTCByZXRocm93cyBlcnJvcnMgd2hlbiBnZXR0aW5nIGBhY2NlcHROb2RlYCBhc3NlcnRfdGhy b3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyB3YWxrZXIuZmlyc3RDaGlsZCgpOyB9IiB0aHJl dyBvYmplY3QgIlR5cGVFcnJvcjogVHlwZSBlcnJvciIgKCJUeXBlRXJyb3IiKSBleHBlY3RlZCBv YmplY3QgIltvYmplY3QgT2JqZWN0XSIgKCJ0ZXN0IikKK1BBU1MgcmV0aHJvd3MgZXJyb3JzIHdo ZW4gZ2V0dGluZyBgYWNjZXB0Tm9kZWAgCiBQQVNTIHBlcmZvcm1zIGBHZXRgIG9uIGV2ZXJ5IHRy YXZlcnNlIAogUEFTUyBUZXN0aW5nIHdpdGggZmlsdGVyIG9iamVjdCB0aGF0IHRocm93cyAKIFRl c3QgSlMgb2JqZWN0cyBhcyBOb2RlRmlsdGVycwo=