200708 2019-08-14 02:41:03 -0700 Remove use of emptySessionID from WebPageCreationParameters 2019-08-14 10:18:18 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200669 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1561113 0 youennf 2019-08-14 02:41:03 -0700 Remove use of SessionID::emptyString from WebPageCreationParameters 1561115 1 376254 youennf 2019-08-14 02:48:20 -0700 Created attachment 376254 Patch 1561220 2 376254 commit-queue 2019-08-14 10:17:05 -0700 Comment on attachment 376254 Patch Clearing flags on attachment: 376254 Committed r248675: <https://trac.webkit.org/changeset/248675> 1561221 3 commit-queue 2019-08-14 10:17:06 -0700 All reviewed patches have been landed. Closing bug. 1561222 4 webkit-bug-importer 2019-08-14 10:18:18 -0700 <rdar://problem/54307070> 376254 2019-08-14 02:48:20 -0700 2019-08-14 10:17:05 -0700 Patch bug-200708-20190814114819.patch text/plain 5225 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZiNWI5ZDE3MjY2MGM0YjI5 N2EwNjZhYWNiMjYyZTdkYjcxMjJiZDUuLjg5ODdiYWQyNDkwOWFlOWY3ODlmNTRjMWVhMTY2MDQ5 NzFhODM5OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDgtMTQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB1c2Ugb2YgZW1wdHlT ZXNzaW9uSUQgZnJvbSBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA3MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFdlYlBhZ2VDcmVhdGlvblBhcmFt ZXRlcnMgY29uc3RydWN0b3IgdGFrZSBhIFNlc3Npb25JRC4KKyAgICAgICAgVXBkYXRlIGNvbnN0 cnVjdG9yIGNhbGwgc2l0ZXMuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFy YW1ldGVycy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnM6 OmRlY29kZSk6CisgICAgICAgICogU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMuaDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6V2ViUGFnZUNyZWF0 aW9uUGFyYW1ldGVycyk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6bWF5YmVJbml0aWFsaXplU2FuZGJveEV4dGVu c2lvbkhhbmRsZSk6CisKIDIwMTktMDgtMTMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZSBTZXNzaW9uSUQgZGVmYXVsdCBjb25zdHJ1Y3RvcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5j cHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcApp bmRleCBkNmFiNGU3NTcxMmEzNzI2NTRmOTA2OWI1NjU0ZjZkMjUwNWEwMjk0Li5lYzMyMzkzZmE3 NmMxYmYwMjlkMjY5MjM4ZjMxZTM2Y2I2NGUwMmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcApAQCAtMzIsNiArMzIsNyBAQCBu YW1lc3BhY2UgV2ViS2l0IHsKIAogdm9pZCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOjplbmNv ZGUoSVBDOjpFbmNvZGVyJiBlbmNvZGVyKSBjb25zdAogeworICAgIGVuY29kZXIgPDwgc2Vzc2lv bklEOwogICAgIGVuY29kZXIgPDwgdmlld1NpemU7CiAgICAgZW5jb2RlciA8PCBhY3Rpdml0eVN0 YXRlOwogCkBAIC01Miw3ICs1Myw2IEBAIHZvaWQgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6 ZW5jb2RlKElQQzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKICAgICBlbmNvZGVyIDw8IHBhZ2lu YXRpb25MaW5lR3JpZEVuYWJsZWQ7CiAgICAgZW5jb2RlciA8PCB1c2VyQWdlbnQ7CiAgICAgZW5j b2RlciA8PCBpdGVtU3RhdGVzOwotICAgIGVuY29kZXIgPDwgc2Vzc2lvbklEOwogICAgIGVuY29k ZXIgPDwgdXNlckNvbnRlbnRDb250cm9sbGVySUQ7CiAgICAgZW5jb2RlciA8PCB2aXNpdGVkTGlu a1RhYmxlSUQ7CiAgICAgZW5jb2RlciA8PCB3ZWJzaXRlRGF0YVN0b3JlSUQ7CkBAIC0xMzcsNyAr MTM3LDEzIEBAIHZvaWQgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2RlKElQQzo6RW5j b2RlciYgZW5jb2RlcikgY29uc3QKIAogT3B0aW9uYWw8V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVy cz4gV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVyczo6ZGVjb2RlKElQQzo6RGVjb2RlciYgZGVjb2Rl cikKIHsKLSAgICBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CisgICAgT3B0 aW9uYWw8UEFMOjpTZXNzaW9uSUQ+IHNlc3Npb25JRDsKKyAgICBkZWNvZGVyID4+IHNlc3Npb25J RDsKKyAgICBpZiAoIXNlc3Npb25JRCkKKyAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKKwor ICAgIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgcGFyYW1ldGVycyB7ICpzZXNzaW9uSUQgfTsK KwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUocGFyYW1ldGVycy52aWV3U2l6ZSkpCiAgICAgICAg IHJldHVybiBXVEY6Om51bGxvcHQ7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShwYXJhbWV0ZXJz LmFjdGl2aXR5U3RhdGUpKQpAQCAtMTkxLDkgKzE5Nyw2IEBAIE9wdGlvbmFsPFdlYlBhZ2VDcmVh dGlvblBhcmFtZXRlcnM+IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnM6OmRlY29kZShJUEM6OkRl Y29kCiAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAgICAgcGFyYW1ldGVycy5pdGVtU3Rh dGVzID0gV1RGTW92ZSgqaXRlbVN0YXRlcyk7CiAKLSAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHBh cmFtZXRlcnMuc2Vzc2lvbklEKSkKLSAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKLQogICAg IE9wdGlvbmFsPFVzZXJDb250ZW50Q29udHJvbGxlcklkZW50aWZpZXI+IHVzZXJDb250ZW50Q29u dHJvbGxlcklkZW50aWZpZXI7CiAgICAgZGVjb2RlciA+PiB1c2VyQ29udGVudENvbnRyb2xsZXJJ ZGVudGlmaWVyOwogICAgIGlmICghdXNlckNvbnRlbnRDb250cm9sbGVySWRlbnRpZmllcikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMu aCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMuaAppbmRl eCBhOTUxYzYwZmYyOWI4NDhhMjFiYWFjOGZkOTMwODVhYjU3ZjJiMzZhLi5lMTlkOTk2YTE2M2I1 NTMwMjBhYzUxMjUyOWZmZmRkZjA1NTc3YTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oCkBAIC02NCw5ICs2NCwxNSBAQCBjbGFzcyBF bmNvZGVyOwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0cnVjdCBXZWJQYWdlQ3JlYXRpb25QYXJh bWV0ZXJzIHsKKyAgICBleHBsaWNpdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzKFBBTDo6U2Vz c2lvbklEIHNlc3Npb25JRCkKKyAgICAgICAgOiBzZXNzaW9uSUQoc2Vzc2lvbklEKQorICAgIHsK KyAgICB9CisKICAgICB2b2lkIGVuY29kZShJUEM6OkVuY29kZXImKSBjb25zdDsKICAgICBzdGF0 aWMgT3B0aW9uYWw8V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycz4gZGVjb2RlKElQQzo6RGVjb2Rl ciYpOwogCisgICAgUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEOwogICAgIFdlYkNvcmU6OkludFNp emUgdmlld1NpemU7CiAKICAgICBPcHRpb25TZXQ8V2ViQ29yZTo6QWN0aXZpdHlTdGF0ZTo6Rmxh Zz4gYWN0aXZpdHlTdGF0ZTsKQEAgLTk3LDcgKzEwMyw2IEBAIHN0cnVjdCBXZWJQYWdlQ3JlYXRp b25QYXJhbWV0ZXJzIHsKICAgICBTdHJpbmcgdXNlckFnZW50OwogCiAgICAgVmVjdG9yPEJhY2tG b3J3YXJkTGlzdEl0ZW1TdGF0ZT4gaXRlbVN0YXRlczsKLSAgICBQQUw6OlNlc3Npb25JRCBzZXNz aW9uSUQgeyBQQUw6OlNlc3Npb25JRDo6ZW1wdHlTZXNzaW9uSUQoKSB9OwogCiAgICAgVXNlckNv bnRlbnRDb250cm9sbGVySWRlbnRpZmllciB1c2VyQ29udGVudENvbnRyb2xsZXJJRDsKICAgICB1 aW50NjRfdCB2aXNpdGVkTGlua1RhYmxlSUQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAppbmRleCA3ZmEyYjRkNmQzYzE2NjFhNzAwM2I3Nzg1NThkYTdjMmZmMjRmMDdl Li4zMjYzMWM0NTBlYjI2ZDc1NDU0NjhiNzI2YzE1YTQ0OTg1Yzk5OGE5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTcxNjksNyArNzE2OSw3IEBAIHZvaWQg V2ViUGFnZVByb3h5OjpyZXNldFN0YXRlQWZ0ZXJQcm9jZXNzRXhpdGVkKFByb2Nlc3NUZXJtaW5h dGlvblJlYXNvbiB0ZXJtaW5hCiAKIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgV2ViUGFnZVBy b3h5OjpjcmVhdGlvblBhcmFtZXRlcnMoV2ViUHJvY2Vzc1Byb3h5JiBwcm9jZXNzLCBEcmF3aW5n QXJlYVByb3h5JiBkcmF3aW5nQXJlYSkKIHsKLSAgICBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJz IHBhcmFtZXRlcnM7CisgICAgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyBwYXJhbWV0ZXJzIHsg cHJvY2Vzcy53ZWJzaXRlRGF0YVN0b3JlKCkuc2Vzc2lvbklEKCkgfTsKIAogICAgIHBhcmFtZXRl cnMudmlld1NpemUgPSBwYWdlQ2xpZW50KCkudmlld1NpemUoKTsKICAgICBwYXJhbWV0ZXJzLmFj dGl2aXR5U3RhdGUgPSBtX2FjdGl2aXR5U3RhdGU7CkBAIC03MTkxLDcgKzcxOTEsNiBAQCBXZWJQ YWdlQ3JlYXRpb25QYXJhbWV0ZXJzIFdlYlBhZ2VQcm94eTo6Y3JlYXRpb25QYXJhbWV0ZXJzKFdl YlByb2Nlc3NQcm94eSYgcHJvYwogICAgIHBhcmFtZXRlcnMucGFnaW5hdGlvbkxpbmVHcmlkRW5h YmxlZCA9IG1fcGFnaW5hdGlvbkxpbmVHcmlkRW5hYmxlZDsKICAgICBwYXJhbWV0ZXJzLnVzZXJB Z2VudCA9IHVzZXJBZ2VudCgpOwogICAgIHBhcmFtZXRlcnMuaXRlbVN0YXRlcyA9IG1fYmFja0Zv cndhcmRMaXN0LT5pdGVtU3RhdGVzKCk7Ci0gICAgcGFyYW1ldGVycy5zZXNzaW9uSUQgPSBwcm9j ZXNzLndlYnNpdGVEYXRhU3RvcmUoKS5zZXNzaW9uSUQoKTsKICAgICBwYXJhbWV0ZXJzLnVzZXJD b250ZW50Q29udHJvbGxlcklEID0gbV91c2VyQ29udGVudENvbnRyb2xsZXItPmlkZW50aWZpZXIo KTsKICAgICBwYXJhbWV0ZXJzLnZpc2l0ZWRMaW5rVGFibGVJRCA9IG1fdmlzaXRlZExpbmtTdG9y ZS0+aWRlbnRpZmllcigpOwogICAgIHBhcmFtZXRlcnMud2Vic2l0ZURhdGFTdG9yZUlEID0gcHJv Y2Vzcy53ZWJzaXRlRGF0YVN0b3JlKCkuaWRlbnRpZmllcigpOwo=