200704 2019-08-14 01:22:38 -0700 Web Inspector: Uncaught Exception: Content request failed. 2019-08-15 10:15:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://aestes.github.io/WorkerWebSocket/ InRadar P2 Normal --- 1 hi hi bburg commit-queue greggy hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1561092 0 hi 2019-08-14 01:22:38 -0700 Hit this on a ToT debug build when clicking websocket.js in the Resources tab. Content request failed. (at Resource.js:​835:​40)​ requestContentFromBackend @ Resource.js:​835:​40 requestContent @ SourceCode.js:​140:​100 _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​367:​38 ResourceClusterContentView @ ResourceClusterContentView.js:​71:​49 createFromRepresentedObject @ ContentView.js:​52:​53 contentViewForRepresentedObject @ ContentView.js:​211:​72 showContentViewForRepresentedObject @ ContentBrowser.js:​151:​63 showRepresentedObject @ ContentBrowserTabContentView.js:​230:​64 ?​ @ Main.js:​1331:​41 _treeSelectionDidChange @ ResourceSidebarPanel.js:​487:​37 dispatch @ Object.js:​165:​30 dispatchEventToListeners @ Object.js:​172:​17 _dispatchSelectionDidChangeEvent @ TreeOutline.js:​1136:​38 selectionControllerSelectionDidChange @ TreeOutline.js:​813:​46 _updateSelectedItems @ SelectionController.js:​392:​65 selectItem @ SelectionController.js:​97:​34 handleItemMouseDown @ SelectionController.js:​258:​28 _handleMouseDown @ TreeOutline.js:​1122:​54 _handleMouseDown @ [native code] 1561093 1 hi 2019-08-14 01:22:49 -0700 <rdar://problem/54279372> 1561094 2 376247 hi 2019-08-14 01:23:54 -0700 Created attachment 376247 Patch 1561096 3 376247 greggy 2019-08-14 01:35:09 -0700 Comment on attachment 376247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review > Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:92 > + console.assert(false, "A WebSocket itself has no content, and should never be requested of as such."); "A WebSocket's content was requested. WebSockets do not have content so the request is nonsensical." 1561159 4 376247 bburg 2019-08-14 08:17:34 -0700 Comment on attachment 376247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review r=me >> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:92 >> + console.assert(false, "A WebSocket itself has no content, and should never be requested of as such."); > > "A WebSocket's content was requested. WebSockets do not have content so the request is nonsensical." +1 to Greg's wording :) > Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:369 > + return; It would be nice to hook the websocket "response" view into the custom view machinery, but not necessary to fix this bug. 1561167 5 376247 hi 2019-08-14 08:56:05 -0700 Comment on attachment 376247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review >> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:369 >> + return; > > It would be nice to hook the websocket "response" view into the custom view machinery, but not necessary to fix this bug. It's already used by the "regular" response view above in `_contentViewForResourceType`. I see a difference between the "regular" response view and the "custom" response view. The "regular" view is something that's immediately deducible just from the resource type (e.g. an image should be displayed differently than text), whereas the "custom" view is for special situations where some aspect of the resource warrants additional UI (e.g. text is actually JSON content). We already do something like this for SVG images (I would argue that that's more of a special case though because I'd consider an SVG image to be _both_ textual and graphical, so even though showing both is "custom", I don't think it would fit here). In the case of WebSocket, I could see us creating (either here or making `WI.WebSocketContentView` into a cluster like SVG images) a JSON view where all frames are automatically shown as JSON views instead, but I'm not sure how common JSON is for frames (e.g. socket.io has it's own format). 1561169 6 376267 hi 2019-08-14 08:57:40 -0700 Created attachment 376267 Patch 1561206 7 376247 joepeck 2019-08-14 10:03:47 -0700 Comment on attachment 376247 Patch Nice! 1561591 8 376267 commit-queue 2019-08-15 10:15:22 -0700 Comment on attachment 376267 Patch Clearing flags on attachment: 376267 Committed r248720: <https://trac.webkit.org/changeset/248720> 1561592 9 commit-queue 2019-08-15 10:15:23 -0700 All reviewed patches have been landed. Closing bug. 376247 2019-08-14 01:23:54 -0700 2019-08-14 08:57:40 -0700 Patch 200704.diff text/plain 2813 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4ZjMzNDBkNjgzLi5mNzE3NDNlOGM5NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDgtMTQgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVu Y2F1Z2h0IEV4Y2VwdGlvbjogQ29udGVudCByZXF1ZXN0IGZhaWxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDcwNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTQyNzkzNzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qczoK KyAgICAgICAgKFdJLldlYlNvY2tldFJlc291cmNlLnByb3RvdHlwZS5yZXF1ZXN0Q29udGVudEZy b21CYWNrZW5kKTogQWRkZWQuCisgICAgICAgIEFkZCBhbiAiYXNzZXJ0IG5vdCByZWFjaGVkIiwg YXMgV2ViU29ja2V0IHJlc291cmNlcyBkb24ndCByZWFsbHkgaGF2ZSAiY29udGVudCIsIGluc3Rl YWQKKyAgICAgICAgaGF2aW5nIGEgbGlzdCBvZiBzZW5kL3JlY2VpdmUgZnJhbWVzLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qczoK KyAgICAgICAgKFdJLlJlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LnByb3RvdHlwZS5fdHJ5RW5h YmxlQ3VzdG9tUmVzcG9uc2VDb250ZW50Vmlldyk6CisgICAgICAgIERvbid0IGF0dGVtcHQgdG8g cmVxdWVzdCB0aGUgY29udGVudCBvZiBhbnkgYFdJLldlYlNvY2tldFJlc291cmNlYCBmb3IgdGhl IHJlYXNvbiBhYm92ZS4KKwogMjAxOS0wOC0xMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjQ4MzkxKTogV2ViIEluc3BlY3RvcjogY2hh bmdpbmcgTGF5b3V0IERpcmVjdGlvbiBEZWJ1ZyBzZXR0aW5nIG5vIGxvbmdlciBhZGRzIGRpcj0i bHRyIiB0byBib2R5IGVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qcwppbmRleCBk N2NhZjllZjgwMS4uYTcyNzIyOTdmMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvV2ViU29ja2V0UmVzb3VyY2UuanMK QEAgLTg1LDYgKzg1LDE1IEBAIFdJLldlYlNvY2tldFJlc291cmNlID0gY2xhc3MgV2ViU29ja2V0 UmVzb3VyY2UgZXh0ZW5kcyBXSS5SZXNvdXJjZQogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRU b0xpc3RlbmVycyhXSS5XZWJTb2NrZXRSZXNvdXJjZS5FdmVudC5GcmFtZUFkZGVkLCBmcmFtZSk7 CiAgICAgfQogCisgICAgLy8gUHJvdGVjdGVkCisKKyAgICByZXF1ZXN0Q29udGVudEZyb21CYWNr ZW5kKCkKKyAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGZhbHNlLCAiQSBXZWJTb2NrZXQg aXRzZWxmIGhhcyBubyBjb250ZW50LCBhbmQgc2hvdWxkIG5ldmVyIGJlIHJlcXVlc3RlZCBvZiBh cyBzdWNoLiIpOworCisgICAgICAgIHJldHVybiBzdXBlci5yZXF1ZXN0Q29udGVudEZyb21CYWNr ZW5kKCk7CisgICAgfQorCiAgICAgLy8gUHJpdmF0ZQogCiAgICAgX3dhbGx0aW1lRm9yV2ViU29j a2V0VGltZXN0YW1wKHRpbWVzdGFtcCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDbHVzdGVyQ29u dGVudFZpZXcuanMKaW5kZXggYzFiZWFjYjkwNjguLjQzNTA1MDhiYzg2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qcwpAQCAtMzY0LDYgKzM2NCwxMCBAQCBX SS5SZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyA9IGNsYXNzIFJlc291cmNlQ2x1c3RlckNvbnRl bnRWaWV3IGV4dGVuZHMgV0kuQ2x1cwogICAgICAgICBpZiAoIXRoaXMuX3Jlc291cmNlLmhhc1Jl c3BvbnNlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgLy8gV2ViU29ja2V0IHJl c291cmNlcyBhbHJlYWR5IHVzZSBhICJjdXN0b20iIHJlc3BvbnNlIGNvbnRlbnQgdmlldy4KKyAg ICAgICAgaWYgKHRoaXMuX3Jlc291cmNlIGluc3RhbmNlb2YgV0kuV2ViU29ja2V0UmVzb3VyY2Up CisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdGhpcy5fcmVzb3VyY2UucmVxdWVzdENv bnRlbnQoKQogICAgICAgICAudGhlbigoe2Vycm9yLCBjb250ZW50fSkgPT4gewogICAgICAgICAg ICAgaWYgKGVycm9yIHx8ICFjb250ZW50IHx8ICF0aGlzLl9jYW5Vc2VKU09OQ29udGVudFZpZXdG b3JDb250ZW50KGNvbnRlbnQpKQo= 376267 2019-08-14 08:57:40 -0700 2019-08-15 10:15:22 -0700 Patch 200704.diff text/plain 2831 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg4ZjMzNDBkNjgzLi5mNzE3NDNlOGM5NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDgtMTQgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVu Y2F1Z2h0IEV4Y2VwdGlvbjogQ29udGVudCByZXF1ZXN0IGZhaWxlZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDcwNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTQyNzkzNzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJpYW4gQnVyZy4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNlLmpzOgorICAg ICAgICAoV0kuV2ViU29ja2V0UmVzb3VyY2UucHJvdG90eXBlLnJlcXVlc3RDb250ZW50RnJvbUJh Y2tlbmQpOiBBZGRlZC4KKyAgICAgICAgQWRkIGFuICJhc3NlcnQgbm90IHJlYWNoZWQiLCBhcyBX ZWJTb2NrZXQgcmVzb3VyY2VzIGRvbid0IHJlYWxseSBoYXZlICJjb250ZW50IiwgaW5zdGVhZAor ICAgICAgICBoYXZpbmcgYSBsaXN0IG9mIHNlbmQvcmVjZWl2ZSBmcmFtZXMuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV0kuUmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcucHJvdG90eXBlLl90cnlFbmFibGVD dXN0b21SZXNwb25zZUNvbnRlbnRWaWV3KToKKyAgICAgICAgRG9uJ3QgYXR0ZW1wdCB0byByZXF1 ZXN0IHRoZSBjb250ZW50IG9mIGFueSBgV0kuV2ViU29ja2V0UmVzb3VyY2VgIGZvciB0aGUgcmVh c29uIGFib3ZlLgorCiAyMDE5LTA4LTEyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDgzOTEpOiBXZWIgSW5zcGVjdG9yOiBjaGFuZ2lu ZyBMYXlvdXQgRGlyZWN0aW9uIERlYnVnIHNldHRpbmcgbm8gbG9uZ2VyIGFkZHMgZGlyPSJsdHIi IHRvIGJvZHkgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNlLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNlLmpzCmluZGV4IGQ3Y2Fm OWVmODAxLi5hNzI3MjI5N2YxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL1dlYlNvY2tldFJlc291cmNlLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9XZWJTb2NrZXRSZXNvdXJjZS5qcwpAQCAt ODUsNiArODUsMTUgQEAgV0kuV2ViU29ja2V0UmVzb3VyY2UgPSBjbGFzcyBXZWJTb2NrZXRSZXNv dXJjZSBleHRlbmRzIFdJLlJlc291cmNlCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlz dGVuZXJzKFdJLldlYlNvY2tldFJlc291cmNlLkV2ZW50LkZyYW1lQWRkZWQsIGZyYW1lKTsKICAg ICB9CiAKKyAgICAvLyBQcm90ZWN0ZWQKKworICAgIHJlcXVlc3RDb250ZW50RnJvbUJhY2tlbmQo KQorICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoZmFsc2UsICJBIFdlYlNvY2tldCdzIGNv bnRlbnQgd2FzIHJlcXVlc3RlZC4gV2ViU29ja2V0cyBkbyBub3QgaGF2ZSBjb250ZW50IHNvIHRo ZSByZXF1ZXN0IGlzIG5vbnNlbnNpY2FsLiIpOworCisgICAgICAgIHJldHVybiBzdXBlci5yZXF1 ZXN0Q29udGVudEZyb21CYWNrZW5kKCk7CisgICAgfQorCiAgICAgLy8gUHJpdmF0ZQogCiAgICAg X3dhbGx0aW1lRm9yV2ViU29ja2V0VGltZXN0YW1wKHRpbWVzdGFtcCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcuanMKaW5kZXggYzFiZWFjYjkwNjguLjQzNTA1MDhi Yzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qcwpAQCAt MzY0LDYgKzM2NCwxMCBAQCBXSS5SZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyA9IGNsYXNzIFJl c291cmNlQ2x1c3RlckNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ2x1cwogICAgICAgICBpZiAoIXRo aXMuX3Jlc291cmNlLmhhc1Jlc3BvbnNlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAg ICAgLy8gV2ViU29ja2V0IHJlc291cmNlcyBhbHJlYWR5IHVzZSBhICJjdXN0b20iIHJlc3BvbnNl IGNvbnRlbnQgdmlldy4KKyAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlIGluc3RhbmNlb2YgV0ku V2ViU29ja2V0UmVzb3VyY2UpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdGhpcy5f cmVzb3VyY2UucmVxdWVzdENvbnRlbnQoKQogICAgICAgICAudGhlbigoe2Vycm9yLCBjb250ZW50 fSkgPT4gewogICAgICAgICAgICAgaWYgKGVycm9yIHx8ICFjb250ZW50IHx8ICF0aGlzLl9jYW5V c2VKU09OQ29udGVudFZpZXdGb3JDb250ZW50KGNvbnRlbnQpKQo=