200701 2019-08-13 21:33:02 -0700 [LFC][TFC] Implement TableFormattingContext::computePreferredWidthForColumns 2019-08-14 08:39:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1561063 0 zalan 2019-08-13 21:33:02 -0700 This is just the first part though. 1561064 1 webkit-bug-importer 2019-08-13 21:33:31 -0700 <rdar://problem/54287828> 1561067 2 376236 zalan 2019-08-13 21:43:12 -0700 Created attachment 376236 Patch 1561162 3 376236 commit-queue 2019-08-14 08:39:29 -0700 Comment on attachment 376236 Patch Clearing flags on attachment: 376236 Committed r248671: <https://trac.webkit.org/changeset/248671> 1561163 4 commit-queue 2019-08-14 08:39:31 -0700 All reviewed patches have been landed. Closing bug. 376236 2019-08-13 21:43:12 -0700 2019-08-14 08:39:29 -0700 Patch bug-200701-20190813214311.patch text/plain 5648 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjM1ZTg3ODJmZjIwNmJh NWU2NjBmMTUzOTliYjFjODJmNWI2Y2MyNS4uYzViMTA0MDM1MDFhN2RiMTI5YWM2ODEyMGVjMDli NDNiMmJjOTcyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA4LTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bVEZDXSBJbXBsZW1l bnQgVGFibGVGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZVByZWZlcnJlZFdpZHRoRm9yQ29sdW1u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNzAx CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDI4NzgyOD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21wdXRlIGNlbGxzJyBtaW4vbWF4IHdpZHRo IGZpcnN0LgorCisgICAgICAgICogbGF5b3V0L3RhYmxlZm9ybWF0dGluZy9UYWJsZUZvcm1hdHRp bmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6VGFibGVGb3JtYXR0aW5n Q29udGV4dDo6Y29tcHV0ZVByZWZlcnJlZFdpZHRoRm9yQ29sdW1ucyBjb25zdCk6CisgICAgICAg ICogbGF5b3V0L3RhYmxlZm9ybWF0dGluZy9UYWJsZUdyaWQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpUYWJsZUdyaWQ6OnNsb3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpU YWJsZUdyaWQ6OmFwcGVuZENlbGwpOgorICAgICAgICAqIGxheW91dC90YWJsZWZvcm1hdHRpbmcv VGFibGVHcmlkLmg6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRhYmxlR3JpZDo6Y2VsbHMp OgorCiAyMDE5LTA4LTEzICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2Ugc3VyZSBVbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb24gdW5yZWdpc3RlciBpdHNl bGYgZnJvbSBJREJTZXJ2ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC90YWJs ZWZvcm1hdHRpbmcvVGFibGVGb3JtYXR0aW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvdGFibGVmb3JtYXR0aW5nL1RhYmxlRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDM0 MDRkYmYzMGQxYmFjYmQ2OGIyMjA0ZTcyZWNmMWQxN2MzNjdlNDYuLmU1YTNhMDI1YmVjMDQ5ZTRh Y2FkMjI3ZjNkYTcwMmI3ZTllMThlMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC90YWJsZWZvcm1hdHRpbmcvVGFibGVGb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L3RhYmxlZm9ybWF0dGluZy9UYWJsZUZvcm1hdHRpbmdDb250ZXh0LmNw cApAQCAtODUsNiArODUsMjUgQEAgdm9pZCBUYWJsZUZvcm1hdHRpbmdDb250ZXh0OjplbnN1cmVU YWJsZUdyaWQoKSBjb25zdAogCiB2b2lkIFRhYmxlRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVQ cmVmZXJyZWRXaWR0aEZvckNvbHVtbnMoKSBjb25zdAogeworICAgIGF1dG8mIGZvcm1hdHRpbmdT dGF0ZSA9IHRoaXMtPmZvcm1hdHRpbmdTdGF0ZSgpOworICAgIGF1dG8mIGdyaWQgPSBmb3JtYXR0 aW5nU3RhdGUudGFibGVHcmlkKCk7CisKKyAgICAvLyAxLiBDYWxjdWxhdGUgdGhlIG1pbmltdW0g Y29udGVudCB3aWR0aCAoTUNXKSBvZiBlYWNoIGNlbGw6IHRoZSBmb3JtYXR0ZWQgY29udGVudCBt YXkgc3BhbiBhbnkgbnVtYmVyIG9mIGxpbmVzIGJ1dCBtYXkgbm90IG92ZXJmbG93IHRoZSBjZWxs IGJveC4KKyAgICAvLyAgICBJZiB0aGUgc3BlY2lmaWVkICd3aWR0aCcgKFcpIG9mIHRoZSBjZWxs IGlzIGdyZWF0ZXIgdGhhbiBNQ1csIFcgaXMgdGhlIG1pbmltdW0gY2VsbCB3aWR0aC4gQSB2YWx1 ZSBvZiAnYXV0bycgbWVhbnMgdGhhdCBNQ1cgaXMgdGhlIG1pbmltdW0gY2VsbCB3aWR0aC4KKyAg ICAvLyAgICBBbHNvLCBjYWxjdWxhdGUgdGhlICJtYXhpbXVtIiBjZWxsIHdpZHRoIG9mIGVhY2gg Y2VsbDogZm9ybWF0dGluZyB0aGUgY29udGVudCB3aXRob3V0IGJyZWFraW5nIGxpbmVzIG90aGVy IHRoYW4gd2hlcmUgZXhwbGljaXQgbGluZSBicmVha3Mgb2NjdXIuCisgICAgZm9yIChhdXRvJiBj ZWxsIDogZ3JpZC5jZWxscygpKSB7CisgICAgICAgIEFTU0VSVChjZWxsLT50YWJsZUNlbGxCb3gu ZXN0YWJsaXNoZXNGb3JtYXR0aW5nQ29udGV4dCgpKTsKKworICAgICAgICBhdXRvIGludHJpbnNp Y1dpZHRoID0gbGF5b3V0U3RhdGUoKS5jcmVhdGVGb3JtYXR0aW5nQ29udGV4dChjZWxsLT50YWJs ZUNlbGxCb3gpLT5jb21wdXRlZEludHJpbnNpY1dpZHRoQ29uc3RyYWludHMoKTsKKyAgICAgICAg aW50cmluc2ljV2lkdGggPSBHZW9tZXRyeTo6Y29uc3RyYWluQnlNaW5NYXhXaWR0aChjZWxsLT50 YWJsZUNlbGxCb3gsIGludHJpbnNpY1dpZHRoKTsKKyAgICAgICAgZm9ybWF0dGluZ1N0YXRlLnNl dEludHJpbnNpY1dpZHRoQ29uc3RyYWludHMoaW50cmluc2ljV2lkdGgpOworCisgICAgICAgIGF1 dG8gY29sdW1uU3BhbiA9IGNlbGwtPnNpemUud2lkdGgoKTsKKyAgICAgICAgYXV0byBzbG90SW50 cmluc2ljV2lkdGggPSBGb3JtYXR0aW5nQ29udGV4dDo6SW50cmluc2ljV2lkdGhDb25zdHJhaW50 cyB7IGludHJpbnNpY1dpZHRoLm1pbmltdW0gLyBjb2x1bW5TcGFuLCBpbnRyaW5zaWNXaWR0aC5t YXhpbXVtIC8gY29sdW1uU3BhbiB9OworICAgICAgICBhdXRvIGluaXRpYWxQb3NpdGlvbiA9IGNl bGwtPnBvc2l0aW9uOworICAgICAgICBmb3IgKGF1dG8gaSA9IDA7IGkgPCBjb2x1bW5TcGFuOyAr K2kpCisgICAgICAgICAgICBncmlkLnNsb3QoeyBpbml0aWFsUG9zaXRpb24ueCgpICsgaSwgaW5p dGlhbFBvc2l0aW9uLnkoKSB9KS0+d2lkdGhDb25zdHJhaW50cyA9IHNsb3RJbnRyaW5zaWNXaWR0 aDsKKyAgICB9CiB9CiAKIHZvaWQgVGFibGVGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZVRhYmxl V2lkdGgoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L3RhYmxlZm9y bWF0dGluZy9UYWJsZUdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L3RhYmxlZm9ybWF0 dGluZy9UYWJsZUdyaWQuY3BwCmluZGV4IGExOTgzNTJlNzQxNTkwNWU1ZTZiZmM2MGRjNmE2NjIx NTgwMDkyYWEuLmM3YWUzZTU4MTBkNjAyZjY1ZWI3MDAyZmZlOWM1MmJmYzVjMDAwYTUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC90YWJsZWZvcm1hdHRpbmcvVGFibGVHcmlkLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvdGFibGVmb3JtYXR0aW5nL1RhYmxlR3JpZC5j cHAKQEAgLTUxLDYgKzUxLDExIEBAIFRhYmxlR3JpZDo6VGFibGVHcmlkKCkKIHsKIH0KIAorVGFi bGVHcmlkOjpTbG90SW5mbyogVGFibGVHcmlkOjpzbG90KFNsb3RQb3NpdGlvbiBwb3NpdGlvbikK K3sKKyAgICByZXR1cm4gbV9zbG90TWFwLmdldChwb3NpdGlvbik7Cit9CisKIHZvaWQgVGFibGVH cmlkOjphcHBlbmRDZWxsKGNvbnN0IEJveCYgdGFibGVDZWxsQm94KQogewogICAgIGludCByb3dT cGFuID0gdGFibGVDZWxsQm94LnJvd1NwYW4oKTsKQEAgLTc5LDcgKzg0LDcgQEAgdm9pZCBUYWJs ZUdyaWQ6OmFwcGVuZENlbGwoY29uc3QgQm94JiB0YWJsZUNlbGxCb3gpCiAgICAgICAgIGZvciAo aW50IGNvbHVtbiA9IDE7IGNvbHVtbiA8PSBjb2x1bW5TcGFuOyArK2NvbHVtbikgewogICAgICAg ICAgICAgYXV0byBwb3NpdGlvbiA9IFNsb3RQb3NpdGlvbiB7IGluaXRpYWxTbG90UG9zaXRpb24u eCgpICsgcm93IC0gMSwgaW5pdGlhbFNsb3RQb3NpdGlvbi55KCkgKyBjb2x1bW4gLSAxIH07CiAg ICAgICAgICAgICBBU1NFUlQoIW1fc2xvdE1hcC5jb250YWlucyhwb3NpdGlvbikpOwotICAgICAg ICAgICAgbV9zbG90TWFwLmFkZChwb3NpdGlvbiwgU2xvdEluZm8geyAqY2VsbEluZm8gfSk7Cisg ICAgICAgICAgICBtX3Nsb3RNYXAuYWRkKHBvc2l0aW9uLCBzdGQ6Om1ha2VfdW5pcXVlPFNsb3RJ bmZvPigqY2VsbEluZm8pKTsKICAgICAgICAgfQogICAgIH0KICAgICBtX2NlbGxMaXN0LmFkZChX VEZNb3ZlKGNlbGxJbmZvKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvdGFi bGVmb3JtYXR0aW5nL1RhYmxlR3JpZC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L3RhYmxlZm9y bWF0dGluZy9UYWJsZUdyaWQuaAppbmRleCAzYTk4YzZkYjZjM2Q4MTlhNGMyN2NiZDIyMzNhMGIx ZjI4NzVjNmFiLi5iYmIyNzM2Nzc0MTdmOTNiODEzYjAzMzcwM2JjOWRmN2MxMjUxZDg3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvdGFibGVmb3JtYXR0aW5nL1RhYmxlR3JpZC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC90YWJsZWZvcm1hdHRpbmcvVGFibGVHcmlkLmgK QEAgLTQ2LDExICs0Niw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGluc2VydENlbGwoY29uc3QgQm94 JiwgY29uc3QgQm94JiBiZWZvcmUpOwogICAgIHZvaWQgcmVtb3ZlQ2VsbChjb25zdCBCb3gmKTsK IAotcHJpdmF0ZToKICAgICB1c2luZyBTbG90UG9zaXRpb24gPSBJbnRQb2ludDsKICAgICB1c2lu ZyBDZWxsU2l6ZSA9IEludFNpemU7Ci0gICAgdXNpbmcgU2xvdExvZ2ljYWxTaXplID0gTGF5b3V0 U2l6ZTsKLQogICAgIHN0cnVjdCBDZWxsSW5mbyA6IHB1YmxpYyBDYW5NYWtlV2Vha1B0cjxDZWxs SW5mbz4gewogICAgICAgICBDZWxsSW5mbyhjb25zdCBCb3gmIHRhYmxlQ2VsbEJveCwgU2xvdFBv c2l0aW9uLCBDZWxsU2l6ZSk7CiAKQEAgLTU4LDE3ICs1NSwyMiBAQCBwcml2YXRlOgogICAgICAg ICBTbG90UG9zaXRpb24gcG9zaXRpb247CiAgICAgICAgIENlbGxTaXplIHNpemU7CiAgICAgfTsK KyAgICB1c2luZyBDZWxsTGlzdCA9IFdURjo6TGlzdEhhc2hTZXQ8c3RkOjp1bmlxdWVfcHRyPENl bGxJbmZvPj47CisgICAgQ2VsbExpc3QmIGNlbGxzKCkgeyByZXR1cm4gbV9jZWxsTGlzdDsgfQog CisgICAgdXNpbmcgU2xvdExvZ2ljYWxTaXplID0gTGF5b3V0U2l6ZTsKICAgICBzdHJ1Y3QgU2xv dEluZm8gewogICAgICAgICBTbG90SW5mbygpID0gZGVmYXVsdDsKICAgICAgICAgU2xvdEluZm8o Q2VsbEluZm8mKTsKIAogICAgICAgICBXZWFrUHRyPENlbGxJbmZvPiBjZWxsOworICAgICAgICBG b3JtYXR0aW5nQ29udGV4dDo6SW50cmluc2ljV2lkdGhDb25zdHJhaW50cyB3aWR0aENvbnN0cmFp bnRzOwogICAgICAgICBTbG90TG9naWNhbFNpemUgc2l6ZTsKICAgICB9OworICAgIFNsb3RJbmZv KiBzbG90KFNsb3RQb3NpdGlvbik7CiAKLSAgICB1c2luZyBDZWxsTGlzdCA9IFdURjo6TGlzdEhh c2hTZXQ8c3RkOjp1bmlxdWVfcHRyPENlbGxJbmZvPj47Ci0gICAgdXNpbmcgU2xvdE1hcCA9IFdU Rjo6SGFzaE1hcDxTbG90UG9zaXRpb24sIFNsb3RJbmZvPjsKK3ByaXZhdGU6CisgICAgdXNpbmcg U2xvdE1hcCA9IFdURjo6SGFzaE1hcDxTbG90UG9zaXRpb24sIHN0ZDo6dW5pcXVlX3B0cjxTbG90 SW5mbz4+OwogICAgIFNsb3RNYXAgbV9zbG90TWFwOwogICAgIENlbGxMaXN0IG1fY2VsbExpc3Q7 CiB9Owo=