200696 2019-08-13 17:33:50 -0700 [WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDeclaration::RareData 2019-08-13 18:37:18 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist mmaxfield webkit-bug-importer oldest_to_newest 1561015 0 rmorisset 2019-08-13 17:33:50 -0700 It is super rare for variable declarations to have either a semantic or qualifiers. Yet we take 24 bytes from each and every one of them to store these. We can trivially hoist them into a separate structure, to save 16 bytes per variable declaration (from 56 to 40). 1561016 1 376225 rmorisset 2019-08-13 17:35:49 -0700 Created attachment 376225 Patch 1561029 2 376225 commit-queue 2019-08-13 18:36:32 -0700 Comment on attachment 376225 Patch Clearing flags on attachment: 376225 Committed r248656: <https://trac.webkit.org/changeset/248656> 1561030 3 commit-queue 2019-08-13 18:36:34 -0700 All reviewed patches have been landed. Closing bug. 1561031 4 webkit-bug-importer 2019-08-13 18:37:18 -0700 <rdar://problem/54283914> 376225 2019-08-13 17:35:49 -0700 2019-08-13 18:36:32 -0700 Patch patch200696 text/plain 3227 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NmVjYWRjMDJhMS4uMTc4M2Q3MjA0YWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wOC0xMyAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gTW92ZSBRdWFsaWZpZXJzIGFuZCBTZW1hbnRpYyBmcm9t IFZhcmlhYmxlRGVjbGFyYXRpb24gdG8gVmFyaWFibGVEZWNsYXJhdGlvbjo6UmFyZURhdGEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDY5NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNocmlua2luZyBW YXJpYWJsZURlY2xhcmF0aW9uIGJ5IDE2IGJ5dGVzIGluIHRoZSBjb21tb24gY2FzZS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gaW50ZW5kZWQgZnVuY3Rpb25hbCBjaGFu Z2UuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmdwdS9XSExTTC9BU1QvV0hMU0xWYXJpYWJsZURl Y2xhcmF0aW9uLmg6CisKIDIwMTktMDgtMTIgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIEZpeCBidWlsZGluZyB3aXRob3V0 IHVuaWZpZWQgc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJn cHUvV0hMU0wvQVNUL1dITFNMVmFyaWFibGVEZWNsYXJhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJncHUvV0hMU0wvQVNUL1dITFNMVmFyaWFibGVEZWNsYXJhdGlvbi5oCmluZGV4 IDkxYTU1YTNhZTIzLi5lOTJkYWExNmVmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJncHUvV0hMU0wvQVNUL1dITFNMVmFyaWFibGVEZWNsYXJhdGlvbi5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML0FTVC9XSExTTFZhcmlhYmxlRGVjbGFy YXRpb24uaApAQCAtNDcsMTQgKzQ3LDI0IEBAIGNsYXNzIFZhcmlhYmxlRGVjbGFyYXRpb24gZmlu YWwgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogLy8gRmluYWwgYmVjYXVzZSB3ZSBt YWRlIHRoZSBkZXN0cnVjdG9yIG5vbi12aXJ0dWFsLgogcHVibGljOgorICAgIHN0cnVjdCBSYXJl RGF0YSB7CisgICAgICAgIFJhcmVEYXRhKFF1YWxpZmllcnMmJiBxdWFsaWZpZXJzQXJndW1lbnQs IHN0ZDo6dW5pcXVlX3B0cjxTZW1hbnRpYz4mJiBzZW1hbnRpY0FyZ3VtZW50KQorICAgICAgICAg ICAgOiBxdWFsaWZpZXJzKFdURk1vdmUocXVhbGlmaWVyc0FyZ3VtZW50KSkKKyAgICAgICAgICAg ICwgc2VtYW50aWMoV1RGTW92ZShzZW1hbnRpY0FyZ3VtZW50KSkKKyAgICAgICAgeworICAgICAg ICB9CisgICAgICAgIFF1YWxpZmllcnMgcXVhbGlmaWVyczsKKyAgICAgICAgc3RkOjp1bmlxdWVf cHRyPFNlbWFudGljPiBzZW1hbnRpYzsKKyAgICB9OworCiAgICAgVmFyaWFibGVEZWNsYXJhdGlv bihDb2RlTG9jYXRpb24gY29kZUxvY2F0aW9uLCBRdWFsaWZpZXJzJiYgcXVhbGlmaWVycywgUmVm UHRyPFVubmFtZWRUeXBlPiB0eXBlLCBTdHJpbmcmJiBuYW1lLCBzdGQ6OnVuaXF1ZV9wdHI8U2Vt YW50aWM+JiYgc2VtYW50aWMsIHN0ZDo6dW5pcXVlX3B0cjxFeHByZXNzaW9uPiYmIGluaXRpYWxp emVyKQogICAgICAgICA6IG1fY29kZUxvY2F0aW9uKGNvZGVMb2NhdGlvbikKLSAgICAgICAgLCBt X3F1YWxpZmllcnMoV1RGTW92ZShxdWFsaWZpZXJzKSkKICAgICAgICAgLCBtX3R5cGUoV1RGTW92 ZSh0eXBlKSkKLSAgICAgICAgLCBtX25hbWUoV1RGTW92ZShuYW1lKSkKLSAgICAgICAgLCBtX3Nl bWFudGljKFdURk1vdmUoc2VtYW50aWMpKQogICAgICAgICAsIG1faW5pdGlhbGl6ZXIoV1RGTW92 ZShpbml0aWFsaXplcikpCisgICAgICAgICwgbV9uYW1lKFdURk1vdmUobmFtZSkpCiAgICAgewor ICAgICAgICBpZiAoc2VtYW50aWMgfHwgIXF1YWxpZmllcnMuaXNFbXB0eSgpKQorICAgICAgICAg ICAgbV9yYXJlRGF0YSA9IHN0ZDo6bWFrZV91bmlxdWU8UmFyZURhdGE+KFdURk1vdmUocXVhbGlm aWVycyksIFdURk1vdmUoc2VtYW50aWMpKTsKICAgICB9CiAKICAgICB+VmFyaWFibGVEZWNsYXJh dGlvbigpID0gZGVmYXVsdDsKQEAgLTc0LDcgKzg0LDYgQEAgcHVibGljOgogICAgIH0KICAgICBj b25zdCBSZWZQdHI8VW5uYW1lZFR5cGU+JiB0eXBlKCkgY29uc3QgeyByZXR1cm4gbV90eXBlOyB9 CiAgICAgVW5uYW1lZFR5cGUqIHR5cGUoKSB7IHJldHVybiBtX3R5cGUgPyAmKm1fdHlwZSA6IG51 bGxwdHI7IH0KLSAgICBTZW1hbnRpYyogc2VtYW50aWMoKSB7IHJldHVybiBtX3NlbWFudGljLmdl dCgpOyB9CiAgICAgRXhwcmVzc2lvbiogaW5pdGlhbGl6ZXIoKSB7IHJldHVybiBtX2luaXRpYWxp emVyLmdldCgpOyB9CiAgICAgYm9vbCBpc0Fub255bW91cygpIGNvbnN0IHsgcmV0dXJuIG1fbmFt ZS5pc051bGwoKTsgfQogICAgIHN0ZDo6dW5pcXVlX3B0cjxFeHByZXNzaW9uPiB0YWtlSW5pdGlh bGl6ZXIoKSB7IHJldHVybiBXVEZNb3ZlKG1faW5pdGlhbGl6ZXIpOyB9CkBAIC04NiwxMyArOTUs MTQgQEAgcHVibGljOgogICAgIH0KICAgICBDb2RlTG9jYXRpb24gY29kZUxvY2F0aW9uKCkgY29u c3QgeyByZXR1cm4gbV9jb2RlTG9jYXRpb247IH0KIAorICAgIFNlbWFudGljKiBzZW1hbnRpYygp IHsgcmV0dXJuIG1fcmFyZURhdGEgPyBtX3JhcmVEYXRhLT5zZW1hbnRpYy5nZXQoKSA6IG51bGxw dHI7IH0KKwogcHJpdmF0ZToKICAgICBDb2RlTG9jYXRpb24gbV9jb2RlTG9jYXRpb247Ci0gICAg UXVhbGlmaWVycyBtX3F1YWxpZmllcnM7CiAgICAgUmVmUHRyPFVubmFtZWRUeXBlPiBtX3R5cGU7 Ci0gICAgU3RyaW5nIG1fbmFtZTsKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8U2VtYW50aWM+IG1fc2Vt YW50aWM7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEV4cHJlc3Npb24+IG1faW5pdGlhbGl6ZXI7Cisg ICAgc3RkOjp1bmlxdWVfcHRyPFJhcmVEYXRhPiBtX3JhcmVEYXRhIHsgbnVsbHB0ciB9OworICAg IFN0cmluZyBtX25hbWU7CiB9OwogCiB1c2luZyBWYXJpYWJsZURlY2xhcmF0aW9ucyA9IFZlY3Rv cjxVbmlxdWVSZWY8VmFyaWFibGVEZWNsYXJhdGlvbj4+Owo=