200695 2019-08-13 16:32:51 -0700 Remove m_blockRectForTextSelection (along with related code) 2019-08-14 17:54:59 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue dino megan_gardner simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1561004 0 wenson_hsieh 2019-08-13 16:32:51 -0700 This member variable is unused. 1561281 1 376292 wenson_hsieh 2019-08-14 12:32:48 -0700 Created attachment 376292 Patch 1561405 2 376292 commit-queue 2019-08-14 17:54:57 -0700 Comment on attachment 376292 Patch Clearing flags on attachment: 376292 Committed r248700: <https://trac.webkit.org/changeset/248700> 1561406 3 commit-queue 2019-08-14 17:54:59 -0700 All reviewed patches have been landed. Closing bug. 376292 2019-08-14 12:32:48 -0700 2019-08-14 17:54:57 -0700 Patch bug-200695-20190814123247.patch text/plain 4352 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJmZWEyNWUzYmY3ODE4MTcx YjEzMTJmNTFiZGEzODRhYWRmZDQyMzUuLjlmNGFlNjZiMWQ0ZGNhMjBmY2IyNjVmMjM2ODA2Mzc5 ZjlkODNkYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDgtMTQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG1fYmxvY2tS ZWN0Rm9yVGV4dFNlbGVjdGlvbiAoYWxvbmcgd2l0aCByZWxhdGVkIGNvZGUpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2OTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG1lbWJlciB2YXJpYWJs ZSB3YXMgY29uc3VsdGVkIGJ5IGJsb2NrIHNlbGVjdGlvbiBjb2RlcGF0aHMgd2hpY2ggbm8gbG9u Z2VyIGV4aXN0LgorICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2VsZWN0VGV4 dFdpdGhHcmFudWxhcml0eUF0UG9pbnQpOgorICAgICAgICAoV2ViS2l0OjpzZWxlY3Rpb25Cb3hG b3JSYW5nZSk6IERlbGV0ZWQuCisKIDIwMTktMDgtMTAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBEaXNhYmxlIENvbnRlbnRDaGFuZ2VPYnNl cnZlciBUb3VjaEV2ZW50IGFkanVzdG1lbnQgb24geW91dHViZS5jb20gb24gaU9TIGluIG1vYmls ZSBicm93c2luZyBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmgKaW5kZXggMmQxMjg5YzgwZGY4MjJhYTJmOWQwODUyNWZhZjlmNTRlOWQ3YTYyNy4uOGZmOTVh N2Q0MTU5OTNhY2M5YzBkNGY0MDdlMmRhMGM5ZjdjMmExMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtMTg1OSw3ICsxODU5LDYgQEAgcHJpdmF0ZToK ICAgICBXZWJDb3JlOjpGbG9hdFNpemUgbV9zY3JlZW5TaXplOwogICAgIFdlYkNvcmU6OkZsb2F0 U2l6ZSBtX2F2YWlsYWJsZVNjcmVlblNpemU7CiAgICAgV2ViQ29yZTo6RmxvYXRTaXplIG1fb3Zl cnJpZGVTY3JlZW5TaXplOwotICAgIFdlYkNvcmU6OkludFJlY3QgbV9ibG9ja1JlY3RGb3JUZXh0 U2VsZWN0aW9uOwogCiAgICAgUmVmUHRyPFdlYkNvcmU6OlJhbmdlPiBtX2luaXRpYWxTZWxlY3Rp b247CiAgICAgV2ViQ29yZTo6VmlzaWJsZVNlbGVjdGlvbiBtX3N0b3JlZFNlbGVjdGlvbkZvckFj Y2Vzc2liaWxpdHkgeyBXZWJDb3JlOjpWaXNpYmxlU2VsZWN0aW9uKCkgfTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggY2Ni MzQ5ZjAwM2UyZTA2NzM0NzMzMGEzOGM0MGNjNTY4MmY1MTQ1Yy4uNDU5MDNiNzk4MzM0ODIwZWI0 MGI4Y2QzOGFmYzM1NmI2MGVkM2ZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTEyNzUsMjYgKzEyNzUsNiBAQCBzdGF0 aWMgSW50UG9pbnQgY29uc3RyYWluUG9pbnQoY29uc3QgSW50UG9pbnQmIHBvaW50LCBjb25zdCBG cmFtZSYgZnJhbWUsIGNvbnN0CiAgICAgcmV0dXJuIGNvbnN0cmFpbmVkUG9pbnQ7CiB9CiAKLXN0 YXRpYyBJbnRSZWN0IHNlbGVjdGlvbkJveEZvclJhbmdlKFdlYkNvcmU6OlJhbmdlKiByYW5nZSkK LXsKLSAgICBpZiAoIXJhbmdlKQotICAgICAgICByZXR1cm4gSW50UmVjdCgpOwotICAgIAotICAg IEludFJlY3QgYm91bmRpbmdSZWN0OwotICAgIFZlY3RvcjxTZWxlY3Rpb25SZWN0PiBzZWxlY3Rp b25SZWN0czsKLSAgICByYW5nZS0+Y29sbGVjdFNlbGVjdGlvblJlY3RzKHNlbGVjdGlvblJlY3Rz KTsKLSAgICB1bnNpZ25lZCBzaXplID0gc2VsZWN0aW9uUmVjdHMuc2l6ZSgpOwotICAgIAotICAg IGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBzaXplOyArK2kpIHsKLSAgICAgICAgY29uc3QgSW50 UmVjdCAmY29yZVJlY3QgPSBzZWxlY3Rpb25SZWN0c1tpXS5yZWN0KCk7Ci0gICAgICAgIGlmICgh aSkKLSAgICAgICAgICAgIGJvdW5kaW5nUmVjdCA9IGNvcmVSZWN0OwotICAgICAgICBlbHNlCi0g ICAgICAgICAgICBib3VuZGluZ1JlY3QudW5pdGUoY29yZVJlY3QpOwotICAgIH0KLSAgICByZXR1 cm4gYm91bmRpbmdSZWN0OwotfQotCiB2b2lkIFdlYlBhZ2U6OnNlbGVjdFdpdGhHZXN0dXJlKGNv bnN0IEludFBvaW50JiBwb2ludCwgdWludDMyX3QgZ3JhbnVsYXJpdHksIHVpbnQzMl90IGdlc3R1 cmVUeXBlLCB1aW50MzJfdCBnZXN0dXJlU3RhdGUsIGJvb2wgaXNJbnRlcmFjdGluZ1dpdGhGb2N1 c2VkRWxlbWVudCwgQ2FsbGJhY2tJRCBjYWxsYmFja0lEKQogewogICAgIGlmIChzdGF0aWNfY2Fz dDxHZXN0dXJlUmVjb2duaXplclN0YXRlPihnZXN0dXJlU3RhdGUpID09IEdlc3R1cmVSZWNvZ25p emVyU3RhdGU6OkJlZ2FuKQpAQCAtMjA4NSwyMSArMjA2NSw3IEBAIHZvaWQgV2ViUGFnZTo6c2Vs ZWN0VGV4dFdpdGhHcmFudWxhcml0eUF0UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHBv aW50LCB1CiAgICAgc2V0Rm9jdXNlZEZyYW1lQmVmb3JlU2VsZWN0aW5nVGV4dEF0TG9jYXRpb24o cG9pbnQpOwogCiAgICAgYXV0byYgZnJhbWUgPSBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZv Y3VzZWRPck1haW5GcmFtZSgpOwotICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2UgPSByYW5nZUZvckdy YW51bGFyaXR5QXRQb2ludChmcmFtZSwgcG9pbnQsIGdyYW51bGFyaXR5LCBpc0ludGVyYWN0aW5n V2l0aEZvY3VzZWRFbGVtZW50KTsKLSAgICBpZiAoIWlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVs ZW1lbnQpIHsKLSAgICAgICAgYXV0byogcmVuZGVyZXIgPSByYW5nZSA/IHJhbmdlLT5zdGFydENv bnRhaW5lcigpLnJlbmRlcmVyKCkgOiBudWxscHRyOwotICAgICAgICBpZiAocmVuZGVyZXIgJiYg cmVuZGVyZXItPnN0eWxlKCkucHJlc2VydmVOZXdsaW5lKCkpCi0gICAgICAgICAgICBtX2Jsb2Nr UmVjdEZvclRleHRTZWxlY3Rpb24gPSByZW5kZXJlci0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3Qo dHJ1ZSk7Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAgYXV0byBwYXJhZ3JhcGhSYW5nZSA9 IGVuY2xvc2luZ1RleHRVbml0T2ZHcmFudWxhcml0eSh2aXNpYmxlUG9zaXRpb25JbkZvY3VzZWRO b2RlRm9yUG9pbnQoZnJhbWUsIHBvaW50LCBpc0ludGVyYWN0aW5nV2l0aEZvY3VzZWRFbGVtZW50 KSwgUGFyYWdyYXBoR3JhbnVsYXJpdHksIERpcmVjdGlvbkZvcndhcmQpOwotICAgICAgICAgICAg aWYgKHBhcmFncmFwaFJhbmdlICYmICFwYXJhZ3JhcGhSYW5nZS0+Y29sbGFwc2VkKCkpCi0gICAg ICAgICAgICAgICAgbV9ibG9ja1JlY3RGb3JUZXh0U2VsZWN0aW9uID0gc2VsZWN0aW9uQm94Rm9y UmFuZ2UocGFyYWdyYXBoUmFuZ2UuZ2V0KCkpOwotICAgICAgICB9Ci0gICAgICAgIAotICAgICAg ICBpZiAocmVjdElzVG9vQmlnRm9yU2VsZWN0aW9uKG1fYmxvY2tSZWN0Rm9yVGV4dFNlbGVjdGlv biwgZnJhbWUpKQotICAgICAgICAgICAgbV9ibG9ja1JlY3RGb3JUZXh0U2VsZWN0aW9uLnNldEhl aWdodCgwKTsKLSAgICB9Ci0KKyAgICBhdXRvIHJhbmdlID0gcmFuZ2VGb3JHcmFudWxhcml0eUF0 UG9pbnQoZnJhbWUsIHBvaW50LCBncmFudWxhcml0eSwgaXNJbnRlcmFjdGluZ1dpdGhGb2N1c2Vk RWxlbWVudCk7CiAgICAgaWYgKHJhbmdlKQogICAgICAgICBmcmFtZS5zZWxlY3Rpb24oKS5zZXRT ZWxlY3RlZFJhbmdlKHJhbmdlLmdldCgpLCBVUFNUUkVBTSwgV2ViQ29yZTo6RnJhbWVTZWxlY3Rp b246OlNob3VsZENsb3NlVHlwaW5nOjpZZXMsIFVzZXJUcmlnZ2VyZWQpOwogICAgIG1faW5pdGlh bFNlbGVjdGlvbiA9IHJhbmdlOwo=