200680 2019-08-13 11:34:09 -0700 Uncaught Exception: content.isJSON is not a function selecting image resource 2019-08-13 21:59:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://bogojoker.com/shell/ InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1560872 0 joepeck 2019-08-13 11:34:09 -0700 Uncaught Exception: content.isJSON is not a function selecting image resource * STEPS TO REPRODUCE 1. Inspect http://bogojoker.com/shell/ 2. Click the gif in the Sources tab => Exception 1560874 1 376186 joepeck 2019-08-13 11:36:28 -0700 Created attachment 376186 [PATCH] Proposed Fix 1560889 2 376186 hi 2019-08-13 12:01:52 -0700 Comment on attachment 376186 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=376186&action=review r=me Interesting. What's the type of the content for image resources? I'd imagine it's a string that's `base64Encoded`? > Source/WebInspectorUI/ChangeLog:10 > + Protect against null, such as there being no request data. There should already be a guard for protecting against no request data (`_canShowRequestContentView`). Was that the issue in this case, or was it just for `null`? 1560939 3 376208 joepeck 2019-08-13 13:36:21 -0700 Created attachment 376208 [PATCH] For Landing 1560940 4 joepeck 2019-08-13 13:37:36 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 376186 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376186&action=review > > Interesting. What's the type of the content for image resources? I'd > imagine it's a string that's `base64Encoded`? In this case it is a Blob. I've clarified the ChangeLog. 1560979 5 376208 commit-queue 2019-08-13 15:14:56 -0700 Comment on attachment 376208 [PATCH] For Landing Clearing flags on attachment: 376208 Committed r248637: <https://trac.webkit.org/changeset/248637> 1561070 6 webkit-bug-importer 2019-08-13 21:59:17 -0700 <rdar://problem/54288272> 376186 2019-08-13 11:36:28 -0700 2019-08-13 13:36:26 -0700 [PATCH] Proposed Fix better-handle-null.patch text/plain 1594 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdjYjY2ZmVhM2RiLi42YzRiOTEyZDRiMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBVbmNhdWdodCBFeGNl cHRpb246IGNvbnRlbnQuaXNKU09OIGlzIG5vdCBhIGZ1bmN0aW9uIHNlbGVjdGluZyBpbWFnZSBy ZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAwNjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV0kuUmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcucHJvdG90eXBlLl9jYW5Vc2VKU09O Q29udGVudFZpZXdGb3JDb250ZW50KToKKyAgICAgICAgUHJvdGVjdCBhZ2FpbnN0IG51bGwsIHN1 Y2ggYXMgdGhlcmUgYmVpbmcgbm8gcmVxdWVzdCBkYXRhLgorCiAyMDE5LTA4LTEyICBEZXZpbiBS b3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbGVt ZW50czogU3R5bGVzOiBhZGQgc3BhY2UgYmV0d2VlbiBtZWRpYSBxdWVyeSBhbmQgc3R5bGUgaWNv bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qcwppbmRleCBjMWJl YWNiOTA2OC4uNTU4MmUwMzRiYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNv bnRlbnRWaWV3LmpzCkBAIC0zNDIsNyArMzQyLDcgQEAgV0kuUmVzb3VyY2VDbHVzdGVyQ29udGVu dFZpZXcgPSBjbGFzcyBSZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyBleHRlbmRzIFdJLkNsdXMK IAogICAgIF9jYW5Vc2VKU09OQ29udGVudFZpZXdGb3JDb250ZW50KGNvbnRlbnQpCiAgICAgewot ICAgICAgICByZXR1cm4gY29udGVudC5pc0pTT04oKGpzb24pID0+IGpzb24gJiYgKHR5cGVvZiBq c29uID09PSAib2JqZWN0IiB8fCBBcnJheS5pc0FycmF5KGpzb24pKSk7CisgICAgICAgIHJldHVy biB0eXBlb2YgY29udGVudCA9PT0gInN0cmluZyIgJiYgY29udGVudC5pc0pTT04oKGpzb24pID0+ IGpzb24gJiYgKHR5cGVvZiBqc29uID09PSAib2JqZWN0IiB8fCBBcnJheS5pc0FycmF5KGpzb24p KSk7CiAgICAgfQogCiAgICAgX3RyeUVuYWJsZUN1c3RvbVJlcXVlc3RDb250ZW50VmlldygpCg== 376208 2019-08-13 13:36:21 -0700 2019-08-13 15:14:56 -0700 [PATCH] For Landing for-landing-1.patch text/plain 1597 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdjYjY2ZmVhM2RiLi5lMzJkMDJiYTQxZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDgtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBVbmNhdWdodCBFeGNl cHRpb246IGNvbnRlbnQuaXNKU09OIGlzIG5vdCBhIGZ1bmN0aW9uIHNlbGVjdGluZyBpbWFnZSBy ZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAwNjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qczoKKyAgICAg ICAgKFdJLlJlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY2FuVXNlSlNPTkNv bnRlbnRWaWV3Rm9yQ29udGVudCk6CisgICAgICAgIFByb3RlY3QgYWdhaW5zdCBub24tc3RyaW5n IGRhdGEsIHN1Y2ggYXMgQmxvYiByZXNwb25zZSBjb250ZW50LgorCiAyMDE5LTA4LTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBF bGVtZW50czogU3R5bGVzOiBhZGQgc3BhY2UgYmV0d2VlbiBtZWRpYSBxdWVyeSBhbmQgc3R5bGUg aWNvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvUmVzb3VyY2VDbHVzdGVyQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNsdXN0ZXJDb250ZW50Vmlldy5qcwppbmRleCBj MWJlYWNiOTA2OC4uNTU4MmUwMzRiYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3RlckNvbnRlbnRWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ2x1c3Rl ckNvbnRlbnRWaWV3LmpzCkBAIC0zNDIsNyArMzQyLDcgQEAgV0kuUmVzb3VyY2VDbHVzdGVyQ29u dGVudFZpZXcgPSBjbGFzcyBSZXNvdXJjZUNsdXN0ZXJDb250ZW50VmlldyBleHRlbmRzIFdJLkNs dXMKIAogICAgIF9jYW5Vc2VKU09OQ29udGVudFZpZXdGb3JDb250ZW50KGNvbnRlbnQpCiAgICAg ewotICAgICAgICByZXR1cm4gY29udGVudC5pc0pTT04oKGpzb24pID0+IGpzb24gJiYgKHR5cGVv ZiBqc29uID09PSAib2JqZWN0IiB8fCBBcnJheS5pc0FycmF5KGpzb24pKSk7CisgICAgICAgIHJl dHVybiB0eXBlb2YgY29udGVudCA9PT0gInN0cmluZyIgJiYgY29udGVudC5pc0pTT04oKGpzb24p ID0+IGpzb24gJiYgKHR5cGVvZiBqc29uID09PSAib2JqZWN0IiB8fCBBcnJheS5pc0FycmF5KGpz b24pKSk7CiAgICAgfQogCiAgICAgX3RyeUVuYWJsZUN1c3RvbVJlcXVlc3RDb250ZW50Vmlldygp Cg==