200673 2019-08-13 08:47:12 -0700 Incorrect head in fast/canvas/webgl/gl-get-calls.html causes test failure 2019-08-13 10:17:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 clord clord ap commit-queue darin dino fpizlo mark.lam webkit-bug-importer oldest_to_newest 1560797 0 clord 2019-08-13 08:47:12 -0700 fast/canvas/webgl/gl-get-calls.html incorrectly puts xmlns="http://www.w3.org/1999/xhtml" in its html tag, which causes it to be treated as xhtml when using libsoup (as used on the Gtk and WPE backends). As it isn't well-formed, this causes the test to fail. 1560798 1 376169 clord 2019-08-13 08:52:05 -0700 Created attachment 376169 Patch 1560804 2 376169 ap 2019-08-13 09:09:07 -0700 Comment on attachment 376169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376169&action=review I would call this a real bug in these ports, as content sniffing local files is no less dangerous than content sniffing resources served by HTTP. This file just shouldn't be parsed as XML. Also, there is an explicit meta http-equiv that should be respected when content sniffing. But it's OK to correct the test. > LayoutTests/fast/canvas/webgl/gl-get-calls.html:1 > +<!DOCTYPE HTML> HTML5 doctype is "<!DOCTYPE html>" (lower case). 1560814 3 376172 clord 2019-08-13 09:24:20 -0700 Created attachment 376172 Patch 1560841 4 376172 commit-queue 2019-08-13 10:16:35 -0700 Comment on attachment 376172 Patch Clearing flags on attachment: 376172 Committed r248599: <https://trac.webkit.org/changeset/248599> 1560842 5 commit-queue 2019-08-13 10:16:37 -0700 All reviewed patches have been landed. Closing bug. 1560843 6 webkit-bug-importer 2019-08-13 10:17:19 -0700 <rdar://problem/54262996> 376169 2019-08-13 08:52:05 -0700 2019-08-13 09:23:48 -0700 Patch bug-200673-20190813165204.patch text/plain 1162 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTI2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWZmNWMyMjI0MzY3ZGExYjQ1YjZi ZjM2YThiNDU4N2Q3MjViN2VhZS4uOWQ5ZTFjNTA1OGFlYmRlYTNkYmViNmExNTM4MTZmMTc3Mjgw MDE5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA4LTEzICBDaHJpcyBMb3JkICA8Y2xv cmRAaWdhbGlhLmNvbT4KKworICAgICAgICBJbmNvcnJlY3QgaGVhZCBpbiBmYXN0L2NhbnZhcy93 ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbCBjYXVzZXMgdGVzdCBmYWlsdXJlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2NzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2ds LWdldC1jYWxscy5odG1sOgorCiAyMDE5LTA4LTExICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJv eWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIERvbid0IHVzZSB2b3Ji aXNwYXJzZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0 LWNhbGxzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMu aHRtbAppbmRleCA1NjkzN2Q4NDI0Y2U1YTU4YjRkYzZhZWM2ZmNhNGQ3MTIwZGQyNDgwLi4wNWE2 YmJlYjAwN2Q2MjRiNmMxNzU4YzU0YWZmNDRiOGYwOWM2YjQxIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbApAQCAtMSw0ICsxLDUgQEAKLTxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKzwhRE9DVFlQRSBIVE1M PgorPGh0bWw+CiA8aGVhZD4KIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KIDx0aXRsZT5XZWJHTCBnbCBjYWxscyBDb25m b3JtYW5jZSBUZXN0czwvdGl0bGU+Cg== 376172 2019-08-13 09:24:20 -0700 2019-08-13 10:16:35 -0700 Patch bug-200673-20190813172419.patch text/plain 1162 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTI2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWZmNWMyMjI0MzY3ZGExYjQ1YjZi ZjM2YThiNDU4N2Q3MjViN2VhZS4uOWQ5ZTFjNTA1OGFlYmRlYTNkYmViNmExNTM4MTZmMTc3Mjgw MDE5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA4LTEzICBDaHJpcyBMb3JkICA8Y2xv cmRAaWdhbGlhLmNvbT4KKworICAgICAgICBJbmNvcnJlY3QgaGVhZCBpbiBmYXN0L2NhbnZhcy93 ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbCBjYXVzZXMgdGVzdCBmYWlsdXJlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2NzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2ds LWdldC1jYWxscy5odG1sOgorCiAyMDE5LTA4LTExICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJv eWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIERvbid0IHVzZSB2b3Ji aXNwYXJzZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0 LWNhbGxzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMu aHRtbAppbmRleCA1NjkzN2Q4NDI0Y2U1YTU4YjRkYzZhZWM2ZmNhNGQ3MTIwZGQyNDgwLi41NTVh MTAzNjM3NDdkN2E0MzcyY2M3NzI0YzhlYjIzYjI1Yzg0OGJhIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbApAQCAtMSw0ICsxLDUgQEAKLTxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+CiA8aGVhZD4KIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KIDx0aXRsZT5XZWJHTCBnbCBjYWxscyBDb25m b3JtYW5jZSBUZXN0czwvdGl0bGU+Cg==