200667 2019-08-13 02:49:54 -0700 [JSCOnly] build broken on macOS due to missing include file 2019-08-14 09:40:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified macOS 10.14 RESOLVED FIXED InRadar P2 Minor --- 1 saelo webkit-unassigned achristensen commit-queue fpizlo msaboff saam webkit-bug-importer oldest_to_newest 1560750 0 saelo 2019-08-13 02:49:54 -0700 The JSCOnly build on macOS appears to be broken (probably) after https://trac.webkit.org/changeset/248441/webkit: > ./Tools/Scripts/build-jsc --jsc-only --debug ... ../../Source/JavaScriptCore/jsc.cpp:141:10: fatal error: 'wtf/spi/darwin/ProcessMemoryFootprint.h' file not found #include <wtf/spi/darwin/ProcessMemoryFootprint.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ninja: build stopped: subcommand failed. 1560983 1 ap 2019-08-13 15:33:00 -0700 Would you be willing to post a patch for this? https://webkit.org/contributing-code/ 1561086 2 376245 saelo 2019-08-14 00:50:04 -0700 Created attachment 376245 Patch 1561088 3 saelo 2019-08-14 00:55:41 -0700 I attempted to create a patch for this. I'm not sure if that's the correct place to add the include file, but `./Tools/Scripts/build-jsc --jsc-only --debug` does seem to work now. 1561190 4 376245 commit-queue 2019-08-14 09:39:21 -0700 Comment on attachment 376245 Patch Clearing flags on attachment: 376245 Committed r248672: <https://trac.webkit.org/changeset/248672> 1561191 5 commit-queue 2019-08-14 09:39:23 -0700 All reviewed patches have been landed. Closing bug. 1561193 6 webkit-bug-importer 2019-08-14 09:40:18 -0700 <rdar://problem/54305336> 376245 2019-08-14 00:50:04 -0700 2019-08-14 09:39:21 -0700 Patch bug-200667-20190814095003.patch text/plain 1475 saelo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFiOGRkZWM5MDYyMDMxYjE0ZmUzYWZm MjhiY2VjMzYzYTNmZjAyODQuLmRlZTg2MTUxN2JmM2YyNzIzMDYzOTMyNmQyNGMxY2RkZGM0MjI4 MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDgtMTQgIFNhbXVlbCBHcm/DnyAgPHNhZWxv QGdvb2dsZS5jb20+CisKKyAgICAgICAgW0pTQ09ubHldIEpTQ09ubHkgcG9ydCBkb2Vzbid0IGJ1 aWxkIG9uIG1hY09TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDA2NjcKKworICAgICAgICBzcGkvZGFyd2luL1Byb2Nlc3NNZW1vcnlGb290cHJpbnQu aCBpcyByZXF1aXJlZCBieSBqc2MuY3BwIHNvIHdlIGFkZCBpdCB0byB0aGUgV1RGX1BVQkxJQ19I RUFERVJTLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL1BsYXRmb3JtSlNDT25seS5jbWFrZToKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1NYWMu Y21ha2U6CisKIDIwMTktMDgtMTMgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbmFtZSBTdHJpbmdCdWlsZGVyOjphcHBlbmQoVUNoYXIzMikgdG8gU3RyaW5nQnVp bGRlcjo6YXBwZW5kQ2hhcmFjdGVyKFVDaGFyMzIpIHRvIGF2b2lkIGFjY2lkZW50YWwgY2hhbmdl IGluIGJlaGF2aW9yIHdoZW4gcmVwbGFjaW5nIGFwcGVuZCB3aXRoIGZsZXhpYmxlQXBwZW5kCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUpTQ09ubHkuY21ha2UgYi9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybUpTQ09ubHkuY21ha2UKaW5kZXggMGRhZTBhYjk1MDViNzMxZDY0YzRm NDk3ODAzMTgzOTVhY2QwYzVjYS4uYTNjZDhlN2JjMjQzODMzZDJjNTZlMzQyNDJiNjkwNDc5YmZi MzI2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1KU0NPbmx5LmNtYWtlCisr KyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSlNDT25seS5jbWFrZQpAQCAtNzUsNiArNzUsOSBA QCBlbHNlaWYgKEFQUExFKQogICAgICAgICAke1dURl9ERVJJVkVEX1NPVVJDRVNfRElSfS9tYWNo X2V4Y1NlcnZlci5jCiAgICAgICAgICR7V1RGX0RFUklWRURfU09VUkNFU19ESVJ9L21hY2hfZXhj VXNlci5jCiAgICAgKQorICAgIGxpc3QoQVBQRU5EIFdURl9QVUJMSUNfSEVBREVSUworICAgICAg ICBzcGkvZGFyd2luL1Byb2Nlc3NNZW1vcnlGb290cHJpbnQuaAorICAgICkKIGVsc2VpZiAoQ01B S0VfU1lTVEVNX05BTUUgTUFUQ0hFUyAiTGludXgiKQogICAgIGxpc3QoQVBQRU5EIFdURl9TT1VS Q0VTCiAgICAgICAgIGxpbnV4L0N1cnJlbnRQcm9jZXNzTWVtb3J5U3RhdHVzLmNwcAo=