200666 2019-08-13 02:41:02 -0700 Make privateBrowsingStateDidChange take an explicit SessionID 2019-08-14 03:28:08 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson commit-queue webkit-bug-importer oldest_to_newest 1560747 0 youennf 2019-08-13 02:41:02 -0700 Make privateBrowsingStateDidChange take an explicit SessionID to improve readability 1560749 1 376155 youennf 2019-08-13 02:46:07 -0700 Created attachment 376155 Patch 1561124 2 376155 commit-queue 2019-08-14 03:25:07 -0700 Comment on attachment 376155 Patch Clearing flags on attachment: 376155 Committed r248667: <https://trac.webkit.org/changeset/248667> 1561125 3 commit-queue 2019-08-14 03:25:08 -0700 All reviewed patches have been landed. Closing bug. 1561126 4 webkit-bug-importer 2019-08-14 03:28:08 -0700 <rdar://problem/54295014> 376155 2019-08-13 02:46:07 -0700 2019-08-14 03:25:07 -0700 Patch bug-200666-20190813114605.patch text/plain 6186 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhkOGEyMjFlMWJmM2Uz YjAzZjdkODkyNDFlMWYyMGNhMjg2ZDA5NS4uOGQwMTJhODZlZjZkZTdjM2E3ZGYzNmY3ZjM2YmEw NzgwMzRmNjM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA4LTEzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHByaXZhdGVCcm93 c2luZ1N0YXRlRGlkQ2hhbmdlIHRha2UgYW4gZXhwbGljaXQgU2Vzc2lvbklECisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2NjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHN0YXRpbmcg dGhhdCB0aGUgcGFnZSBzZXNzaW9uIElEIGNoYW5nZWQgYW5kIGdldCBpdCBmcm9tIHRoZSBwYWdl LAorICAgICAgICBwYXNzIGl0IGRpcmVjdGx5IHRvIHByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hh bmdlLgorICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAgICAgICAgKiBkb20vRG9j dW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnByaXZhdGVCcm93c2luZ1N0 YXRlRGlkQ2hhbmdlKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiBkb20v RWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cHJpdmF0ZUJyb3dzaW5nU3Rh dGVEaWRDaGFuZ2UpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENo YW5nZSk6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgICogcGFn ZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNldFNlc3Npb25JRCk6CisKIDIw MTktMDgtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEJs b2IgcmVnaXN0cmllcyBzaG91bGQgYmUga2V5ZWQgYnkgc2Vzc2lvbiBJRHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCmluZGV4IGQxN2ZmMmNmZWMxODc4ZTY3YzU4MTA3OTI4MGI0OTFiODg1OTNlNTku LjQzYzA5YTRhY2M3YWEyYjBmNGRlMjA4NDk4NWMzZGE3ZmQxMTNmOTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcApAQCAtNTI2MiwxOSArNTI2MiwxOSBAQCB2b2lkIERvY3VtZW50OjpzdG9yYWdl QmxvY2tpbmdTdGF0ZURpZENoYW5nZSgpCiAgICAgc2VjdXJpdHlPcmlnaW4oKS5zZXRTdG9yYWdl QmxvY2tpbmdQb2xpY3koc2V0dGluZ3MoKS5zdG9yYWdlQmxvY2tpbmdQb2xpY3koKSk7CiB9CiAK LXZvaWQgRG9jdW1lbnQ6OnByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hhbmdlKCkgCit2b2lkIERv Y3VtZW50Ojpwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZShQQUw6OlNlc3Npb25JRCBzZXNz aW9uSUQpCiB7Ci0gICAgbV9zZXNzaW9uSUQgPSBTZXNzaW9uSUQ6OmVtcHR5U2Vzc2lvbklEKCk7 CisgICAgbV9zZXNzaW9uSUQgPSBzZXNzaW9uSUQ7CiAgICAgaWYgKG1fbG9nZ2VyKQotICAgICAg ICBtX2xvZ2dlci0+c2V0RW5hYmxlZCh0aGlzLCBzZXNzaW9uSUQoKS5pc0Fsd2F5c09uTG9nZ2lu Z0FsbG93ZWQoKSk7CisgICAgICAgIG1fbG9nZ2VyLT5zZXRFbmFibGVkKHRoaXMsIHNlc3Npb25J RC5pc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSk7CiAKICAgICBmb3IgKGF1dG8qIGVsZW1lbnQg OiBtX3ByaXZhdGVCcm93c2luZ1N0YXRlQ2hhbmdlZEVsZW1lbnRzKQotICAgICAgICBlbGVtZW50 LT5wcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZSgpOworICAgICAgICBlbGVtZW50LT5wcml2 YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZShzZXNzaW9uSUQpOwogCiAjaWYgRU5BQkxFKFNFUlZJ Q0VfV09SS0VSKQotICAgIEFTU0VSVChzZXNzaW9uSUQoKS5pc1ZhbGlkKCkpOwotICAgIGlmIChS dW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNlcnZpY2VXb3JrZXJFbmFi bGVkKCkgJiYgbV9zZXJ2aWNlV29ya2VyQ29ubmVjdGlvbiAmJiBzZXNzaW9uSUQoKS5pc1ZhbGlk KCkpCi0gICAgICAgIHNldFNlcnZpY2VXb3JrZXJDb25uZWN0aW9uKCZTZXJ2aWNlV29ya2VyUHJv dmlkZXI6OnNpbmdsZXRvbigpLnNlcnZpY2VXb3JrZXJDb25uZWN0aW9uRm9yU2Vzc2lvbihzZXNz aW9uSUQoKSkpOworICAgIEFTU0VSVChzZXNzaW9uSUQuaXNWYWxpZCgpKTsKKyAgICBpZiAoUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5zZXJ2aWNlV29ya2VyRW5hYmxl ZCgpICYmIG1fc2VydmljZVdvcmtlckNvbm5lY3Rpb24gJiYgc2Vzc2lvbklELmlzVmFsaWQoKSkK KyAgICAgICAgc2V0U2VydmljZVdvcmtlckNvbm5lY3Rpb24oJlNlcnZpY2VXb3JrZXJQcm92aWRl cjo6c2luZ2xldG9uKCkuc2VydmljZVdvcmtlckNvbm5lY3Rpb25Gb3JTZXNzaW9uKHNlc3Npb25J RCkpOwogI2VuZGlmCiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggZjk3ZGJlNzUxYmQ1MDQz NjI3M2MwNzhmNzBlZWExNWI2NWM3NjJhOS4uMGY1MzhiZmEwNWRiY2VmM2U4YTZmOGU2NmM5ODBm ZDNkOTdjZWU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTEwOTIsNyArMTA5Miw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIHJlZ2lzdGVyRm9yUHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkQ2Fs bGJhY2tzKEVsZW1lbnQmKTsKICAgICB2b2lkIHVucmVnaXN0ZXJGb3JQcml2YXRlQnJvd3NpbmdT dGF0ZUNoYW5nZWRDYWxsYmFja3MoRWxlbWVudCYpOwogICAgIHZvaWQgc3RvcmFnZUJsb2NraW5n U3RhdGVEaWRDaGFuZ2UoKTsKLSAgICB2b2lkIHByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hhbmdl KCk7CisgICAgdm9pZCBwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZShQQUw6OlNlc3Npb25J RCk7CiAKICNpZiBFTkFCTEUoVklERU9fVFJBQ0spCiAgICAgdm9pZCByZWdpc3RlckZvckNhcHRp b25QcmVmZXJlbmNlc0NoYW5nZWRDYWxsYmFja3MoRWxlbWVudCYpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgK aW5kZXggZTY0ODY1ZmI3ZjdhM2I3ZjA3YzEzNzE2MTcwZTkzMTU2MjljMzQyMS4uMTNiYmJlOWI0 MTNlOGU3N2EyMzc5OTM4MDk4MTg0M2NiNjg5ZTk2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC00 MTksNyArNDE5LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBtZWRpYVZvbHVtZURpZENo YW5nZSgpIHsgfQogCiAgICAgLy8gVXNlIERvY3VtZW50OjpyZWdpc3RlckZvclByaXZhdGVCcm93 c2luZ1N0YXRlQ2hhbmdlZENhbGxiYWNrcygpIHRvIHN1YnNjcmliZSB0byB0aGlzLgotICAgIHZp cnR1YWwgdm9pZCBwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZSgpIHsgfQorICAgIHZpcnR1 YWwgdm9pZCBwcml2YXRlQnJvd3NpbmdTdGF0ZURpZENoYW5nZShQQUw6OlNlc3Npb25JRCkgeyB9 CiAKICAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlY29tZUZ1bGxzY3JlZW5FbGVtZW50KCk7CiAgICAg dmlydHVhbCB2b2lkIGFuY2VzdG9yV2lsbEVudGVyRnVsbHNjcmVlbigpIHsgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggZjc0MGNjYWMyNDJlOWUwZjNiYzhk ZGM5NTc1ZmIzMmE0ZWYxOThhZi4uYjU1YzQ2OTA2MWRjYzA0ZjJhMTE5YTI1NTM4ZWYwODJmZTZl NDM1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC02NDM2 LDEzICs2NDM2LDEyIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cmVzZXRNZWRpYUVuZ2luZXMo KQogICAgIE1lZGlhUGxheWVyOjpyZXNldE1lZGlhRW5naW5lcygpOwogfQogCi12b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OnByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hhbmdlKCkKK3ZvaWQgSFRNTE1l ZGlhRWxlbWVudDo6cHJpdmF0ZUJyb3dzaW5nU3RhdGVEaWRDaGFuZ2UoUEFMOjpTZXNzaW9uSUQg c2Vzc2lvbklEKQogewogICAgIGlmICghbV9wbGF5ZXIpCiAgICAgICAgIHJldHVybjsKIAotICAg IGJvb2wgcHJpdmF0ZU1vZGUgPSBkb2N1bWVudCgpLnBhZ2UoKSAmJiBkb2N1bWVudCgpLnBhZ2Uo KS0+dXNlc0VwaGVtZXJhbFNlc3Npb24oKTsKLSAgICBtX3BsYXllci0+c2V0UHJpdmF0ZUJyb3dz aW5nTW9kZShwcml2YXRlTW9kZSk7CisgICAgbV9wbGF5ZXItPnNldFByaXZhdGVCcm93c2luZ01v ZGUoc2Vzc2lvbklELmlzRXBoZW1lcmFsKCkpOwogfQogCiBNZWRpYUNvbnRyb2xzKiBIVE1MTWVk aWFFbGVtZW50OjptZWRpYUNvbnRyb2xzKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFFbGVtZW50LmgKaW5kZXggZDBiYWI5ZmM5ZDZlZGExYzFiYzJhNjA5NjgzZjI3NmZlNzYwM2Nm OC4uNjEyNDU0MWY3Y2Y1NGExMTBhNWU0ODZlNDJjNzFjZDJhMmVmYTE5MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKQEAgLTQ1Niw3ICs0NTYsNyBAQCBwdWJsaWM6CiAg ICAgdm9pZCBzb3VyY2VXYXNSZW1vdmVkKEhUTUxTb3VyY2VFbGVtZW50Jik7CiAgICAgdm9pZCBz b3VyY2VXYXNBZGRlZChIVE1MU291cmNlRWxlbWVudCYpOwogCi0gICAgdm9pZCBwcml2YXRlQnJv d3NpbmdTdGF0ZURpZENoYW5nZSgpIG92ZXJyaWRlOworICAgIHZvaWQgcHJpdmF0ZUJyb3dzaW5n U3RhdGVEaWRDaGFuZ2UoUEFMOjpTZXNzaW9uSUQpIG92ZXJyaWRlOwogCiAgICAgLy8gTWVkaWEg Y2FjaGUgbWFuYWdlbWVudC4KICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgdm9pZCBzZXRNZWRp YUNhY2hlRGlyZWN0b3J5KGNvbnN0IFN0cmluZyYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggZWRh N2M1ZmE1ZDY0NzliYTcxMDkwMjBiNTI4MzJjZTI2MWJjZDdlOS4uNGQ0YTQ5YzczMWE0Y2FmNDZl ZGU2MTE1NzdjYjM5ZTZiZmZmMGEyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Q YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0yNTE3LDcgKzI1 MTcsNyBAQCB2b2lkIFBhZ2U6OnNldFNlc3Npb25JRChQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQp CiAgICAgZm9yIChGcmFtZSogZnJhbWUgPSAmbWFpbkZyYW1lKCk7IGZyYW1lOyBmcmFtZSA9IGZy YW1lLT50cmVlKCkudHJhdmVyc2VOZXh0KCkpIHsKICAgICAgICAgaWYgKCFmcmFtZS0+ZG9jdW1l bnQoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+ cHJpdmF0ZUJyb3dzaW5nU3RhdGVEaWRDaGFuZ2UoKTsKKyAgICAgICAgZnJhbWUtPmRvY3VtZW50 KCktPnByaXZhdGVCcm93c2luZ1N0YXRlRGlkQ2hhbmdlKG1fc2Vzc2lvbklEKTsKICAgICB9CiAK ICAgICAvLyBDb2xsZWN0IHRoZSBQbHVnaW5WaWV3cyBpbiB0byBhIHZlY3RvciB0byBlbnN1cmUg dGhhdCBhY3Rpb24gdGhlIHBsdWctaW4gdGFrZXMK