200663 2019-08-13 02:03:21 -0700 Fail decoding an invalid SessionID 2019-08-14 02:27:09 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen beidson cdumez commit-queue webkit-bug-importer oldest_to_newest 1560738 0 youennf 2019-08-13 02:03:21 -0700 Fail decoding an invalid SessionID 1560740 1 376152 youennf 2019-08-13 02:05:01 -0700 Created attachment 376152 Patch 1560757 2 webkit-bug-importer 2019-08-13 03:59:17 -0700 <rdar://problem/54251062> 1560758 3 youennf 2019-08-13 04:00:07 -0700 I kept a release assert for now when encoding a bad sessionID. Plan is to let it seat for a while and move it back to a regular ASSERT. I can change it back to a regular ASSERT() if that is thought as too crash risky though. 1560848 4 376152 achristensen 2019-08-13 10:47:42 -0700 Comment on attachment 376152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review > Source/WebCore/PAL/pal/SessionID.h:86 > + // FIXME: Change to a regular ASSERT. > + RELEASE_ASSERT(isValid()); I think we should just leave it a RELEASE_ASSERT 1560849 5 376152 achristensen 2019-08-13 10:48:20 -0700 Comment on attachment 376152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review > Source/WebCore/PAL/pal/SessionID.h:-107 > - // FIXME: We should fail to decode an invalid sessionID. I think we ought to return nullopt if isValid() is false. 1561102 6 376152 youennf 2019-08-14 01:59:14 -0700 Comment on attachment 376152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review >> Source/WebCore/PAL/pal/SessionID.h:86 >> + RELEASE_ASSERT(isValid()); > > I think we should just leave it a RELEASE_ASSERT OK. >> Source/WebCore/PAL/pal/SessionID.h:-107 >> - // FIXME: We should fail to decode an invalid sessionID. > > I think we ought to return nullopt if isValid() is false. It is returning nullopt, see line above. 1561104 7 376152 commit-queue 2019-08-14 02:27:07 -0700 Comment on attachment 376152 Patch Clearing flags on attachment: 376152 Committed r248663: <https://trac.webkit.org/changeset/248663> 1561105 8 commit-queue 2019-08-14 02:27:09 -0700 All reviewed patches have been landed. Closing bug. 376152 2019-08-13 02:05:01 -0700 2019-08-14 02:27:07 -0700 Patch bug-200663-20190813110457.patch text/plain 2837 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAwZTFiZmU3 MzU0MTQyNGMwZDE5ZGI5MThjNDUyZmUwNWY5ZTY3NWFmLi5mZDU0MGUxMjQ4N2M2Y2EwZWMyMjUx MWVjMDYzMzQ0ZmMwODMyMDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAor MjAxOS0wOC0xMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAg RmFpbCBkZWNvZGluZyBhbiBpbnZhbGlkIFNlc3Npb25JRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNjYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvU2Vzc2lvbklELmg6CisgICAgICAgIChQ QUw6OlNlc3Npb25JRDo6aXNWYWxpZCBjb25zdCk6CisgICAgICAgIChQQUw6OlNlc3Npb25JRDo6 aXNWYWxpZFNlc3Npb25JRFZhbHVlKToKKyAgICAgICAgKFBBTDo6U2Vzc2lvbklEOjplbmNvZGUg Y29uc3QpOgorICAgICAgICBBZGQgYSByZWxlYXNlIGFzc2VydCB0byBjYXRjaCBiYWQgc2Vzc2lv bklEIHNlbmRlcnMuCisgICAgICAgIChQQUw6OlNlc3Npb25JRDo6ZGVjb2RlKToKKyAgICAgICAg RmFpbCBkZWNvZGluZyBpZiBzZXNzaW9uIElEIGlzIG5vdCBhIHZhbGlkIHZhbHVlLgorCiAyMDE5 LTA4LTA5ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IFRhcHBpbmcgYnV0dG9ucyBpbiBEYXRhIERldGVjdG9ycyBsb29rdXAgcHJldmlld3MgZG9lc24n dCB3b3JrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1Nlc3Npb25JRC5oIGIv U291cmNlL1dlYkNvcmUvUEFML3BhbC9TZXNzaW9uSUQuaAppbmRleCBmN2NjYTdkZjEzNDdlMGNh MzkwNTVlY2NiMWVhYzgwYTkyMTQ2YzdhLi4yMTI5MDIyM2I4Mzg0Njk1ZGExMjIwNWQ5NWY1YzI5 ZTU5NzE2ZDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL1Nlc3Npb25JRC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvU2Vzc2lvbklELmgKQEAgLTUwLDcgKzUwLDcg QEAgcHVibGljOgogICAgIHN0YXRpYyBTZXNzaW9uSUQgZGVmYXVsdFNlc3Npb25JRCgpIHsgcmV0 dXJuIFNlc3Npb25JRChEZWZhdWx0U2Vzc2lvbklEKTsgfQogICAgIHN0YXRpYyBTZXNzaW9uSUQg bGVnYWN5UHJpdmF0ZVNlc3Npb25JRCgpIHsgcmV0dXJuIFNlc3Npb25JRChMZWdhY3lQcml2YXRl U2Vzc2lvbklEKTsgfQogCi0gICAgYm9vbCBpc1ZhbGlkKCkgY29uc3QgeyByZXR1cm4gbV9zZXNz aW9uSUQgIT0gSGFzaFRhYmxlRW1wdHlWYWx1ZUlEICYmIG1fc2Vzc2lvbklEICE9IEhhc2hUYWJs ZURlbGV0ZWRWYWx1ZUlEOyB9CisgICAgYm9vbCBpc1ZhbGlkKCkgY29uc3QgeyByZXR1cm4gaXNW YWxpZFNlc3Npb25JRFZhbHVlKG1fc2Vzc2lvbklEKTsgfQogICAgIGJvb2wgaXNFcGhlbWVyYWwo KSBjb25zdCB7IHJldHVybiBtX3Nlc3Npb25JRCAmIEVwaGVtZXJhbFNlc3Npb25NYXNrICYmIG1f c2Vzc2lvbklEICE9IEhhc2hUYWJsZURlbGV0ZWRWYWx1ZUlEOyB9CiAKICAgICBQQUxfRVhQT1JU IHN0YXRpYyBTZXNzaW9uSUQgZ2VuZXJhdGVFcGhlbWVyYWxTZXNzaW9uSUQoKTsKQEAgLTc0LDEz ICs3NCwxNiBAQCBwcml2YXRlOgogICAgIHsKICAgICB9CiAKKyAgICBzdGF0aWMgYm9vbCBpc1Zh bGlkU2Vzc2lvbklEVmFsdWUodWludDY0X3Qgc2Vzc2lvbklEKSB7IHJldHVybiBzZXNzaW9uSUQg IT0gSGFzaFRhYmxlRW1wdHlWYWx1ZUlEICYmIHNlc3Npb25JRCAhPSBIYXNoVGFibGVEZWxldGVk VmFsdWVJRDsgfQorCiAgICAgdWludDY0X3QgbV9zZXNzaW9uSUQ7CiB9OwogCiB0ZW1wbGF0ZTxj bGFzcyBFbmNvZGVyPgogdm9pZCBTZXNzaW9uSUQ6OmVuY29kZShFbmNvZGVyJiBlbmNvZGVyKSBj b25zdAogewotICAgIEFTU0VSVChpc1ZhbGlkKCkpOworICAgIC8vIEZJWE1FOiBDaGFuZ2UgdG8g YSByZWd1bGFyIEFTU0VSVC4KKyAgICBSRUxFQVNFX0FTU0VSVChpc1ZhbGlkKCkpOwogICAgIGVu Y29kZXIgPDwgbV9zZXNzaW9uSUQ7CiB9CiAKQEAgLTkyLDcgKzk1LDcgQEAgYm9vbCBTZXNzaW9u SUQ6OmRlY29kZShEZWNvZGVyJiBkZWNvZGVyLCBTZXNzaW9uSUQmIHNlc3Npb25JRCkKICAgICBp ZiAoIWRlY29kZWRTZXNzaW9uSUQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIHNlc3Np b25JRCA9IGRlY29kZWRTZXNzaW9uSUQudmFsdWUoKTsKKyAgICBzZXNzaW9uSUQgPSAqZGVjb2Rl ZFNlc3Npb25JRDsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMTAxLDExICsxMDQsOSBAQCBP cHRpb25hbDxTZXNzaW9uSUQ+IFNlc3Npb25JRDo6ZGVjb2RlKERlY29kZXImIGRlY29kZXIpCiB7 CiAgICAgT3B0aW9uYWw8dWludDY0X3Q+IHNlc3Npb25JRDsKICAgICBkZWNvZGVyID4+IHNlc3Np b25JRDsKLSAgICBpZiAoIXNlc3Npb25JRCkKKyAgICBpZiAoIXNlc3Npb25JRCB8fCAhaXNWYWxp ZFNlc3Npb25JRFZhbHVlKCpzZXNzaW9uSUQpKQogICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0 OwogCi0gICAgLy8gRklYTUU6IFdlIHNob3VsZCBmYWlsIHRvIGRlY29kZSBhbiBpbnZhbGlkIHNl c3Npb25JRC4KLSAgICBBU1NFUlQoU2Vzc2lvbklEIHsgKnNlc3Npb25JRCB9LmlzVmFsaWQoKSk7 CiAgICAgcmV0dXJuIFNlc3Npb25JRCB7ICpzZXNzaW9uSUQgfTsKIH0KIAo=