<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200660</bug_id>
          
          <creation_ts>2019-08-13 01:32:01 -0700</creation_ts>
          <short_desc>NetworkProcess::m_swServerConnections should use WeakPtr</short_desc>
          <delta_ts>2019-08-14 03:11:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1560727</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-08-13 01:32:01 -0700</bug_when>
    <thetext>NetworkProcess::m_swServerConnections should use WeakPtr</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560729</commentid>
    <comment_count>1</comment_count>
      <attachid>376148</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2019-08-13 01:34:42 -0700</bug_when>
    <thetext>Created attachment 376148
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560755</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-08-13 03:58:59 -0700</bug_when>
    <thetext>&lt;rdar://problem/54251053&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560796</commentid>
    <comment_count>3</comment_count>
      <attachid>376148</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2019-08-13 08:46:08 -0700</bug_when>
    <thetext>Comment on attachment 376148
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1561120</commentid>
    <comment_count>4</comment_count>
      <attachid>376148</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-14 03:11:17 -0700</bug_when>
    <thetext>Comment on attachment 376148
Patch

Clearing flags on attachment: 376148

Committed r248665: &lt;https://trac.webkit.org/changeset/248665&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1561121</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-14 03:11:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376148</attachid>
            <date>2019-08-13 01:34:42 -0700</date>
            <delta_ts>2019-08-14 03:11:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200660-20190813103441.patch</filename>
            <type>text/plain</type>
            <size>4345</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY0NTA5ZmJlZWQxNzc5NTNk
ZjQ4YTBjYTdhZjIxYmJhNjg1N2IxNGUuLmU2NjZkNDJiZWFiMmQ4OGZjZmRlMzYzOTBlOTYwYmYy
MzBmN2FkZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgtMTMgIFlvdWVubiBG
YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtQcm9jZXNzOjptX3N3
U2VydmVyQ29ubmVjdGlvbnMgc2hvdWxkIHVzZSBXZWFrUHRyCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2NjAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgV2Vha1B0ciBmb3IgU1dTZXJ2ZXIgY29u
bmVjdGlvbnMgYXMgYW4gZXh0cmEgc2FmZXR5IG1lYXN1cmUuCisKKyAgICAgICAgKiBOZXR3b3Jr
UHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9j
ZXNzOjpwb3N0TWVzc2FnZVRvU2VydmljZVdvcmtlckNsaWVudCk6CisgICAgICAgIChXZWJLaXQ6
Ok5ldHdvcmtQcm9jZXNzOjpwb3N0TWVzc2FnZVRvU2VydmljZVdvcmtlcik6CisgICAgICAgIChX
ZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpyZWdpc3RlclNXU2VydmVyQ29ubmVjdGlvbik6CisgICAg
ICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjp1bnJlZ2lzdGVyU1dTZXJ2ZXJDb25uZWN0aW9u
KToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oOgorCiAyMDE5LTA4
LTEyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBCbG9iIHJl
Z2lzdHJpZXMgc2hvdWxkIGJlIGtleWVkIGJ5IHNlc3Npb24gSURzCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJL
aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwCmluZGV4IGE5OGY3MGZhOTlhNTY1
MDFjN2MxZGFmNTI5YWVlYjA3MDlkMmM2ZjEuLjM0MDEzZjg1YmFmYzhhOTU5MTkyMmIyZTI2OGRh
NGIzOThhYzE5N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0
d29ya1Byb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29y
a1Byb2Nlc3MuY3BwCkBAIC0yNDc1LDEzICsyNDc1LDEzIEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6
OmNyZWF0ZVNlcnZlclRvQ29udGV4dENvbm5lY3Rpb24oY29uc3QgUmVnaXN0cmFibGVEb21haW4m
IHJlCiAKIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnBvc3RNZXNzYWdlVG9TZXJ2aWNlV29ya2VyQ2xp
ZW50KGNvbnN0IFNlcnZpY2VXb3JrZXJDbGllbnRJZGVudGlmaWVyJiBkZXN0aW5hdGlvbklkZW50
aWZpZXIsIE1lc3NhZ2VXaXRoTWVzc2FnZVBvcnRzJiYgbWVzc2FnZSwgU2VydmljZVdvcmtlcklk
ZW50aWZpZXIgc291cmNlSWRlbnRpZmllciwgY29uc3QgU3RyaW5nJiBzb3VyY2VPcmlnaW4pCiB7
Ci0gICAgaWYgKGF1dG8qIGNvbm5lY3Rpb24gPSBtX3N3U2VydmVyQ29ubmVjdGlvbnMuZ2V0KGRl
c3RpbmF0aW9uSWRlbnRpZmllci5zZXJ2ZXJDb25uZWN0aW9uSWRlbnRpZmllcikpCisgICAgaWYg
KGF1dG8gY29ubmVjdGlvbiA9IG1fc3dTZXJ2ZXJDb25uZWN0aW9ucy5nZXQoZGVzdGluYXRpb25J
ZGVudGlmaWVyLnNlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyKSkKICAgICAgICAgY29ubmVjdGlv
bi0+cG9zdE1lc3NhZ2VUb1NlcnZpY2VXb3JrZXJDbGllbnQoZGVzdGluYXRpb25JZGVudGlmaWVy
LmNvbnRleHRJZGVudGlmaWVyLCBXVEZNb3ZlKG1lc3NhZ2UpLCBzb3VyY2VJZGVudGlmaWVyLCBz
b3VyY2VPcmlnaW4pOwogfQogCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpwb3N0TWVzc2FnZVRvU2Vy
dmljZVdvcmtlcihXZWJDb3JlOjpTZXJ2aWNlV29ya2VySWRlbnRpZmllciBkZXN0aW5hdGlvbiwg
V2ViQ29yZTo6TWVzc2FnZVdpdGhNZXNzYWdlUG9ydHMmJiBtZXNzYWdlLCBjb25zdCBXZWJDb3Jl
OjpTZXJ2aWNlV29ya2VyT3JDbGllbnRJZGVudGlmaWVyJiBzb3VyY2UsIFNXU2VydmVyQ29ubmVj
dGlvbklkZW50aWZpZXIgY29ubmVjdGlvbklkZW50aWZpZXIpCiB7Ci0gICAgaWYgKGF1dG8qIGNv
bm5lY3Rpb24gPSBtX3N3U2VydmVyQ29ubmVjdGlvbnMuZ2V0KGNvbm5lY3Rpb25JZGVudGlmaWVy
KSkKKyAgICBpZiAoYXV0byBjb25uZWN0aW9uID0gbV9zd1NlcnZlckNvbm5lY3Rpb25zLmdldChj
b25uZWN0aW9uSWRlbnRpZmllcikpCiAgICAgICAgIGNvbm5lY3Rpb24tPnBvc3RNZXNzYWdlVG9T
ZXJ2aWNlV29ya2VyKGRlc3RpbmF0aW9uLCBXVEZNb3ZlKG1lc3NhZ2UpLCBzb3VyY2UpOwogfQog
CkBAIC0yNDg5LDcgKzI0ODksNyBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpyZWdpc3RlclNXU2Vy
dmVyQ29ubmVjdGlvbihXZWJTV1NlcnZlckNvbm5lY3Rpb24mIGNvbm5lY3RpbwogewogICAgIEFT
U0VSVChwYXJlbnRQcm9jZXNzSGFzU2VydmljZVdvcmtlckVudGl0bGVtZW50KCkpOwogICAgIEFT
U0VSVCghbV9zd1NlcnZlckNvbm5lY3Rpb25zLmNvbnRhaW5zKGNvbm5lY3Rpb24uaWRlbnRpZmll
cigpKSk7Ci0gICAgbV9zd1NlcnZlckNvbm5lY3Rpb25zLmFkZChjb25uZWN0aW9uLmlkZW50aWZp
ZXIoKSwgJmNvbm5lY3Rpb24pOworICAgIG1fc3dTZXJ2ZXJDb25uZWN0aW9ucy5hZGQoY29ubmVj
dGlvbi5pZGVudGlmaWVyKCksIG1ha2VXZWFrUHRyKGNvbm5lY3Rpb24pKTsKICAgICBhdXRvKiBz
dG9yZSA9IGV4aXN0aW5nU1dPcmlnaW5TdG9yZUZvclNlc3Npb24oY29ubmVjdGlvbi5zZXNzaW9u
SUQoKSk7CiAgICAgQVNTRVJUKHN0b3JlKTsKICAgICBpZiAoc3RvcmUpCkBAIC0yNDk4LDcgKzI0
OTgsNyBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpyZWdpc3RlclNXU2VydmVyQ29ubmVjdGlvbihX
ZWJTV1NlcnZlckNvbm5lY3Rpb24mIGNvbm5lY3RpbwogCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjp1
bnJlZ2lzdGVyU1dTZXJ2ZXJDb25uZWN0aW9uKFdlYlNXU2VydmVyQ29ubmVjdGlvbiYgY29ubmVj
dGlvbikKIHsKLSAgICBBU1NFUlQobV9zd1NlcnZlckNvbm5lY3Rpb25zLmdldChjb25uZWN0aW9u
LmlkZW50aWZpZXIoKSkgPT0gJmNvbm5lY3Rpb24pOworICAgIEFTU0VSVChtX3N3U2VydmVyQ29u
bmVjdGlvbnMuZ2V0KGNvbm5lY3Rpb24uaWRlbnRpZmllcigpKS5nZXQoKSA9PSAmY29ubmVjdGlv
bik7CiAgICAgbV9zd1NlcnZlckNvbm5lY3Rpb25zLnJlbW92ZShjb25uZWN0aW9uLmlkZW50aWZp
ZXIoKSk7CiAgICAgaWYgKGF1dG8qIHN0b3JlID0gZXhpc3RpbmdTV09yaWdpblN0b3JlRm9yU2Vz
c2lvbihjb25uZWN0aW9uLnNlc3Npb25JRCgpKSkKICAgICAgICAgc3RvcmUtPnVucmVnaXN0ZXJT
V1NlcnZlckNvbm5lY3Rpb24oY29ubmVjdGlvbik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ
cm9jZXNzL05ldHdvcmtQcm9jZXNzLmgKaW5kZXggOTQ4NjkwNDY1YWExNjQwYjlhYWVlYWVmYThi
MmU0NGJjNjUyZDM5MC4uNWJkYzg2ZDc5MTQzZDQ2MTlmMzBjM2U1N2QxNzJkODM3ZTNmZmMxMyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5o
CisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaApAQCAt
NTM0LDcgKzUzNCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nob3VsZERpc2FibGVTZXJ2aWNl
V29ya2VyUHJvY2Vzc1Rlcm1pbmF0aW9uRGVsYXkgeyBmYWxzZSB9OwogICAgIEhhc2hNYXA8UEFM
OjpTZXNzaW9uSUQsIFN0cmluZz4gbV9zd0RhdGFiYXNlUGF0aHM7CiAgICAgSGFzaE1hcDxQQUw6
OlNlc3Npb25JRCwgc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OlNXU2VydmVyPj4gbV9zd1NlcnZl
cnM7Ci0gICAgSGFzaE1hcDxXZWJDb3JlOjpTV1NlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyLCBX
ZWJTV1NlcnZlckNvbm5lY3Rpb24qPiBtX3N3U2VydmVyQ29ubmVjdGlvbnM7CisgICAgSGFzaE1h
cDxXZWJDb3JlOjpTV1NlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyLCBXZWFrUHRyPFdlYlNXU2Vy
dmVyQ29ubmVjdGlvbj4+IG1fc3dTZXJ2ZXJDb25uZWN0aW9uczsKICNlbmRpZgogCiAjaWYgUExB
VEZPUk0oQ09DT0EpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>