200659 2019-08-13 00:29:12 -0700 JSContext Inspector: Basic CommandLineAPI doesn't work 2019-08-13 08:34:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1560713 0 joepeck 2019-08-13 00:29:12 -0700 JSContext Inspector: Basic CommandLineAPI doesn't work Steps to Reproduce: 1. Inspect a JSContext 2. Try to use `dir(...)` and $n 1560714 1 webkit-bug-importer 2019-08-13 00:29:28 -0700 <rdar://problem/54245476> 1560715 2 joepeck 2019-08-13 00:30:34 -0700 Caught by ESLint on InjectedScriptSource. So I'll also address ESLint issues. 1560717 3 376141 joepeck 2019-08-13 00:35:53 -0700 Created attachment 376141 [PATCH] Proposed Fix 1560783 4 376141 bburg 2019-08-13 08:16:19 -0700 Comment on attachment 376141 [PATCH] Proposed Fix r=me 1560785 5 376141 commit-queue 2019-08-13 08:34:35 -0700 Comment on attachment 376141 [PATCH] Proposed Fix Clearing flags on attachment: 376141 Committed r248595: <https://trac.webkit.org/changeset/248595> 1560786 6 commit-queue 2019-08-13 08:34:37 -0700 All reviewed patches have been landed. Closing bug. 376141 2019-08-13 00:35:53 -0700 2019-08-13 08:34:35 -0700 [PATCH] Proposed Fix fix.patch text/plain 4812 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE3MjUzMWY3YzYwLi5kMjIxY2ZjMmEyNSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDgtMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBKU0NvbnRleHQgSW5z cGVjdG9yOiBCYXNpYyBDb21tYW5kTGluZUFQSSBkb2Vzbid0IHdvcmsKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDY1OQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTQyNDU0NzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAg IChCYXNpY0NvbW1hbmRMaW5lQVBJKToKKyAgICAgICAgVXNlIGBtZXRob2RgIGRpcmVjdGx5IHNp bmNlIGl0IGFscmVhZHkgaGFzIGJlZW4gc2V0dXAgbmljZWx5IGFuZCBkb2Vzbid0CisgICAgICAg IG5lZWQgdG8gYmUgYm91bmQuIFRlY2huaWNhbGx5IHRoaXMgYWxsb3dzIHNvbWVvbmUgdG8gYWRk IHByb3BlcnRpZXMgdG8KKyAgICAgICAgdGhlIENvbW1hbmRMaW5lQVBJIG1ldGhvZHMgaW4gYmFz aWMgbW9kZSAoYGRpci5wcm9wZXJ0eSA9IDFgKSBidXQgdGhhdAorICAgICAgICBzZWVtcyBoYXJt bGVzcy4KKwogMjAxOS0wOC0xMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgog CiAgICAgICAgIFtXVEZdW0pTQ10gTWFrZSBKU0MgYW5kIFdURiBhZ2dyZXNzaXZlbHktZmFzdC1t YWxsb2NlZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9Jbmpl Y3RlZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRTb3VyY2UuanMKaW5kZXggM2JkNmFmMzYxZjguLmU5YTMxN2ViMTA4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291 cmNlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRTb3VyY2UuanMKQEAgLTI5MCw3ICsyOTAsNyBAQCBsZXQgSW5qZWN0ZWRTY3JpcHQgPSBjbGFz cyBJbmplY3RlZFNjcmlwdAogICAgICAgICAgICAgbGV0IGNhbGxBcmd1bWVudCA9IEluamVjdGVk U2NyaXB0SG9zdC5ldmFsdWF0ZSgiKCIgKyBjYWxsQXJndW1lbnRKU09OICsgIikiKTsKICAgICAg ICAgICAgIGxldCB2YWx1ZSA9IHRoaXMuX3Jlc29sdmVDYWxsQXJndW1lbnQoY2FsbEFyZ3VtZW50 KTsKICAgICAgICAgICAgIHRoaXMuX3NhdmVSZXN1bHQodmFsdWUpOwotICAgICAgICB9IGNhdGNo IChlKSB7fQorICAgICAgICB9IGNhdGNoIHsgfQogCiAgICAgICAgIHJldHVybiB0aGlzLl9zYXZl ZFJlc3VsdEluZGV4OwogICAgIH0KQEAgLTUxNCw3ICs1MTQsNyBAQCBsZXQgSW5qZWN0ZWRTY3Jp cHQgPSBjbGFzcyBJbmplY3RlZFNjcmlwdAogICAgICAgICBsZXQgcmVtb3RlT2JqZWN0ID0gUmVt b3RlT2JqZWN0LmNyZWF0ZSh2YWx1ZSwgb2JqZWN0R3JvdXApOwogICAgICAgICB0cnkgewogICAg ICAgICAgICAgcmVtb3RlT2JqZWN0LmRlc2NyaXB0aW9uID0gdG9TdHJpbmdEZXNjcmlwdGlvbih2 YWx1ZSk7Ci0gICAgICAgIH0gY2F0Y2ggKGUpIHt9CisgICAgICAgIH0gY2F0Y2ggeyB9CiAgICAg ICAgIHJldHVybiB7CiAgICAgICAgICAgICB3YXNUaHJvd246IHRydWUsCiAgICAgICAgICAgICBy ZXN1bHQ6IHJlbW90ZU9iamVjdApAQCAtNzQ0LDcgKzc0NCw3IEBAIGxldCBJbmplY3RlZFNjcmlw dCA9IGNsYXNzIEluamVjdGVkU2NyaXB0CiAgICAgICAgIGxldCBpc0FycmF5TGlrZSA9IGZhbHNl OwogICAgICAgICB0cnkgewogICAgICAgICAgICAgaXNBcnJheUxpa2UgPSBSZW1vdGVPYmplY3Qu c3VidHlwZShvYmplY3QpID09PSAiYXJyYXkiICYmIGlzRmluaXRlKG9iamVjdC5sZW5ndGgpICYm IG9iamVjdC5sZW5ndGggPiAwOwotICAgICAgICB9IGNhdGNoKGUpIHt9CisgICAgICAgIH0gY2F0 Y2ggeyB9CiAKICAgICAgICAgZm9yIChsZXQgbyA9IG9iamVjdDsgaXNEZWZpbmVkKG8pOyBvID0g T2JqZWN0LmdldFByb3RvdHlwZU9mKG8pKSB7CiAgICAgICAgICAgICBsZXQgaXNPd25Qcm9wZXJ0 eSA9IG8gPT09IG9iamVjdDsKQEAgLTc2NSw3ICs3NjUsNyBAQCBsZXQgSW5qZWN0ZWRTY3JpcHQg PSBjbGFzcyBJbmplY3RlZFNjcmlwdAogICAgICAgICB0cnkgewogICAgICAgICAgICAgaWYgKG9i amVjdC5fX3Byb3RvX18pCiAgICAgICAgICAgICAgICAgZGVzY3JpcHRvcnMucHVzaCh7bmFtZTog Il9fcHJvdG9fXyIsIHZhbHVlOiBvYmplY3QuX19wcm90b19fLCB3cml0YWJsZTogdHJ1ZSwgY29u ZmlndXJhYmxlOiB0cnVlLCBlbnVtZXJhYmxlOiBmYWxzZSwgaXNPd246IHRydWV9KTsKLSAgICAg ICAgfSBjYXRjaCAoZSkge30KKyAgICAgICAgfSBjYXRjaCB7IH0KIAogICAgICAgICByZXR1cm4g ZGVzY3JpcHRvcnM7CiAgICAgfQpAQCAtODY2LDcgKzg2Niw3IEBAIGxldCBJbmplY3RlZFNjcmlw dCA9IGNsYXNzIEluamVjdGVkU2NyaXB0CiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fc2F2 ZWRSZXN1bHRzW2luZGV4XTsKICAgICB9Ci19Cit9OwogCiBJbmplY3RlZFNjcmlwdC5Db2xsZWN0 aW9uTW9kZSA9IHsKICAgICBPd25Qcm9wZXJ0aWVzOiAxIDw8IDAsICAgICAgICAgIC8vIG93biBw cm9wZXJ0aWVzLgpAQCAtOTgwLDcgKzk4MCw3IEBAIGxldCBSZW1vdGVPYmplY3QgPSBjbGFzcyBS ZW1vdGVPYmplY3QKICAgICAgICAgdHJ5IHsKICAgICAgICAgICAgIGlmICh0eXBlb2YgdmFsdWUu c3BsaWNlID09PSAiZnVuY3Rpb24iICYmIGlzRmluaXRlKHZhbHVlLmxlbmd0aCkpCiAgICAgICAg ICAgICAgICAgcmV0dXJuICJhcnJheSI7Ci0gICAgICAgIH0gY2F0Y2ggKGUpIHt9CisgICAgICAg IH0gY2F0Y2ggeyB9CiAKICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgfQpAQCAtMTEzNCw3ICsx MTM0LDcgQEAgbGV0IFJlbW90ZU9iamVjdCA9IGNsYXNzIFJlbW90ZU9iamVjdAogICAgICAgICAg ICAgdGhpcy5fYXBwZW5kUHJvcGVydHlQcmV2aWV3cyhvYmplY3QsIHByZXZpZXcsIGRlc2NyaXB0 b3JzLCBmYWxzZSwgcHJvcGVydGllc1RocmVzaG9sZCwgZmlyc3RMZXZlbEtleXMsIHNlY29uZExl dmVsS2V5cyk7CiAgICAgICAgICAgICBpZiAocHJvcGVydGllc1RocmVzaG9sZC5pbmRleGVzIDwg MCB8fCBwcm9wZXJ0aWVzVGhyZXNob2xkLnByb3BlcnRpZXMgPCAwKQogICAgICAgICAgICAgICAg IHJldHVybiBwcmV2aWV3OwotICAgICAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIH0gY2F0Y2gg ewogICAgICAgICAgICAgcHJldmlldy5sb3NzbGVzcyA9IGZhbHNlOwogICAgICAgICB9CiAKQEAg LTEzODYsNyArMTM4Niw3IEBAIGxldCBSZW1vdGVPYmplY3QgPSBjbGFzcyBSZW1vdGVPYmplY3QK IAogICAgICAgICByZXR1cm4gc3RyaW5nLnN1YnN0cigwLCBtYXhMZW5ndGgpICsgIlx1MjAyNiI7 CiAgICAgfQotfQorfTsKIAogLy8gLS0tLS0tLQogCkBAIC0xMzk4LDcgKzEzOTgsNyBAQCBJbmpl Y3RlZFNjcmlwdC5DYWxsRnJhbWVQcm94eSA9IGZ1bmN0aW9uKG9yZGluYWwsIGNhbGxGcmFtZSkK ICAgICB0aGlzLnNjb3BlQ2hhaW4gPSB0aGlzLl93cmFwU2NvcGVDaGFpbihjYWxsRnJhbWUpOwog ICAgIHRoaXMudGhpcyA9IFJlbW90ZU9iamVjdC5jcmVhdGUoY2FsbEZyYW1lLnRoaXNPYmplY3Qs ICJiYWNrdHJhY2UiKTsKICAgICB0aGlzLmlzVGFpbERlbGV0ZWQgPSBjYWxsRnJhbWUuaXNUYWls RGVsZXRlZDsKLX0KK307CiAKIEluamVjdGVkU2NyaXB0LkNhbGxGcmFtZVByb3h5LnByb3RvdHlw ZSA9IHsKICAgICBfd3JhcFNjb3BlQ2hhaW4oY2FsbEZyYW1lKQpAQCAtMTQxMSw3ICsxNDExLDcg QEAgSW5qZWN0ZWRTY3JpcHQuQ2FsbEZyYW1lUHJveHkucHJvdG90eXBlID0gewogICAgICAgICAg ICAgc2NvcGVDaGFpblByb3h5W2ldID0gSW5qZWN0ZWRTY3JpcHQuQ2FsbEZyYW1lUHJveHkuX2Ny ZWF0ZVNjb3BlSnNvbihzY29wZUNoYWluW2ldLCBzY29wZURlc2NyaXB0aW9uc1tpXSwgImJhY2t0 cmFjZSIpOwogICAgICAgICByZXR1cm4gc2NvcGVDaGFpblByb3h5OwogICAgIH0KLX0KK307CiAK IEluamVjdGVkU2NyaXB0LkNhbGxGcmFtZVByb3h5Ll9zY29wZVR5cGVOYW1lcyA9IHsKICAgICAw OiAiZ2xvYmFsIiwgLy8gR0xPQkFMX1NDT1BFCkBAIC0xNDgyLDggKzE0ODIsNyBAQCBmdW5jdGlv biBCYXNpY0NvbW1hbmRMaW5lQVBJKGNhbGxGcmFtZSkKICAgICAvLyBDb21tYW5kIExpbmUgQVBJ IG1ldGhvZHMuCiAgICAgZm9yIChsZXQgaSA9IDA7IGkgPCBCYXNpY0NvbW1hbmRMaW5lQVBJLm1l dGhvZHMubGVuZ3RoOyArK2kpIHsKICAgICAgICAgbGV0IG1ldGhvZCA9IEJhc2ljQ29tbWFuZExp bmVBUEkubWV0aG9kc1tpXTsKLSAgICAgICAgdGhpc1ttZXRob2RdID0gYmluZChjb21tYW5kTGlu ZUFQSUltcGxbbWV0aG9kXSwgY29tbWFuZExpbmVBUElJbXBsKTsKLSAgICAgICAgdGhpc1ttZXRo b2RdLnRvU3RyaW5nID0gZnVuY3Rpb24oKSB7IHJldHVybiAiZnVuY3Rpb24gIiArIG1ldGhvZCAr ICIoKSB7IFtDb21tYW5kIExpbmUgQVBJXSB9IiB9OworICAgICAgICB0aGlzW21ldGhvZC5uYW1l XSA9IG1ldGhvZDsKICAgICB9CiB9CiAK