200650 2019-08-12 17:58:33 -0700 Make sure UniqueIDBDatabaseConnection unregister itself from IDBServer 2019-08-13 10:09:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen alecflett beidson cdumez commit-queue ews-watchlist jsbell webkit-bug-importer youennf oldest_to_newest 1560636 0 sihui_liu 2019-08-12 17:58:33 -0700 Like https://bugs.webkit.org/show_bug.cgi?id=196651 but the real UniqueIDBDatabaseConnection version :P 1560637 1 sihui_liu 2019-08-12 18:08:56 -0700 <rdar://problem/54236010> 1560649 2 376123 sihui_liu 2019-08-12 18:28:42 -0700 Created attachment 376123 Patch 1560833 3 376123 commit-queue 2019-08-13 10:09:01 -0700 Comment on attachment 376123 Patch Clearing flags on attachment: 376123 Committed r248597: <https://trac.webkit.org/changeset/248597> 1560834 4 commit-queue 2019-08-13 10:09:02 -0700 All reviewed patches have been landed. Closing bug. 376123 2019-08-12 18:28:42 -0700 2019-08-13 10:09:01 -0700 Patch bug-200650-20190812182841.patch text/plain 5925 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhmY2FkZWJkMzJkYmJk OWY3YWQ1MDRmMzk0ZjQ5MDk3YzM4NGMzNy4uNWI5ZWI5Y2VhMzYwNzc5YmEyMmM0MzQyY2IzYzQ1 NzRmOGFjZmI3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA4LTEyICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugc3VyZSBVbmlxdWVJ REJEYXRhYmFzZUNvbm5lY3Rpb24gdW5yZWdpc3RlciBpdHNlbGYgZnJvbSBJREJTZXJ2ZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDY1MAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTQyMzYwMTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgcmVnaXN0ZXIgVW5pcXVlSURCRGF0YWJhc2VDb25u ZWN0aW9uIHVuY29uZGl0aW9uYWxseSB0byBJREJTZXJ2ZXIgYnV0IGZhaWwgdG8gdW5yZWdpc3Rl ciBpZiBVbmlxdWVJREJEYXRhYmFzZQorICAgICAgICBvZiBVbmlxdWVJREJEYXRhYmFzZUNvbm5l Y3Rpb24gaXMgZ29uZS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9Vbmlx dWVJREJEYXRhYmFzZUNvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVy OjpVbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb246OlVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlv bik6CisgICAgICAgIChXZWJDb3JlOjpJREJTZXJ2ZXI6OlVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVj dGlvbjo6flVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlvbik6CisgICAgICAgICogTW9kdWxlcy9p bmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlvbi5oOgorICAgICAgICAo V2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb246OnNlcnZlcik6 CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlVHJh bnNhY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRh YmFzZVRyYW5zYWN0aW9uOjpVbmlxdWVJREJEYXRhYmFzZVRyYW5zYWN0aW9uKToKKyAgICAgICAg KFdlYkNvcmU6OklEQlNlcnZlcjo6VW5pcXVlSURCRGF0YWJhc2VUcmFuc2FjdGlvbjo6flVuaXF1 ZUlEQkRhdGFiYXNlVHJhbnNhY3Rpb24pOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3Nl cnZlci9VbmlxdWVJREJEYXRhYmFzZVRyYW5zYWN0aW9uLmg6CisKIDIwMTktMDgtMTIgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgQmxvYjo6bV9zaXpl IGFuIE9wdGlvbmFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk Yi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2VDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb24uY3Bw CmluZGV4IDk5OTFkMWVlNjlkOGUyZTA2NWEzZmU1MWYyNzM4YzkzYWVmOWU0ZTIuLjdmZGRmMGZh MzQwMDY3MTY0MzEzNTA3YzA4MTZlZjdlMjBjZTBlZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJ REJEYXRhYmFzZUNvbm5lY3Rpb24uY3BwCkBAIC00NSwxNyArNDUsMTggQEAgUmVmPFVuaXF1ZUlE QkRhdGFiYXNlQ29ubmVjdGlvbj4gVW5pcXVlSURCRGF0YWJhc2VDb25uZWN0aW9uOjpjcmVhdGUo VW5pcXVlSURCRGEKIAogVW5pcXVlSURCRGF0YWJhc2VDb25uZWN0aW9uOjpVbmlxdWVJREJEYXRh YmFzZUNvbm5lY3Rpb24oVW5pcXVlSURCRGF0YWJhc2UmIGRhdGFiYXNlLCBTZXJ2ZXJPcGVuREJS ZXF1ZXN0JiByZXF1ZXN0KQogICAgIDogbV9kYXRhYmFzZShtYWtlV2Vha1B0cihkYXRhYmFzZSkp CisgICAgLCBtX3NlcnZlcihtYWtlV2Vha1B0cihtX2RhdGFiYXNlLT5zZXJ2ZXIoKSkpCiAgICAg LCBtX2Nvbm5lY3Rpb25Ub0NsaWVudChyZXF1ZXN0LmNvbm5lY3Rpb24oKSkKICAgICAsIG1fb3Bl blJlcXVlc3RJZGVudGlmaWVyKHJlcXVlc3QucmVxdWVzdERhdGEoKS5yZXF1ZXN0SWRlbnRpZmll cigpKQogewotICAgIG1fZGF0YWJhc2UtPnNlcnZlcigpLnJlZ2lzdGVyRGF0YWJhc2VDb25uZWN0 aW9uKCp0aGlzKTsKKyAgICBtX3NlcnZlci0+cmVnaXN0ZXJEYXRhYmFzZUNvbm5lY3Rpb24oKnRo aXMpOwogICAgIG1fY29ubmVjdGlvblRvQ2xpZW50LT5yZWdpc3RlckRhdGFiYXNlQ29ubmVjdGlv bigqdGhpcyk7CiB9CiAKIFVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlvbjo6flVuaXF1ZUlEQkRh dGFiYXNlQ29ubmVjdGlvbigpCiB7Ci0gICAgaWYgKG1fZGF0YWJhc2UpCi0gICAgICAgIG1fZGF0 YWJhc2UtPnNlcnZlcigpLnVucmVnaXN0ZXJEYXRhYmFzZUNvbm5lY3Rpb24oKnRoaXMpOworICAg IGlmIChtX3NlcnZlcikKKyAgICAgICAgbV9zZXJ2ZXItPnVucmVnaXN0ZXJEYXRhYmFzZUNvbm5l Y3Rpb24oKnRoaXMpOwogICAgIG1fY29ubmVjdGlvblRvQ2xpZW50LT51bnJlZ2lzdGVyRGF0YWJh c2VDb25uZWN0aW9uKCp0aGlzKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlvbi5oIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlQ29u bmVjdGlvbi5oCmluZGV4IDAxZDE4MTMyMDQ5NDE0OWU3OGRhYTVhMzM1ZTk2OWIyYTg0ZWQ1NWIu LjY1MzY5YjY1M2VkMDBlNTdiZTM0NjJiOWNiZmNlYzg1ZmJhNmVhZTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZUNv bm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIv VW5pcXVlSURCRGF0YWJhc2VDb25uZWN0aW9uLmgKQEAgLTU0LDYgKzU0LDcgQEAgcHVibGljOgog CiAgICAgY29uc3QgSURCUmVzb3VyY2VJZGVudGlmaWVyJiBvcGVuUmVxdWVzdElkZW50aWZpZXIo KSB7IHJldHVybiBtX29wZW5SZXF1ZXN0SWRlbnRpZmllcjsgfQogICAgIFVuaXF1ZUlEQkRhdGFi YXNlKiBkYXRhYmFzZSgpIHsgcmV0dXJuIG1fZGF0YWJhc2UuZ2V0KCk7IH0KKyAgICBJREJTZXJ2 ZXIqIHNlcnZlcigpIHsgcmV0dXJuIG1fc2VydmVyLmdldCgpOyB9CiAgICAgSURCQ29ubmVjdGlv blRvQ2xpZW50JiBjb25uZWN0aW9uVG9DbGllbnQoKSB7IHJldHVybiBtX2Nvbm5lY3Rpb25Ub0Ns aWVudDsgfQogCiAgICAgdm9pZCBjb25uZWN0aW9uUGVuZGluZ0Nsb3NlRnJvbUNsaWVudCgpOwpA QCAtOTAsNiArOTEsNyBAQCBwcml2YXRlOgogICAgIFVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlv bihVbmlxdWVJREJEYXRhYmFzZSYsIFNlcnZlck9wZW5EQlJlcXVlc3QmKTsKIAogICAgIFdlYWtQ dHI8VW5pcXVlSURCRGF0YWJhc2U+IG1fZGF0YWJhc2U7CisgICAgV2Vha1B0cjxJREJTZXJ2ZXI+ IG1fc2VydmVyOwogICAgIFJlZjxJREJDb25uZWN0aW9uVG9DbGllbnQ+IG1fY29ubmVjdGlvblRv Q2xpZW50OwogICAgIElEQlJlc291cmNlSWRlbnRpZmllciBtX29wZW5SZXF1ZXN0SWRlbnRpZmll cjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVy L1VuaXF1ZUlEQkRhdGFiYXNlVHJhbnNhY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlVHJhbnNhY3Rpb24uY3BwCmluZGV4 IGFmOTJlYmM2MzY4ODVjNjljMjVlNTAyOTljZTZjNGFjZWFhNjU5YzguLmYxN2E0ZTU1MjNmYjVm NjFiMDI2YTA5MTQ3ZjgxNDFkNWI2NDEzOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZVRyYW5zYWN0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0 YWJhc2VUcmFuc2FjdGlvbi5jcHAKQEAgLTUzLDkgKzUzLDggQEAgVW5pcXVlSURCRGF0YWJhc2VU cmFuc2FjdGlvbjo6VW5pcXVlSURCRGF0YWJhc2VUcmFuc2FjdGlvbihVbmlxdWVJREJEYXRhYmFz ZUNvbm4KICAgICBpZiAobV90cmFuc2FjdGlvbkluZm8ubW9kZSgpID09IElEQlRyYW5zYWN0aW9u TW9kZTo6VmVyc2lvbmNoYW5nZSkKICAgICAgICAgbV9vcmlnaW5hbERhdGFiYXNlSW5mbyA9IHN0 ZDo6bWFrZV91bmlxdWU8SURCRGF0YWJhc2VJbmZvPihkYXRhYmFzZS0+aW5mbygpKTsKIAotICAg IGF1dG8mIHNlcnZlciA9IGRhdGFiYXNlLT5zZXJ2ZXIoKTsKLSAgICBtX3NlcnZlciA9IG1ha2VX ZWFrUHRyKHNlcnZlcik7Ci0gICAgc2VydmVyLnJlZ2lzdGVyVHJhbnNhY3Rpb24oKnRoaXMpOwor ICAgIGlmIChhdXRvKiBzZXJ2ZXIgPSBtX2RhdGFiYXNlQ29ubmVjdGlvbi0+c2VydmVyKCkpCisg ICAgICAgIHNlcnZlci0+cmVnaXN0ZXJUcmFuc2FjdGlvbigqdGhpcyk7CiB9CiAKIFVuaXF1ZUlE QkRhdGFiYXNlVHJhbnNhY3Rpb246On5VbmlxdWVJREJEYXRhYmFzZVRyYW5zYWN0aW9uKCkKQEAg LTYzLDggKzYyLDggQEAgVW5pcXVlSURCRGF0YWJhc2VUcmFuc2FjdGlvbjo6flVuaXF1ZUlEQkRh dGFiYXNlVHJhbnNhY3Rpb24oKQogICAgIGlmIChhdXRvIGRhdGFiYXNlID0gbV9kYXRhYmFzZUNv bm5lY3Rpb24tPmRhdGFiYXNlKCkpCiAgICAgICAgIGRhdGFiYXNlLT50cmFuc2FjdGlvbkRlc3Ry b3llZCgqdGhpcyk7CiAKLSAgICBpZiAobV9zZXJ2ZXIpCi0gICAgICAgIG1fc2VydmVyLT51bnJl Z2lzdGVyVHJhbnNhY3Rpb24oKnRoaXMpOworICAgIGlmIChhdXRvKiBzZXJ2ZXIgPSBtX2RhdGFi YXNlQ29ubmVjdGlvbi0+c2VydmVyKCkpCisgICAgICAgIHNlcnZlci0+dW5yZWdpc3RlclRyYW5z YWN0aW9uKCp0aGlzKTsKIH0KIAogSURCRGF0YWJhc2VJbmZvKiBVbmlxdWVJREJEYXRhYmFzZVRy YW5zYWN0aW9uOjpvcmlnaW5hbERhdGFiYXNlSW5mbygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2VUcmFu c2FjdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1 ZUlEQkRhdGFiYXNlVHJhbnNhY3Rpb24uaAppbmRleCBkNzVkMDExYmQ5OTg1Y2YyZGQwMWRkY2Vk MWQ5YjRlY2RkZjQwYzczLi44ZDhkOGQyMmI0NGVlMGRkMWQzYWZkYWI0MWYwMzZjNWJjNmM2MWQ2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5p cXVlSURCRGF0YWJhc2VUcmFuc2FjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZVRyYW5zYWN0aW9uLmgKQEAgLTEwMSw3 ICsxMDEsNiBAQCBwcml2YXRlOgogCiAgICAgUmVmPFVuaXF1ZUlEQkRhdGFiYXNlQ29ubmVjdGlv bj4gbV9kYXRhYmFzZUNvbm5lY3Rpb247CiAgICAgSURCVHJhbnNhY3Rpb25JbmZvIG1fdHJhbnNh Y3Rpb25JbmZvOwotICAgIFdlYWtQdHI8SURCU2VydmVyPiBtX3NlcnZlcjsKIAogICAgIHN0ZDo6 dW5pcXVlX3B0cjxJREJEYXRhYmFzZUluZm8+IG1fb3JpZ2luYWxEYXRhYmFzZUluZm87CiAK