200649 2019-08-12 17:02:06 -0700 Add a way to opt out of kern TCSM for layout tests 2019-08-13 20:38:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ap benjamin commit-queue fpizlo ggaren gskachkov guijemont jbedard keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1560611 0 saam 2019-08-12 17:02:06 -0700 ... 1560612 1 saam 2019-08-12 17:02:38 -0700 <rdar://problem/51304923> 1560655 2 376127 saam 2019-08-12 19:06:13 -0700 Created attachment 376127 patch 1560670 3 376127 ap 2019-08-12 20:26:43 -0700 Comment on attachment 376127 patch How does one pass an option of this kind to WebKitTestRunner’s WebContent process? 1560972 4 saam 2019-08-13 15:06:02 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 376127 [details] > patch > > How does one pass an option of this kind to WebKitTestRunner’s WebContent > process? Set the environment variable "JSC_useKernTCSM=false" 1561006 5 376223 jbedard 2019-08-13 16:33:37 -0700 Created attachment 376223 set-environment-webkitpy Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree? 1561009 6 ap 2019-08-13 17:10:05 -0700 > Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree? I don't think that there is any practical difference. Theoretically, setting it in WebKitTestRunner/DumpRenderTree is slightly better because running them manually (without run-webkit-tests) will result in the same behavior as with run-webkit-tests. In addition to layout tests, JSC tests probably need this too. Also, we should probably use a separate bug for the adoption. 1561058 7 376127 commit-queue 2019-08-13 20:38:13 -0700 Comment on attachment 376127 patch Clearing flags on attachment: 376127 Committed r248661: <https://trac.webkit.org/changeset/248661> 1561059 8 commit-queue 2019-08-13 20:38:15 -0700 All reviewed patches have been landed. Closing bug. 376127 2019-08-12 19:06:13 -0700 2019-08-13 20:38:13 -0700 patch a-backup.diff text/plain 2087 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ4NTgzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE5LTA4LTEyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBhIHdheSB0byBvcHQgb3V0IG9mIGtlcm4gVENTTSBmb3IgbGF5b3V0IHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA2NDkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUxMzA0OTIzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0NQVS5jcHA6CisgICAgICAgIChKU0M6 OmlzS2VyblRDU01BdmFpbGFibGUpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAy MDE5LTA4LTEyICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBs YWNlIG11bHRpcGFyYW1ldGVyIG92ZXJsb2FkcyBvZiBhcHBlbmQoKSBpbiBTdHJpbmdCdWlsZGVy IGFzIGEgZmlyc3Qgc3RlcCB0b3dhcmQgc3RhbmRhcmRpemluZ2luZyBvbiB0aGUgZmxleGlibGVB cHBlbmQoKSBpbXBsZW1lbnRhdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9DUFUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQ1BVLmNwcAkocmV2aXNpb24gMjQ4NTgzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9DUFUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw5IEBAIG5hbWVzcGFj ZSBKU0MgewogI2lmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSkgJiYgT1MoREFSV0lOKQogYm9v bCBpc0tlcm5UQ1NNQXZhaWxhYmxlKCkKIHsKKyAgICBpZiAoIU9wdGlvbnM6OnVzZUtlcm5UQ1NN KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHVpbnQzMl90IHZhbCA9IDA7CiAgICAg c2l6ZV90IHZhbFNpemUgPSBzaXplb2YodmFsKTsKICAgICBpbnQgcmMgPSBzeXNjdGxieW5hbWUo Imtlcm4udGNzbV9hdmFpbGFibGUiLCAmdmFsLCAmdmFsU2l6ZSwgTlVMTCwgMCk7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCShyZXZpc2lvbiAyNDg1ODMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkK QEAgLTExMyw2ICsxMTMsNyBAQCBjb25zdGV4cHIgYm9vbCBlbmFibGVXZWJBc3NlbWJseVN0cmVh bWluCiAjZW5kaWYKIAogI2RlZmluZSBKU0NfT1BUSU9OUyh2KSBcCisgICAgdihib29sLCB1c2VL ZXJuVENTTSwgdHJ1ZSwgTm9ybWFsLCAiTm90ZTogdGhpcyBuZWVkcyB0byBnbyBiZWZvcmUgb3Ro ZXIgb3B0aW9ucyBzaW5jZSB0aGV5IGRlcGVuZCBvbiB0aGlzIHZhbHVlLiIpIFwKICAgICB2KGJv b2wsIHZhbGlkYXRlT3B0aW9ucywgZmFsc2UsIE5vcm1hbCwgImNyYXNoZXMgaWYgbWlzLXR5cGVk IEpTQyBvcHRpb25zIHdlcmUgcGFzc2VkIHRvIHRoZSBWTSIpIFwKICAgICB2KHVuc2lnbmVkLCBk dW1wT3B0aW9ucywgMCwgTm9ybWFsLCAiZHVtcHMgSlNDIG9wdGlvbnMgKDAgPSBOb25lLCAxID0g T3ZlcnJpZGRlbiBvbmx5LCAyID0gQWxsLCAzID0gVmVyYm9zZSkiKSBcCiAgICAgdihvcHRpb25T dHJpbmcsIGNvbmZpZ0ZpbGUsIG51bGxwdHIsIE5vcm1hbCwgImZpbGUgdG8gY29uZmlndXJlIEpT QyBvcHRpb25zIGFuZCBsb2dnaW5nIGxvY2F0aW9uIikgXAo= 376223 2019-08-13 16:33:37 -0700 2019-08-13 16:33:37 -0700 set-environment-webkitpy patch.patch text/plain 1556 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0ODY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTA4LTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgYSB3YXkgdG8gb3B0IG91dCBvZiBrZXJuIFRDU00gZm9yIGxheW91 dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjAwNjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9zZXR1 cF9lbnZpcm9uX2Zvcl9kcml2ZXIpOiBEaXNhYmxlIFRDU00gaW4gSmF2YVNjcmlwdENvcmUgd2hl biBydW5uaW5nCisgICAgICAgIGxheW91dCB0ZXN0cy4KKwogMjAxOS0wOC0xMyAgSm9obiBXaWxh bmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNvdXJjZSBMb2FkIFN0YXRp c3RpY3M6IFN3aXRjaCBOU1VSTFNlc3Npb24gb24gdG9wIG5hdmlnYXRpb24gdG8gcHJldmFsZW50 IHJlc291cmNlIHdpdGggdXNlciBpbnRlcmFjdGlvbgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2RyaXZlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvZHJpdmVyLnB5CShyZXZpc2lvbiAyNDg2NDEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZHJpdmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MzQsNiArNDM0LDkgQEAgY2xh c3MgRHJpdmVyKG9iamVjdCk6CiAgICAgICAgIGVudmlyb25tZW50WydTUUxJVEVfRVhFTVBUX1BB VEhfRlJPTV9WTk9ERV9HVUFSRFMnXSA9IG9zLnBhdGgucmVhbHBhdGgoZW52aXJvbm1lbnRbJ0RV TVBSRU5ERVJUUkVFX1RFTVAnXSkKICAgICAgICAgZW52aXJvbm1lbnRbJ19fWFBDX1NRTElURV9F WEVNUFRfUEFUSF9GUk9NX1ZOT0RFX0dVQVJEUyddID0gZW52aXJvbm1lbnRbJ1NRTElURV9FWEVN UFRfUEFUSF9GUk9NX1ZOT0RFX0dVQVJEUyddCiAKKyAgICAgICAgZW52aXJvbm1lbnRbJ0pTQ191 c2VLZXJuVENTTSddID0gJzAnCisgICAgICAgIGVudmlyb25tZW50WydfX1hQQ19KU0NfdXNlS2Vy blRDU00nXSA9ICcwJworCiAgICAgICAgIGlmIHN5cy5wbGF0Zm9ybS5zdGFydHN3aXRoKCdsaW51 eCcpOgogICAgICAgICAgICAgIyBDdXJyZW50bHkgb24gV2ViS2l0MiwgdGhlcmUgaXMgbm8gQVBJ IGZvciBzZXR0aW5nIHRoZSBhcHBsaWNhdGlvbiBjYWNoZSBkaXJlY3RvcnkuCiAgICAgICAgICAg ICAjIEVhY2ggd29ya2VyIHNob3VsZCBoYXZlIGl0J3Mgb3duIGFuZCBpdCBzaG91bGQgYmUgY2xl YW5lZCBhZnRlcndhcmRzLgo=