200644 2019-08-12 14:43:12 -0700 [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs 2019-08-12 16:45:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue ews-watchlist fujii glenn webkit-bug-importer oldest_to_newest 1560561 0 jbedard 2019-08-12 14:43:12 -0700 This is a regression from <https://trac.webkit.org/changeset/245544/webkit>. The SimulatorProcess inherits from ServerProcess, so it also needs to define _system_pid. We didn't notice this before because you need the same process to crash multiple times in a given test run for this to actually be an issue. 1560563 1 376096 jbedard 2019-08-12 14:55:25 -0700 Created attachment 376096 Patch 1560574 2 376096 aakash_jain 2019-08-12 15:29:27 -0700 Comment on attachment 376096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376096&action=review > Tools/Scripts/webkitpy/port/simulator_process.py:97 > + self._system_pid = self._pid Where/how is this _system_pid used? 1560575 3 aakash_jain 2019-08-12 15:30:59 -0700 > Where/how is this _system_pid used? Just noticed your comment 'SimulatorProcess inherits from ServerProcess'. That makes sense. Can you please copy/paste the exception which this patch is fixing. 1560581 4 fujii 2019-08-12 15:54:26 -0700 Thanks. LGTM. 1560587 5 jbedard 2019-08-12 16:17:26 -0700 (In reply to Aakash Jain from comment #3) > > Where/how is this _system_pid used? > Just noticed your comment 'SimulatorProcess inherits from ServerProcess'. > > That makes sense. Can you please copy/paste the exception which this patch > is fixing. Not really an exception (that's what took us so long to notice the problem), <https://trac.webkit.org/changeset/245544/webkit> does a good job of showing how we use system_pid. Basically, we're using it to piece together crashlogs. If it's not defined, we search by process name and pull the first crash log that matches the process name. Nothing in Buildbot shows the failure at the moment, we need a configuration that's exotic enough to cause multiple crashes in a single run, I can't find any examples of that on build.webkit.org. 1560595 6 376096 commit-queue 2019-08-12 16:44:01 -0700 Comment on attachment 376096 Patch Clearing flags on attachment: 376096 Committed r248583: <https://trac.webkit.org/changeset/248583> 1560596 7 commit-queue 2019-08-12 16:44:03 -0700 All reviewed patches have been landed. Closing bug. 1560597 8 webkit-bug-importer 2019-08-12 16:45:17 -0700 <rdar://problem/54233104> 376096 2019-08-12 14:55:25 -0700 2019-08-12 16:44:01 -0700 Patch bug-200644-20190812145524.patch text/plain 1425 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0ODU0OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA4LTEyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbUkVHUkVTU0lPTl0gcnVuLXdlYmtpdC10ZXN0czogTm8gUElEIGRlZmlu ZWQgd2hlbiBzZWFyY2hpbmcgZm9yIHNpbXVsYXRvciBjcmFzaGxvZ3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDY0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0 L3NpbXVsYXRvcl9wcm9jZXNzLnB5OgorICAgICAgICAoU2ltdWxhdG9yUHJvY2Vzcy5fc3RhcnQp OiBEZWZpbmUgc3lzdGVtIFBJRCBhZnRlciBsYXVuY2hpbmcgYXBwLgorCiAyMDE5LTA4LTEyICBN ZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IENy YXNoIGluIE1haWwgU2VhcmNoCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2lt dWxhdG9yX3Byb2Nlc3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L3NpbXVsYXRvcl9wcm9jZXNzLnB5CShyZXZpc2lvbiAyNDg1MjgpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHdvcmtpbmcgY29weSkKQEAg LTk0LDYgKzk0LDcgQEAgY2xhc3MgU2ltdWxhdG9yUHJvY2VzcyhTZXJ2ZXJQcm9jZXNzKToKICAg ICAgICAgIyAzIGNsaWVudCBjb25uZWN0aW9ucyB3aWxsIGJlIGFjY2VwdGVkIGZvciBzdGRpbiwg c3Rkb3V0IGFuZCBzdGRlcnIgaW4gdGhhdCBvcmRlci4KICAgICAgICAgc2VsZi5fdGFyZ2V0X2hv c3QubGlzdGVuaW5nX3NvY2tldC5saXN0ZW4oMykKICAgICAgICAgc2VsZi5fcGlkID0gc2VsZi5f dGFyZ2V0X2hvc3QubGF1bmNoX2FwcChzZWxmLl9idW5kbGVfaWQsIHNlbGYuX2NtZFsxOl0sIGVu dj1zZWxmLl9lbnYpCisgICAgICAgIHNlbGYuX3N5c3RlbV9waWQgPSBzZWxmLl9waWQKIAogICAg ICAgICB3aXRoIFRpbWVvdXQoMTUsIFJ1bnRpbWVFcnJvcignVGltZWQgb3V0IHdhaXRpbmcgZm9y IHBpZCB7fSB0byBjb25uZWN0IGF0IHBvcnQge30nLmZvcm1hdChzZWxmLl9waWQsIHNlbGYuX3Rh cmdldF9ob3N0Lmxpc3RlbmluZ19wb3J0KCkpKSk6CiAgICAgICAgICAgICBzdGRpbiA9IE5vbmUK