200639 2019-08-12 11:54:26 -0700 Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes 2019-08-12 20:51:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1560499 0 hi 2019-08-12 11:54:26 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. set a DOM breakpoint 3. disable breakpoints 4. reload the page => breakpoints enabled Since DOM breakpoints revolve around a given DOM node, we attempt to restore those breakpoints whenever new nodes are added by matching them to the path of the DOM breakpoint. When doing so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly enable all breakpoints. 1560501 1 376084 hi 2019-08-12 11:59:58 -0700 Created attachment 376084 Patch 1560674 2 376084 joepeck 2019-08-12 20:42:14 -0700 Comment on attachment 376084 Patch rs=me 1560681 3 376084 commit-queue 2019-08-12 20:50:47 -0700 Comment on attachment 376084 Patch Clearing flags on attachment: 376084 Committed r248587: <https://trac.webkit.org/changeset/248587> 1560682 4 commit-queue 2019-08-12 20:50:48 -0700 All reviewed patches have been landed. Closing bug. 1560683 5 webkit-bug-importer 2019-08-12 20:51:17 -0700 <rdar://problem/54240350> 376084 2019-08-12 11:59:58 -0700 2019-08-12 20:50:47 -0700 Patch bug-200639-20190812115957.patch text/plain 2496 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBkZmU0YTQzMTBlOGYxMjgwNzQ2OTA1YzE3Yjhk Y2JjYmViYmM0NzMuLmIzMzg2MTQwNGQ0Mzc5NzJhNGRjMGM5YjE1OWMyZDdkNDI3NmU2NDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA4LTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBET01EZWJ1Z2dlcjogYnJlYWtwb2ludHMgYXJlIGZvcmNpYmx5IGVuYWJsZWQg d2hlbiByZXNvbHZpbmcgRE9NIGJyZWFrcG9pbnRzIGZvciBuZXdseSBhZGRlZCBub2RlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNjM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgRE9NIGJy ZWFrcG9pbnRzIHJldm9sdmUgYXJvdW5kIGEgZ2l2ZW4gRE9NIG5vZGUsIHdlIGF0dGVtcHQgdG8g cmVzdG9yZSBET00gYnJlYWtwb2ludHMKKyAgICAgICAgd2hlbmV2ZXIgbmV3IG5vZGVzIGFyZSBh ZGRlZCBieSBtYXRjaGluZyB0aGVtIHRvIHRoZSBwYXRoIG9mIHRoZSBET00gYnJlYWtwb2ludC4g V2hlbiBkb2luZworICAgICAgICBzbywgd2Ugc2hvdWxkIGJlIGluIGEgInRlbXBvcmFyaWx5IHJl c3RvcmluZyBicmVha3BvaW50cyIgbW9kZSBzbyB0aGF0IHdlIGRvbid0IGZvcmNpYmx5CisgICAg ICAgIGVuYWJsZSBhbGwgYnJlYWtwb2ludHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdJLkRPTURlYnVnZ2Vy TWFuYWdlci5wcm90b3R5cGUuX3NwZWN1bGF0aXZlbHlSZXNvbHZlRE9NQnJlYWtwb2ludHNGb3JV UkwpOgorICAgICAgICAoV0kuRE9NRGVidWdnZXJNYW5hZ2VyLnByb3RvdHlwZS5fbm9kZUluc2Vy dGVkKToKKwogMjAxOS0wOC0wOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJldHRlciBvcmdhbml6ZSBtYW5hZ2VyIC8gb2Jz ZXJ2ZXIgQVBJIGdyb3VwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpz CmluZGV4IDdkNTQ0NzFkNjkzY2JkYTI1OWIxM2Y1MzdjOThmMGMxNDkwMjBmNmYuLjU3NjVjMTdh NDZmZDg4MGRjZjQ1ZTE4NDc0NDQxMjljZDI2NzBkMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9E T01EZWJ1Z2dlck1hbmFnZXIuanMKQEAgLTU2MSw4ICs1NjEsMTIgQEAgV0kuRE9NRGVidWdnZXJN YW5hZ2VyID0gY2xhc3MgRE9NRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAg ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAg ICAgICBpZiAobm9kZUlkZW50aWZpZXIpCi0gICAgICAgICAgICAgICAgICAgIHRoaXMuX3Jlc29s dmVET01CcmVha3BvaW50KGJyZWFrcG9pbnQsIG5vZGVJZGVudGlmaWVyKTsKKyAgICAgICAgICAg ICAgICBpZiAoIW5vZGVJZGVudGlmaWVyKQorICAgICAgICAgICAgICAgICAgICByZXR1cm47CisK KyAgICAgICAgICAgICAgICB0aGlzLl9yZXN0b3JpbmdCcmVha3BvaW50cyA9IHRydWU7CisgICAg ICAgICAgICAgICAgdGhpcy5fcmVzb2x2ZURPTUJyZWFrcG9pbnQoYnJlYWtwb2ludCwgbm9kZUlk ZW50aWZpZXIpOworICAgICAgICAgICAgICAgIHRoaXMuX3Jlc3RvcmluZ0JyZWFrcG9pbnRzID0g ZmFsc2U7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQogICAgIH0KQEAgLTgyNiw3ICs4MzAs OSBAQCBXSS5ET01EZWJ1Z2dlck1hbmFnZXIgPSBjbGFzcyBET01EZWJ1Z2dlck1hbmFnZXIgZXh0 ZW5kcyBXSS5PYmplY3QKICAgICAgICAgICAgIGlmIChicmVha3BvaW50LnBhdGggIT09IG5vZGUu cGF0aCgpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCisgICAgICAgICAgICB0aGlzLl9y ZXN0b3JpbmdCcmVha3BvaW50cyA9IHRydWU7CiAgICAgICAgICAgICB0aGlzLl9yZXNvbHZlRE9N QnJlYWtwb2ludChicmVha3BvaW50LCBub2RlLmlkKTsKKyAgICAgICAgICAgIHRoaXMuX3Jlc3Rv cmluZ0JyZWFrcG9pbnRzID0gZmFsc2U7CiAgICAgICAgIH0KICAgICB9CiAK