200630 2019-08-12 10:25:10 -0700 Remove an assertion in ~StorageArea() 2019-08-12 12:34:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1560455 0 sihui_liu 2019-08-12 10:25:10 -0700 In https://bugs.webkit.org/show_bug.cgi?id=199713, we clear the LocalStorageNamespace before the destructor of LocalStorageNamespace is invoked, to make sure StorageArea gets destroyed on the background thread. StorageArea can get destroyed before LocalStorageNamespace, so the ASSERT(!m_localStorageNamespace) in ~StorageArea() is not true any more. 1560458 1 sihui_liu 2019-08-12 10:28:09 -0700 <rdar://problem/54097722> 1560460 2 376074 sihui_liu 2019-08-12 10:29:27 -0700 Created attachment 376074 Patch 1560517 3 376074 commit-queue 2019-08-12 12:33:59 -0700 Comment on attachment 376074 Patch Clearing flags on attachment: 376074 Committed r248542: <https://trac.webkit.org/changeset/248542> 1560518 4 commit-queue 2019-08-12 12:34:01 -0700 All reviewed patches have been landed. Closing bug. 376074 2019-08-12 10:29:27 -0700 2019-08-12 12:33:59 -0700 Patch bug-200630-20190812102926.patch text/plain 1598 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVmYzA2OGFiNzI0MjFhMjNi NTA2OTFhYjg5OGY4NGRlNzNhMDk0NWEuLjk5OTQyZDgxZTljNjliZWRiMDBmOTI1MWE0OTY4M2Ji YWFlMDU2Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgtMTIgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFuIGFzc2VydGlvbiBp biB+U3RvcmFnZUFyZWEoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjAwNjMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDA5NzcyMj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjQ3MzcwLCB3 ZSBjbGVhciB0aGUgTG9jYWxTdG9yYWdlTmFtZXNwYWNlIGJlZm9yZSB0aGUgZGVzdHJ1Y3RvciBv ZiBMb2NhbFN0b3JhZ2VOYW1lc3BhY2UgaXMgaW52b2tlZCwgdG8gCisgICAgICAgIG1ha2Ugc3Vy ZSBTdG9yYWdlQXJlYSBnZXRzIGRlc3Ryb3llZCBvbiB0aGUgYmFja2dyb3VuZCB0aHJlYWQuIAor ICAgICAgICBTdG9yYWdlQXJlYSBjYW4gZ2V0IGRlc3Ryb3llZCBiZWZvcmUgTG9jYWxTdG9yYWdl TmFtZXNwYWNlLCBzbyB0aGUgYXNzZXJ0aW9uIGluIH5TdG9yYWdlQXJlYSgpIGlzIG5vdCB0cnVl IGFueSAKKyAgICAgICAgbW9yZS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1dlYlN0b3Jh Z2UvU3RvcmFnZUFyZWEuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlQXJlYTo6flN0b3Jh Z2VBcmVhKToKKwogMjAxOS0wOC0xMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDg1MjUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZUFyZWEuY3BwIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VBcmVhLmNwcApp bmRleCA1ZTgyOWNiMDc0ZmE3MTY3NWIwMDUwNDY2MDRhZWI3ZjNjYjRhNWJmLi4zNDk0MzFmZWE1 NmM0N2FiODE0NjBjYjgzZjU1NmU3MjRkY2EyZDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZUFyZWEuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlQXJlYS5jcHAKQEAgLTQ5LDcg KzQ5LDYgQEAgU3RvcmFnZUFyZWE6On5TdG9yYWdlQXJlYSgpCiB7CiAgICAgQVNTRVJUKCFSdW5M b29wOjppc01haW4oKSk7CiAgICAgQVNTRVJUKG1fZXZlbnRMaXN0ZW5lcnMuaXNFbXB0eSgpKTsK LSAgICBBU1NFUlQoIW1fbG9jYWxTdG9yYWdlTmFtZXNwYWNlKTsKIAogICAgIGlmIChtX2xvY2Fs U3RvcmFnZURhdGFiYXNlKQogICAgICAgICBtX2xvY2FsU3RvcmFnZURhdGFiYXNlLT5jbG9zZSgp Owo=