200622 2019-08-11 08:01:58 -0700 [MSE][GStreamer] Don't use vorbisparse 2019-08-11 09:21:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply commit-queue pnormand oldest_to_newest 1560339 0 aboya 2019-08-11 08:01:58 -0700 This patch has been splitted from the original WebKitMediaSrc rework patch (https://bugs.webkit.org/show_bug.cgi?id=199719). Unlike other parsers, vorbisparse has latency (in the sense that when it gets a chain call with a series of complete frames, it may not emit the parsed frames until another chain in the future), which makes it inappropriate for AppendPipeline, as there is no good way I know to flush it. But actually vorbisparse is not known to be necessary and it was only introduced for consistency with other formats. Parsers are used in AppendPipeline to reconstruct information that is lost due to poor muxes. There have been no reported cases of this being a problem with Vorbis in WebM, so I'm just removing the parser. Fixes imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html 1560340 1 376042 aboya 2019-08-11 08:03:06 -0700 Created attachment 376042 Patch 1560342 2 376042 commit-queue 2019-08-11 09:21:31 -0700 Comment on attachment 376042 Patch Clearing flags on attachment: 376042 Committed r248521: <https://trac.webkit.org/changeset/248521> 1560343 3 commit-queue 2019-08-11 09:21:33 -0700 All reviewed patches have been landed. Closing bug. 376042 2019-08-11 08:03:06 -0700 2019-08-11 09:21:31 -0700 Patch bug-200622-20190811170305.patch text/plain 4398 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc3MzY4NTUxMDRlYTcy MTM1ZDFlYjRjMTU0MWQxODEwNjEwMTIyMC4uZjQ4NmRkMzc0MzVlMjU5OGEwNDEwYjkzNjVhMjE4 MzAzYjBkODhjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE5LTA4LTExICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIERvbid0IHVzZSB2b3JiaXNwYXJzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBoYXMgYmVlbiBzcGxpdHRlZCBmcm9tIHRo ZSBvcmlnaW5hbCBXZWJLaXRNZWRpYVNyYyByZXdvcmsKKyAgICAgICAgcGF0Y2ggKGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTk3MTkpLgorCisgICAgICAgIFVubGlr ZSBvdGhlciBwYXJzZXJzLCB2b3JiaXNwYXJzZSBoYXMgbGF0ZW5jeSAoaW4gdGhlIHNlbnNlIHRo YXQgd2hlbgorICAgICAgICBpdCBnZXRzIGEgY2hhaW4gY2FsbCB3aXRoIGEgc2VyaWVzIG9mIGNv bXBsZXRlIGZyYW1lcywgaXQgbWF5IG5vdCBlbWl0CisgICAgICAgIHRoZSBwYXJzZWQgZnJhbWVz IHVudGlsIGFub3RoZXIgY2hhaW4gaW4gdGhlIGZ1dHVyZSksIHdoaWNoIG1ha2VzIGl0CisgICAg ICAgIGluYXBwcm9wcmlhdGUgZm9yIEFwcGVuZFBpcGVsaW5lLCBhcyB0aGVyZSBpcyBubyBnb29k IHdheSBJIGtub3cgdG8KKyAgICAgICAgZmx1c2ggaXQuCisKKyAgICAgICAgQnV0IGFjdHVhbGx5 IHZvcmJpc3BhcnNlIGlzIG5vdCBrbm93biB0byBiZSBuZWNlc3NhcnkgYW5kIGl0IHdhcyBvbmx5 CisgICAgICAgIGludHJvZHVjZWQgZm9yIGNvbnNpc3RlbmN5IHdpdGggb3RoZXIgZm9ybWF0cy4g UGFyc2VycyBhcmUgdXNlZCBpbgorICAgICAgICBBcHBlbmRQaXBlbGluZSB0byByZWNvbnN0cnVj dCBpbmZvcm1hdGlvbiB0aGF0IGlzIGxvc3QgZHVlIHRvIHBvb3IKKyAgICAgICAgbXV4ZXMuIFRo ZXJlIGhhdmUgYmVlbiBubyByZXBvcnRlZCBjYXNlcyBvZiB0aGlzIGJlaW5nIGEgcHJvYmxlbSB3 aXRoCisgICAgICAgIFZvcmJpcyBpbiBXZWJNLCBzbyBJJ20ganVzdCByZW1vdmluZyB0aGUgcGFy c2VyLgorCisgICAgICAgIEZpeGVzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWVk aWEtc291cmNlL21lZGlhc291cmNlLWNvbmZpZy1jaGFuZ2Utd2VibS1hLWJpdHJhdGUuaHRtbAor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGlu ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVPcHRpb25hbFBhcnNlckZvckZvcm1hdCk6 CisKIDIwMTktMDgtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAg ICAgIEZhY3RvciBjb21wbGV4IGxpbmUgbGF5b3V0IHBhdGggb3V0IGZyb20gUmVuZGVyQmxvY2tG bG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCmluZGV4IDdiYjEwNTk2MjliNmQ5 MmY5MjBlN2M5MjAxZGMyZGViYzA5NjMxZGQuLjA5N2IxY2VkMmIwMmRiOTE5ZWZkZGZiNDEyOTQ1 YTQyODJlNmI1MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwCkBAIC02NDUs MTIgKzY0NSw2IEBAIGNyZWF0ZU9wdGlvbmFsUGFyc2VyRm9yRm9ybWF0KEdzdFBhZCogZGVtdXhl clNyY1BhZCkKICAgICAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwob3B1c3BhcnNlLCBudWxscHRy KTsKICAgICAgICAgcmV0dXJuIEdSZWZQdHI8R3N0RWxlbWVudD4ob3B1c3BhcnNlKTsKICAgICB9 Ci0gICAgaWYgKCFnX3N0cmNtcDAobWVkaWFUeXBlLCAiYXVkaW8veC12b3JiaXMiKSkgewotICAg ICAgICBHc3RFbGVtZW50KiB2b3JiaXNwYXJzZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgi dm9yYmlzcGFyc2UiLCBwYXJzZXJOYW1lLmdldCgpKTsKLSAgICAgICAgQVNTRVJUKHZvcmJpc3Bh cnNlKTsKLSAgICAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwodm9yYmlzcGFyc2UsIG51bGxwdHIp OwotICAgICAgICByZXR1cm4gR1JlZlB0cjxHc3RFbGVtZW50Pih2b3JiaXNwYXJzZSk7Ci0gICAg fQogICAgIGlmICghZ19zdHJjbXAwKG1lZGlhVHlwZSwgInZpZGVvL3gtaDI2NCIpKSB7CiAgICAg ICAgIEdzdEVsZW1lbnQqIGgyNjRwYXJzZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiaDI2 NHBhcnNlIiwgcGFyc2VyTmFtZS5nZXQoKSk7CiAgICAgICAgIEFTU0VSVChoMjY0cGFyc2UpOwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGQ1ZGRlMTEzMjlmZGFmYzVlNjUwMGVjNmUwYjcyMGU4MDNjMGNlZTcuLmJmZDVlNzA2 YzJkYTcyZmQ4Y2IyOTNhN2NhNTFjNzVjYmM4YzhlY2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOS0wOC0xMSAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW01TRV1bR1N0cmVhbWVyXSBEb24ndCB1c2Ugdm9yYmlzcGFyc2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDYyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnM6CisKIDIwMTktMDgtMTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI0NTk3NCk6IE1pc3NpbmcgY29udGVu dCBvbiBoYWJpdGJ1cmdlci5jb20sIGFtYXpvbi5jb20KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMWQ1YTkwOWJkYzRmNWRkNDQ4NTU1ZDcyMDQ1NTQyZjYx YTg0YTM1ZC4uMTI4OWVlNmMxOGJkNTgxN2ZkYTNjN2EwMWFhMzQ5MzkzZTYwN2M4YiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIyOCw3ICsyMjgsNiBA QCB3ZWJraXQub3JnL2IvMTY3MTA4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWVk aWEtc291cmNlL21lZGlhc291cmNlLWF2dAogd2Via2l0Lm9yZy9iLzE2NzEwOCBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1idWZmZXJlZC5o dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTY3MTA4IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvbWVkaWEtc291cmNlL21lZGlhc291cmNlLWNoYW5nZXR5cGUuaHRtbCBbIEZh aWx1cmUgQ3Jhc2ggXQogd2Via2l0Lm9yZy9iLzE2NzEwOCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1jaGFuZ2V0eXBlLXBsYXkuaHRtbCBb IEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2NzEwOCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1jb25maWctY2hhbmdlLXdlYm0tYS1iaXRy YXRlLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjcxMDggaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvbWVkaWFzb3VyY2UtY29uZmlnLWNoYW5nZS13 ZWJtLXYtZnJhbWVzaXplLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogIyBDcmFzaCBpcyB3ZWJraXQu b3JnL2IvMTc2MDIwCiB3ZWJraXQub3JnL2IvMTY3MTA4IGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvbWVkaWEtc291cmNlL21lZGlhc291cmNlLWR1cmF0aW9uLmh0bWwgWyBGYWlsdXJl IENyYXNoIF0K