200595 2019-08-09 15:44:02 -0700 Fix WebKitLegacy's post-process-header-rule script to support paths with spaces in them 2019-08-09 16:52:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin aestes bfulgham commit-queue darin jbedard thorton webkit-bug-importer oldest_to_newest 1560084 0 krollin 2019-08-09 15:44:02 -0700 A number of scripts were added to WebKit, JavaScriptCore, and WebKitLegacy to support XCBuild's new facility for copying and modifying files in one atomic step. The first two are OK, but WebKitLegacy's script (post-process-header-rule) references a file via a variable named "header", and does so without quoting the variable's value. When the header's path contains spaces -- as can happen when building Safari Technology Preview -- the script breaks. Fix this by adding quoting. Also fix a spot where post-process-header-rule expected that WebKitAvailability.h was referenced via a relative path for the form "./WebKitAvailability.h" rather than -- as is the case now -- an absolute path. <rdar://problem/54045608> 1560086 1 krollin 2019-08-09 15:45:03 -0700 Ignore that comment about WebKitAvailability.h. I'll be taking care of that in another patch. 1560088 2 375972 krollin 2019-08-09 15:46:41 -0700 Created attachment 375972 Patch 1560121 3 375972 commit-queue 2019-08-09 16:52:20 -0700 Comment on attachment 375972 Patch Clearing flags on attachment: 375972 Committed r248489: <https://trac.webkit.org/changeset/248489> 1560122 4 commit-queue 2019-08-09 16:52:22 -0700 All reviewed patches have been landed. Closing bug. 375972 2019-08-09 15:46:41 -0700 2019-08-09 16:52:20 -0700 Patch bug-200595-20190809154640.patch text/plain 2573 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCmluZGV4IDNkZTA0 NTMyMWFhY2Y4MmIzMTZlZTNkOGFlZThkMjQ1MmNiYTZhNTguLjM1Yjg0ZDMwMjEwMDlhZmFjOWNk ZGM2OTY1NWY5NmUwYjk2OGIzNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTktMDgtMDkgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBXZWJLaXRMZWdhY3kncyBwb3N0LXByb2Nlc3MtaGVhZGVyLXJ1bGUgc2NyaXB0IHRv IHN1cHBvcnQgcGF0aHMgd2l0aCBzcGFjZXMgaW4gdGhlbQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTk1CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS81NDA0NTYwOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBIG51bWJlciBvZiBzY3JpcHRzIHdlcmUgYWRkZWQgdG8gV2ViS2l0LCBKYXZhU2NyaXB0 Q29yZSwgYW5kCisgICAgICAgIFdlYktpdExlZ2FjeSB0byBzdXBwb3J0IFhDQnVpbGQncyBuZXcg ZmFjaWxpdHkgZm9yIGNvcHlpbmcgYW5kCisgICAgICAgIG1vZGlmeWluZyBmaWxlcyBpbiBvbmUg YXRvbWljIHN0ZXAuIFRoZSBmaXJzdCB0d28gYXJlIE9LLCBidXQKKyAgICAgICAgV2ViS2l0TGVn YWN5J3Mgc2NyaXB0IChwb3N0LXByb2Nlc3MtaGVhZGVyLXJ1bGUpIHJlZmVyZW5jZXMgYSBmaWxl IHZpYQorICAgICAgICBhIHZhcmlhYmxlIG5hbWVkICJoZWFkZXIiLCBhbmQgZG9lcyBzbyB3aXRo b3V0IHF1b3RpbmcgdGhlIHZhcmlhYmxlJ3MKKyAgICAgICAgdmFsdWUuIFdoZW4gdGhlIGhlYWRl cidzIHBhdGggY29udGFpbnMgc3BhY2VzIC0tIGFzIGNhbiBoYXBwZW4gd2hlbgorICAgICAgICBi dWlsZGluZyBTYWZhcmkgVGVjaG5vbG9neSBQcmV2aWV3IC0tIHRoZSBzY3JpcHQgYnJlYWtzLiBG aXggdGhpcyBieQorICAgICAgICBhZGRpbmcgcXVvdGluZy4KKworICAgICAgICAqIHNjcmlwdHMv cG9zdHByb2Nlc3MtaGVhZGVyLXJ1bGU6CisKIDIwMTktMDgtMDYgIFBlciBBcm5lIFZvbGxhbiAg PHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIEZpeCBBcHBsZVdpbiBidWlsZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9zY3JpcHRzL3Bvc3Rwcm9jZXNzLWhlYWRl ci1ydWxlIGIvU291cmNlL1dlYktpdExlZ2FjeS9zY3JpcHRzL3Bvc3Rwcm9jZXNzLWhlYWRlci1y dWxlCmluZGV4IGRhOGU4MmJkODUzOWZlNzk5OTJhNDIyMzQ3MDYxZWRjMGRiNTFlNzQuLmI0YzU2 NGRmODQzYjRmYzFkNzMwODQ2ODdhOWZkNTY3ODg3MDdmMDMgMTAwNzU1Ci0tLSBhL1NvdXJjZS9X ZWJLaXRMZWdhY3kvc2NyaXB0cy9wb3N0cHJvY2Vzcy1oZWFkZXItcnVsZQorKysgYi9Tb3VyY2Uv V2ViS2l0TGVnYWN5L3NjcmlwdHMvcG9zdHByb2Nlc3MtaGVhZGVyLXJ1bGUKQEAgLTU5LDIyICs1 OSwyMiBAQCBkbwogICAgIGZpCiBkb25lCiAKLXVuaWZkZWYgLUIgJHt1bmlmZGVmT3B0aW9uc30g LW8gJHtoZWFkZXJ9LnVuaWZkZWYgJHtoZWFkZXJ9Cit1bmlmZGVmIC1CICR7dW5pZmRlZk9wdGlv bnN9IC1vICIke2hlYWRlcn0udW5pZmRlZiIgIiR7aGVhZGVyfSIKIGNhc2UgJD8gaW4KLSAgICAw KSBybSAke2hlYWRlcn0udW5pZmRlZiA7OwotICAgIDEpIG12ICR7aGVhZGVyfXsudW5pZmRlZix9 IDs7CisgICAgMCkgcm0gIiR7aGVhZGVyfSIudW5pZmRlZiA7OworICAgIDEpIG12ICIke2hlYWRl cn0iey51bmlmZGVmLH0gOzsKICAgICAqKSBleGl0IDEgOzsKIGVzYWMKIAotaWYgW1sgJHtoZWFk ZXJ9ID09ICIuL1dlYktpdEF2YWlsYWJpbGl0eS5oIiBdXTsgdGhlbgoraWYgW1sgIiR7aGVhZGVy fSIgPT0gIi4vV2ViS2l0QXZhaWxhYmlsaXR5LmgiIF1dOyB0aGVuCiAgICAgZXhpdCAwCiBmaQog CiBpZiBbWyAke1dLX1BMQVRGT1JNX05BTUV9ICE9IG1hY29zeCBdXTsgdGhlbgotICAgIHNlZCAt RSAtZSAicy8gKldFQktJVF8oKENMQVNTX3xFTlVNXyk/KEFWQUlMQUJMRXxERVBSRUNBVEVEKSlf TUFDXChbXildK1wpLy9nIiA8ICR7aGVhZGVyfSA+ICR7aGVhZGVyfS5zZWQKLSAgICBpZiBjbXAg LXMgJHtoZWFkZXJ9ICR7aGVhZGVyfS5zZWQ7IHRoZW4KLSAgICAgICAgcm0gJHtoZWFkZXJ9LnNl ZAorICAgIHNlZCAtRSAtZSAicy8gKldFQktJVF8oKENMQVNTX3xFTlVNXyk/KEFWQUlMQUJMRXxE RVBSRUNBVEVEKSlfTUFDXChbXildK1wpLy9nIiA8ICIke2hlYWRlcn0iID4gIiR7aGVhZGVyfS5z ZWQiCisgICAgaWYgY21wIC1zICIke2hlYWRlcn0iICIke2hlYWRlcn0uc2VkIjsgdGhlbgorICAg ICAgICBybSAiJHtoZWFkZXJ9LnNlZCIKICAgICBlbHNlCi0gICAgICAgIG12ICR7aGVhZGVyfS5z ZWQgJHtoZWFkZXJ9CisgICAgICAgIG12ICIke2hlYWRlcn0uc2VkIiAiJHtoZWFkZXJ9IgogICAg IGZpCiBmaQo=