200591 2019-08-09 14:32:48 -0700 [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error 2019-08-09 16:07:02 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin megan_gardner rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1560043 0 wenson_hsieh 2019-08-09 14:32:48 -0700 <rdar://problem/54102238> 1560053 1 375961 wenson_hsieh 2019-08-09 14:41:55 -0700 Created attachment 375961 Patch 1560058 2 375961 rniwa 2019-08-09 14:53:03 -0700 Comment on attachment 375961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826 > + switch (_focusedElementInformation.elementType) { > + case WebKit::InputType::Password: Either plain text field doesn't support pasting of an image, or all these could potentially support pasting of an image if we rely on page's scripts. r=me with this element type check removed as we discussed in person. 1560079 3 375961 wenson_hsieh 2019-08-09 15:38:16 -0700 Comment on attachment 375961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826 >> + case WebKit::InputType::Password: > > Either plain text field doesn't support pasting of an image, > or all these could potentially support pasting of an image if we rely on page's scripts. > > r=me with this element type check removed as we discussed in person. Thanks for the review! I’ll need to adjust this patch a little more after some feedback from UIKit folks (moving the SPI to the UITextInputPrivate protocol instead) 1560080 4 375969 wenson_hsieh 2019-08-09 15:40:03 -0700 Created attachment 375969 Patch 1560101 5 wenson_hsieh 2019-08-09 16:07:02 -0700 Landed <https://trac.webkit.org/r248487>. 375961 2019-08-09 14:41:55 -0700 2019-08-09 15:40:01 -0700 Patch bug-200591-20190809144154.patch text/plain 7533 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5MWVhNmUwYmI2ZDk5OTQ4 ODgzZTkyMmE4NDRhNmM3MGE0MWUzZDMuLjEzZDk5NjdjN2UzY2NhNTU2OTVkZThkZTc5YTdmNTJm ZDJiMTM2MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDgtMDkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyAxM10gR29vZ2xl IERvY3MvU2xpZGVzL1NoZWV0czogcGFzdGUgb2Z0ZW4gZG9lc24ndCB3b3JrIGFuZCBzb21ldGlt ZXMgcHJvZHVjZXMgYW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMDU5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQxMDIyMzg+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRvcHRzIFVJ S2l0IFNQSSB0byBhdm9pZCBpbmNyZW1lbnRpbmcgdGhlIGdlbmVyYWwgcGFzdGVib2FyZCdzIGNo YW5nZSBjb3VudCB3aGVuZXZlciBhbiBlZGl0YWJsZSBlbGVtZW50IGlzCisgICAgICAgIGZvY3Vz ZWQuIFRoaXMgaXMgZHVlIHRvIGhvdywgaW4gaU9TIDEzLCBVSUtpdCB0ZW1wb3JhcmlseSB3cml0 ZXMgYW4gaW1hZ2UgdG8gdGhlIHBhc3RlYm9hcmQgd2hlbiBzaG93aW5nIHRoZQorICAgICAgICBr ZXlib2FyZCwgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgb3Igbm90IHRvIHNob3cgdGhlIE1lbW9qaXMg aW4gdGhlIGlucHV0IHZpZXcuCisKKyAgICAgICAgVGhpcyBjYXVzZXMgVUlQYXN0ZWJvYXJkJ3Mg Y2hhbmdlQ291bnQgdG8gaW5jcmVtZW50IHR3aWNlIGR1ZSB0byBhZGRpbmcgYW5kIHRoZW4gcmVt b3ZpbmcgdGhlIGltYWdlLCB3aGljaCBtZWFucworICAgICAgICB0aGF0IHRoZSBjaGFuZ2VDb3Vu dCBzYW5pdHkgY2hlY2tzIGluIHRoZSB3ZWIgcHJvY2VzcyB3aWxsIHJhY2UgYWdhaW5zdCB0aGUg cGFzdGVib2FyZCBnYWluaW5nIGFuZCB0aGVuIGxvc2luZworICAgICAgICB0aGlzIHRlbXBvcmFy eSBpbWFnZS4KKworICAgICAgICBJbnN0ZWFkLCB0aGUgbmV3IC1zdXBwb3J0c0ltYWdlUGFzdGUg U1BJIG1heSBiZSB1c2VkIHRvIHNob3J0LWNpcmN1aXQgdGhpcyBzdGVwLCBhbmQgYXZvaWQgdXBk YXRpbmcgdGhlCisgICAgICAgIGNoYW5nZUNvdW50IHdoZW4gVUlLZXlib2FyZEltcGwncyBkZWxl Z2F0ZSBjaGFuZ2VzLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc3VwcG9ydHNJbWFnZVBhc3Rl XSk6CisKIDIwMTktMDgtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgdGhyZWFkaW5nIGFzc2VydGlvbnMgdG8gV2ViU3RvcmFnZSBjb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQppbmRleCAyMTI5OWIxNDI0OGVmNWZkNDZmNWZjM2NhZTgyYjIyNDg1MjMzMWE1Li5hYTNk ZjcwNjc5OGI0MjQxMTZkMGJiNmQ5ZWRlZWI5MDNjNzAxNjc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAg LTY4MjAsNiArNjgyMCwyMyBAQCAtIChOU0RpY3Rpb25hcnkgKilfYXV0b2ZpbGxDb250ZXh0CiAg ICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQk9PTClzdXBwb3J0c0ltYWdlUGFzdGUKK3sKKyAgICBz d2l0Y2ggKF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uLmVsZW1lbnRUeXBlKSB7CisgICAgY2Fz ZSBXZWJLaXQ6OklucHV0VHlwZTo6UGFzc3dvcmQ6CisgICAgY2FzZSBXZWJLaXQ6OklucHV0VHlw ZTo6TnVtYmVyOgorICAgIGNhc2UgV2ViS2l0OjpJbnB1dFR5cGU6Ok51bWJlclBhZDoKKyAgICBj YXNlIFdlYktpdDo6SW5wdXRUeXBlOjpVUkw6CisgICAgY2FzZSBXZWJLaXQ6OklucHV0VHlwZTo6 V2VlazoKKyAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpEYXRlVGltZToKKyAgICBjYXNlIFdl YktpdDo6SW5wdXRUeXBlOjpFbWFpbDoKKyAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpQaG9u ZToKKyAgICAgICAgcmV0dXJuIE5POworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBtYXlD b250YWluU2VsZWN0YWJsZVRleHQoX2ZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24uZWxlbWVudFR5 cGUpOworICAgIH0KK30KKwogI2lmIEhBVkUoVUlfV0tfRE9DVU1FTlRfQ09OVEVYVCkKIAogc3Rh dGljIGlubGluZSBPcHRpb25TZXQ8V2ViS2l0OjpEb2N1bWVudEVkaXRpbmdDb250ZXh0UmVxdWVz dDo6T3B0aW9ucz4gdG9XZWJEb2N1bWVudFJlcXVlc3RPcHRpb25zKFVJV0tEb2N1bWVudFJlcXVl c3RGbGFncyBmbGFncykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA0OTY5ZDMwMjVjOWRiNDYzNjlhZmU0YTJjOTgyZjI2OTRiNTcyY2QyLi44OTgw YjhmZTYzMjlmNTlkZGU3MWQ4YTllMWQwNTBiMTAwYTIxODJiIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDgt MDkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lP UyAxM10gR29vZ2xlIERvY3MvU2xpZGVzL1NoZWV0czogcGFzdGUgb2Z0ZW4gZG9lc24ndCB3b3Jr IGFuZCBzb21ldGltZXMgcHJvZHVjZXMgYW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDU5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NTQxMDIyMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGEgbmV3IEFQSSB0ZXN0IHRvIGV4ZXJjaXNlIC1zdXBwb3J0c0ltYWdlUGFzdGUuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVzdHNJT1Mu bW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL2lvcy9VSVBhc3RlYm9hcmRUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRB UEk6OlRFU1QpOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmg6CisKIDIw MTktMDgtMDggIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAg IHdlYmtpdHB5OiBEaXNhYmxlIHNoYXJlZCBjbGlwYm9hcmQgYmV0d2VlbiBTaW11bGF0b3JzCmRp ZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVz dHNJT1MubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVz dHNJT1MubW0KaW5kZXggYjUzZmYyOGM2MDVkMTYxYmExMjRkZGNkZDJjMTI3NTNkMTBjYzkwYy4u ZjBjOGZkZTAxNTY1YTRkN2Y4ZWYwNzBhOGI2MDY1MTBhZmRiMjQyYSAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lPUy5tbQpA QCAtNTU1LDYgKzU1NSwzOCBAQCBURVNUKEtleWJvYXJkSW5wdXRUZXN0cywgVGVzdFdlYlZpZXdB ZGRpdGlvbmFsQ29udGV4dEZvclN0cm9uZ1Bhc3N3b3JkQXNzaXN0YW5jZQogICAgIEVYUEVDVF9U UlVFKFtbYWN0dWFsIGFsbFZhbHVlc10gY29udGFpbnNPYmplY3Q6ZXhwZWN0ZWRdKTsKIH0KIAor VEVTVChLZXlib2FyZElucHV0VGVzdHMsIFN1cHBvcnRzSW1hZ2VQYXN0ZSkKK3sKKyAgICBhdXRv IGlucHV0RGVsZWdhdGUgPSBhZG9wdE5TKFtbVGVzdElucHV0RGVsZWdhdGUgYWxsb2NdIGluaXRd KTsKKyAgICBbaW5wdXREZWxlZ2F0ZSBzZXRGb2N1c1N0YXJ0c0lucHV0U2Vzc2lvblBvbGljeUhh bmRsZXI6WyZdIChXS1dlYlZpZXcgKiwgaWQgPF9XS0ZvY3VzZWRFbGVtZW50SW5mbz4pIC0+IF9X S0ZvY3VzU3RhcnRzSW5wdXRTZXNzaW9uUG9saWN5IHsKKyAgICAgICAgcmV0dXJuIF9XS0ZvY3Vz U3RhcnRzSW5wdXRTZXNzaW9uUG9saWN5QWxsb3c7CisgICAgfV07CisKKyAgICBhdXRvIHdlYlZp ZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RN YWtlKDAsIDAsIDMyMCwgNTY4KV0pOworICAgIGF1dG8gY29udGVudFZpZXcgPSAoaWQgPFVJV0tJ bnRlcmFjdGlvblZpZXdQcm90b2NvbF9TdGFnaW5nX2lPU18xMz4pW3dlYlZpZXcgdGV4dElucHV0 Q29udGVudFZpZXddOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRNTFN0cmluZzpA IjxpbnB1dCBpZD0naW5wdXQnPjwvaW5wdXQ+PGRpdiBjb250ZW50ZWRpdGFibGUgaWQ9J2VkaXRv cic+PC9kaXY+PHRleHRhcmVhIGlkPSd0ZXh0YXJlYSc+PC90ZXh0YXJlYT4iXTsKKyAgICBbd2Vi VmlldyBfc2V0SW5wdXREZWxlZ2F0ZTppbnB1dERlbGVnYXRlLmdldCgpXTsKKworICAgIFt3ZWJW aWV3IGV2YWx1YXRlSmF2YVNjcmlwdEFuZFdhaXRGb3JJbnB1dFNlc3Npb25Ub0NoYW5nZTpAImlu cHV0LmZvY3VzKCkiXTsKKyAgICBFWFBFQ1RfVFJVRShjb250ZW50Vmlldy5zdXBwb3J0c0ltYWdl UGFzdGUpOworCisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0QW5kV2FpdEZvcklucHV0 U2Vzc2lvblRvQ2hhbmdlOkAiZG9jdW1lbnQuYWN0aXZlRWxlbWVudC5ibHVyKCk7IGlucHV0LnR5 cGUgPSAncGFzc3dvcmQnIl07CisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0QW5kV2Fp dEZvcklucHV0U2Vzc2lvblRvQ2hhbmdlOkAiaW5wdXQuZm9jdXMoKSJdOworICAgIEVYUEVDVF9G QUxTRShjb250ZW50Vmlldy5zdXBwb3J0c0ltYWdlUGFzdGUpOworCisgICAgW3dlYlZpZXcgZXZh bHVhdGVKYXZhU2NyaXB0QW5kV2FpdEZvcklucHV0U2Vzc2lvblRvQ2hhbmdlOkAiZG9jdW1lbnQu YWN0aXZlRWxlbWVudC5ibHVyKCkiXTsKKyAgICBbd2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHRB bmRXYWl0Rm9ySW5wdXRTZXNzaW9uVG9DaGFuZ2U6QCJlZGl0b3IuZm9jdXMoKSJdOworICAgIEVY UEVDVF9UUlVFKGNvbnRlbnRWaWV3LnN1cHBvcnRzSW1hZ2VQYXN0ZSk7CisKKyAgICBbd2ViVmll dyBldmFsdWF0ZUphdmFTY3JpcHRBbmRXYWl0Rm9ySW5wdXRTZXNzaW9uVG9DaGFuZ2U6QCJkb2N1 bWVudC5hY3RpdmVFbGVtZW50LmJsdXIoKTsgaW5wdXQudHlwZSA9ICd0ZWwnIl07CisgICAgW3dl YlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0QW5kV2FpdEZvcklucHV0U2Vzc2lvblRvQ2hhbmdlOkAi aW5wdXQuZm9jdXMoKSJdOworICAgIEVYUEVDVF9GQUxTRShjb250ZW50Vmlldy5zdXBwb3J0c0lt YWdlUGFzdGUpOworCisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0QW5kV2FpdEZvcklu cHV0U2Vzc2lvblRvQ2hhbmdlOkAiZG9jdW1lbnQuYWN0aXZlRWxlbWVudC5ibHVyKCk7Il07Cisg ICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0QW5kV2FpdEZvcklucHV0U2Vzc2lvblRvQ2hh bmdlOkAidGV4dGFyZWEuZm9jdXMoKSJdOworICAgIEVYUEVDVF9UUlVFKGNvbnRlbnRWaWV3LnN1 cHBvcnRzSW1hZ2VQYXN0ZSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkKIAog I2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL2lvcy9VSVBhc3RlYm9hcmRUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvaW9zL1VJUGFzdGVib2FyZFRlc3RzLm1tCmluZGV4IDBkYTQ1MGJmMTVkODE2YmM4 NjA4YzMxZjEwZjMzYzFlZTBlZGM3MjEuLjM2ZDM4ZmYwMjVlZTk2MDJhYzIwOGZkNzE2YmE2ODRi ZTYyNzhmOGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJUGFz dGVib2FyZFRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1VJUGFz dGVib2FyZFRlc3RzLm1tCkBAIC0xNTEsNyArMTUxLDcgQEAgVEVTVChVSVBhc3RlYm9hcmRUZXN0 cywgUGFzdGVXaXRoQ29tcGxldGlvbkhhbmRsZXIpCiAgICAgW1VJUGFzdGVib2FyZCBnZW5lcmFs UGFzdGVib2FyZF0uVVJMID0gW05TVVJMIFVSTFdpdGhTdHJpbmc6QCJodHRwczovL3d3dy5hcHBs ZS5jb20vIl07CiAKICAgICBib29sIGRvbmUgPSBmYWxzZTsKLSAgICBbKGlkIDxVSVdLSW50ZXJh Y3Rpb25WaWV3UHJvdG9jb2xfU3RhZ2luZ180OTIzNjM4ND4pW3dlYlZpZXcgdGV4dElucHV0Q29u dGVudFZpZXddIHBhc3RlV2l0aENvbXBsZXRpb25IYW5kbGVyOlt3ZWJWaWV3LCAmZG9uZV0gewor ICAgIFsoaWQgPFVJV0tJbnRlcmFjdGlvblZpZXdQcm90b2NvbF9TdGFnaW5nX2lPU18xMz4pW3dl YlZpZXcgdGV4dElucHV0Q29udGVudFZpZXddIHBhc3RlV2l0aENvbXBsZXRpb25IYW5kbGVyOlt3 ZWJWaWV3LCAmZG9uZV0gewogICAgICAgICBbVUlQYXN0ZWJvYXJkIGdlbmVyYWxQYXN0ZWJvYXJk XS5pdGVtcyA9IEBbIF07CiAgICAgICAgIGRvbmUgPSB0cnVlOwogICAgIH1dOwpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvVUlLaXRTUEkuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvaW9zL1VJS2l0U1BJLmgKaW5kZXggZDFlMTA5ZGQwZDdmMWQyZTNjMzNlNjkxNWJjNGIxNTVl NjU3ZTI5Yy4uNmFmMzZmZjgxMTc4NDcxYTkzYTc1YWI2Yzk0NGY1N2Q4NzNkZDY3YyAxMDA2NDQK LS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3MvVUlLaXRTUEkuaAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL2lvcy9VSUtpdFNQSS5oCkBAIC0yMTMsOCArMjEzLDkgQEAgSUdOT1JFX1dBUk5J TkdTX0VORAogKyAoQk9PTClpc0luSGFyZHdhcmVLZXlib2FyZE1vZGU7CiBAZW5kCiAKLUBwcm90 b2NvbCBVSVdLSW50ZXJhY3Rpb25WaWV3UHJvdG9jb2xfU3RhZ2luZ180OTIzNjM4NCA8VUlXS0lu dGVyYWN0aW9uVmlld1Byb3RvY29sPgorQHByb3RvY29sIFVJV0tJbnRlcmFjdGlvblZpZXdQcm90 b2NvbF9TdGFnaW5nX2lPU18xMyA8VUlXS0ludGVyYWN0aW9uVmlld1Byb3RvY29sPgogLSAodm9p ZClwYXN0ZVdpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikodm9pZCkpY29tcGxldGlvbkhh bmRsZXI7CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIEJPT0wgc3VwcG9ydHNJbWFn ZVBhc3RlOwogQGVuZAogCiBAaW50ZXJmYWNlIFVJV2ViRm9ybUFjY2Vzc29yeSAoU3RhZ2luZ180 OTY2NjY0MykK 375969 2019-08-09 15:40:03 -0700 2019-08-09 15:45:29 -0700 Patch bug-200591-20190809154002.patch text/plain 5845 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5MWVhNmUwYmI2ZDk5OTQ4 ODgzZTkyMmE4NDRhNmM3MGE0MWUzZDMuLjEzZDk5NjdjN2UzY2NhNTU2OTVkZThkZTc5YTdmNTJm ZDJiMTM2MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDgtMDkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyAxM10gR29vZ2xl IERvY3MvU2xpZGVzL1NoZWV0czogcGFzdGUgb2Z0ZW4gZG9lc24ndCB3b3JrIGFuZCBzb21ldGlt ZXMgcHJvZHVjZXMgYW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMDU5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQxMDIyMzg+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRvcHRzIFVJ S2l0IFNQSSB0byBhdm9pZCBpbmNyZW1lbnRpbmcgdGhlIGdlbmVyYWwgcGFzdGVib2FyZCdzIGNo YW5nZSBjb3VudCB3aGVuZXZlciBhbiBlZGl0YWJsZSBlbGVtZW50IGlzCisgICAgICAgIGZvY3Vz ZWQuIFRoaXMgaXMgZHVlIHRvIGhvdywgaW4gaU9TIDEzLCBVSUtpdCB0ZW1wb3JhcmlseSB3cml0 ZXMgYW4gaW1hZ2UgdG8gdGhlIHBhc3RlYm9hcmQgd2hlbiBzaG93aW5nIHRoZQorICAgICAgICBr ZXlib2FyZCwgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgb3Igbm90IHRvIHNob3cgdGhlIE1lbW9qaXMg aW4gdGhlIGlucHV0IHZpZXcuCisKKyAgICAgICAgVGhpcyBjYXVzZXMgVUlQYXN0ZWJvYXJkJ3Mg Y2hhbmdlQ291bnQgdG8gaW5jcmVtZW50IHR3aWNlIGR1ZSB0byBhZGRpbmcgYW5kIHRoZW4gcmVt b3ZpbmcgdGhlIGltYWdlLCB3aGljaCBtZWFucworICAgICAgICB0aGF0IHRoZSBjaGFuZ2VDb3Vu dCBzYW5pdHkgY2hlY2tzIGluIHRoZSB3ZWIgcHJvY2VzcyB3aWxsIHJhY2UgYWdhaW5zdCB0aGUg cGFzdGVib2FyZCBnYWluaW5nIGFuZCB0aGVuIGxvc2luZworICAgICAgICB0aGlzIHRlbXBvcmFy eSBpbWFnZS4KKworICAgICAgICBJbnN0ZWFkLCB0aGUgbmV3IC1zdXBwb3J0c0ltYWdlUGFzdGUg U1BJIG1heSBiZSB1c2VkIHRvIHNob3J0LWNpcmN1aXQgdGhpcyBzdGVwLCBhbmQgYXZvaWQgdXBk YXRpbmcgdGhlCisgICAgICAgIGNoYW5nZUNvdW50IHdoZW4gVUlLZXlib2FyZEltcGwncyBkZWxl Z2F0ZSBjaGFuZ2VzLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc3VwcG9ydHNJbWFnZVBhc3Rl XSk6CisKIDIwMTktMDgtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgdGhyZWFkaW5nIGFzc2VydGlvbnMgdG8gV2ViU3RvcmFnZSBjb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQppbmRleCAyMTI5OWIxNDI0OGVmNWZkNDZmNWZjM2NhZTgyYjIyNDg1MjMzMWE1Li5lNWVm MzJjZjQ3OTc1MGM2YzZhOTZmZGI3ZWE4MTdlZGVhYTlhOTZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAg LTY4MjAsNiArNjgyMCwxMSBAQCAtIChOU0RpY3Rpb25hcnkgKilfYXV0b2ZpbGxDb250ZXh0CiAg ICAgcmV0dXJuIG5pbDsKIH0KIAorLSAoQk9PTClzdXBwb3J0c0ltYWdlUGFzdGUKK3sKKyAgICBy ZXR1cm4gbWF5Q29udGFpblNlbGVjdGFibGVUZXh0KF9mb2N1c2VkRWxlbWVudEluZm9ybWF0aW9u LmVsZW1lbnRUeXBlKTsKK30KKwogI2lmIEhBVkUoVUlfV0tfRE9DVU1FTlRfQ09OVEVYVCkKIAog c3RhdGljIGlubGluZSBPcHRpb25TZXQ8V2ViS2l0OjpEb2N1bWVudEVkaXRpbmdDb250ZXh0UmVx dWVzdDo6T3B0aW9ucz4gdG9XZWJEb2N1bWVudFJlcXVlc3RPcHRpb25zKFVJV0tEb2N1bWVudFJl cXVlc3RGbGFncyBmbGFncykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCA0OTY5ZDMwMjVjOWRiNDYzNjlhZmU0YTJjOTgyZjI2OTRiNTcyY2QyLi4w MmZkNGQ2MzI2OTNkYTM4ZjJjOGU3YWRjZWRkMThjZGI3NjNhMGIwIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTkt MDgtMDkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAg W2lPUyAxM10gR29vZ2xlIERvY3MvU2xpZGVzL1NoZWV0czogcGFzdGUgb2Z0ZW4gZG9lc24ndCB3 b3JrIGFuZCBzb21ldGltZXMgcHJvZHVjZXMgYW4gZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDU5MQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTQxMDIyMzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgbmV3IEFQSSB0ZXN0IHRvIGV4ZXJjaXNlIC1zdXBwb3J0c0ltYWdlUGFzdGUu CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVzdHNJ T1MubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKyAgICAgICAgKiBUZXN0V2Vi S2l0QVBJL2lvcy9VSUtpdFNQSS5oOgorCiAyMDE5LTA4LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogRGlzYWJsZSBzaGFyZWQgY2xp cGJvYXJkIGJldHdlZW4gU2ltdWxhdG9ycwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9pb3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9pb3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tCmluZGV4IGI1M2ZmMjhjNjA1ZDE2 MWJhMTI0ZGRjZGQyYzEyNzUzZDEwY2M5MGMuLmEzZWM4MmJlYzQ5NWIxNTRjODNmNmMxMzc5Mzgz ZmVjYzZiYjRmZWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tl eWJvYXJkSW5wdXRUZXN0c0lPUy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lv cy9LZXlib2FyZElucHV0VGVzdHNJT1MubW0KQEAgLTU1NSw2ICs1NTUsMzggQEAgVEVTVChLZXli b2FyZElucHV0VGVzdHMsIFRlc3RXZWJWaWV3QWRkaXRpb25hbENvbnRleHRGb3JTdHJvbmdQYXNz d29yZEFzc2lzdGFuY2UKICAgICBFWFBFQ1RfVFJVRShbW2FjdHVhbCBhbGxWYWx1ZXNdIGNvbnRh aW5zT2JqZWN0OmV4cGVjdGVkXSk7CiB9CiAKK1RFU1QoS2V5Ym9hcmRJbnB1dFRlc3RzLCBTdXBw b3J0c0ltYWdlUGFzdGUpCit7CisgICAgYXV0byBpbnB1dERlbGVnYXRlID0gYWRvcHROUyhbW1Rl c3RJbnB1dERlbGVnYXRlIGFsbG9jXSBpbml0XSk7CisgICAgW2lucHV0RGVsZWdhdGUgc2V0Rm9j dXNTdGFydHNJbnB1dFNlc3Npb25Qb2xpY3lIYW5kbGVyOlsmXSAoV0tXZWJWaWV3ICosIGlkIDxf V0tGb2N1c2VkRWxlbWVudEluZm8+KSAtPiBfV0tGb2N1c1N0YXJ0c0lucHV0U2Vzc2lvblBvbGlj eSB7CisgICAgICAgIHJldHVybiBfV0tGb2N1c1N0YXJ0c0lucHV0U2Vzc2lvblBvbGljeUFsbG93 OworICAgIH1dOworCisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcg YWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDU2OCldKTsKKyAgICBh dXRvIGNvbnRlbnRWaWV3ID0gKGlkIDxVSVRleHRJbnB1dFByaXZhdGVfU3RhZ2luZ181NDE0MDQx OD4pW3dlYlZpZXcgdGV4dElucHV0Q29udGVudFZpZXddOworICAgIFt3ZWJWaWV3IHN5bmNocm9u b3VzbHlMb2FkSFRNTFN0cmluZzpAIjxpbnB1dCBpZD0naW5wdXQnPjwvaW5wdXQ+PGRpdiBjb250 ZW50ZWRpdGFibGUgaWQ9J2VkaXRvcic+PC9kaXY+PHRleHRhcmVhIGlkPSd0ZXh0YXJlYSc+PC90 ZXh0YXJlYT4iXTsKKyAgICBbd2ViVmlldyBfc2V0SW5wdXREZWxlZ2F0ZTppbnB1dERlbGVnYXRl LmdldCgpXTsKKworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJp bnB1dC5mb2N1cygpIl07CisgICAgRVhQRUNUX1RSVUUoY29udGVudFZpZXcuc3VwcG9ydHNJbWFn ZVBhc3RlKTsKKworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJk b2N1bWVudC5hY3RpdmVFbGVtZW50LmJsdXIoKTsgaW5wdXQudHlwZSA9ICdkYXRlJyJdOworICAg IFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKKyAgICBbd2ViVmlldyBz dHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiaW5wdXQuZm9jdXMoKSJdOworICAgIEVYUEVD VF9GQUxTRShjb250ZW50Vmlldy5zdXBwb3J0c0ltYWdlUGFzdGUpOworCisgICAgW3dlYlZpZXcg c3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVkaXRvci5mb2N1cygpIl07CisgICAgRVhQ RUNUX1RSVUUoY29udGVudFZpZXcuc3VwcG9ydHNJbWFnZVBhc3RlKTsKKworICAgIFt3ZWJWaWV3 IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5hY3RpdmVFbGVtZW50LmJs dXIoKTsgaW5wdXQudHlwZSA9ICdjb2xvciciXTsKKyAgICBbd2ViVmlldyB3YWl0Rm9yTmV4dFBy ZXNlbnRhdGlvblVwZGF0ZV07CisgICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNj cmlwdDpAImlucHV0LmZvY3VzKCkiXTsKKyAgICBFWFBFQ1RfRkFMU0UoY29udGVudFZpZXcuc3Vw cG9ydHNJbWFnZVBhc3RlKTsKKworICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJ0ZXh0YXJlYS5mb2N1cygpIl07CisgICAgRVhQRUNUX1RSVUUoY29udGVudFZpZXcu c3VwcG9ydHNJbWFnZVBhc3RlKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQog CiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmggYi9Ub29scy9UZXN0V2ViS2l0QVBJL2lvcy9VSUtpdFNQ SS5oCmluZGV4IGQxZTEwOWRkMGQ3ZjFkMmUzYzMzZTY5MTViYzRiMTU1ZTY1N2UyOWMuLjg2ZGE1 YWQxN2FiNjk1MzhlNTY3NjAxODg0Zjg3MDYwNDE3MGVjY2EgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmgKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9pb3Mv VUlLaXRTUEkuaApAQCAtMjE3LDYgKzIxNywxMCBAQCBJR05PUkVfV0FSTklOR1NfRU5ECiAtICh2 b2lkKXBhc3RlV2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKSh2b2lkKSljb21wbGV0aW9u SGFuZGxlcjsKIEBlbmQKIAorQHByb3RvY29sIFVJVGV4dElucHV0UHJpdmF0ZV9TdGFnaW5nXzU0 MTQwNDE4IDxVSVRleHRJbnB1dFByaXZhdGU+CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9u bHkpIEJPT0wgc3VwcG9ydHNJbWFnZVBhc3RlOworQGVuZAorCiBAaW50ZXJmYWNlIFVJV2ViRm9y bUFjY2Vzc29yeSAoU3RhZ2luZ180OTY2NjY0MykKIC0gKHZvaWQpc2V0TmV4dFByZXZpb3VzSXRl bXNWaXNpYmxlOihCT09MKXZpc2libGU7CiBAZW5kCg==