<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200589</bug_id>
          
          <creation_ts>2019-08-09 14:11:59 -0700</creation_ts>
          <short_desc>Fix Crash in Mail Search</short_desc>
          <delta_ts>2019-08-12 14:41:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Megan Gardner">megan_gardner</reporter>
          <assigned_to name="Megan Gardner">megan_gardner</assigned_to>
          <cc>bdakin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>rniwa</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1560016</commentid>
    <comment_count>0</comment_count>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 14:11:59 -0700</bug_when>
    <thetext>Fix Crash in Mail Search</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560021</commentid>
    <comment_count>1</comment_count>
      <attachid>375953</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 14:14:13 -0700</bug_when>
    <thetext>Created attachment 375953
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560030</commentid>
    <comment_count>2</comment_count>
      <attachid>375953</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 14:17:51 -0700</bug_when>
    <thetext>Comment on attachment 375953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375953&amp;action=review

&gt; Source/WebKit/ChangeLog:10
&gt; +        It is possible for AppKit reasons to get a -1 for the index
&gt; +        of the found item. Do not try and insert data in this case.
&gt; +
&gt; +        Reviewed by NOBODY (OOPS!).

Something bad happened here with the order.

Also, it would be nice to be more specific about the &quot;AppKit reasons&quot;. Isn&apos;t it really about reverse search? (And then, why is it OK not to have any rects? does it actually behave correctly?)

&gt; Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:85
&gt; +            if (matchIndex &gt; 0 &amp;&amp; matchIndex &lt; matchCount)
&gt; +                allMatches[matchIndex].appendVector(matchRects);

matchIndex 0 is valid, so you want &gt;=</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560031</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 14:18:17 -0700</bug_when>
    <thetext>Please test both Mail and Notes, forward and backward, in conversations and not (in Mail).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560032</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 14:18:40 -0700</bug_when>
    <thetext>ALSO ALSO this should totally be API testable</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560051</commentid>
    <comment_count>5</comment_count>
      <attachid>375960</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 14:38:16 -0700</bug_when>
    <thetext>Created attachment 375960
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560054</commentid>
    <comment_count>6</comment_count>
      <attachid>375962</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 14:45:07 -0700</bug_when>
    <thetext>Created attachment 375962
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560059</commentid>
    <comment_count>7</comment_count>
      <attachid>375964</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 14:56:04 -0700</bug_when>
    <thetext>Created attachment 375964
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560078</commentid>
    <comment_count>8</comment_count>
      <attachid>375968</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 15:33:09 -0700</bug_when>
    <thetext>Created attachment 375968
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560094</commentid>
    <comment_count>9</comment_count>
      <attachid>375968</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 15:50:49 -0700</bug_when>
    <thetext>Comment on attachment 375968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375968&amp;action=review

&gt; Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:84
&gt; -            allMatches[matchIndex].appendVector(matchRects);
&gt; +            if (matchIndex &gt;= 0 &amp;&amp; (uint32_t)matchIndex &lt; matchCount)

This is fine for now given current clients, but maybe leave a FIXME that we should have match rects when doing an incremental backwards search (did you test Notes??).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560152</commentid>
    <comment_count>10</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2019-08-09 19:28:12 -0700</bug_when>
    <thetext>&lt;rdar://problem/53666720&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560164</commentid>
    <comment_count>11</comment_count>
      <attachid>375968</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2019-08-09 19:57:13 -0700</bug_when>
    <thetext>Comment on attachment 375968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375968&amp;action=review

&gt;&gt; Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:84
&gt;&gt; +            if (matchIndex &gt;= 0 &amp;&amp; (uint32_t)matchIndex &lt; matchCount)
&gt; 
&gt; This is fine for now given current clients, but maybe leave a FIXME that we should have match rects when doing an incremental backwards search (did you test Notes??).

Also, please use static_cast&lt;uint32_t&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560387</commentid>
    <comment_count>12</comment_count>
      <attachid>376059</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-12 06:45:34 -0700</bug_when>
    <thetext>Created attachment 376059
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560534</commentid>
    <comment_count>13</comment_count>
      <attachid>376090</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-12 13:12:15 -0700</bug_when>
    <thetext>Created attachment 376090
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560559</commentid>
    <comment_count>14</comment_count>
      <attachid>376090</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 14:41:03 -0700</bug_when>
    <thetext>Comment on attachment 376090
Patch for landing

Clearing flags on attachment: 376090

Committed r248548: &lt;https://trac.webkit.org/changeset/248548&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560560</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 14:41:04 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375953</attachid>
            <date>2019-08-09 14:14:13 -0700</date>
            <delta_ts>2019-08-09 14:38:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200589-20190809171412.patch</filename>
            <type>text/plain</type>
            <size>1605</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmVlZTQzMzIyMjkwNmM2NTU2N2UwYzE5ZjdiY2RmZDJh
MmM3ODg0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
SXQgaXMgcG9zc2libGUgZm9yIEFwcEtpdCByZWFzb25zIHRvIGdldCBhIC0xIGZvciB0aGUgaW5k
ZXgKKyAgICAgICAgb2YgdGhlIGZvdW5kIGl0ZW0uIERvIG5vdCB0cnkgYW5kIGluc2VydCBkYXRh
IGluIHRoaXMgY2FzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tOgorCiAyMDE5LTA4
LTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250ZXh0IG1l
bnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNlcyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0gYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tCmluZGV4IGI3
ZjZjMmZiN2E2YmY1ZWNkZGI0NjU5ZDdjZTcwY2UyYWU3YWQ1NTUuLjZjMjVhNjhhNWU0MGNjNGQw
MWI2OTA5YjM2N2Q2YjE4NzVmM2VhZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl
c3MvbWFjL1dLVGV4dEZpbmRlckNsaWVudC5tbQpAQCAtODEsNyArODEsOCBAQCBwcml2YXRlOgog
ICAgICAgICAgICAgLy8gVGhlIHJlc3Qgd2lsbCByZW1haW4gZW1wdHksIGJ1dCBpdCdzIGltcG9y
dGFudCB0byBOU1RleHRGaW5kZXIKICAgICAgICAgICAgIC8vIHRoYXQgdGhleSBhdCBsZWFzdCBl
eGlzdC4KICAgICAgICAgICAgIGFsbE1hdGNoZXMucmVzaXplKG1hdGNoQ291bnQpOwotICAgICAg
ICAgICAgYWxsTWF0Y2hlc1ttYXRjaEluZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7Cisg
ICAgICAgICAgICBpZiAobWF0Y2hJbmRleCA+IDAgJiYgbWF0Y2hJbmRleCA8IG1hdGNoQ291bnQp
CisgICAgICAgICAgICAgICAgYWxsTWF0Y2hlc1ttYXRjaEluZGV4XS5hcHBlbmRWZWN0b3IobWF0
Y2hSZWN0cyk7CiAgICAgICAgIH0KIAogICAgICAgICBbbV90ZXh0RmluZGVyQ2xpZW50IGRpZEZp
bmRTdHJpbmdNYXRjaGVzV2l0aFJlY3RzOmFsbE1hdGNoZXMgZGlkV3JhcEFyb3VuZDpkaWRXcmFw
QXJvdW5kXTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375960</attachid>
            <date>2019-08-09 14:38:16 -0700</date>
            <delta_ts>2019-08-09 14:45:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200589-20190809173814.patch</filename>
            <type>text/plain</type>
            <size>1606</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmVlZTQzMzIyMjkwNmM2NTU2N2UwYzE5ZjdiY2RmZDJh
MmM3ODg0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
SXQgaXMgcG9zc2libGUgZm9yIEFwcEtpdCByZWFzb25zIHRvIGdldCBhIC0xIGZvciB0aGUgaW5k
ZXgKKyAgICAgICAgb2YgdGhlIGZvdW5kIGl0ZW0uIERvIG5vdCB0cnkgYW5kIGluc2VydCBkYXRh
IGluIHRoaXMgY2FzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tOgorCiAyMDE5LTA4
LTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250ZXh0IG1l
bnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNlcyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0gYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tCmluZGV4IGI3
ZjZjMmZiN2E2YmY1ZWNkZGI0NjU5ZDdjZTcwY2UyYWU3YWQ1NTUuLjQ2ZWUyMTUwYTRjODBiM2I1
NDBlMjNjMGRiN2UxZGU1MTUyNGU1M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl
c3MvbWFjL1dLVGV4dEZpbmRlckNsaWVudC5tbQpAQCAtODEsNyArODEsOCBAQCBwcml2YXRlOgog
ICAgICAgICAgICAgLy8gVGhlIHJlc3Qgd2lsbCByZW1haW4gZW1wdHksIGJ1dCBpdCdzIGltcG9y
dGFudCB0byBOU1RleHRGaW5kZXIKICAgICAgICAgICAgIC8vIHRoYXQgdGhleSBhdCBsZWFzdCBl
eGlzdC4KICAgICAgICAgICAgIGFsbE1hdGNoZXMucmVzaXplKG1hdGNoQ291bnQpOwotICAgICAg
ICAgICAgYWxsTWF0Y2hlc1ttYXRjaEluZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7Cisg
ICAgICAgICAgICBpZiAobWF0Y2hJbmRleCA+PSAwICYmIG1hdGNoSW5kZXggPCBtYXRjaENvdW50
KQorICAgICAgICAgICAgICAgIGFsbE1hdGNoZXNbbWF0Y2hJbmRleF0uYXBwZW5kVmVjdG9yKG1h
dGNoUmVjdHMpOwogICAgICAgICB9CiAKICAgICAgICAgW21fdGV4dEZpbmRlckNsaWVudCBkaWRG
aW5kU3RyaW5nTWF0Y2hlc1dpdGhSZWN0czphbGxNYXRjaGVzIGRpZFdyYXBBcm91bmQ6ZGlkV3Jh
cEFyb3VuZF07Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375962</attachid>
            <date>2019-08-09 14:45:07 -0700</date>
            <delta_ts>2019-08-09 14:56:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200589-20190809174506.patch</filename>
            <type>text/plain</type>
            <size>1616</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmVlZTQzMzIyMjkwNmM2NTU2N2UwYzE5ZjdiY2RmZDJh
MmM3ODg0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
SXQgaXMgcG9zc2libGUgZm9yIEFwcEtpdCByZWFzb25zIHRvIGdldCBhIC0xIGZvciB0aGUgaW5k
ZXgKKyAgICAgICAgb2YgdGhlIGZvdW5kIGl0ZW0uIERvIG5vdCB0cnkgYW5kIGluc2VydCBkYXRh
IGluIHRoaXMgY2FzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tOgorCiAyMDE5LTA4
LTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250ZXh0IG1l
bnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNlcyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0gYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tCmluZGV4IGI3
ZjZjMmZiN2E2YmY1ZWNkZGI0NjU5ZDdjZTcwY2UyYWU3YWQ1NTUuLjkxYThlOGFiMGJmNWExMTE5
MmEyYzhlZDE0NDA4NDE1NTIxMzFmZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl
c3MvbWFjL1dLVGV4dEZpbmRlckNsaWVudC5tbQpAQCAtODEsNyArODEsOCBAQCBwcml2YXRlOgog
ICAgICAgICAgICAgLy8gVGhlIHJlc3Qgd2lsbCByZW1haW4gZW1wdHksIGJ1dCBpdCdzIGltcG9y
dGFudCB0byBOU1RleHRGaW5kZXIKICAgICAgICAgICAgIC8vIHRoYXQgdGhleSBhdCBsZWFzdCBl
eGlzdC4KICAgICAgICAgICAgIGFsbE1hdGNoZXMucmVzaXplKG1hdGNoQ291bnQpOwotICAgICAg
ICAgICAgYWxsTWF0Y2hlc1ttYXRjaEluZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7Cisg
ICAgICAgICAgICBpZiAobWF0Y2hJbmRleCA+PSAwICYmICh1aW50MzJfdCltYXRjaEluZGV4IDwg
bWF0Y2hDb3VudCkKKyAgICAgICAgICAgICAgICBhbGxNYXRjaGVzW21hdGNoSW5kZXhdLmFwcGVu
ZFZlY3RvcihtYXRjaFJlY3RzKTsKICAgICAgICAgfQogCiAgICAgICAgIFttX3RleHRGaW5kZXJD
bGllbnQgZGlkRmluZFN0cmluZ01hdGNoZXNXaXRoUmVjdHM6YWxsTWF0Y2hlcyBkaWRXcmFwQXJv
dW5kOmRpZFdyYXBBcm91bmRdOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375964</attachid>
            <date>2019-08-09 14:56:04 -0700</date>
            <delta_ts>2019-08-09 15:33:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200589-20190809175603.patch</filename>
            <type>text/plain</type>
            <size>1616</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmVlZTQzMzIyMjkwNmM2NTU2N2UwYzE5ZjdiY2RmZDJh
MmM3ODg0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
SXQgaXMgcG9zc2libGUgZm9yIEFwcEtpdCByZWFzb25zIHRvIGdldCBhIC0xIGZvciB0aGUgaW5k
ZXgKKyAgICAgICAgb2YgdGhlIGZvdW5kIGl0ZW0uIERvIG5vdCB0cnkgYW5kIGluc2VydCBkYXRh
IGluIHRoaXMgY2FzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tOgorCiAyMDE5LTA4
LTA2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250ZXh0IG1l
bnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNlcyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0gYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tCmluZGV4IGI3
ZjZjMmZiN2E2YmY1ZWNkZGI0NjU5ZDdjZTcwY2UyYWU3YWQ1NTUuLjkxYThlOGFiMGJmNWExMTE5
MmEyYzhlZDE0NDA4NDE1NTIxMzFmZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl
c3MvbWFjL1dLVGV4dEZpbmRlckNsaWVudC5tbQpAQCAtODEsNyArODEsOCBAQCBwcml2YXRlOgog
ICAgICAgICAgICAgLy8gVGhlIHJlc3Qgd2lsbCByZW1haW4gZW1wdHksIGJ1dCBpdCdzIGltcG9y
dGFudCB0byBOU1RleHRGaW5kZXIKICAgICAgICAgICAgIC8vIHRoYXQgdGhleSBhdCBsZWFzdCBl
eGlzdC4KICAgICAgICAgICAgIGFsbE1hdGNoZXMucmVzaXplKG1hdGNoQ291bnQpOwotICAgICAg
ICAgICAgYWxsTWF0Y2hlc1ttYXRjaEluZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7Cisg
ICAgICAgICAgICBpZiAobWF0Y2hJbmRleCA+PSAwICYmICh1aW50MzJfdCltYXRjaEluZGV4IDwg
bWF0Y2hDb3VudCkKKyAgICAgICAgICAgICAgICBhbGxNYXRjaGVzW21hdGNoSW5kZXhdLmFwcGVu
ZFZlY3RvcihtYXRjaFJlY3RzKTsKICAgICAgICAgfQogCiAgICAgICAgIFttX3RleHRGaW5kZXJD
bGllbnQgZGlkRmluZFN0cmluZ01hdGNoZXNXaXRoUmVjdHM6YWxsTWF0Y2hlcyBkaWRXcmFwQXJv
dW5kOmRpZFdyYXBBcm91bmRdOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375968</attachid>
            <date>2019-08-09 15:33:09 -0700</date>
            <delta_ts>2019-08-12 06:45:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200589-20190809183308.patch</filename>
            <type>text/plain</type>
            <size>3553</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmM4NjMyZDliNzdmZGY3Y2U5Nzk5YWJkMzAwYmVkMTY4
YWUzNWFkYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgd2Ugc2VhcmNoIGluIE1h
aWwgYmFja3dhcmRzIGZpcnN0LCBmb3IgQXBwS2l0IHJlYXNvbnMgCisgICAgICAgIHdlIGdldCBh
IC0xIGZvciB0aGUgaW5kZXggb2YgdGhlIGZvdW5kIGl0ZW0uCisgICAgICAgIERvIG5vdCB0cnkg
YW5kIGluc2VydCBkYXRhIGluIHRoaXMgY2FzZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMv
V0tUZXh0RmluZGVyQ2xpZW50Lm1tOgorCiAyMDE5LTA4LTA2ICBEZWFuIEphY2tzb24gIDxkaW5v
QGFwcGxlLmNvbT4KIAogICAgICAgICBDb250ZXh0IG1lbnUgb24gYSB1bml2ZXJzYWwgbGluayBw
cm9kdWNlcyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9t
YWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tCmluZGV4IGI3ZjZjMmZiN2E2YmY1ZWNkZGI0NjU5ZDdj
ZTcwY2UyYWU3YWQ1NTUuLjkxYThlOGFiMGJmNWExMTE5MmEyYzhlZDE0NDA4NDE1NTIxMzFmZmQg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGll
bnQubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLVGV4dEZpbmRlckNsaWVu
dC5tbQpAQCAtODEsNyArODEsOCBAQCBwcml2YXRlOgogICAgICAgICAgICAgLy8gVGhlIHJlc3Qg
d2lsbCByZW1haW4gZW1wdHksIGJ1dCBpdCdzIGltcG9ydGFudCB0byBOU1RleHRGaW5kZXIKICAg
ICAgICAgICAgIC8vIHRoYXQgdGhleSBhdCBsZWFzdCBleGlzdC4KICAgICAgICAgICAgIGFsbE1h
dGNoZXMucmVzaXplKG1hdGNoQ291bnQpOwotICAgICAgICAgICAgYWxsTWF0Y2hlc1ttYXRjaElu
ZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7CisgICAgICAgICAgICBpZiAobWF0Y2hJbmRl
eCA+PSAwICYmICh1aW50MzJfdCltYXRjaEluZGV4IDwgbWF0Y2hDb3VudCkKKyAgICAgICAgICAg
ICAgICBhbGxNYXRjaGVzW21hdGNoSW5kZXhdLmFwcGVuZFZlY3RvcihtYXRjaFJlY3RzKTsKICAg
ICAgICAgfQogCiAgICAgICAgIFttX3RleHRGaW5kZXJDbGllbnQgZGlkRmluZFN0cmluZ01hdGNo
ZXNXaXRoUmVjdHM6YWxsTWF0Y2hlcyBkaWRXcmFwQXJvdW5kOmRpZFdyYXBBcm91bmRdOwpkaWZm
IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDJkY2QzZjc1
ZDA5NjEyNmIxMTUyMTM4MTFmZjM3ZGZkNjYxYjIyMWYuLjdmMzU1MGRhMTBkNjVjNjliNWQxZjU0
MTIxYTE3YTY3ZjY5NDUxMzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s
cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wOC0wOSAgTWVnYW4gR2FyZG5lciAg
PG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBDcmFzaCBpbiBNYWlsIFNl
YXJjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAw
NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYg
eW91IHNlYXJjaCBiYWNrd2FyZHMgZmlyc3QgaW4gbWFpbCwgd2Ugd291bGQgY3Jhc2gsCisgICAg
ICAgIHRoaXMgdGVzdHMgdGhhdCBjb2RlcGF0aC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv
VGVzdHMvV2ViS2l0Q29jb2EvRmluZEluUGFnZS5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE5
LTA4LTA3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg
ICAgQWRkIFdITFNMIGFuZCBXZWJHUFUgdG8gdGhlIHdhdGNobGlzdCBmaWxlCmRpZmYgLS1naXQg
YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0ZpbmRJblBhZ2UubW0gYi9U
b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0ZpbmRJblBhZ2UubW0KaW5kZXgg
NDFlYjE2MzkzOWFmOWExZmYzNDcwZmM3ZTA5YTEwMmNkYTQ3MDMyZi4uMzg5ZWNkYzBhODNkZTVj
MmIyMWI1Mzc5NDQwYmIwMTg4ZGU5Y2M0NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ
SS9UZXN0cy9XZWJLaXRDb2NvYS9GaW5kSW5QYWdlLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB
UEkvVGVzdHMvV2ViS2l0Q29jb2EvRmluZEluUGFnZS5tbQpAQCAtMjI0LDYgKzIyNCwyMiBAQCBU
RVNUKFdlYktpdCwgRmluZEluUGFnZVdyYXBwaW5nRGlzYWJsZWQpCiAgICAgRVhQRUNUX0ZBTFNF
KHJlc3VsdC5kaWRXcmFwKTsKIH0KIAorVEVTVChXZWJLaXQsIEZpbmRJblBhZ2VCYWNrd2FyZHNG
aXJzdCkKK3sKKyAgICBSZXRhaW5QdHI8V0tXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dL
V2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDEwMCwgMTAwKV0p
OworICAgIFt3ZWJWaWV3IF9zZXRPdmVycmlkZURldmljZVNjYWxlRmFjdG9yOjJdOworCisgICAg
W3dlYlZpZXcgbG9hZEhUTUxTdHJpbmc6QCJ3b3JkIHdvcmQiIGJhc2VVUkw6bmlsXTsKKyAgICBb
d2ViVmlldyBfdGVzdF93YWl0Rm9yRGlkRmluaXNoTmF2aWdhdGlvbl07CisKKyAgICAvLyBGaW5k
IG9uZSBtYXRjaCwgZG9pbmcgYW4gaW5jcmVtZW50YWwgc2VhcmNoLgorICAgIGF1dG8gcmVzdWx0
ID0gZmluZE1hdGNoZXMod2ViVmlldy5nZXQoKSwgQCJ3b3JkIiwgd3JhcEJhY2t3YXJkc0ZpbmRP
cHRpb25zLCAxKTsKKyAgICBFWFBFQ1RfRVEoKE5TVUludGVnZXIpMSwgW3Jlc3VsdC5tYXRjaGVz
IGNvdW50XSk7CisKKyAgICByZXN1bHQgPSBmaW5kTWF0Y2hlcyh3ZWJWaWV3LmdldCgpLCBAIndv
cmQiLCB3cmFwQmFja3dhcmRzRmluZE9wdGlvbnMsIDEpOworICAgIEVYUEVDVF9FUSgoTlNVSW50
ZWdlcikxLCBbcmVzdWx0Lm1hdGNoZXMgY291bnRdKTsKK30KKwogVEVTVChXZWJLaXQsIEZpbmRJ
blBhZ2VXcmFwcGluZ1N1YmZyYW1lKQogewogICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZp
ZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3Qo
MCwgMCwgMTAwLCAxMDApXSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376059</attachid>
            <date>2019-08-12 06:45:34 -0700</date>
            <delta_ts>2019-08-12 13:11:56 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-200589-20190812094533.patch</filename>
            <type>text/plain</type>
            <size>3640</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyMDEzY2ZlMzM3Mjk0ZTEx
NTdkMzBjZGMwYmFmNjA5ZTQzMTc3ODcuLmE1ZjVmZmY0ZDFhZTA2ZjE0NGRkMDA2OTEyYmY4NGE5
YWE5ZjA1ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBJZiB3ZSBzZWFyY2ggaW4gTWFpbCBi
YWNrd2FyZHMgZmlyc3QsIGZvciBBcHBLaXQgcmVhc29ucyAKKyAgICAgICAgd2UgZ2V0IGEgLTEg
Zm9yIHRoZSBpbmRleCBvZiB0aGUgZm91bmQgaXRlbS4KKyAgICAgICAgRG8gbm90IHRyeSBhbmQg
aW5zZXJ0IGRhdGEgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS1Rl
eHRGaW5kZXJDbGllbnQubW06CisKIDIwMTktMDgtMDYgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw
bGUuY29tPgogCiAgICAgICAgIENvbnRleHQgbWVudSBvbiBhIHVuaXZlcnNhbCBsaW5rIHByb2R1
Y2VzIGEgYmxhbmsgcHJldmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
bWFjL1dLVGV4dEZpbmRlckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9X
S1RleHRGaW5kZXJDbGllbnQubW0KaW5kZXggYjdmNmMyZmI3YTZiZjVlY2RkYjQ2NTlkN2NlNzBj
ZTJhZTdhZDU1NS4uNjYwMzE3YzJmYmM3OWI2OGJiNWI3MzQ3NmE1OGJlZmVhMDliMDZkMyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLVGV4dEZpbmRlckNsaWVudC5t
bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1t
CkBAIC04MSw3ICs4MSw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAvLyBUaGUgcmVzdCB3aWxs
IHJlbWFpbiBlbXB0eSwgYnV0IGl0J3MgaW1wb3J0YW50IHRvIE5TVGV4dEZpbmRlcgogICAgICAg
ICAgICAgLy8gdGhhdCB0aGV5IGF0IGxlYXN0IGV4aXN0LgogICAgICAgICAgICAgYWxsTWF0Y2hl
cy5yZXNpemUobWF0Y2hDb3VudCk7Ci0gICAgICAgICAgICBhbGxNYXRjaGVzW21hdGNoSW5kZXhd
LmFwcGVuZFZlY3RvcihtYXRjaFJlY3RzKTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBDbGVhbiB0
aGlzIHVwIGFuZCBmaWd1cmUgb3V0IHdoeSB3ZSBhcmUgZ2V0dGluZyBhIC0xIGluZGV4CisgICAg
ICAgICAgICBpZiAobWF0Y2hJbmRleCA+PSAwICYmIHN0YXRpY19jYXN0PHVpbnQzMl90PihtYXRj
aEluZGV4KSA8IG1hdGNoQ291bnQpCisgICAgICAgICAgICAgICAgYWxsTWF0Y2hlc1ttYXRjaElu
ZGV4XS5hcHBlbmRWZWN0b3IobWF0Y2hSZWN0cyk7CiAgICAgICAgIH0KIAogICAgICAgICBbbV90
ZXh0RmluZGVyQ2xpZW50IGRpZEZpbmRTdHJpbmdNYXRjaGVzV2l0aFJlY3RzOmFsbE1hdGNoZXMg
ZGlkV3JhcEFyb3VuZDpkaWRXcmFwQXJvdW5kXTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv
ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZGNkM2Y3NWQwOTYxMjZiMTE1MjEzODExZmYzN2Rm
ZDY2MWIyMjFmLi43MGMxMmYxYjQwNGQ0MzQyYjVjYWJhMTNkNTVmZTI2MGRiNzkzMTQzIDEwMDY0
NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTYgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNv
bT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4gTWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDU4OQorCisgICAgICAgIFJldmlld2Vk
IGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgSWYgeW91IHNlYXJjaCBiYWNrd2FyZHMgZmlyc3Qg
aW4gbWFpbCwgd2Ugd291bGQgY3Jhc2gsCisgICAgICAgIHRoaXMgdGVzdHMgdGhhdCBjb2RlcGF0
aC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRmluZEluUGFn
ZS5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE5LTA4LTA3ICBNeWxlcyBDLiBNYXhmaWVsZCAg
PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdITFNMIGFuZCBXZWJHUFUgdG8g
dGhlIHdhdGNobGlzdCBmaWxlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz
L1dlYktpdENvY29hL0ZpbmRJblBhZ2UubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl
YktpdENvY29hL0ZpbmRJblBhZ2UubW0KaW5kZXggNDFlYjE2MzkzOWFmOWExZmYzNDcwZmM3ZTA5
YTEwMmNkYTQ3MDMyZi4uMzg5ZWNkYzBhODNkZTVjMmIyMWI1Mzc5NDQwYmIwMTg4ZGU5Y2M0NCAx
MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9GaW5kSW5Q
YWdlLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRmluZElu
UGFnZS5tbQpAQCAtMjI0LDYgKzIyNCwyMiBAQCBURVNUKFdlYktpdCwgRmluZEluUGFnZVdyYXBw
aW5nRGlzYWJsZWQpCiAgICAgRVhQRUNUX0ZBTFNFKHJlc3VsdC5kaWRXcmFwKTsKIH0KIAorVEVT
VChXZWJLaXQsIEZpbmRJblBhZ2VCYWNrd2FyZHNGaXJzdCkKK3sKKyAgICBSZXRhaW5QdHI8V0tX
ZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt
ZTpOU01ha2VSZWN0KDAsIDAsIDEwMCwgMTAwKV0pOworICAgIFt3ZWJWaWV3IF9zZXRPdmVycmlk
ZURldmljZVNjYWxlRmFjdG9yOjJdOworCisgICAgW3dlYlZpZXcgbG9hZEhUTUxTdHJpbmc6QCJ3
b3JkIHdvcmQiIGJhc2VVUkw6bmlsXTsKKyAgICBbd2ViVmlldyBfdGVzdF93YWl0Rm9yRGlkRmlu
aXNoTmF2aWdhdGlvbl07CisKKyAgICAvLyBGaW5kIG9uZSBtYXRjaCwgZG9pbmcgYW4gaW5jcmVt
ZW50YWwgc2VhcmNoLgorICAgIGF1dG8gcmVzdWx0ID0gZmluZE1hdGNoZXMod2ViVmlldy5nZXQo
KSwgQCJ3b3JkIiwgd3JhcEJhY2t3YXJkc0ZpbmRPcHRpb25zLCAxKTsKKyAgICBFWFBFQ1RfRVEo
KE5TVUludGVnZXIpMSwgW3Jlc3VsdC5tYXRjaGVzIGNvdW50XSk7CisKKyAgICByZXN1bHQgPSBm
aW5kTWF0Y2hlcyh3ZWJWaWV3LmdldCgpLCBAIndvcmQiLCB3cmFwQmFja3dhcmRzRmluZE9wdGlv
bnMsIDEpOworICAgIEVYUEVDVF9FUSgoTlNVSW50ZWdlcikxLCBbcmVzdWx0Lm1hdGNoZXMgY291
bnRdKTsKK30KKwogVEVTVChXZWJLaXQsIEZpbmRJblBhZ2VXcmFwcGluZ1N1YmZyYW1lKQogewog
ICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFs
bG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgMTAwLCAxMDApXSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376090</attachid>
            <date>2019-08-12 13:12:15 -0700</date>
            <delta_ts>2019-08-12 14:41:03 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-200589-20190812161214.patch</filename>
            <type>text/plain</type>
            <size>3655</size>
            <attacher name="Megan Gardner">megan_gardner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3M2NlZjZjNjMzMDRmNmUx
OWU0NDllYTM1YjExN2E2MDk1MWIwN2MuLjZhODNhOTg1ZGQzZjI2OTJjZDFhN2IwYzdhMjkyY2E3
MWJmMTNiZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDgtMDkgIE1lZ2FuIEdh
cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ3Jhc2ggaW4g
TWFpbCBTZWFyY2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIwMDU4OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM2NjY3MjA+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBJZiB3ZSBzZWFyY2ggaW4gTWFpbCBi
YWNrd2FyZHMgZmlyc3QsIGZvciBBcHBLaXQgcmVhc29ucyAKKyAgICAgICAgd2UgZ2V0IGEgLTEg
Zm9yIHRoZSBpbmRleCBvZiB0aGUgZm91bmQgaXRlbS4KKyAgICAgICAgRG8gbm90IHRyeSBhbmQg
aW5zZXJ0IGRhdGEgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS1Rl
eHRGaW5kZXJDbGllbnQubW06CisKIDIwMTktMDgtMTIgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBh
cHBsZS5jb20+CiAKICAgICAgICAgQ2xlYXIgbV9zZXNzaW9uU3RvcmFnZU5hbWVzcGFjZXMgb24g
dGhlIGJhY2tncm91bmQgdGhyZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz
cy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFj
L1dLVGV4dEZpbmRlckNsaWVudC5tbQppbmRleCBiN2Y2YzJmYjdhNmJmNWVjZGRiNDY1OWQ3Y2U3
MGNlMmFlN2FkNTU1Li42NjAzMTdjMmZiYzc5YjY4YmI1YjczNDc2YTU4YmVmZWEwOWIwNmQzIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tUZXh0RmluZGVyQ2xpZW50
Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1RleHRGaW5kZXJDbGllbnQu
bW0KQEAgLTgxLDcgKzgxLDkgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIC8vIFRoZSByZXN0IHdp
bGwgcmVtYWluIGVtcHR5LCBidXQgaXQncyBpbXBvcnRhbnQgdG8gTlNUZXh0RmluZGVyCiAgICAg
ICAgICAgICAvLyB0aGF0IHRoZXkgYXQgbGVhc3QgZXhpc3QuCiAgICAgICAgICAgICBhbGxNYXRj
aGVzLnJlc2l6ZShtYXRjaENvdW50KTsKLSAgICAgICAgICAgIGFsbE1hdGNoZXNbbWF0Y2hJbmRl
eF0uYXBwZW5kVmVjdG9yKG1hdGNoUmVjdHMpOworICAgICAgICAgICAgLy8gRklYTUU6IENsZWFu
IHRoaXMgdXAgYW5kIGZpZ3VyZSBvdXQgd2h5IHdlIGFyZSBnZXR0aW5nIGEgLTEgaW5kZXgKKyAg
ICAgICAgICAgIGlmIChtYXRjaEluZGV4ID49IDAgJiYgc3RhdGljX2Nhc3Q8dWludDMyX3Q+KG1h
dGNoSW5kZXgpIDwgbWF0Y2hDb3VudCkKKyAgICAgICAgICAgICAgICBhbGxNYXRjaGVzW21hdGNo
SW5kZXhdLmFwcGVuZFZlY3RvcihtYXRjaFJlY3RzKTsKICAgICAgICAgfQogCiAgICAgICAgIFtt
X3RleHRGaW5kZXJDbGllbnQgZGlkRmluZFN0cmluZ01hdGNoZXNXaXRoUmVjdHM6YWxsTWF0Y2hl
cyBkaWRXcmFwQXJvdW5kOmRpZFdyYXBBcm91bmRdOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl
TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDkwMDc3MzdmOGE4OTIxYWY2NjlmMjU5MzA3YjJm
NmFhNWFlM2FiNzEuLmEwY2NjZjFiMzJmYjg1M2IyNjc0ZGI4YTk0ZmVlMjY1OWUzYTVlZWEgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNiBAQAorMjAxOS0wOC0wOSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUu
Y29tPgorCisgICAgICAgIEZpeCBDcmFzaCBpbiBNYWlsIFNlYXJjaAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTg5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBJZiB5b3Ugc2VhcmNoIGJhY2t3YXJkcyBmaXJz
dCBpbiBtYWlsLCB3ZSB3b3VsZCBjcmFzaCwKKyAgICAgICAgdGhpcyB0ZXN0cyB0aGF0IGNvZGVw
YXRoLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9GaW5kSW5Q
YWdlLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMTktMDgtMTIgIFdlbnNvbiBIc2llaCAgPHdl
bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lQYWRPU10gV2ViIHBhZ2VzIHNvbWV0
aW1lcyBsb2FkIGF0IGhhbGYgd2lkdGggaW4gU2FmYXJpCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0
V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0ZpbmRJblBhZ2UubW0gYi9Ub29scy9UZXN0V2Vi
S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0ZpbmRJblBhZ2UubW0KaW5kZXggNDFlYjE2MzkzOWFm
OWExZmYzNDcwZmM3ZTA5YTEwMmNkYTQ3MDMyZi4uMzg5ZWNkYzBhODNkZTVjMmIyMWI1Mzc5NDQw
YmIwMTg4ZGU5Y2M0NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL
aXRDb2NvYS9GaW5kSW5QYWdlLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi
S2l0Q29jb2EvRmluZEluUGFnZS5tbQpAQCAtMjI0LDYgKzIyNCwyMiBAQCBURVNUKFdlYktpdCwg
RmluZEluUGFnZVdyYXBwaW5nRGlzYWJsZWQpCiAgICAgRVhQRUNUX0ZBTFNFKHJlc3VsdC5kaWRX
cmFwKTsKIH0KIAorVEVTVChXZWJLaXQsIEZpbmRJblBhZ2VCYWNrd2FyZHNGaXJzdCkKK3sKKyAg
ICBSZXRhaW5QdHI8V0tXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxv
Y10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDEwMCwgMTAwKV0pOworICAgIFt3ZWJW
aWV3IF9zZXRPdmVycmlkZURldmljZVNjYWxlRmFjdG9yOjJdOworCisgICAgW3dlYlZpZXcgbG9h
ZEhUTUxTdHJpbmc6QCJ3b3JkIHdvcmQiIGJhc2VVUkw6bmlsXTsKKyAgICBbd2ViVmlldyBfdGVz
dF93YWl0Rm9yRGlkRmluaXNoTmF2aWdhdGlvbl07CisKKyAgICAvLyBGaW5kIG9uZSBtYXRjaCwg
ZG9pbmcgYW4gaW5jcmVtZW50YWwgc2VhcmNoLgorICAgIGF1dG8gcmVzdWx0ID0gZmluZE1hdGNo
ZXMod2ViVmlldy5nZXQoKSwgQCJ3b3JkIiwgd3JhcEJhY2t3YXJkc0ZpbmRPcHRpb25zLCAxKTsK
KyAgICBFWFBFQ1RfRVEoKE5TVUludGVnZXIpMSwgW3Jlc3VsdC5tYXRjaGVzIGNvdW50XSk7CisK
KyAgICByZXN1bHQgPSBmaW5kTWF0Y2hlcyh3ZWJWaWV3LmdldCgpLCBAIndvcmQiLCB3cmFwQmFj
a3dhcmRzRmluZE9wdGlvbnMsIDEpOworICAgIEVYUEVDVF9FUSgoTlNVSW50ZWdlcikxLCBbcmVz
dWx0Lm1hdGNoZXMgY291bnRdKTsKK30KKwogVEVTVChXZWJLaXQsIEZpbmRJblBhZ2VXcmFwcGlu
Z1N1YmZyYW1lKQogewogICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5T
KFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgMTAwLCAx
MDApXSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>