<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200579</bug_id>
          
          <creation_ts>2019-08-09 10:17:19 -0700</creation_ts>
          <short_desc>Tapping buttons in Data Detectors lookup previews doesn&apos;t work</short_desc>
          <delta_ts>2019-08-12 11:42:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>bdakin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>jbedard</cc>
    
    <cc>megan_gardner</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1559930</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 10:17:19 -0700</bug_when>
    <thetext>Tapping buttons in Data Detectors lookup previews doesn&apos;t work</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559936</commentid>
    <comment_count>1</comment_count>
      <attachid>375932</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 10:21:39 -0700</bug_when>
    <thetext>Created attachment 375932
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559937</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 10:21:41 -0700</bug_when>
    <thetext>&lt;rdar://problem/54056519&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559939</commentid>
    <comment_count>3</comment_count>
      <attachid>375933</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 10:25:44 -0700</bug_when>
    <thetext>Created attachment 375933
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559952</commentid>
    <comment_count>4</comment_count>
      <attachid>375933</attachid>
    <who name="Megan Gardner">megan_gardner</who>
    <bug_when>2019-08-09 11:23:33 -0700</bug_when>
    <thetext>Comment on attachment 375933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375933&amp;action=review

&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8298
&gt; +    if ([configuration isKindOfClass:getDDContextMenuConfigurationClass()]) {

File a bug to clean this all up once the SPI has settled?

&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8305
&gt; +        shouldExpandPreview = !!ddConfiguration.interactionViewControllerProvider;

I find it odd that the SPI had a var for this, but now does not? But I&apos;m assuming you know what&apos;s going on here..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559953</commentid>
    <comment_count>5</comment_count>
      <attachid>375933</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 11:24:41 -0700</bug_when>
    <thetext>Comment on attachment 375933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375933&amp;action=review

&gt;&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8298
&gt;&gt; +    if ([configuration isKindOfClass:getDDContextMenuConfigurationClass()]) {
&gt; 
&gt; File a bug to clean this all up once the SPI has settled?

Sure

&gt;&gt; Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8305
&gt;&gt; +        shouldExpandPreview = !!ddConfiguration.interactionViewControllerProvider;
&gt; 
&gt; I find it odd that the SPI had a var for this, but now does not? But I&apos;m assuming you know what&apos;s going on here..

They upgraded from a bool to a nullable block that returns a VC 🤷‍♂️</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559979</commentid>
    <comment_count>6</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2019-08-09 12:50:46 -0700</bug_when>
    <thetext>Committed r248469: &lt;https://trac.webkit.org/changeset/248469&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560438</commentid>
    <comment_count>7</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-08-12 09:56:11 -0700</bug_when>
    <thetext>This broke the iOS 13 seed build...we don&apos;t have bots for it yet, but I&apos;ve been building it pretty regularly locally looking for this sort of thing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560440</commentid>
    <comment_count>8</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-08-12 09:58:00 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560441</commentid>
    <comment_count>9</comment_count>
      <attachid>376073</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2019-08-12 09:58:01 -0700</bug_when>
    <thetext>Created attachment 376073
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560487</commentid>
    <comment_count>10</comment_count>
      <attachid>376073</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 11:42:26 -0700</bug_when>
    <thetext>Comment on attachment 376073
Patch

Clearing flags on attachment: 376073

Committed r248535: &lt;https://trac.webkit.org/changeset/248535&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560488</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-12 11:42:27 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375932</attachid>
            <date>2019-08-09 10:21:39 -0700</date>
            <delta_ts>2019-08-09 10:25:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200579-20190809102138.patch</filename>
            <type>text/plain</type>
            <size>7230</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q
QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBlNmU0ZDRk
Y2M2NzNiY2IxODFlZmRiOGI0MTAzMGJmYzUxMjc0ODU1Li5mZjVlNzYzMTlhYTRjY2Q2M2QyYTI1
ZTg3Y2Q2MWEyMWZkOThkMmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor
MjAxOS0wOC0wOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg
ICAgICBUYXBwaW5nIGJ1dHRvbnMgaW4gRGF0YSBEZXRlY3RvcnMgbG9va3VwIHByZXZpZXdzIGRv
ZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjAwNTc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDA1NjUxOT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvaW9zL0RhdGFE
ZXRlY3RvcnNVSVNQSS5oOgorCiAyMDE5LTA4LTA3ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl
LmNvbT4KIAogICAgICAgICBDb250ZXh0IG1lbnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNl
cyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIv
U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggMWYxZjViMTA4ODNmMDA4YTFjMDdjNTZhYWJl
ZjI2NzlkZTcwZDE5ZC4uZWZmMzg1NWY5ZGRkZTVmODI2MDU3NmMzYWQ0NmRmOTNhMzhkNzQ5OCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxOS0wOC0wOSAgVGltIEhvcnRvbiAgPHRpbW90
aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGJ1dHRvbnMgaW4gRGF0YSBE
ZXRlY3RvcnMgbG9va3VwIHByZXZpZXdzIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTc5CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS81NDA1NjUxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBVSVByb2Nl
c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50
VmlldyBfY29udGV4dE1lbnVJbnRlcmFjdGlvbjpzdHlsZUZvck1lbnVXaXRoQ29uZmlndXJhdGlv
bjpdKToKKyAgICAgICAgSWYgYSBEYXRhIERldGVjdG9ycyBjb250ZXh0IG1lbnUgd2FudHMgdGhl
IGFjdGlvbiBtZW51IHN0eWxlLCBwcm92aWRlIGl0LgorCisgICAgICAgICgtW1dLQ29udGVudFZp
ZXcgY29udGV4dE1lbnVJbnRlcmFjdGlvbjp3aWxsUGVyZm9ybVByZXZpZXdBY3Rpb25Gb3JNZW51
V2l0aENvbmZpZ3VyYXRpb246YW5pbWF0b3I6XSk6CisgICAgICAgIElmIGEgRGF0YSBEZXRlY3Rv
cnMgY29udGV4dCBtZW51IHByb3ZpZGVzIGEgdmlldyBjb250cm9sbGVyIHRvIHByZXNlbnQKKyAg
ICAgICAgb24gY29udGV4dCBtZW51IGNvbW1pdCwgcHJlc2VudCBpdC4gV2UgcHJlc2VudCBvbiB0
b3Agb2YgdGhlIHNhbWUgdmlldworICAgICAgICBjb250cm9sbGVyIHRoYXQgaXMgY3VycmVudGx5
IHByZXNlbnRpbmcgdGhlIGNvbnRleHQgbWVudSwgYnV0IG1vZGFsbHkKKyAgICAgICAgaW5zdGVh
ZCBvZiBpbnNpZGUgdGhlIGNvbnRleHQgbWVudS4KKworICAgICAgICBJZiBhIERhdGEgRGV0ZWN0
b3JzIGNvbnRleHQgbWVudSBpbnN0ZWFkIHByb3ZpZGVzIGEgVVJMIHRvIGxhdW5jaCBvbgorICAg
ICAgICBjb250ZXh0IG1lbnUgY29tbWl0LCBjYWxsIG9wZW5VUkwuCisKKyAgICAgICAgSW4gYm90
aCBjYXNlcywgY2hhbmdlIHRoZSBjb21taXQgc3R5bGUgdG8gcG9wLCBzaW5jZSB3ZSdyZSBjb21t
aXR0aW5nCisgICAgICAgIGluc3RlYWQgb2YgZGlzbWlzc2luZy4KKwogMjAxOS0wOC0wOCAgRGVh
biBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoNTIyNzk5
ODcpOiBNb3N0IG9mIHRoZSBXS1VJRGVsZWdhdGUgY29udGV4dE1lbnUgZGVsZWdhdGUgbWV0aG9k
cyBhcmUgbm90IGJlaW5nIGNhbGxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3Bh
bC9zcGkvaW9zL0RhdGFEZXRlY3RvcnNVSVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9z
cGkvaW9zL0RhdGFEZXRlY3RvcnNVSVNQSS5oCmluZGV4IDVjMmE1YTE4NjAxNDRmYmRjNWU1MmYz
MDRmMjI4MDJiZDk5M2JjZDYuLjEwMTI0NDgwMjA4ODJiMjU0ZWIyOWE2NzhmZDY2ZjM1NmI1MDNj
MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2lvcy9EYXRhRGV0ZWN0
b3JzVUlTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9pb3MvRGF0YURldGVj
dG9yc1VJU1BJLmgKQEAgLTgzLDYgKzgzLDcgQEAKIFNPRlRfTElOS19QUklWQVRFX0ZSQU1FV09S
SyhEYXRhRGV0ZWN0b3JzVUkpCiAjaWYgSEFWRShMSU5LX1BSRVZJRVcpICYmIFVTRShVSUNPTlRF
WFRNRU5VKQogU09GVF9MSU5LX0NMQVNTKERhdGFEZXRlY3RvcnNVSSwgRERDb250ZXh0TWVudUFj
dGlvbik7CitTT0ZUX0xJTktfQ0xBU1MoRGF0YURldGVjdG9yc1VJLCBERENvbnRleHRNZW51Q29u
ZmlndXJhdGlvbik7CiAjZW5kaWYKIFNPRlRfTElOS19DTEFTUyhEYXRhRGV0ZWN0b3JzVUksIERE
RGV0ZWN0aW9uQ29udHJvbGxlcikKIFNPRlRfTElOS19DT05TVEFOVChEYXRhRGV0ZWN0b3JzVUks
IGtEYXRhRGV0ZWN0b3JzTGVhZGluZ1RleHQsIGNvbnN0IE5TU3RyaW5nICopCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJL
aXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDgyYTc1YzMyMmM0YWFhMTg5YTEw
NDQ1YmQ2N2IxMDQxMDg5Y2JjMTMuLmZmMzAyNWZiZGFhMDYwY2Y1ZTNiY2IyZDRkZTdhMTQyNWUy
NTMzNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ
SS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC05
MCw2ICs5MCw3IEBACiAjaW1wb3J0IDxVSUtpdC9VSVByZXZpZXdBY3Rpb25fUHJpdmF0ZS5oPgog
I2ltcG9ydCA8VUlLaXQvVUlQcmV2aWV3SXRlbUNvbnRyb2xsZXIuaD4KICNpZiBVU0UoVUlDT05U
RVhUTUVOVSkKKyNpbXBvcnQgPFVJS2l0L1VJQ29udGV4dE1lbnVJbnRlcmFjdGlvbl9Gb3JTcHJp
bmdCb2FyZE9ubHkuaD4KICNpbXBvcnQgPFVJS2l0L1VJQ29udGV4dE1lbnVJbnRlcmFjdGlvbl9G
b3JXZWJLaXRPbmx5Lmg+CiAjZW5kaWYKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJL
aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYmQ1OGFj
N2VhYWNhYjNhMWJmZmU1ODhjYmE2ZmQwMjJkYzA2MDQzZi4uZTFhZDUxOTk4M2FmM2Y2YjJiNzM3
NjkwODlkYzQ2ZjJkNmJkNGY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04MjI1LDYgKzgyMjUsMjMg
QEAgLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRl
eHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmEKICAgICByZXR1cm4gc3RkOjpleGNoYW5nZShfY29u
dGV4dE1lbnVJbnRlcmFjdGlvblRhcmdldGVkUHJldmlldywgbmlsKS5hdXRvcmVsZWFzZSgpOwog
fQogCistIChudWxsYWJsZSBfVUlDb250ZXh0TWVudVN0eWxlICopX2NvbnRleHRNZW51SW50ZXJh
Y3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHN0eWxlRm9yTWVu
dVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3Vy
YXRpb24KK3sKKyNpZiBkZWZpbmVkKEREX0NPTlRFWFRfTUVOVV9TUElfVkVSU0lPTikgJiYgRERf
Q09OVEVYVF9NRU5VX1NQSV9WRVJTSU9OID49IDIKKyAgICBpZiAoW2NvbmZpZ3VyYXRpb24gaXNL
aW5kT2ZDbGFzczpnZXRERENvbnRleHRNZW51Q29uZmlndXJhdGlvbkNsYXNzKCldKSB7CisgICAg
ICAgIEREQ29udGV4dE1lbnVDb25maWd1cmF0aW9uICpkZENvbmZpZ3VyYXRpb24gPSBzdGF0aWNf
Y2FzdDxERENvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqPihjb25maWd1cmF0aW9uKTsKKworICAg
ICAgICBpZiAoZGRDb25maWd1cmF0aW9uLnByZWZlcnNBY3Rpb25NZW51U3R5bGUpIHsKKyAgICAg
ICAgICAgIF9VSUNvbnRleHRNZW51U3R5bGUgKnN0eWxlID0gW19VSUNvbnRleHRNZW51U3R5bGUg
ZGVmYXVsdFN0eWxlXTsKKyAgICAgICAgICAgIHN0eWxlLnByZWZlcnJlZExheW91dCA9IF9VSUNv
bnRleHRNZW51TGF5b3V0QWN0aW9uc09ubHk7CisgICAgICAgICAgICByZXR1cm4gc3R5bGU7Cisg
ICAgICAgIH0KKyAgICB9CisjZW5kaWYKKworICAgIHJldHVybiBuaWw7Cit9CisKIC0gKHZvaWQp
Y29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJh
Y3Rpb24gd2lsbFBlcmZvcm1QcmV2aWV3QWN0aW9uRm9yTWVudVdpdGhDb25maWd1cmF0aW9uOihV
SUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYW5pbWF0b3I6KGlkPFVJ
Q29udGV4dE1lbnVJbnRlcmFjdGlvbkNvbW1pdEFuaW1hdGluZz4pYW5pbWF0b3IKIHsKICAgICBp
ZiAoIV93ZWJWaWV3KQpAQCAtODI3Niw2ICs4MjkzLDQyIEBAIC0gKHZvaWQpY29udGV4dE1lbnVJ
bnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gd2lsbFBl
cmZvCiAgICAgICAgIFt1aURlbGVnYXRlIF93ZWJWaWV3Ol93ZWJWaWV3IGNvbnRleHRNZW51Rm9y
RWxlbWVudDpfY29udGV4dE1lbnVFbGVtZW50SW5mby5nZXQoKSB3aWxsQ29tbWl0V2l0aEFuaW1h
dG9yOmFuaW1hdG9yXTsKICAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5E
CiAgICAgfQorCisjaWYgZGVmaW5lZChERF9DT05URVhUX01FTlVfU1BJX1ZFUlNJT04pICYmIERE
X0NPTlRFWFRfTUVOVV9TUElfVkVSU0lPTiA+PSAyCisgICAgaWYgKFtjb25maWd1cmF0aW9uIGlz
S2luZE9mQ2xhc3M6Z2V0RERDb250ZXh0TWVudUNvbmZpZ3VyYXRpb25DbGFzcygpXSkgeworICAg
ICAgICBERENvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqZGRDb25maWd1cmF0aW9uID0gc3RhdGlj
X2Nhc3Q8RERDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKj4oY29uZmlndXJhdGlvbik7CisKKyAg
ICAgICAgQk9PTCBzaG91bGRFeHBhbmRQcmV2aWV3ID0gTk87CisgICAgICAgIFJldGFpblB0cjxV
SVZpZXdDb250cm9sbGVyPiBwcmVzZW50ZWRWaWV3Q29udHJvbGxlcjsKKworI2lmIGRlZmluZWQo
RERfQ09OVEVYVF9NRU5VX1NQSV9WRVJTSU9OKSAmJiBERF9DT05URVhUX01FTlVfU1BJX1ZFUlNJ
T04gPj0gMworICAgICAgICBzaG91bGRFeHBhbmRQcmV2aWV3ID0gISFkZENvbmZpZ3VyYXRpb24u
aW50ZXJhY3Rpb25WaWV3Q29udHJvbGxlclByb3ZpZGVyOworICAgICAgICBpZiAoc2hvdWxkRXhw
YW5kUHJldmlldykKKyAgICAgICAgICAgIHByZXNlbnRlZFZpZXdDb250cm9sbGVyID0gZGRDb25m
aWd1cmF0aW9uLmludGVyYWN0aW9uVmlld0NvbnRyb2xsZXJQcm92aWRlcigpOworI2Vsc2UKKyAg
ICAgICAgc2hvdWxkRXhwYW5kUHJldmlldyA9IGRkQ29uZmlndXJhdGlvbi5leHBhbmRQcmV2aWV3
T25JbnRlcmFjdGlvbjsKKyAgICAgICAgcHJlc2VudGVkVmlld0NvbnRyb2xsZXIgPSBhbmltYXRv
ci5wcmV2aWV3Vmlld0NvbnRyb2xsZXI7CisjZW5kaWYKKworICAgICAgICBpZiAoc2hvdWxkRXhw
YW5kUHJldmlldykgeworICAgICAgICAgICAgYW5pbWF0b3IucHJlZmVycmVkQ29tbWl0U3R5bGUg
PSBVSUNvbnRleHRNZW51SW50ZXJhY3Rpb25Db21taXRTdHlsZVBvcDsKKworICAgICAgICAgICAg
Ly8gV2Ugd2lsbCByZS1wcmVzZW50IG1vZGFsbHkgb24gdGhlIHNhbWUgVkMgdGhhdCBpcyBjdXJy
ZW50bHkgcHJlc2VudGluZyB0aGUgcHJldmlldyBpbiBhIGNvbnRleHQgbWVudS4KKyAgICAgICAg
ICAgIFJldGFpblB0cjxVSVZpZXdDb250cm9sbGVyPiBwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIg
PSBhbmltYXRvci5wcmV2aWV3Vmlld0NvbnRyb2xsZXIucHJlc2VudGluZ1ZpZXdDb250cm9sbGVy
OworCisgICAgICAgICAgICBbYW5pbWF0b3IgYWRkQW5pbWF0aW9uczpeeworICAgICAgICAgICAg
ICAgIFtwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIgcHJlc2VudFZpZXdDb250cm9sbGVyOnByZXNl
bnRlZFZpZXdDb250cm9sbGVyLmdldCgpIGFuaW1hdGVkOk5PIGNvbXBsZXRpb246bmlsXTsKKyAg
ICAgICAgICAgIH1dOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAg
aWYgKE5TVVJMICppbnRlcmFjdGlvblVSTCA9IGRkQ29uZmlndXJhdGlvbi5pbnRlcmFjdGlvblVS
TCkgeworICAgICAgICAgICAgYW5pbWF0b3IucHJlZmVycmVkQ29tbWl0U3R5bGUgPSBVSUNvbnRl
eHRNZW51SW50ZXJhY3Rpb25Db21taXRTdHlsZVBvcDsKKyAgICAgICAgICAgIFtbVUlBcHBsaWNh
dGlvbiBzaGFyZWRBcHBsaWNhdGlvbl0gb3BlblVSTDppbnRlcmFjdGlvblVSTCB3aXRoQ29tcGxl
dGlvbkhhbmRsZXI6bmlsXTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0K
KyNlbmRpZgogfQogCiAtICh2b2lkKWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1l
bnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHdpbGxFbmRGb3JDb25maWd1cmF0aW9uOihVSUNv
bnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYW5pbWF0b3I6KG51bGxhYmxl
IGlkPFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkFuaW1hdGluZz4pYW5pbWF0b3IK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375933</attachid>
            <date>2019-08-09 10:25:44 -0700</date>
            <delta_ts>2019-08-12 10:05:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200579-20190809102543.patch</filename>
            <type>text/plain</type>
            <size>7293</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q
QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBlNmU0ZDRk
Y2M2NzNiY2IxODFlZmRiOGI0MTAzMGJmYzUxMjc0ODU1Li5mZjVlNzYzMTlhYTRjY2Q2M2QyYTI1
ZTg3Y2Q2MWEyMWZkOThkMmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor
MjAxOS0wOC0wOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg
ICAgICBUYXBwaW5nIGJ1dHRvbnMgaW4gRGF0YSBEZXRlY3RvcnMgbG9va3VwIHByZXZpZXdzIGRv
ZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjAwNTc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NDA1NjUxOT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhbC9zcGkvaW9zL0RhdGFE
ZXRlY3RvcnNVSVNQSS5oOgorCiAyMDE5LTA4LTA3ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl
LmNvbT4KIAogICAgICAgICBDb250ZXh0IG1lbnUgb24gYSB1bml2ZXJzYWwgbGluayBwcm9kdWNl
cyBhIGJsYW5rIHByZXZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIv
U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggMWYxZjViMTA4ODNmMDA4YTFjMDdjNTZhYWJl
ZjI2NzlkZTcwZDE5ZC4uZWZmMzg1NWY5ZGRkZTVmODI2MDU3NmMzYWQ0NmRmOTNhMzhkNzQ5OCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxOS0wOC0wOSAgVGltIEhvcnRvbiAgPHRpbW90
aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGJ1dHRvbnMgaW4gRGF0YSBE
ZXRlY3RvcnMgbG9va3VwIHByZXZpZXdzIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTc5CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS81NDA1NjUxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIFBsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDoKKyAgICAgICAgKiBVSVByb2Nl
c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50
VmlldyBfY29udGV4dE1lbnVJbnRlcmFjdGlvbjpzdHlsZUZvck1lbnVXaXRoQ29uZmlndXJhdGlv
bjpdKToKKyAgICAgICAgSWYgYSBEYXRhIERldGVjdG9ycyBjb250ZXh0IG1lbnUgd2FudHMgdGhl
IGFjdGlvbiBtZW51IHN0eWxlLCBwcm92aWRlIGl0LgorCisgICAgICAgICgtW1dLQ29udGVudFZp
ZXcgY29udGV4dE1lbnVJbnRlcmFjdGlvbjp3aWxsUGVyZm9ybVByZXZpZXdBY3Rpb25Gb3JNZW51
V2l0aENvbmZpZ3VyYXRpb246YW5pbWF0b3I6XSk6CisgICAgICAgIElmIGEgRGF0YSBEZXRlY3Rv
cnMgY29udGV4dCBtZW51IHByb3ZpZGVzIGEgdmlldyBjb250cm9sbGVyIHRvIHByZXNlbnQKKyAg
ICAgICAgb24gY29udGV4dCBtZW51IGNvbW1pdCwgcHJlc2VudCBpdC4gV2UgcHJlc2VudCBvbiB0
b3Agb2YgdGhlIHNhbWUgdmlldworICAgICAgICBjb250cm9sbGVyIHRoYXQgaXMgY3VycmVudGx5
IHByZXNlbnRpbmcgdGhlIGNvbnRleHQgbWVudSwgYnV0IG1vZGFsbHkKKyAgICAgICAgaW5zdGVh
ZCBvZiBpbnNpZGUgdGhlIGNvbnRleHQgbWVudS4KKworICAgICAgICBJZiBhIERhdGEgRGV0ZWN0
b3JzIGNvbnRleHQgbWVudSBpbnN0ZWFkIHByb3ZpZGVzIGEgVVJMIHRvIGxhdW5jaCBvbgorICAg
ICAgICBjb250ZXh0IG1lbnUgY29tbWl0LCBjYWxsIG9wZW5VUkwuCisKKyAgICAgICAgSW4gYm90
aCBjYXNlcywgY2hhbmdlIHRoZSBjb21taXQgc3R5bGUgdG8gcG9wLCBzaW5jZSB3ZSdyZSBjb21t
aXR0aW5nCisgICAgICAgIGluc3RlYWQgb2YgZGlzbWlzc2luZy4KKwogMjAxOS0wOC0wOCAgRGVh
biBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoNTIyNzk5
ODcpOiBNb3N0IG9mIHRoZSBXS1VJRGVsZWdhdGUgY29udGV4dE1lbnUgZGVsZWdhdGUgbWV0aG9k
cyBhcmUgbm90IGJlaW5nIGNhbGxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3Bh
bC9zcGkvaW9zL0RhdGFEZXRlY3RvcnNVSVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9z
cGkvaW9zL0RhdGFEZXRlY3RvcnNVSVNQSS5oCmluZGV4IDVjMmE1YTE4NjAxNDRmYmRjNWU1MmYz
MDRmMjI4MDJiZDk5M2JjZDYuLjEwMTI0NDgwMjA4ODJiMjU0ZWIyOWE2NzhmZDY2ZjM1NmI1MDNj
MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2lvcy9EYXRhRGV0ZWN0
b3JzVUlTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9pb3MvRGF0YURldGVj
dG9yc1VJU1BJLmgKQEAgLTgzLDYgKzgzLDcgQEAKIFNPRlRfTElOS19QUklWQVRFX0ZSQU1FV09S
SyhEYXRhRGV0ZWN0b3JzVUkpCiAjaWYgSEFWRShMSU5LX1BSRVZJRVcpICYmIFVTRShVSUNPTlRF
WFRNRU5VKQogU09GVF9MSU5LX0NMQVNTKERhdGFEZXRlY3RvcnNVSSwgRERDb250ZXh0TWVudUFj
dGlvbik7CitTT0ZUX0xJTktfQ0xBU1MoRGF0YURldGVjdG9yc1VJLCBERENvbnRleHRNZW51Q29u
ZmlndXJhdGlvbik7CiAjZW5kaWYKIFNPRlRfTElOS19DTEFTUyhEYXRhRGV0ZWN0b3JzVUksIERE
RGV0ZWN0aW9uQ29udHJvbGxlcikKIFNPRlRfTElOS19DT05TVEFOVChEYXRhRGV0ZWN0b3JzVUks
IGtEYXRhRGV0ZWN0b3JzTGVhZGluZ1RleHQsIGNvbnN0IE5TU3RyaW5nICopCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJL
aXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCmluZGV4IDgyYTc1YzMyMmM0YWFhMTg5YTEw
NDQ1YmQ2N2IxMDQxMDg5Y2JjMTMuLmZmMzAyNWZiZGFhMDYwY2Y1ZTNiY2IyZDRkZTdhMTQyNWUy
NTMzNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ
SS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC05
MCw2ICs5MCw3IEBACiAjaW1wb3J0IDxVSUtpdC9VSVByZXZpZXdBY3Rpb25fUHJpdmF0ZS5oPgog
I2ltcG9ydCA8VUlLaXQvVUlQcmV2aWV3SXRlbUNvbnRyb2xsZXIuaD4KICNpZiBVU0UoVUlDT05U
RVhUTUVOVSkKKyNpbXBvcnQgPFVJS2l0L1VJQ29udGV4dE1lbnVJbnRlcmFjdGlvbl9Gb3JTcHJp
bmdCb2FyZE9ubHkuaD4KICNpbXBvcnQgPFVJS2l0L1VJQ29udGV4dE1lbnVJbnRlcmFjdGlvbl9G
b3JXZWJLaXRPbmx5Lmg+CiAjZW5kaWYKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJL
aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYmQ1OGFj
N2VhYWNhYjNhMWJmZmU1ODhjYmE2ZmQwMjJkYzA2MDQzZi4uYTcwOTJiYzBhZjBkYjNmZTFmYzhi
ZTU5M2QzNDc3YTIxY2IwMmMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04MjI1LDYgKzgyMjUsMjMg
QEAgLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRl
eHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmEKICAgICByZXR1cm4gc3RkOjpleGNoYW5nZShfY29u
dGV4dE1lbnVJbnRlcmFjdGlvblRhcmdldGVkUHJldmlldywgbmlsKS5hdXRvcmVsZWFzZSgpOwog
fQogCistIChudWxsYWJsZSBfVUlDb250ZXh0TWVudVN0eWxlICopX2NvbnRleHRNZW51SW50ZXJh
Y3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHN0eWxlRm9yTWVu
dVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3Vy
YXRpb24KK3sKKyNpZiBkZWZpbmVkKEREX0NPTlRFWFRfTUVOVV9TUElfVkVSU0lPTikgJiYgRERf
Q09OVEVYVF9NRU5VX1NQSV9WRVJTSU9OID49IDIKKyAgICBpZiAoW2NvbmZpZ3VyYXRpb24gaXNL
aW5kT2ZDbGFzczpnZXRERENvbnRleHRNZW51Q29uZmlndXJhdGlvbkNsYXNzKCldKSB7CisgICAg
ICAgIEREQ29udGV4dE1lbnVDb25maWd1cmF0aW9uICpkZENvbmZpZ3VyYXRpb24gPSBzdGF0aWNf
Y2FzdDxERENvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqPihjb25maWd1cmF0aW9uKTsKKworICAg
ICAgICBpZiAoZGRDb25maWd1cmF0aW9uLnByZWZlcnNBY3Rpb25NZW51U3R5bGUpIHsKKyAgICAg
ICAgICAgIF9VSUNvbnRleHRNZW51U3R5bGUgKnN0eWxlID0gW19VSUNvbnRleHRNZW51U3R5bGUg
ZGVmYXVsdFN0eWxlXTsKKyAgICAgICAgICAgIHN0eWxlLnByZWZlcnJlZExheW91dCA9IF9VSUNv
bnRleHRNZW51TGF5b3V0QWN0aW9uc09ubHk7CisgICAgICAgICAgICByZXR1cm4gc3R5bGU7Cisg
ICAgICAgIH0KKyAgICB9CisjZW5kaWYKKworICAgIHJldHVybiBuaWw7Cit9CisKIC0gKHZvaWQp
Y29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJh
Y3Rpb24gd2lsbFBlcmZvcm1QcmV2aWV3QWN0aW9uRm9yTWVudVdpdGhDb25maWd1cmF0aW9uOihV
SUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYW5pbWF0b3I6KGlkPFVJ
Q29udGV4dE1lbnVJbnRlcmFjdGlvbkNvbW1pdEFuaW1hdGluZz4pYW5pbWF0b3IKIHsKICAgICBp
ZiAoIV93ZWJWaWV3KQpAQCAtODI3Niw2ICs4MjkzLDQ1IEBAIC0gKHZvaWQpY29udGV4dE1lbnVJ
bnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gd2lsbFBl
cmZvCiAgICAgICAgIFt1aURlbGVnYXRlIF93ZWJWaWV3Ol93ZWJWaWV3IGNvbnRleHRNZW51Rm9y
RWxlbWVudDpfY29udGV4dE1lbnVFbGVtZW50SW5mby5nZXQoKSB3aWxsQ29tbWl0V2l0aEFuaW1h
dG9yOmFuaW1hdG9yXTsKICAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5E
CiAgICAgfQorCisjaWYgZGVmaW5lZChERF9DT05URVhUX01FTlVfU1BJX1ZFUlNJT04pICYmIERE
X0NPTlRFWFRfTUVOVV9TUElfVkVSU0lPTiA+PSAyCisgICAgaWYgKFtjb25maWd1cmF0aW9uIGlz
S2luZE9mQ2xhc3M6Z2V0RERDb250ZXh0TWVudUNvbmZpZ3VyYXRpb25DbGFzcygpXSkgeworICAg
ICAgICBERENvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqZGRDb25maWd1cmF0aW9uID0gc3RhdGlj
X2Nhc3Q8RERDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gKj4oY29uZmlndXJhdGlvbik7CisKKyAg
ICAgICAgQk9PTCBzaG91bGRFeHBhbmRQcmV2aWV3ID0gTk87CisgICAgICAgIFJldGFpblB0cjxV
SVZpZXdDb250cm9sbGVyPiBwcmVzZW50ZWRWaWV3Q29udHJvbGxlcjsKKworI2lmIGRlZmluZWQo
RERfQ09OVEVYVF9NRU5VX1NQSV9WRVJTSU9OKSAmJiBERF9DT05URVhUX01FTlVfU1BJX1ZFUlNJ
T04gPj0gMworICAgICAgICBzaG91bGRFeHBhbmRQcmV2aWV3ID0gISFkZENvbmZpZ3VyYXRpb24u
aW50ZXJhY3Rpb25WaWV3Q29udHJvbGxlclByb3ZpZGVyOworICAgICAgICBpZiAoc2hvdWxkRXhw
YW5kUHJldmlldykKKyAgICAgICAgICAgIHByZXNlbnRlZFZpZXdDb250cm9sbGVyID0gZGRDb25m
aWd1cmF0aW9uLmludGVyYWN0aW9uVmlld0NvbnRyb2xsZXJQcm92aWRlcigpOworI2Vsc2UKKyAg
ICAgICAgc2hvdWxkRXhwYW5kUHJldmlldyA9IGRkQ29uZmlndXJhdGlvbi5leHBhbmRQcmV2aWV3
T25JbnRlcmFjdGlvbjsKKyAgICAgICAgcHJlc2VudGVkVmlld0NvbnRyb2xsZXIgPSBhbmltYXRv
ci5wcmV2aWV3Vmlld0NvbnRyb2xsZXI7CisjZW5kaWYKKworICAgICAgICBpZiAoc2hvdWxkRXhw
YW5kUHJldmlldykgeworICAgICAgICAgICAgYW5pbWF0b3IucHJlZmVycmVkQ29tbWl0U3R5bGUg
PSBVSUNvbnRleHRNZW51SW50ZXJhY3Rpb25Db21taXRTdHlsZVBvcDsKKworICAgICAgICAgICAg
Ly8gV2Ugd2lsbCByZS1wcmVzZW50IG1vZGFsbHkgb24gdGhlIHNhbWUgVkMgdGhhdCBpcyBjdXJy
ZW50bHkgcHJlc2VudGluZyB0aGUgcHJldmlldyBpbiBhIGNvbnRleHQgbWVudS4KKyAgICAgICAg
ICAgIFJldGFpblB0cjxVSVZpZXdDb250cm9sbGVyPiBwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIg
PSBhbmltYXRvci5wcmV2aWV3Vmlld0NvbnRyb2xsZXIucHJlc2VudGluZ1ZpZXdDb250cm9sbGVy
OworCisgICAgICAgICAgICBbYW5pbWF0b3IgYWRkQW5pbWF0aW9uczpeeworICAgICAgICAgICAg
ICAgIFtwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIgcHJlc2VudFZpZXdDb250cm9sbGVyOnByZXNl
bnRlZFZpZXdDb250cm9sbGVyLmdldCgpIGFuaW1hdGVkOk5PIGNvbXBsZXRpb246bmlsXTsKKyAg
ICAgICAgICAgIH1dOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAg
aWYgKE5TVVJMICppbnRlcmFjdGlvblVSTCA9IGRkQ29uZmlndXJhdGlvbi5pbnRlcmFjdGlvblVS
TCkgeworICAgICAgICAgICAgYW5pbWF0b3IucHJlZmVycmVkQ29tbWl0U3R5bGUgPSBVSUNvbnRl
eHRNZW51SW50ZXJhY3Rpb25Db21taXRTdHlsZVBvcDsKKworICAgICAgICAgICAgW2FuaW1hdG9y
IGFkZEFuaW1hdGlvbnM6XnsKKyAgICAgICAgICAgICAgICBbW1VJQXBwbGljYXRpb24gc2hhcmVk
QXBwbGljYXRpb25dIG9wZW5VUkw6aW50ZXJhY3Rpb25VUkwgd2l0aENvbXBsZXRpb25IYW5kbGVy
Om5pbF07CisgICAgICAgICAgICB9XTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor
ICAgIH0KKyNlbmRpZgogfQogCiAtICh2b2lkKWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29u
dGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHdpbGxFbmRGb3JDb25maWd1cmF0aW9u
OihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYW5pbWF0b3I6KG51
bGxhYmxlIGlkPFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkFuaW1hdGluZz4pYW5pbWF0b3IK
</data>
<flag name="commit-queue"
          id="391838"
          type_id="3"
          status="+"
          setter="jbedard"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>376073</attachid>
            <date>2019-08-12 09:58:01 -0700</date>
            <delta_ts>2019-08-12 11:42:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200579-20190812095800.patch</filename>
            <type>text/plain</type>
            <size>1143</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDg1MjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTEyICBKb25hdGhhbiBC
ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGJ1dHRvbnMgaW4g
RGF0YSBEZXRlY3RvcnMgbG9va3VwIHByZXZpZXdzIGRvZXNuJ3Qgd29yayAoRm9sbG93LXVwIGZp
eCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDU3
OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQwNTY1MTk+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJ
Lmg6IEFkZCBfVUlDb250ZXh0TWVudVN0eWxlIFNQSS4KKwogMjAxOS0wOC0xMiAgWW91ZW5uIEZh
YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIElEQi1zcGVjaWZpYyBx
dW90YQpJbmRleDogU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gU291cmNlL1dlYktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJKHJl
dmlzaW9uIDI0ODUyOCkKKysrIFNvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ
SS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDgyLDYgKzEwODIsOSBAQCB0eXBlZGVmIE5TX09QVElP
TlMoTlNJbnRlZ2VyLCBVSVdLRG9jdW1lCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25nKSBV
SUltYWdlICppbWFnZTsKIEBlbmQKIAorQGludGVyZmFjZSBfVUlDb250ZXh0TWVudVN0eWxlIDog
TlNPYmplY3QgPE5TQ29weWluZz4KK0BlbmQKKwogI2VuZGlmIC8vIFVTRShBUFBMRV9JTlRFUk5B
TF9TREspCiAKIEBpbnRlcmZhY2UgVUlHZXN0dXJlUmVjb2duaXplciAoU3RhZ2luZ180NTk3MDA0
MCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>