200561 2019-08-08 21:37:29 -0700 Web Inspector: REGRESSION(r248201): DOMDebugger: unable to add event breakpoint when All Events breakpoint is enabled 2019-08-12 20:53:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1559796 0 hi 2019-08-08 21:37:29 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. add an All Events breakpoint 3. try to add an event breakpoint for "click" => nothing happens 4. disable the All Events breakpoint 5. repeat step 3 => "click" event breakpoint added 1559798 1 375890 hi 2019-08-08 21:42:01 -0700 Created attachment 375890 Patch 1560676 2 375890 joepeck 2019-08-12 20:43:37 -0700 Comment on attachment 375890 Patch Heh, nice. r=me 1560684 3 375890 commit-queue 2019-08-12 20:52:46 -0700 Comment on attachment 375890 Patch Clearing flags on attachment: 375890 Committed r248588: <https://trac.webkit.org/changeset/248588> 1560685 4 commit-queue 2019-08-12 20:52:47 -0700 All reviewed patches have been landed. Closing bug. 1560686 5 webkit-bug-importer 2019-08-12 20:53:38 -0700 <rdar://problem/54240429> 375890 2019-08-08 21:42:01 -0700 2019-08-12 20:52:46 -0700 Patch bug-200561-20190808214200.patch text/plain 3037 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNlMzJhYzFmZmFkZDY5MjY5MGZjYmY3Y2NjN2Vi NTViZGI1ZGY1NjcuLjQ5YzU5ODUwZjRkMmNkOWYwMjUyNWEzYWE4YTIzNzMyYzE2OWUwNGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA4LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDgyMDEpOiBET01EZWJ1Z2dlcjogdW5hYmxlIHRvIGFkZCBldmVudCBicmVh a3BvaW50IHdoZW4gQWxsIEV2ZW50cyBicmVha3BvaW50IGlzIGVuYWJsZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDU2MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFnZXIuanM6CisgICAgICAgIChXSS5ET01EZWJ1Z2dlck1h bmFnZXIucHJvdG90eXBlLmFkZEV2ZW50QnJlYWtwb2ludCk6CisgICAgICAgIChXSS5ET01EZWJ1 Z2dlck1hbmFnZXIucHJvdG90eXBlLnJlbW92ZUV2ZW50QnJlYWtwb2ludCk6CisKIDIwMTktMDgt MDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFBhZ2U6IGRvbid0IGFsbG93IHRoZSBkb21haW4gdG8gYmUgZGlzYWJsZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RP TURlYnVnZ2VyTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5qcwppbmRleCA3ZDU0NDcxZDY5M2NiZGEy NTliMTNmNTM3Yzk4ZjBjMTQ5MDIwZjZmLi40MzY1MjhjNGJjMThhNWQ1MTdjNjhjNzY3ZDU4YjY3 OTI2ZWEwYTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db250cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzCkBA IC0zNjgsNyArMzY4LDcgQEAgV0kuRE9NRGVidWdnZXJNYW5hZ2VyID0gY2xhc3MgRE9NRGVidWdn ZXJNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAKICAgICBhZGRFdmVudEJyZWFrcG9pbnQoYnJl YWtwb2ludCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQgaW5zdGFu Y2VvZiBXSS5FdmVudEJyZWFrcG9pbnQpOworICAgICAgICBjb25zb2xlLmFzc2VydChicmVha3Bv aW50IGluc3RhbmNlb2YgV0kuRXZlbnRCcmVha3BvaW50LCBicmVha3BvaW50KTsKICAgICAgICAg aWYgKCFicmVha3BvaW50KQogICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0zNzcsOSArMzc3LDEw IEBAIFdJLkRPTURlYnVnZ2VyTWFuYWdlciA9IGNsYXNzIERPTURlYnVnZ2VyTWFuYWdlciBleHRl bmRzIFdJLk9iamVjdAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAg Y29uc29sZS5hc3NlcnQoYnJlYWtwb2ludC50eXBlID09PSBXSS5FdmVudEJyZWFrcG9pbnQuVHlw ZS5MaXN0ZW5lcik7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQudHlwZSA9PT0g V0kuRXZlbnRCcmVha3BvaW50LlR5cGUuTGlzdGVuZXIsIGJyZWFrcG9pbnQpOworICAgICAgICBj b25zb2xlLmFzc2VydChicmVha3BvaW50LmV2ZW50TmFtZSwgYnJlYWtwb2ludCk7CiAKLSAgICAg ICAgaWYgKHRoaXMubGlzdGVuZXJCcmVha3BvaW50Rm9yRXZlbnROYW1lKGJyZWFrcG9pbnQuZXZl bnROYW1lKSkKKyAgICAgICAgaWYgKHRoaXMuX2xpc3RlbmVyQnJlYWtwb2ludHMuZmluZCgoZXhp c3RpbmcpID0+IGV4aXN0aW5nLmV2ZW50TmFtZSA9PT0gYnJlYWtwb2ludC5ldmVudE5hbWUpKQog ICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMuX2xpc3RlbmVyQnJlYWtwb2ludHMu cHVzaChicmVha3BvaW50KTsKQEAgLTM5Nyw3ICszOTgsNyBAQCBXSS5ET01EZWJ1Z2dlck1hbmFn ZXIgPSBjbGFzcyBET01EZWJ1Z2dlck1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKIAogICAgIHJl bW92ZUV2ZW50QnJlYWtwb2ludChicmVha3BvaW50KQogICAgIHsKLSAgICAgICAgY29uc29sZS5h c3NlcnQoYnJlYWtwb2ludCBpbnN0YW5jZW9mIFdJLkV2ZW50QnJlYWtwb2ludCk7CisgICAgICAg IGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQgaW5zdGFuY2VvZiBXSS5FdmVudEJyZWFrcG9pbnQs IGJyZWFrcG9pbnQpOwogICAgICAgICBpZiAoIWJyZWFrcG9pbnQpCiAgICAgICAgICAgICByZXR1 cm47CiAKQEAgLTQwNyw4ICs0MDgsMTAgQEAgV0kuRE9NRGVidWdnZXJNYW5hZ2VyID0gY2xhc3Mg RE9NRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICByZXR1cm47 CiAgICAgICAgIH0KIAotICAgICAgICBjb25zb2xlLmFzc2VydChicmVha3BvaW50LnR5cGUgPT09 IFdJLkV2ZW50QnJlYWtwb2ludC5UeXBlLkxpc3RlbmVyKTsKKyAgICAgICAgY29uc29sZS5hc3Nl cnQoYnJlYWtwb2ludC50eXBlID09PSBXSS5FdmVudEJyZWFrcG9pbnQuVHlwZS5MaXN0ZW5lciwg YnJlYWtwb2ludCk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGJyZWFrcG9pbnQuZXZlbnROYW1l LCBicmVha3BvaW50KTsKIAorICAgICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9saXN0ZW5lckJy ZWFrcG9pbnRzLmluY2x1ZGVzKGJyZWFrcG9pbnQpLCBicmVha3BvaW50KTsKICAgICAgICAgaWYg KCF0aGlzLl9saXN0ZW5lckJyZWFrcG9pbnRzLmluY2x1ZGVzKGJyZWFrcG9pbnQpKQogICAgICAg ICAgICAgcmV0dXJuOwogCg==