200558 2019-08-08 19:11:19 -0700 [Win][WebKit2] Can't prevent input events by canceling keydown events 2019-12-01 19:21:41 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 204694 https://bugs.webkit.org/show_bug.cgi?id=56020 P2 Normal --- 204694 1 fujii fujii achristensen bfulgham don.olmstead pvollan ross.kirsling oldest_to_newest 1559775 0 fujii 2019-08-08 19:11:19 -0700 [Win][WebKit2] Can't prevent input events by canceling keydown events You can test it by using https://javascript.info/keyboard-events In old Windows WK2, this issue was fixed in Bug 56020 – WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options r83633 In Windows WK1, WM_CHAR event is removed if WM_DOWN is consumed. WebView::keyDown ::PeekMessage(&msg, m_viewWindow, WM_CHAR, WM_CHAR, PM_REMOVE); https://trac.webkit.org/browser/webkit/trunk/Source/WebKitLegacy/win/WebView.cpp?rev=248454#L2393 r23462 r25377 r28620 (Bug 13916) 1576705 1 fujii 2019-10-03 21:33:11 -0700 Test cases testing preventing a keydown event. fast/events/inputText-never-fired-on-keydown-cancel.html fast/events/keydown-keypress-preventDefault.html 1576706 2 fujii 2019-10-03 21:44:54 -0700 In old WebKit2 approach, TranslateMessage was called if a keydown event isn't comsumed. This has two problems: 1. This method can't be used in applications which is using TranslateMessage normally. For example and particularly, MiniBrowser can't use it because it supports WK1 and WK2 windows. 2. keypress event could be dispatched after keyup event unexpectedly. For example, if I type VK_A and VK_B quickly. Following native key events are queued: WM_KEYDOWN (VK_A) WM_KEYUP (VK_A) WM_KEYDOWN (VK_B) WM_KEYUP (VK_B) The first WM_KEYDOWN is sent to web process, and remaining events are queued in m_keyEventQueue. In didNotHandleKeyEvent of the first event, WM_CHAR (a) is posted by TranslateMessage. This is too late. 1576709 3 380184 fujii 2019-10-03 21:50:04 -0700 Created attachment 380184 WIP patch This WIP patch removed queued WebEvent::Char events if WebEvent::RawKeyDown is handled. This WIP patch works fine for MiniBrowser, but for WebKitTestRunner because WebKitTestRunner processes IPC messages synchronously. 1576715 4 380185 fujii 2019-10-03 22:07:19 -0700 Created attachment 380185 Patch 1576716 5 380186 fujii 2019-10-03 22:08:12 -0700 Created attachment 380186 Patch 1576749 6 fujii 2019-10-04 00:27:30 -0700 (In reply to Fujii Hironori from comment #2) > In old WebKit2 approach, TranslateMessage was called if a keydown > event isn't comsumed. > > This has two problems: > 1. This method can't be used in applications which is using TranslateMessage > normally. > For example and particularly, MiniBrowser can't use it because it > supports WK1 and WK2 windows. This might be possible by checking the target window is WK1. > while (PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) { > if (isWebKit1BrowserWindow(msg.hwnd)) > TranslateMessage(&msg); > DispatchMessage(&msg); > } 1577756 7 380186 fujii 2019-10-08 06:25:07 -0700 Comment on attachment 380186 Patch This approach doesn't seem good for Bug 202183. Cleared r? flag. 1594487 8 fujii 2019-12-01 19:21:41 -0800 Fixed in r252976. *** This bug has been marked as a duplicate of bug 204694 *** 380184 2019-10-03 21:50:04 -0700 2019-10-03 22:07:02 -0700 WIP patch wip.patch text/plain 907 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGY0ZjA4ZTQ3NWYz Li45MmQ0ZTYyY2IxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CkBAIC02NDc4LDYgKzY0NzgsMTMgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFJlY2VpdmVFdmVu dCh1aW50MzJfdCBvcGFxdWVUeXBlLCBib29sIGhhbmRsZWQpCiAKICAgICAgICAgTUVTU0FHRV9D SEVDSyhtX3Byb2Nlc3MsIHR5cGUgPT0gZXZlbnQudHlwZSgpKTsKIAorI2lmIFBMQVRGT1JNKFdJ TikKKyAgICAgICAgaWYgKHR5cGUgPT0gV2ViRXZlbnQ6OlJhd0tleURvd24gJiYgaGFuZGxlZCkg eworICAgICAgICAgICAgLy8gZm9sbG93aW5nIGtleXByZXNzIGV2ZW50cyBzaG91bGQgYmUgcHJl dmVudGVkIGlmIGEga2V5ZG93biBldmVudCBpcyBoYW5kbGVkCisgICAgICAgICAgICB3aGlsZSAo IW1fa2V5RXZlbnRRdWV1ZS5pc0VtcHR5KCkgJiYgbV9rZXlFdmVudFF1ZXVlLmZpcnN0KCkudHlw ZSgpID09IFdlYkV2ZW50OjpDaGFyKQorICAgICAgICAgICAgICAgIG1fa2V5RXZlbnRRdWV1ZS5y ZW1vdmVGaXJzdCgpOworICAgICAgICB9CisjZW5kaWYKICAgICAgICAgYm9vbCBjYW5Qcm9jZXNz TW9yZUtleUV2ZW50cyA9ICFtX2tleUV2ZW50UXVldWUuaXNFbXB0eSgpOwogICAgICAgICBpZiAo Y2FuUHJvY2Vzc01vcmVLZXlFdmVudHMpIHsKICAgICAgICAgICAgIExPRyhLZXlIYW5kbGluZywg IiBVSSBwcm9jZXNzOiBzZW50IGtleUV2ZW50IGZyb20gZGlkUmVjZWl2ZUV2ZW50Iik7Cg== 380185 2019-10-03 22:07:19 -0700 2019-10-03 22:07:57 -0700 Patch bug-200558-20191004140718.patch text/plain 2651 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3MDk0YmMwZjI3MGE4MGE0 NWIzZjA1NGI5MzVkMzU2ZjVhMmQwMzYuLjFhNTkzYWFlM2NjNzE5YTc2MWZlYzFkMTJkYTE5M2Vk YTYwN2ZjNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMTAtMDMgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV2ViS2l0 Ml0gQ2FuJ3QgcHJldmVudCBpbnB1dCBldmVudHMgYnkgY2FuY2VsaW5nIGtleWRvd24gZXZlbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA1NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIGtl eWRvd24gZXZlbnQgaXMgaGFuZGxlZCwgdGhlIGtleXByZXNzIGV2ZW50IHNob3VsZG4ndCBiZQor ICAgICAgICBkaXNwYXRjaGVkLgorCisgICAgICAgIFRlc3RlZCBieSBmYXN0L2V2ZW50cy9pbnB1 dFRleHQtbmV2ZXItZmlyZWQtb24ta2V5ZG93bi1jYW5jZWwuaHRtbAorICAgICAgICBhbmQgZmFz dC9ldmVudHMva2V5ZG93bi1rZXlwcmVzcy1wcmV2ZW50RGVmYXVsdC5odG1sLgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6ZGlkUmVjZWl2ZUV2ZW50KTogUmVtb3ZlIHF1ZXVlZAorICAgICAgICBXZWJFdmVudDo6 Q2hhciBhbmQgV01fQ0hBUiBldmVudHMgaWYgV2ViRXZlbnQ6OlJhd0tleURvd24gaXMgaGFuZGxl ZC4KKwogMjAxOS0xMC0wMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFByb2dyZXNzIHRvd2FyZHMgYSBmdW5jdGlvbmluZyBDTWFrZSBidWls ZCBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGY0 ZjA4ZTQ3NWYzMTA4YzJhMTM1NGE2YTZmNWE0Mzc5Y2JlMzExNDEuLmU3YzkxMWYyYzFiNjEzM2Fk M2M0YmQyNWFjOTgxYmUxN2Q3NGU3OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcApAQCAtNjQ3OCw2ICs2NDc4LDIyIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRS ZWNlaXZlRXZlbnQodWludDMyX3Qgb3BhcXVlVHlwZSwgYm9vbCBoYW5kbGVkKQogCiAgICAgICAg IE1FU1NBR0VfQ0hFQ0sobV9wcm9jZXNzLCB0eXBlID09IGV2ZW50LnR5cGUoKSk7CiAKKyNpZiBQ TEFURk9STShXSU4pCisgICAgICAgIC8vIGZvbGxvd2luZyBrZXlwcmVzcyBldmVudHMgc2hvdWxk IGJlIGNhbmNlbGVkIGlmIGEga2V5ZG93biBldmVudCBpcyBoYW5kbGVkCisgICAgICAgIGlmICh0 eXBlID09IFdlYkV2ZW50OjpSYXdLZXlEb3duICYmIGhhbmRsZWQpIHsKKyAgICAgICAgICAgIGlm IChtX2tleUV2ZW50UXVldWUuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgTVNHIG1zZzsK KyAgICAgICAgICAgICAgICAvLyBJbiBXZWJLaXRUZXN0UnVubmVyLCBkaWRSZWNlaXZlRXZlbnQg aXMgY2FsbGVkIGltbWVkaWF0ZWx5IGJlY2F1c2UgaXQgcHJvY2Vzc2VzIElQQyBtZXNzYWdlcyBz eW5jaHJvbm91c2x5LgorICAgICAgICAgICAgICAgIC8vIFdNX0NIQVIgZXZlbnRzIGFyZSBub3Qg cXVldWVkIGluIG1fa2V5RXZlbnRRdWV1ZSB5ZXQuIFJlbW92ZSBXTV9DSEFSIG1lc3NhZ2UgYnkg dXNpbmcgUGVla01lc3NhZ2UuCisgICAgICAgICAgICAgICAgLy8gV01fU1lTQ0hBUiBldmVudHMg c2hvdWxkIG5vdCBiZSByZW1vdmVkLCBiZWNhdXNlIGFjY2VzcyBrZXlzIGFyZSBpbXBsZW1lbnRl ZCBpbiBXZWJDb3JlIGluIFdNX1NZU0NIQVIgaGFuZGxlci4KKyAgICAgICAgICAgICAgICBpZiAo ZXZlbnQubmF0aXZlRXZlbnQoKS0+bWVzc2FnZSA9PSBXTV9LRVlET1dOKQorICAgICAgICAgICAg ICAgICAgICBQZWVrTWVzc2FnZSgmbXNnLCBldmVudC5uYXRpdmVFdmVudCgpLT5od25kLCBXTV9D SEFSLCBXTV9DSEFSLCBQTV9SRU1PVkUpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgICAgICB3aGlsZSAoIW1fa2V5RXZlbnRRdWV1ZS5pc0VtcHR5KCkgJiYgbV9rZXlFdmVudFF1 ZXVlLmZpcnN0KCkudHlwZSgpID09IFdlYkV2ZW50OjpDaGFyKQorICAgICAgICAgICAgICAgICAg ICBtX2tleUV2ZW50UXVldWUucmVtb3ZlRmlyc3QoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorI2VuZGlmCiAgICAgICAgIGJvb2wgY2FuUHJvY2Vzc01vcmVLZXlFdmVudHMgPSAhbV9rZXlF dmVudFF1ZXVlLmlzRW1wdHkoKTsKICAgICAgICAgaWYgKGNhblByb2Nlc3NNb3JlS2V5RXZlbnRz KSB7CiAgICAgICAgICAgICBMT0coS2V5SGFuZGxpbmcsICIgVUkgcHJvY2Vzczogc2VudCBrZXlF dmVudCBmcm9tIGRpZFJlY2VpdmVFdmVudCIpOwo= 380186 2019-10-03 22:08:12 -0700 2019-10-08 06:25:07 -0700 Patch bug-200558-20191004140811.patch text/plain 2651 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3MDk0YmMwZjI3MGE4MGE0 NWIzZjA1NGI5MzVkMzU2ZjVhMmQwMzYuLjFhNTkzYWFlM2NjNzE5YTc2MWZlYzFkMTJkYTE5M2Vk YTYwN2ZjNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMTAtMDMgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl1bV2ViS2l0 Ml0gQ2FuJ3QgcHJldmVudCBpbnB1dCBldmVudHMgYnkgY2FuY2VsaW5nIGtleWRvd24gZXZlbnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA1NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIGtl eWRvd24gZXZlbnQgaXMgaGFuZGxlZCwgdGhlIGtleXByZXNzIGV2ZW50IHNob3VsZG4ndCBiZQor ICAgICAgICBkaXNwYXRjaGVkLgorCisgICAgICAgIFRlc3RlZCBieSBmYXN0L2V2ZW50cy9pbnB1 dFRleHQtbmV2ZXItZmlyZWQtb24ta2V5ZG93bi1jYW5jZWwuaHRtbAorICAgICAgICBhbmQgZmFz dC9ldmVudHMva2V5ZG93bi1rZXlwcmVzcy1wcmV2ZW50RGVmYXVsdC5odG1sLgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6ZGlkUmVjZWl2ZUV2ZW50KTogUmVtb3ZlIHF1ZXVlZAorICAgICAgICBXZWJFdmVudDo6 Q2hhciBhbmQgV01fQ0hBUiBldmVudHMgaWYgV2ViRXZlbnQ6OlJhd0tleURvd24gaXMgaGFuZGxl ZC4KKwogMjAxOS0xMC0wMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFByb2dyZXNzIHRvd2FyZHMgYSBmdW5jdGlvbmluZyBDTWFrZSBidWls ZCBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGY0 ZjA4ZTQ3NWYzMTA4YzJhMTM1NGE2YTZmNWE0Mzc5Y2JlMzExNDEuLmU3YzkxMWYyYzFiNjEzM2Fk M2M0YmQyNWFjOTgxYmUxN2Q3NGU3OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcApAQCAtNjQ3OCw2ICs2NDc4LDIyIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRS ZWNlaXZlRXZlbnQodWludDMyX3Qgb3BhcXVlVHlwZSwgYm9vbCBoYW5kbGVkKQogCiAgICAgICAg IE1FU1NBR0VfQ0hFQ0sobV9wcm9jZXNzLCB0eXBlID09IGV2ZW50LnR5cGUoKSk7CiAKKyNpZiBQ TEFURk9STShXSU4pCisgICAgICAgIC8vIGZvbGxvd2luZyBrZXlwcmVzcyBldmVudHMgc2hvdWxk IGJlIGNhbmNlbGVkIGlmIGEga2V5ZG93biBldmVudCBpcyBoYW5kbGVkCisgICAgICAgIGlmICh0 eXBlID09IFdlYkV2ZW50OjpSYXdLZXlEb3duICYmIGhhbmRsZWQpIHsKKyAgICAgICAgICAgIGlm IChtX2tleUV2ZW50UXVldWUuaXNFbXB0eSgpKSB7CisgICAgICAgICAgICAgICAgTVNHIG1zZzsK KyAgICAgICAgICAgICAgICAvLyBJbiBXZWJLaXRUZXN0UnVubmVyLCBkaWRSZWNlaXZlRXZlbnQg aXMgY2FsbGVkIGltbWVkaWF0ZWx5IGJlY2F1c2UgaXQgcHJvY2Vzc2VzIElQQyBtZXNzYWdlcyBz eW5jaHJvbm91c2x5LgorICAgICAgICAgICAgICAgIC8vIFdNX0NIQVIgZXZlbnRzIGFyZSBub3Qg cXVldWVkIGluIG1fa2V5RXZlbnRRdWV1ZSB5ZXQuIFJlbW92ZSBXTV9DSEFSIG1lc3NhZ2UgYnkg dXNpbmcgUGVla01lc3NhZ2UuCisgICAgICAgICAgICAgICAgLy8gV01fU1lTQ0hBUiBldmVudHMg c2hvdWxkIG5vdCBiZSByZW1vdmVkLCBiZWNhdXNlIGFjY2VzcyBrZXlzIGFyZSBpbXBsZW1lbnRl ZCBpbiBXZWJDb3JlIGluIFdNX1NZU0NIQVIgaGFuZGxlci4KKyAgICAgICAgICAgICAgICBpZiAo ZXZlbnQubmF0aXZlRXZlbnQoKS0+bWVzc2FnZSA9PSBXTV9LRVlET1dOKQorICAgICAgICAgICAg ICAgICAgICBQZWVrTWVzc2FnZSgmbXNnLCBldmVudC5uYXRpdmVFdmVudCgpLT5od25kLCBXTV9D SEFSLCBXTV9DSEFSLCBQTV9SRU1PVkUpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgICAgICB3aGlsZSAoIW1fa2V5RXZlbnRRdWV1ZS5pc0VtcHR5KCkgJiYgbV9rZXlFdmVudFF1 ZXVlLmZpcnN0KCkudHlwZSgpID09IFdlYkV2ZW50OjpDaGFyKQorICAgICAgICAgICAgICAgICAg ICBtX2tleUV2ZW50UXVldWUucmVtb3ZlRmlyc3QoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorI2VuZGlmCiAgICAgICAgIGJvb2wgY2FuUHJvY2Vzc01vcmVLZXlFdmVudHMgPSAhbV9rZXlF dmVudFF1ZXVlLmlzRW1wdHkoKTsKICAgICAgICAgaWYgKGNhblByb2Nlc3NNb3JlS2V5RXZlbnRz KSB7CiAgICAgICAgICAgICBMT0coS2V5SGFuZGxpbmcsICIgVUkgcHJvY2Vzczogc2VudCBrZXlF dmVudCBmcm9tIGRpZFJlY2VpdmVFdmVudCIpOwo=